Skip to content
Snippets Groups Projects
PL1

Feature buster

Merged Imported Juan Font Alonso requested to merge feature_buster into master

Merge request reports

Approval is optional

Merged by Juan Font AlonsoJuan Font Alonso 4 years ago (Dec 11, 2020 9:27am UTC)

Merge details

  • Changes merged into master with 8688fe9f.
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Juan Font Alonso @juanfont commented on commit 1e834a40 Imported
      Author Contributor

      The second part ("if Size (...)") should be an else branch of the first test (if "Taste_Property.Name = " ...). No?

      By Maxime Perrotin on 2020-02-13T12:57:35

    • Author Contributor

      Not quite. A function may feature multiple properties and "TASTE_IV_Properties::FPGA_Configurations" property is present on HW functions only. So the last if safeguards the case where the function didn't find an FPGA_Configurations in its TASTE properties, but a value for the function's FPGA configurations need to be included to ensure vector coherency.

      By Laura Alexandra Sequeira Gouveia on 2020-02-13T13:06:03

    • Author Contributor

      OK

      By Maxime Perrotin on 2020-02-13T15:16:48

    • Please register or sign in to reply
  • Juan Font Alonso merged · Imported

    merged

  • Juan Font Alonso mentioned in commit 8688fe9f · Imported

    mentioned in commit 8688fe9f

    By Maxime Perrotin on 2020-12-11T09:27:17

Please register or sign in to reply
Loading