Skip to content
Snippets Groups Projects
PL1

Remove unneeded check of initialization flag

Open Imported Juan Font Alonso requested to merge improve_init_functions into feature_bullseye

This MR removes the unneeded check for the initialization flag (0 == @_LOWER:Sync_RIs_Parent_@_initialized) of the synchronous required interfaces. These flags are already checked inside the initialization function (init_@_LOWER:Sync_RIs_Parent_@();), thus, it is not needed to be checked by the caller.

if (0 == @_LOWER:Sync_RIs_Parent_@_initialized) { // Removed!
    init_@_LOWER:Sync_RIs_Parent_@();             // the *_initialized flag is checked inside!
}                                                 // Removed!

Note that issue #3 fixes the initialization lock problem and introduces a new test case called test-recursive-init. The changes applied in this MR passed this test.

Edited by Juan Font Alonso

Merge request reports

Approval is optional
Ready to merge by members who can write to the target branch.

Merge details

  • The source branch is 332 commits behind the target branch.
  • 1 commit and 1 merge commit will be added to feature_bullseye.
  • Source branch will be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading