Commit e429daa5 authored by Paul Sokolovsky's avatar Paul Sokolovsky
Browse files

extmod/utime_mphal: Fix implementation of new semantics of ticks_diff().

Now the function properly uses ring arithmetic to return signed value
in range (inclusive):

That means that function can properly process 2 time values away from
each other within MICROPY_PY_UTIME_TICKS_PERIOD/2 ticks, but away in
both directions. For example, if tick value 'a' predates tick value 'b',
ticks_diff(a, b) will return negative value, and positive value otherwise.
But at positive value of MICROPY_PY_UTIME_TICKS_PERIOD/2-1, the result
of the function will wrap around to negative -MICROPY_PY_UTIME_TICKS_PERIOD/2,
in other words, if a follows b in more than MICROPY_PY_UTIME_TICKS_PERIOD/2 - 1
ticks, the function will "consider" a to actually predate b.
parent 76146b3d
......@@ -89,7 +89,13 @@ STATIC mp_obj_t time_ticks_diff(mp_obj_t end_in, mp_obj_t start_in) {
// we assume that the arguments come from ticks_xx so are small ints
uint32_t start = MP_OBJ_SMALL_INT_VALUE(start_in);
uint32_t end = MP_OBJ_SMALL_INT_VALUE(end_in);
return MP_OBJ_NEW_SMALL_INT((int32_t)(end - start));
int32_t diff = end - start;
if (diff < (signed)-(MICROPY_PY_UTIME_TICKS_PERIOD / 2)) {
} else if (diff >= (signed)(MICROPY_PY_UTIME_TICKS_PERIOD / 2)) {
return MP_OBJ_NEW_SMALL_INT(diff);
MP_DEFINE_CONST_FUN_OBJ_2(mp_utime_ticks_diff_obj, time_ticks_diff);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment