Commit a0ad77ba authored by Paul Sokolovsky's avatar Paul Sokolovsky
Browse files

vm: Establish macros PUSH_EXC_BLOCK & POP_EXC_BLOCK to deal with exc stack.

E.g. to handle currently_in_except_block restoring properly.
parent d109676e
...@@ -45,7 +45,7 @@ typedef enum { ...@@ -45,7 +45,7 @@ typedef enum {
#define TOP() (*sp) #define TOP() (*sp)
#define SET_TOP(val) *sp = (val) #define SET_TOP(val) *sp = (val)
#define SETUP_BLOCK() \ #define PUSH_EXC_BLOCK() \
DECODE_ULABEL; /* except labels are always forward */ \ DECODE_ULABEL; /* except labels are always forward */ \
++exc_sp; \ ++exc_sp; \
exc_sp->opcode = op; \ exc_sp->opcode = op; \
...@@ -53,6 +53,10 @@ typedef enum { ...@@ -53,6 +53,10 @@ typedef enum {
exc_sp->val_sp = MP_TAGPTR_MAKE(sp, currently_in_except_block); \ exc_sp->val_sp = MP_TAGPTR_MAKE(sp, currently_in_except_block); \
currently_in_except_block = 0; /* in a try block now */ currently_in_except_block = 0; /* in a try block now */
#define POP_EXC_BLOCK() \
currently_in_except_block = MP_TAGPTR_TAG(exc_sp->val_sp); /* restore previous state */ \
exc_sp--; /* pop back to previous exception handler */
mp_vm_return_kind_t mp_execute_byte_code(const byte *code, const mp_obj_t *args, uint n_args, const mp_obj_t *args2, uint n_args2, mp_obj_t *ret) { mp_vm_return_kind_t mp_execute_byte_code(const byte *code, const mp_obj_t *args, uint n_args, const mp_obj_t *args2, uint n_args2, mp_obj_t *ret) {
const byte *ip = code; const byte *ip = code;
...@@ -386,7 +390,7 @@ dispatch_loop: ...@@ -386,7 +390,7 @@ dispatch_loop:
SET_TOP(rt_load_attr(obj1, MP_QSTR___exit__)); SET_TOP(rt_load_attr(obj1, MP_QSTR___exit__));
rt_load_method(obj1, MP_QSTR___enter__, sp + 1); rt_load_method(obj1, MP_QSTR___enter__, sp + 1);
obj2 = rt_call_method_n_kw(0, 0, sp + 1); obj2 = rt_call_method_n_kw(0, 0, sp + 1);
SETUP_BLOCK(); PUSH_EXC_BLOCK();
PUSH(obj2); PUSH(obj2);
break; break;
...@@ -478,7 +482,7 @@ unwind_jump: ...@@ -478,7 +482,7 @@ unwind_jump:
// matched against: POP_BLOCK or POP_EXCEPT (anything else?) // matched against: POP_BLOCK or POP_EXCEPT (anything else?)
case MP_BC_SETUP_EXCEPT: case MP_BC_SETUP_EXCEPT:
case MP_BC_SETUP_FINALLY: case MP_BC_SETUP_FINALLY:
SETUP_BLOCK(); PUSH_EXC_BLOCK();
break; break;
case MP_BC_END_FINALLY: case MP_BC_END_FINALLY:
...@@ -527,8 +531,7 @@ unwind_jump: ...@@ -527,8 +531,7 @@ unwind_jump:
case MP_BC_POP_BLOCK: case MP_BC_POP_BLOCK:
// we are exiting an exception handler, so pop the last one of the exception-stack // we are exiting an exception handler, so pop the last one of the exception-stack
assert(exc_sp >= exc_stack); assert(exc_sp >= exc_stack);
currently_in_except_block = MP_TAGPTR_TAG(exc_sp->val_sp); // restore previous state POP_EXC_BLOCK();
exc_sp--; // pop back to previous exception handler
break; break;
// matched against: SETUP_EXCEPT // matched against: SETUP_EXCEPT
...@@ -539,8 +542,7 @@ unwind_jump: ...@@ -539,8 +542,7 @@ unwind_jump:
assert(currently_in_except_block); assert(currently_in_except_block);
//sp = (mp_obj_t*)(*exc_sp--); //sp = (mp_obj_t*)(*exc_sp--);
//exc_sp--; // discard ip //exc_sp--; // discard ip
currently_in_except_block = MP_TAGPTR_TAG(exc_sp->val_sp); // restore previous state POP_EXC_BLOCK();
exc_sp--; // pop back to previous exception handler
//sp -= 3; // pop 3 exception values //sp -= 3; // pop 3 exception values
break; break;
...@@ -830,8 +832,7 @@ yield: ...@@ -830,8 +832,7 @@ yield:
// at the moment we are just raising the very last exception (the one that caused the nested exception) // at the moment we are just raising the very last exception (the one that caused the nested exception)
// move up to previous exception handler // move up to previous exception handler
currently_in_except_block = MP_TAGPTR_TAG(exc_sp->val_sp); // restore previous state POP_EXC_BLOCK();
exc_sp--; // pop back to previous exception handler
} }
if (exc_sp >= exc_stack) { if (exc_sp >= exc_stack) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment