Commit 2a1090a6 authored by Damien George's avatar Damien George
Browse files

py: Clarify comment in parsenum.c about ValueError vs SyntaxError.

parent 228c68a9
...@@ -36,7 +36,8 @@ ...@@ -36,7 +36,8 @@
#endif #endif
STATIC NORETURN void raise_exc(mp_obj_t exc, mp_lexer_t *lex) { STATIC NORETURN void raise_exc(mp_obj_t exc, mp_lexer_t *lex) {
// if lex!=NULL then the parser called us and we need to make a SyntaxError with traceback // if lex!=NULL then the parser called us and we need to convert the
// exception's type from ValueError to SyntaxError and add traceback info
if (lex != NULL) { if (lex != NULL) {
((mp_obj_base_t*)exc)->type = &mp_type_SyntaxError; ((mp_obj_base_t*)exc)->type = &mp_type_SyntaxError;
mp_obj_exception_add_traceback(exc, lex->source_name, lex->tok_line, MP_QSTR_NULL); mp_obj_exception_add_traceback(exc, lex->source_name, lex->tok_line, MP_QSTR_NULL);
...@@ -142,7 +143,6 @@ overflow: ...@@ -142,7 +143,6 @@ overflow:
} }
value_error: value_error:
// if lex!=NULL then the parser called us and we need to make a ValueError with traceback
if (MICROPY_ERROR_REPORTING == MICROPY_ERROR_REPORTING_TERSE) { if (MICROPY_ERROR_REPORTING == MICROPY_ERROR_REPORTING_TERSE) {
mp_obj_t exc = mp_obj_new_exception_msg(&mp_type_ValueError, mp_obj_t exc = mp_obj_new_exception_msg(&mp_type_ValueError,
"invalid syntax for integer"); "invalid syntax for integer");
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment