compile.c 149 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
/*
 * This file is part of the Micro Python project, http://micropython.org/
 *
 * The MIT License (MIT)
 *
 * Copyright (c) 2013, 2014 Damien P. George
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

xbe's avatar
xbe committed
27
#include <stdbool.h>
Damien's avatar
Damien committed
28
29
30
31
#include <stdint.h>
#include <stdio.h>
#include <string.h>
#include <assert.h>
32
#include <math.h>
Damien's avatar
Damien committed
33

34
#include "mpconfig.h"
35
#include "misc.h"
36
#include "qstr.h"
Damien's avatar
Damien committed
37
38
#include "lexer.h"
#include "parse.h"
39
#include "runtime0.h"
40
#include "obj.h"
41
42
43
#include "emitglue.h"
#include "scope.h"
#include "emit.h"
44
45
#include "compile.h"
#include "runtime.h"
46
#include "builtin.h"
47
#include "smallint.h"
Damien's avatar
Damien committed
48
49
50
51
52

// TODO need to mangle __attr names

typedef enum {
    PN_none = 0,
53
#define DEF_RULE(rule, comp, kind, ...) PN_##rule,
Damien's avatar
Damien committed
54
55
56
#include "grammar.h"
#undef DEF_RULE
    PN_maximum_number_of,
57
    PN_string, // special node for non-interned string
Damien's avatar
Damien committed
58
59
} pn_kind_t;

60
61
62
63
#define EMIT(fun) (comp->emit_method_table->fun(comp->emit))
#define EMIT_ARG(fun, ...) (comp->emit_method_table->fun(comp->emit, __VA_ARGS__))
#define EMIT_INLINE_ASM(fun) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm))
#define EMIT_INLINE_ASM_ARG(fun, ...) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm, __VA_ARGS__))
Damien's avatar
Damien committed
64

65
// elements in this struct are ordered to make it compact
Damien's avatar
Damien committed
66
typedef struct _compiler_t {
67
    qstr source_file;
68

69
70
71
    uint8_t is_repl;
    uint8_t pass; // holds enum type pass_kind_t
    uint8_t func_arg_is_super; // used to compile special case of super() function call
72
73
74
75
76
    uint8_t have_star;

    // try to keep compiler clean from nlr
    // this is set to an exception object if we have a compile error
    mp_obj_t compile_error;
Damien's avatar
Damien committed
77

78
    uint next_label;
79

80
81
82
    uint16_t num_dict_params;
    uint16_t num_default_params;

83
84
    uint16_t break_label; // highest bit set indicates we are breaking out of a for loop
    uint16_t continue_label;
85
    uint16_t cur_except_level; // increased for SETUP_EXCEPT, SETUP_FINALLY; decreased for POP_BLOCK, POP_EXCEPT
86
    uint16_t break_continue_except_level;
Damien's avatar
Damien committed
87
88
89
90

    scope_t *scope_head;
    scope_t *scope_cur;

91
92
    emit_t *emit;                                   // current emitter
    const emit_method_table_t *emit_method_table;   // current emit method table
93
94
95

    emit_inline_asm_t *emit_inline_asm;                                   // current emitter for inline asm
    const emit_inline_asm_method_table_t *emit_inline_asm_method_table;   // current emit method table for inline asm
Damien's avatar
Damien committed
96
97
} compiler_t;

98
STATIC void compile_syntax_error(compiler_t *comp, mp_parse_node_t pn, const char *msg) {
99
100
    mp_obj_t exc = mp_obj_new_exception_msg(&mp_type_SyntaxError, msg);
    // we don't have a 'block' name, so just pass the NULL qstr to indicate this
101
    if (MP_PARSE_NODE_IS_STRUCT(pn)) {
102
        mp_obj_exception_add_traceback(exc, comp->source_file, (mp_uint_t)((mp_parse_node_struct_t*)pn)->source_line, MP_QSTR_NULL);
103
    } else {
104
105
        // we don't have a line number, so just pass 0
        mp_obj_exception_add_traceback(exc, comp->source_file, 0, MP_QSTR_NULL);
106
    }
107
    comp->compile_error = exc;
108
109
}

110
STATIC const mp_map_elem_t mp_constants_table[] = {
111
112
113
    #if MICROPY_PY_UCTYPES
    { MP_OBJ_NEW_QSTR(MP_QSTR_uctypes), (mp_obj_t)&mp_module_uctypes },
    #endif
114
    // Extra constants as defined by a port
115
    MICROPY_PORT_CONSTANTS
116
117
118
119
120
};

STATIC const mp_map_t mp_constants_map = {
    .all_keys_are_qstrs = 1,
    .table_is_fixed_array = 1,
121
122
    .used = MP_ARRAY_SIZE(mp_constants_table),
    .alloc = MP_ARRAY_SIZE(mp_constants_table),
123
124
125
    .table = (mp_map_elem_t*)mp_constants_table,
};

126
127
128
129
// this function is essentially a simple preprocessor
STATIC mp_parse_node_t fold_constants(compiler_t *comp, mp_parse_node_t pn, mp_map_t *consts) {
    if (0) {
        // dummy
130
#if MICROPY_COMP_CONST
131
132
133
134
135
136
137
138
139
    } else if (MP_PARSE_NODE_IS_ID(pn)) {
        // lookup identifier in table of dynamic constants
        qstr qst = MP_PARSE_NODE_LEAF_ARG(pn);
        mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(qst), MP_MAP_LOOKUP);
        if (elem != NULL) {
            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, MP_OBJ_SMALL_INT_VALUE(elem->value));
        }
#endif
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
140
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
Damien's avatar
Damien committed
141

142
143
        // fold some parse nodes before folding their arguments
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
144
#if MICROPY_COMP_CONST
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
            case PN_expr_stmt:
                if (!MP_PARSE_NODE_IS_NULL(pns->nodes[1])) {
                    mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_expr_stmt_assign) {
                        if (MP_PARSE_NODE_IS_ID(pns->nodes[0])
                            && MP_PARSE_NODE_IS_STRUCT_KIND(pns1->nodes[0], PN_power)
                            && MP_PARSE_NODE_IS_ID(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0])
                            && MP_PARSE_NODE_LEAF_ARG(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0]) == MP_QSTR_const
                            && MP_PARSE_NODE_IS_STRUCT_KIND(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1], PN_trailer_paren)
                            && MP_PARSE_NODE_IS_NULL(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[2])
                            ) {
                            // code to assign dynamic constants: id = const(value)

                            // get the id
                            qstr id_qstr = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);

                            // get the value
                            mp_parse_node_t pn_value = ((mp_parse_node_struct_t*)((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1])->nodes[0];
                            pn_value = fold_constants(comp, pn_value, consts);
                            if (!MP_PARSE_NODE_IS_SMALL_INT(pn_value)) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant must be an integer");
                                break;
                            }
168
                            mp_int_t value = MP_PARSE_NODE_LEAF_SMALL_INT(pn_value);
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187

                            // store the value in the table of dynamic constants
                            mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(id_qstr), MP_MAP_LOOKUP_ADD_IF_NOT_FOUND);
                            if (elem->value != MP_OBJ_NULL) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant redefined");
                                break;
                            }
                            elem->value = MP_OBJ_NEW_SMALL_INT(value);

                            // replace const(value) with value
                            pns1->nodes[0] = pn_value;

                            // finished folding this assignment
                            return pn;
                        }
                    }
                }
                break;
#endif
188
189
            case PN_string:
                return pn;
190
191
192
193
        }

        // fold arguments
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
194
        for (int i = 0; i < n; i++) {
195
            pns->nodes[i] = fold_constants(comp, pns->nodes[i], consts);
Damien's avatar
Damien committed
196
197
        }

198
        // try to fold this parse node
199
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
200
201
202
203
204
205
206
207
208
209
            case PN_atom_paren:
                if (n == 1 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0])) {
                    // (int)
                    pn = pns->nodes[0];
                }
                break;

            case PN_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int | int
210
211
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
212
213
214
215
216
217
218
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 | arg1);
                }
                break;

            case PN_and_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int & int
219
220
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
221
222
223
224
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 & arg1);
                }
                break;

Damien's avatar
Damien committed
225
            case PN_shift_expr:
226
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
227
228
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
229
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_LESS)) {
230
231
232
233
                        // int << int
                        if (!(arg1 >= BITS_PER_WORD || arg0 > (MP_SMALL_INT_MAX >> arg1) || arg0 < (MP_SMALL_INT_MIN >> arg1))) {
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 << arg1);
                        }
234
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_MORE)) {
235
                        // int >> int
236
237
238
239
240
                        if (arg1 >= BITS_PER_WORD) {
                            // Shifting to big amounts is underfined behavior
                            // in C and is CPU-dependent; propagate sign bit.
                            arg1 = BITS_PER_WORD - 1;
                        }
241
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 >> arg1);
Damien's avatar
Damien committed
242
243
244
245
246
247
248
249
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_arith_expr:
250
                // overflow checking here relies on SMALL_INT being strictly smaller than mp_int_t
251
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
252
253
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
254
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PLUS)) {
255
                        // int + int
256
                        arg0 += arg1;
257
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_MINUS)) {
258
                        // int - int
259
                        arg0 -= arg1;
Damien's avatar
Damien committed
260
261
262
                    } else {
                        // shouldn't happen
                        assert(0);
263
                    }
264
                    if (MP_SMALL_INT_FITS(arg0)) {
265
                        //printf("%ld + %ld\n", arg0, arg1);
266
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
Damien's avatar
Damien committed
267
268
269
270
271
                    }
                }
                break;

            case PN_term:
272
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
273
274
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
275
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_STAR)) {
276
                        // int * int
277
278
                        if (!mp_small_int_mul_overflow(arg0, arg1)) {
                            arg0 *= arg1;
279
                            if (MP_SMALL_INT_FITS(arg0)) {
280
281
282
                                pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
                            }
                        }
283
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_SLASH)) {
284
285
                        // int / int
                        // pass
286
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PERCENT)) {
287
                        // int%int
288
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_modulo(arg0, arg1));
289
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_SLASH)) {
290
                        if (arg1 != 0) {
291
                            // int // int
292
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_floor_divide(arg0, arg1));
293
                        }
Damien's avatar
Damien committed
294
295
296
297
298
299
300
301
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_factor_2:
302
                if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
303
                    mp_int_t arg = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
304
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_PLUS)) {
305
                        // +int
306
307
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_MINUS)) {
308
                        // -int
309
310
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, -arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_TILDE)) {
311
                        // ~int
312
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ~arg);
Damien's avatar
Damien committed
313
314
315
316
317
318
319
320
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_power:
321
322
323
                if (0) {
#if MICROPY_EMIT_CPYTHON
                } else if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_NULL(pns->nodes[1]) && !MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
324
                    // int ** x
325
                    // can overflow; enabled only to compare with CPython
326
327
                    mp_parse_node_struct_t* pns2 = (mp_parse_node_struct_t*)pns->nodes[2];
                    if (MP_PARSE_NODE_IS_SMALL_INT(pns2->nodes[0])) {
328
                        int power = MP_PARSE_NODE_LEAF_SMALL_INT(pns2->nodes[0]);
Damien's avatar
Damien committed
329
330
                        if (power >= 0) {
                            int ans = 1;
331
                            int base = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
Damien's avatar
Damien committed
332
333
334
                            for (; power > 0; power--) {
                                ans *= base;
                            }
335
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ans);
Damien's avatar
Damien committed
336
337
                        }
                    }
338
339
340
341
342
343
344
345
346
347
348
349
350
#endif
                } else if (MP_PARSE_NODE_IS_ID(pns->nodes[0]) && MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[1], PN_trailer_period) && MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
                    // id.id
                    // look it up in constant table, see if it can be replaced with an integer
                    mp_parse_node_struct_t* pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
                    qstr q_base = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);
                    qstr q_attr = MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]);
                    mp_map_elem_t *elem = mp_map_lookup((mp_map_t*)&mp_constants_map, MP_OBJ_NEW_QSTR(q_base), MP_MAP_LOOKUP);
                    if (elem != NULL) {
                        mp_obj_t dest[2];
                        mp_load_method_maybe(elem->value, q_attr, dest);
                        if (MP_OBJ_IS_SMALL_INT(dest[0]) && dest[1] == NULL) {
351
                            mp_int_t val = MP_OBJ_SMALL_INT_VALUE(dest[0]);
352
                            if (MP_SMALL_INT_FITS(val)) {
353
354
355
356
                                pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, val);
                            }
                        }
                    }
Damien's avatar
Damien committed
357
358
359
360
361
362
363
364
                }
                break;
        }
    }

    return pn;
}

365
STATIC void compile_trailer_paren_helper(compiler_t *comp, mp_parse_node_t pn_arglist, bool is_method_call, int n_positional_extra);
366
STATIC void compile_comprehension(compiler_t *comp, mp_parse_node_struct_t *pns, scope_kind_t kind);
367
STATIC void compile_node(compiler_t *comp, mp_parse_node_t pn);
Damien's avatar
Damien committed
368

369
STATIC uint comp_next_label(compiler_t *comp) {
370
371
372
    return comp->next_label++;
}

373
374
375
376
377
378
379
380
381
382
383
384
STATIC void compile_increase_except_level(compiler_t *comp) {
    comp->cur_except_level += 1;
    if (comp->cur_except_level > comp->scope_cur->exc_stack_size) {
        comp->scope_cur->exc_stack_size = comp->cur_except_level;
    }
}

STATIC void compile_decrease_except_level(compiler_t *comp) {
    assert(comp->cur_except_level > 0);
    comp->cur_except_level -= 1;
}

385
STATIC scope_t *scope_new_and_link(compiler_t *comp, scope_kind_t kind, mp_parse_node_t pn, uint emit_options) {
386
    scope_t *scope = scope_new(kind, pn, comp->source_file, emit_options);
Damien's avatar
Damien committed
387
388
389
390
391
392
393
394
395
396
397
398
399
400
    scope->parent = comp->scope_cur;
    scope->next = NULL;
    if (comp->scope_head == NULL) {
        comp->scope_head = scope;
    } else {
        scope_t *s = comp->scope_head;
        while (s->next != NULL) {
            s = s->next;
        }
        s->next = scope;
    }
    return scope;
}

401
STATIC void apply_to_single_or_list(compiler_t *comp, mp_parse_node_t pn, int pn_list_kind, void (*f)(compiler_t*, mp_parse_node_t)) {
402
403
404
    if (MP_PARSE_NODE_IS_STRUCT(pn) && MP_PARSE_NODE_STRUCT_KIND((mp_parse_node_struct_t*)pn) == pn_list_kind) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
405
406
407
        for (int i = 0; i < num_nodes; i++) {
            f(comp, pns->nodes[i]);
        }
408
    } else if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
409
410
411
412
        f(comp, pn);
    }
}

413
STATIC int list_get(mp_parse_node_t *pn, int pn_kind, mp_parse_node_t **nodes) {
414
    if (MP_PARSE_NODE_IS_NULL(*pn)) {
Damien's avatar
Damien committed
415
416
        *nodes = NULL;
        return 0;
417
    } else if (MP_PARSE_NODE_IS_LEAF(*pn)) {
Damien's avatar
Damien committed
418
419
420
        *nodes = pn;
        return 1;
    } else {
421
422
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)(*pn);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) != pn_kind) {
Damien's avatar
Damien committed
423
424
425
426
            *nodes = pn;
            return 1;
        } else {
            *nodes = pns->nodes;
427
            return MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
428
429
430
431
        }
    }
}

432
void compile_do_nothing(compiler_t *comp, mp_parse_node_struct_t *pns) {
Damien's avatar
Damien committed
433
434
}

435
436
void compile_generic_all_nodes(compiler_t *comp, mp_parse_node_struct_t *pns) {
    int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
437
438
439
440
441
    for (int i = 0; i < num_nodes; i++) {
        compile_node(comp, pns->nodes[i]);
    }
}

442
#if MICROPY_EMIT_CPYTHON
443
STATIC bool cpython_c_tuple_is_const(mp_parse_node_t pn) {
444
445
446
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string)) {
        return true;
    }
447
    if (!MP_PARSE_NODE_IS_LEAF(pn)) {
Damien's avatar
Damien committed
448
449
        return false;
    }
450
    if (MP_PARSE_NODE_IS_ID(pn)) {
Damien's avatar
Damien committed
451
452
453
454
455
        return false;
    }
    return true;
}

456
STATIC void cpython_c_print_quoted_str(vstr_t *vstr, const char *str, uint len, bool bytes) {
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
    bool has_single_quote = false;
    bool has_double_quote = false;
    for (int i = 0; i < len; i++) {
        if (str[i] == '\'') {
            has_single_quote = true;
        } else if (str[i] == '"') {
            has_double_quote = true;
        }
    }
    if (bytes) {
        vstr_printf(vstr, "b");
    }
    bool quote_single = false;
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        quote_single = true;
        vstr_printf(vstr, "'");
    }
    for (int i = 0; i < len; i++) {
        if (str[i] == '\n') {
            vstr_printf(vstr, "\\n");
        } else if (str[i] == '\\') {
            vstr_printf(vstr, "\\\\");
        } else if (str[i] == '\'' && quote_single) {
            vstr_printf(vstr, "\\'");
        } else {
            vstr_printf(vstr, "%c", str[i]);
        }
    }
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        vstr_printf(vstr, "'");
    }
}

494
STATIC void cpython_c_tuple_emit_const(compiler_t *comp, mp_parse_node_t pn, vstr_t *vstr) {
495
496
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
497
        cpython_c_print_quoted_str(vstr, (const char*)pns->nodes[0], (mp_uint_t)pns->nodes[1], false);
498
499
500
        return;
    }

501
    assert(MP_PARSE_NODE_IS_LEAF(pn));
502
503
504
505
506
    if (MP_PARSE_NODE_IS_SMALL_INT(pn)) {
        vstr_printf(vstr, INT_FMT, MP_PARSE_NODE_LEAF_SMALL_INT(pn));
        return;
    }

507
    mp_uint_t arg = MP_PARSE_NODE_LEAF_ARG(pn);
508
509
510
511
    switch (MP_PARSE_NODE_LEAF_KIND(pn)) {
        case MP_PARSE_NODE_ID: assert(0);
        case MP_PARSE_NODE_INTEGER: vstr_printf(vstr, "%s", qstr_str(arg)); break;
        case MP_PARSE_NODE_DECIMAL: vstr_printf(vstr, "%s", qstr_str(arg)); break;
512
513
        case MP_PARSE_NODE_STRING:
        case MP_PARSE_NODE_BYTES: {
514
            mp_uint_t len;
515
516
517
518
            const byte *str = qstr_data(arg, &len);
            cpython_c_print_quoted_str(vstr, (const char*)str, len, MP_PARSE_NODE_LEAF_KIND(pn) == MP_PARSE_NODE_BYTES);
            break;
        }
519
        case MP_PARSE_NODE_TOKEN:
Damien's avatar
Damien committed
520
            switch (arg) {
521
522
523
                case MP_TOKEN_KW_FALSE: vstr_printf(vstr, "False"); break;
                case MP_TOKEN_KW_NONE: vstr_printf(vstr, "None"); break;
                case MP_TOKEN_KW_TRUE: vstr_printf(vstr, "True"); break;
524
                default: assert(0); // shouldn't happen
Damien's avatar
Damien committed
525
526
527
528
529
530
            }
            break;
        default: assert(0);
    }
}

531
STATIC void cpython_c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
Damien's avatar
Damien committed
532
533
    int n = 0;
    if (pns_list != NULL) {
534
        n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
Damien's avatar
Damien committed
535
536
537
    }
    int total = n;
    bool is_const = true;
538
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
539
        total += 1;
540
        if (!cpython_c_tuple_is_const(pn)) {
Damien's avatar
Damien committed
541
542
543
544
            is_const = false;
        }
    }
    for (int i = 0; i < n; i++) {
545
        if (!cpython_c_tuple_is_const(pns_list->nodes[i])) {
Damien's avatar
Damien committed
546
547
548
549
550
551
            is_const = false;
            break;
        }
    }
    if (total > 0 && is_const) {
        bool need_comma = false;
552
553
        vstr_t *vstr = vstr_new();
        vstr_printf(vstr, "(");
554
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
555
            cpython_c_tuple_emit_const(comp, pn, vstr);
Damien's avatar
Damien committed
556
557
558
559
            need_comma = true;
        }
        for (int i = 0; i < n; i++) {
            if (need_comma) {
560
                vstr_printf(vstr, ", ");
Damien's avatar
Damien committed
561
            }
562
            cpython_c_tuple_emit_const(comp, pns_list->nodes[i], vstr);
Damien's avatar
Damien committed
563
564
565
            need_comma = true;
        }
        if (total == 1) {
566
            vstr_printf(vstr, ",)");
Damien's avatar
Damien committed
567
        } else {
568
            vstr_printf(vstr, ")");
Damien's avatar
Damien committed
569
        }
570
        EMIT_ARG(load_const_verbatim_str, vstr_str(vstr));
571
        vstr_free(vstr);
Damien's avatar
Damien committed
572
    } else {
573
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
574
575
576
577
578
            compile_node(comp, pn);
        }
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
579
        EMIT_ARG(build_tuple, total);
Damien's avatar
Damien committed
580
581
    }
}
582
583
584
#endif

// funnelling all tuple creations through this function is purely so we can optionally agree with CPython
585
STATIC void c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
586
#if MICROPY_EMIT_CPYTHON
587
588
589
    cpython_c_tuple(comp, pn, pns_list);
#else
    int total = 0;
590
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
591
592
593
594
        compile_node(comp, pn);
        total += 1;
    }
    if (pns_list != NULL) {
595
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
596
597
598
599
600
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
        total += n;
    }
601
    EMIT_ARG(build_tuple, total);
602
603
#endif
}
Damien's avatar
Damien committed
604

605
void compile_generic_tuple(compiler_t *comp, mp_parse_node_struct_t *pns) {
Damien's avatar
Damien committed
606
    // a simple tuple expression
607
    c_tuple(comp, MP_PARSE_NODE_NULL, pns);
Damien's avatar
Damien committed
608
609
}

610
STATIC bool node_is_const_false(mp_parse_node_t pn) {
611
612
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_FALSE)
        || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) == 0);
Damien's avatar
Damien committed
613
614
}

615
STATIC bool node_is_const_true(mp_parse_node_t pn) {
616
617
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_TRUE)
        || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) != 0);
Damien's avatar
Damien committed
618
619
}

620
#if MICROPY_EMIT_CPYTHON
621
// the is_nested variable is purely to match with CPython, which doesn't fully optimise not's
622
STATIC void cpython_c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label, bool is_nested) {
Damien's avatar
Damien committed
623
624
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
625
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
626
627
628
629
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
630
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
631
632
        }
        return;
633
634
635
636
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
Damien's avatar
Damien committed
637
            if (jump_if == false) {
638
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
639
                for (int i = 0; i < n - 1; i++) {
640
                    cpython_c_if_cond(comp, pns->nodes[i], true, label2, true);
Damien's avatar
Damien committed
641
                }
642
                cpython_c_if_cond(comp, pns->nodes[n - 1], false, label, true);
643
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
644
645
            } else {
                for (int i = 0; i < n; i++) {
646
                    cpython_c_if_cond(comp, pns->nodes[i], true, label, true);
Damien's avatar
Damien committed
647
648
649
                }
            }
            return;
650
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
Damien's avatar
Damien committed
651
652
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
653
                    cpython_c_if_cond(comp, pns->nodes[i], false, label, true);
Damien's avatar
Damien committed
654
655
                }
            } else {
656
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
657
                for (int i = 0; i < n - 1; i++) {
658
                    cpython_c_if_cond(comp, pns->nodes[i], false, label2, true);
Damien's avatar
Damien committed
659
                }
660
                cpython_c_if_cond(comp, pns->nodes[n - 1], true, label, true);
661
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
662
663
            }
            return;
664
        } else if (!is_nested && MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
665
            cpython_c_if_cond(comp, pns->nodes[0], !jump_if, label, true);
Damien's avatar
Damien committed
666
667
668
669
670
671
672
            return;
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
    if (jump_if == false) {
673
        EMIT_ARG(pop_jump_if_false, label);
Damien's avatar
Damien committed
674
    } else {
675
        EMIT_ARG(pop_jump_if_true, label);
Damien's avatar
Damien committed
676
677
    }
}
678
#endif
Damien's avatar
Damien committed
679

680
STATIC void c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label) {
681
#if MICROPY_EMIT_CPYTHON
682
683
684
685
    cpython_c_if_cond(comp, pn, jump_if, label, false);
#else
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
686
            EMIT_ARG(jump, label);
687
688
689
690
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
691
            EMIT_ARG(jump, label);
692
693
        }
        return;
694
695
696
697
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
698
            if (jump_if == false) {
699
                uint label2 = comp_next_label(comp);
700
701
702
703
                for (int i = 0; i < n - 1; i++) {
                    c_if_cond(comp, pns->nodes[i], true, label2);
                }
                c_if_cond(comp, pns->nodes[n - 1], false, label);
704
                EMIT_ARG(label_assign, label2);
705
706
707
708
709
710
            } else {
                for (int i = 0; i < n; i++) {
                    c_if_cond(comp, pns->nodes[i], true, label);
                }
            }
            return;
711
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
712
713
714
715
716
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
                    c_if_cond(comp, pns->nodes[i], false, label);
                }
            } else {
717
                uint label2 = comp_next_label(comp);
718
719
720
721
                for (int i = 0; i < n - 1; i++) {
                    c_if_cond(comp, pns->nodes[i], false, label2);
                }
                c_if_cond(comp, pns->nodes[n - 1], true, label);
722
                EMIT_ARG(label_assign, label2);
723
724
            }
            return;
725
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
726
727
            c_if_cond(comp, pns->nodes[0], !jump_if, label);
            return;
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_atom_paren) {
            // cond is something in parenthesis
            if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
                // empty tuple, acts as false for the condition
                if (jump_if == false) {
                    EMIT_ARG(jump, label);
                }
            } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                // non-empty tuple, acts as true for the condition
                if (jump_if == true) {
                    EMIT_ARG(jump, label);
                }
            } else {
                // parenthesis around 1 item, is just that item
                c_if_cond(comp, pns->nodes[0], jump_if, label);
            }
            return;
745
746
747
748
749
750
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
    if (jump_if == false) {
751
        EMIT_ARG(pop_jump_if_false, label);
752
    } else {
753
        EMIT_ARG(pop_jump_if_true, label);
754
755
    }
#endif
Damien's avatar
Damien committed
756
757
758
}

typedef enum { ASSIGN_STORE, ASSIGN_AUG_LOAD, ASSIGN_AUG_STORE } assign_kind_t;
759
STATIC void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t kind);
Damien's avatar
Damien committed
760

761
STATIC void c_assign_power(compiler_t *comp, mp_parse_node_struct_t *pns, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
762
763
764
765
    if (assign_kind != ASSIGN_AUG_STORE) {
        compile_node(comp, pns->nodes[0]);
    }

766
767
768
769
    if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
        mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_power_trailers) {
            int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns1);
Damien's avatar
Damien committed
770
771
772
773
774
            if (assign_kind != ASSIGN_AUG_STORE) {
                for (int i = 0; i < n - 1; i++) {
                    compile_node(comp, pns1->nodes[i]);
                }
            }
775
776
            assert(MP_PARSE_NODE_IS_STRUCT(pns1->nodes[n - 1]));
            pns1 = (mp_parse_node_struct_t*)pns1->nodes[n - 1];
Damien's avatar
Damien committed
777
        }
778
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_paren) {
779
            goto cannot_assign;
780
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_bracket) {
Damien's avatar
Damien committed
781
782
783
784
785
786
787
            if (assign_kind == ASSIGN_AUG_STORE) {
                EMIT(rot_three);
                EMIT(store_subscr);
            } else {
                compile_node(comp, pns1->nodes[0]);
                if (assign_kind == ASSIGN_AUG_LOAD) {
                    EMIT(dup_top_two);
788
                    EMIT(load_subscr);
Damien's avatar
Damien committed
789
790
791
792
                } else {
                    EMIT(store_subscr);
                }
            }
793
794
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_period) {
            assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
Damien's avatar
Damien committed
795
796
            if (assign_kind == ASSIGN_AUG_LOAD) {
                EMIT(dup_top);
797
                EMIT_ARG(load_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
798
799
800
801
            } else {
                if (assign_kind == ASSIGN_AUG_STORE) {
                    EMIT(rot_two);
                }
802
                EMIT_ARG(store_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
803
804
            }
        } else {
805
            goto cannot_assign;
Damien's avatar
Damien committed
806
807
        }
    } else {
808
        goto cannot_assign;
Damien's avatar
Damien committed
809
810
    }

811
    if (!MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
812
        goto cannot_assign;
Damien's avatar
Damien committed
813
    }
814
815
816
817
818

    return;

cannot_assign:
    compile_syntax_error(comp, (mp_parse_node_t)pns, "can't assign to expression");
Damien's avatar
Damien committed
819
820
}

821
// we need to allow for a caller passing in 1 initial node (node_head) followed by an array of nodes (nodes_tail)
822
STATIC void c_assign_tuple(compiler_t *comp, mp_parse_node_t node_head, uint num_tail, mp_parse_node_t *nodes_tail) {
823
824
825
    uint num_head = (node_head == MP_PARSE_NODE_NULL) ? 0 : 1;

    // look for star expression
Damien's avatar
Damien committed
826
    int have_star_index = -1;
827
828
829
830
831
832
    if (num_head != 0 && MP_PARSE_NODE_IS_STRUCT_KIND(node_head, PN_star_expr)) {
        EMIT_ARG(unpack_ex, 0, num_tail);
        have_star_index = 0;
    }
    for (int i = 0; i < num_tail; i++) {
        if (MP_PARSE_NODE_IS_STRUCT_KIND(nodes_tail[i], PN_star_expr)) {
Damien's avatar
Damien committed
833
            if (have_star_index < 0) {
834
835
                EMIT_ARG(unpack_ex, num_head + i, num_tail - i - 1);
                have_star_index = num_head + i;
Damien's avatar
Damien committed
836
            } else {
837
                compile_syntax_error(comp, nodes_tail[i], "multiple *x in assignment");
Damien's avatar
Damien committed
838
839
840
841
842
                return;
            }
        }
    }
    if (have_star_index < 0) {
843
        EMIT_ARG(unpack_sequence, num_head + num_tail);
Damien's avatar
Damien committed
844
    }
845
846
847
    if (num_head != 0) {
        if (0 == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)node_head)->nodes[0], ASSIGN_STORE);
Damien's avatar
Damien committed
848
        } else {
849
850
851
852
853
854
855
856
            c_assign(comp, node_head, ASSIGN_STORE);
        }
    }
    for (int i = 0; i < num_tail; i++) {
        if (num_head + i == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)nodes_tail[i])->nodes[0], ASSIGN_STORE);
        } else {
            c_assign(comp, nodes_tail[i], ASSIGN_STORE);
Damien's avatar
Damien committed
857
858
859
860
861
        }
    }
}

// assigns top of stack to pn
862
STATIC void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
863
    tail_recursion:
864
    if (MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
865
        assert(0);
866
867
    } else if (MP_PARSE_NODE_IS_LEAF(pn)) {
        if (MP_PARSE_NODE_IS_ID(pn)) {
868
            qstr arg = MP_PARSE_NODE_LEAF_ARG(pn);
Damien's avatar
Damien committed
869
870
871
            switch (assign_kind) {
                case ASSIGN_STORE:
                case ASSIGN_AUG_STORE:
872
                    EMIT_ARG(store_id, arg);
Damien's avatar
Damien committed
873
874
                    break;
                case ASSIGN_AUG_LOAD:
875
                    EMIT_ARG(load_id, arg);
Damien's avatar
Damien committed
876
877
878
                    break;
            }
        } else {
879
            compile_syntax_error(comp, pn, "can't assign to literal");
Damien's avatar
Damien committed
880
881
882
            return;
        }
    } else {
883
884
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
Damien's avatar
Damien committed
885
886
887
888
889
890
891
892
893
894
895
            case PN_power:
                // lhs is an index or attribute
                c_assign_power(comp, pns, assign_kind);
                break;

            case PN_testlist_star_expr:
            case PN_exprlist:
                // lhs is a tuple
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
896
                c_assign_tuple(comp, MP_PARSE_NODE_NULL, MP_PARSE_NODE_STRUCT_NUM_NODES(pns), pns->nodes);
Damien's avatar
Damien committed
897
898
899
900
                break;

            case PN_atom_paren:
                // lhs is something in parenthesis
901
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
902
                    // empty tuple
903
                    goto cannot_assign;
904
905
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
906
907
908
909
910
911
912
913
914
915
916
917
918
                    goto testlist_comp;
                } else {
                    // parenthesis around 1 item, is just that item
                    pn = pns->nodes[0];
                    goto tail_recursion;
                }
                break;

            case PN_atom_bracket:
                // lhs is something in brackets
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
919
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
920
                    // empty list, assignment allowed
921
                    c_assign_tuple(comp, MP_PARSE_NODE_NULL, 0, NULL);
922
923
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
924
925
926
                    goto testlist_comp;
                } else {
                    // brackets around 1 item
927
                    c_assign_tuple(comp, pns->nodes[0], 0, NULL);
Damien's avatar
Damien committed
928
929
930
931
                }
                break;

            default:
932
                goto cannot_assign;
Damien's avatar
Damien committed
933
934
935
936
937
        }
        return;

        testlist_comp:
        // lhs is a sequence
938
939
940
        if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
            mp_parse_node_struct_t *pns2 = (mp_parse_node_struct_t*)pns->nodes[1];
            if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3b) {
Damien's avatar
Damien committed
941
                // sequence of one item, with trailing comma
942
                assert(MP_PARSE_NODE_IS_NULL(pns2->nodes[0]));
943
                c_assign_tuple(comp, pns->nodes[0], 0, NULL);
944
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3c) {
Damien's avatar
Damien committed
945
                // sequence of many items
946
947
                uint n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns2);
                c_assign_tuple(comp, pns->nodes[0], n, pns2->nodes);
948
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_comp_for) {
949
                // TODO can we ever get here? can it be compiled?
950
                goto cannot_assign;
Damien's avatar
Damien committed
951
952
953
954
955
956
957
            } else {
                // sequence with 2 items
                goto sequence_with_2_items;
            }
        } else {
            // sequence with 2 items
            sequence_with_2_items:
958
            c_assign_tuple(comp, MP_PARSE_NODE_NULL, 2, pns->nodes);
Damien's avatar
Damien committed
959
960
961
962
963
        }
        return;
    }
    return;

964
965
966
967
    cannot_assign:
    compile_syntax_error(comp, pn, "can't assign to expression");
    return;

Damien's avatar
Damien committed
968
    bad_aug:
969
    compile_syntax_error(comp, pn, "illegal expression for augmented assignment");
Damien's avatar
Damien committed
970
971
972
}

// stuff for lambda and comprehensions and generators
973
974
975
976
// if we are not in CPython compatibility mode then:
//  if n_pos_defaults > 0 then there is a tuple on the stack with the positional defaults
//  if n_kw_defaults > 0 then there is a dictionary on the stack with the keyword defaults
//  if both exist, the tuple is above the dictionary (ie the first pop gets the tuple)
977
STATIC void close_over_variables_etc(compiler_t *comp, scope_t *this_scope, int n_pos_defaults, int n_kw_defaults) {
978
979
980
    assert(n_pos_defaults >= 0);
    assert(n_kw_defaults >= 0);

Damien's avatar
Damien committed
981
    // make closed over variables, if any
982
    // ensure they are closed over in the order defined in the outer scope (mainly to agree with CPython)
Damien's avatar
Damien committed
983
984
    int nfree = 0;
    if (comp->scope_cur->kind != SCOPE_MODULE) {
985
986
987
988
989
        for (int i = 0; i < comp->scope_cur->id_info_len; i++) {
            id_info_t *id = &comp->scope_cur->id_info[i];
            if (id->kind == ID_INFO_KIND_CELL || id->kind == ID_INFO_KIND_FREE) {
                for (int j = 0; j < this_scope->id_info_len; j++) {
                    id_info_t *id2 = &this_scope->id_info[j];
990
                    if (id2->kind == ID_INFO_KIND_FREE && id->qst == id2->qst) {
Damien George's avatar
Damien George committed
991
#if MICROPY_EMIT_CPYTHON
992
                        EMIT_ARG(load_closure, id->qst, id->local_num);
Damien George's avatar
Damien George committed
993
994
#else
                        // in Micro Python we load closures using LOAD_FAST
995
                        EMIT_ARG(load_fast, id->qst, id->flags, id->local_num);
Damien George's avatar
Damien George committed
996
#endif
997
998
999
                        nfree += 1;
                    }
                }
Damien's avatar
Damien committed
1000
            }