compile.c 144 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
/*
 * This file is part of the Micro Python project, http://micropython.org/
 *
 * The MIT License (MIT)
 *
 * Copyright (c) 2013, 2014 Damien P. George
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

xbe's avatar
xbe committed
27
#include <stdbool.h>
Damien's avatar
Damien committed
28
29
30
31
#include <stdint.h>
#include <stdio.h>
#include <string.h>
#include <assert.h>
32
#include <math.h>
Damien's avatar
Damien committed
33

34
#include "mpconfig.h"
35
#include "misc.h"
36
#include "qstr.h"
Damien's avatar
Damien committed
37
38
#include "lexer.h"
#include "parse.h"
39
#include "runtime0.h"
40
#include "obj.h"
41
42
43
#include "emitglue.h"
#include "scope.h"
#include "emit.h"
44
45
#include "compile.h"
#include "runtime.h"
46
#include "builtin.h"
47
#include "smallint.h"
Damien's avatar
Damien committed
48
49
50

// TODO need to mangle __attr names

51
52
#define MICROPY_EMIT_NATIVE (MICROPY_EMIT_X64 || MICROPY_EMIT_THUMB)

Damien's avatar
Damien committed
53
54
typedef enum {
    PN_none = 0,
55
#define DEF_RULE(rule, comp, kind, ...) PN_##rule,
Damien's avatar
Damien committed
56
57
58
#include "grammar.h"
#undef DEF_RULE
    PN_maximum_number_of,
59
    PN_string, // special node for non-interned string
Damien's avatar
Damien committed
60
61
} pn_kind_t;

62
63
64
65
#define EMIT(fun) (comp->emit_method_table->fun(comp->emit))
#define EMIT_ARG(fun, ...) (comp->emit_method_table->fun(comp->emit, __VA_ARGS__))
#define EMIT_INLINE_ASM(fun) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm))
#define EMIT_INLINE_ASM_ARG(fun, ...) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm, __VA_ARGS__))
Damien's avatar
Damien committed
66
67

typedef struct _compiler_t {
68
    qstr source_file;
69
70
71
72
    uint8_t is_repl;
    uint8_t pass; // holds enum type pass_kind_t
    uint8_t had_error; // try to keep compiler clean from nlr
    uint8_t func_arg_is_super; // used to compile special case of super() function call
Damien's avatar
Damien committed
73

74
    uint next_label;
75

76
77
    uint16_t break_label; // highest bit set indicates we are breaking out of a for loop
    uint16_t continue_label;
78
    int break_continue_except_level;
79
    uint16_t cur_except_level; // increased for SETUP_EXCEPT, SETUP_FINALLY; decreased for POP_BLOCK, POP_EXCEPT
Damien's avatar
Damien committed
80

81
    uint8_t have_star;
82
83
    uint16_t num_dict_params;
    uint16_t num_default_params;
Damien's avatar
Damien committed
84
85
86
87

    scope_t *scope_head;
    scope_t *scope_cur;

88
89
    emit_t *emit;                                   // current emitter
    const emit_method_table_t *emit_method_table;   // current emit method table
90
91
92

    emit_inline_asm_t *emit_inline_asm;                                   // current emitter for inline asm
    const emit_inline_asm_method_table_t *emit_inline_asm_method_table;   // current emit method table for inline asm
Damien's avatar
Damien committed
93
94
} compiler_t;

95
STATIC void compile_syntax_error(compiler_t *comp, mp_parse_node_t pn, const char *msg) {
96
    // TODO store the error message to a variable in compiler_t instead of printing it
97
    if (MP_PARSE_NODE_IS_STRUCT(pn)) {
98
        printf("  File \"%s\", line " UINT_FMT "\n", qstr_str(comp->source_file), (mp_uint_t)((mp_parse_node_struct_t*)pn)->source_line);
99
100
101
    } else {
        printf("  File \"%s\"\n", qstr_str(comp->source_file));
    }
102
103
104
105
    printf("SyntaxError: %s\n", msg);
    comp->had_error = true;
}

106
STATIC const mp_map_elem_t mp_constants_table[] = {
107
108
109
    #if MICROPY_PY_UCTYPES
    { MP_OBJ_NEW_QSTR(MP_QSTR_uctypes), (mp_obj_t)&mp_module_uctypes },
    #endif
110
    // Extra constants as defined by a port
111
    MICROPY_PORT_CONSTANTS
112
113
114
115
116
};

STATIC const mp_map_t mp_constants_map = {
    .all_keys_are_qstrs = 1,
    .table_is_fixed_array = 1,
117
118
    .used = MP_ARRAY_SIZE(mp_constants_table),
    .alloc = MP_ARRAY_SIZE(mp_constants_table),
119
120
121
    .table = (mp_map_elem_t*)mp_constants_table,
};

122
123
124
125
// this function is essentially a simple preprocessor
STATIC mp_parse_node_t fold_constants(compiler_t *comp, mp_parse_node_t pn, mp_map_t *consts) {
    if (0) {
        // dummy
126
#if MICROPY_COMP_CONST
127
128
129
130
131
132
133
134
135
    } else if (MP_PARSE_NODE_IS_ID(pn)) {
        // lookup identifier in table of dynamic constants
        qstr qst = MP_PARSE_NODE_LEAF_ARG(pn);
        mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(qst), MP_MAP_LOOKUP);
        if (elem != NULL) {
            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, MP_OBJ_SMALL_INT_VALUE(elem->value));
        }
#endif
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
136
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
Damien's avatar
Damien committed
137

138
139
        // fold some parse nodes before folding their arguments
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
140
#if MICROPY_COMP_CONST
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
            case PN_expr_stmt:
                if (!MP_PARSE_NODE_IS_NULL(pns->nodes[1])) {
                    mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_expr_stmt_assign) {
                        if (MP_PARSE_NODE_IS_ID(pns->nodes[0])
                            && MP_PARSE_NODE_IS_STRUCT_KIND(pns1->nodes[0], PN_power)
                            && MP_PARSE_NODE_IS_ID(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0])
                            && MP_PARSE_NODE_LEAF_ARG(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0]) == MP_QSTR_const
                            && MP_PARSE_NODE_IS_STRUCT_KIND(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1], PN_trailer_paren)
                            && MP_PARSE_NODE_IS_NULL(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[2])
                            ) {
                            // code to assign dynamic constants: id = const(value)

                            // get the id
                            qstr id_qstr = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);

                            // get the value
                            mp_parse_node_t pn_value = ((mp_parse_node_struct_t*)((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1])->nodes[0];
                            pn_value = fold_constants(comp, pn_value, consts);
                            if (!MP_PARSE_NODE_IS_SMALL_INT(pn_value)) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant must be an integer");
                                break;
                            }
164
                            mp_int_t value = MP_PARSE_NODE_LEAF_SMALL_INT(pn_value);
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183

                            // store the value in the table of dynamic constants
                            mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(id_qstr), MP_MAP_LOOKUP_ADD_IF_NOT_FOUND);
                            if (elem->value != MP_OBJ_NULL) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant redefined");
                                break;
                            }
                            elem->value = MP_OBJ_NEW_SMALL_INT(value);

                            // replace const(value) with value
                            pns1->nodes[0] = pn_value;

                            // finished folding this assignment
                            return pn;
                        }
                    }
                }
                break;
#endif
184
185
            case PN_string:
                return pn;
186
187
188
189
        }

        // fold arguments
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
190
        for (int i = 0; i < n; i++) {
191
            pns->nodes[i] = fold_constants(comp, pns->nodes[i], consts);
Damien's avatar
Damien committed
192
193
        }

194
        // try to fold this parse node
195
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
196
197
198
199
200
201
202
203
204
205
            case PN_atom_paren:
                if (n == 1 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0])) {
                    // (int)
                    pn = pns->nodes[0];
                }
                break;

            case PN_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int | int
206
207
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
208
209
210
211
212
213
214
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 | arg1);
                }
                break;

            case PN_and_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int & int
215
216
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
217
218
219
220
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 & arg1);
                }
                break;

Damien's avatar
Damien committed
221
            case PN_shift_expr:
222
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
223
224
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
225
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_LESS)) {
226
227
228
229
                        // int << int
                        if (!(arg1 >= BITS_PER_WORD || arg0 > (MP_SMALL_INT_MAX >> arg1) || arg0 < (MP_SMALL_INT_MIN >> arg1))) {
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 << arg1);
                        }
230
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_MORE)) {
231
                        // int >> int
232
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 >> arg1);
Damien's avatar
Damien committed
233
234
235
236
237
238
239
240
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_arith_expr:
241
                // overflow checking here relies on SMALL_INT being strictly smaller than mp_int_t
242
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
243
244
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
245
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PLUS)) {
246
                        // int + int
247
                        arg0 += arg1;
248
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_MINUS)) {
249
                        // int - int
250
                        arg0 -= arg1;
Damien's avatar
Damien committed
251
252
253
                    } else {
                        // shouldn't happen
                        assert(0);
254
                    }
255
                    if (MP_SMALL_INT_FITS(arg0)) {
256
                        //printf("%ld + %ld\n", arg0, arg1);
257
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
Damien's avatar
Damien committed
258
259
260
261
262
                    }
                }
                break;

            case PN_term:
263
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
264
265
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
266
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_STAR)) {
267
                        // int * int
268
269
                        if (!mp_small_int_mul_overflow(arg0, arg1)) {
                            arg0 *= arg1;
270
                            if (MP_SMALL_INT_FITS(arg0)) {
271
272
273
                                pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
                            }
                        }
274
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_SLASH)) {
275
276
                        // int / int
                        // pass
277
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PERCENT)) {
278
                        // int%int
279
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_modulo(arg0, arg1));
280
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_SLASH)) {
281
                        if (arg1 != 0) {
282
                            // int // int
283
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_floor_divide(arg0, arg1));
284
                        }
Damien's avatar
Damien committed
285
286
287
288
289
290
291
292
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_factor_2:
293
                if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
294
                    mp_int_t arg = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
295
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_PLUS)) {
296
                        // +int
297
298
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_MINUS)) {
299
                        // -int
300
301
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, -arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_TILDE)) {
302
                        // ~int
303
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ~arg);
Damien's avatar
Damien committed
304
305
306
307
308
309
310
311
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_power:
312
313
314
                if (0) {
#if MICROPY_EMIT_CPYTHON
                } else if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_NULL(pns->nodes[1]) && !MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
315
                    // int ** x
316
                    // can overflow; enabled only to compare with CPython
317
318
                    mp_parse_node_struct_t* pns2 = (mp_parse_node_struct_t*)pns->nodes[2];
                    if (MP_PARSE_NODE_IS_SMALL_INT(pns2->nodes[0])) {
319
                        int power = MP_PARSE_NODE_LEAF_SMALL_INT(pns2->nodes[0]);
Damien's avatar
Damien committed
320
321
                        if (power >= 0) {
                            int ans = 1;
322
                            int base = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
Damien's avatar
Damien committed
323
324
325
                            for (; power > 0; power--) {
                                ans *= base;
                            }
326
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ans);
Damien's avatar
Damien committed
327
328
                        }
                    }
329
330
331
332
333
334
335
336
337
338
339
340
341
#endif
                } else if (MP_PARSE_NODE_IS_ID(pns->nodes[0]) && MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[1], PN_trailer_period) && MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
                    // id.id
                    // look it up in constant table, see if it can be replaced with an integer
                    mp_parse_node_struct_t* pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
                    qstr q_base = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);
                    qstr q_attr = MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]);
                    mp_map_elem_t *elem = mp_map_lookup((mp_map_t*)&mp_constants_map, MP_OBJ_NEW_QSTR(q_base), MP_MAP_LOOKUP);
                    if (elem != NULL) {
                        mp_obj_t dest[2];
                        mp_load_method_maybe(elem->value, q_attr, dest);
                        if (MP_OBJ_IS_SMALL_INT(dest[0]) && dest[1] == NULL) {
342
                            mp_int_t val = MP_OBJ_SMALL_INT_VALUE(dest[0]);
343
                            if (MP_SMALL_INT_FITS(val)) {
344
345
346
347
                                pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, val);
                            }
                        }
                    }
Damien's avatar
Damien committed
348
349
350
351
352
353
354
355
                }
                break;
        }
    }

    return pn;
}

356
STATIC void compile_trailer_paren_helper(compiler_t *comp, mp_parse_node_t pn_arglist, bool is_method_call, int n_positional_extra);
357
void compile_comprehension(compiler_t *comp, mp_parse_node_struct_t *pns, scope_kind_t kind);
358
STATIC void compile_node(compiler_t *comp, mp_parse_node_t pn);
Damien's avatar
Damien committed
359

360
STATIC uint comp_next_label(compiler_t *comp) {
361
362
363
    return comp->next_label++;
}

364
365
366
367
368
369
370
371
372
373
374
375
STATIC void compile_increase_except_level(compiler_t *comp) {
    comp->cur_except_level += 1;
    if (comp->cur_except_level > comp->scope_cur->exc_stack_size) {
        comp->scope_cur->exc_stack_size = comp->cur_except_level;
    }
}

STATIC void compile_decrease_except_level(compiler_t *comp) {
    assert(comp->cur_except_level > 0);
    comp->cur_except_level -= 1;
}

376
STATIC scope_t *scope_new_and_link(compiler_t *comp, scope_kind_t kind, mp_parse_node_t pn, uint emit_options) {
377
    scope_t *scope = scope_new(kind, pn, comp->source_file, emit_options);
Damien's avatar
Damien committed
378
379
380
381
382
383
384
385
386
387
388
389
390
391
    scope->parent = comp->scope_cur;
    scope->next = NULL;
    if (comp->scope_head == NULL) {
        comp->scope_head = scope;
    } else {
        scope_t *s = comp->scope_head;
        while (s->next != NULL) {
            s = s->next;
        }
        s->next = scope;
    }
    return scope;
}

392
STATIC void apply_to_single_or_list(compiler_t *comp, mp_parse_node_t pn, int pn_list_kind, void (*f)(compiler_t*, mp_parse_node_t)) {
393
394
395
    if (MP_PARSE_NODE_IS_STRUCT(pn) && MP_PARSE_NODE_STRUCT_KIND((mp_parse_node_struct_t*)pn) == pn_list_kind) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
396
397
398
        for (int i = 0; i < num_nodes; i++) {
            f(comp, pns->nodes[i]);
        }
399
    } else if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
400
401
402
403
        f(comp, pn);
    }
}

404
STATIC int list_get(mp_parse_node_t *pn, int pn_kind, mp_parse_node_t **nodes) {
405
    if (MP_PARSE_NODE_IS_NULL(*pn)) {
Damien's avatar
Damien committed
406
407
        *nodes = NULL;
        return 0;
408
    } else if (MP_PARSE_NODE_IS_LEAF(*pn)) {
Damien's avatar
Damien committed
409
410
411
        *nodes = pn;
        return 1;
    } else {
412
413
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)(*pn);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) != pn_kind) {
Damien's avatar
Damien committed
414
415
416
417
            *nodes = pn;
            return 1;
        } else {
            *nodes = pns->nodes;
418
            return MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
419
420
421
422
        }
    }
}

423
void compile_do_nothing(compiler_t *comp, mp_parse_node_struct_t *pns) {
Damien's avatar
Damien committed
424
425
}

426
427
void compile_generic_all_nodes(compiler_t *comp, mp_parse_node_struct_t *pns) {
    int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
428
429
430
431
432
    for (int i = 0; i < num_nodes; i++) {
        compile_node(comp, pns->nodes[i]);
    }
}

433
#if MICROPY_EMIT_CPYTHON
434
STATIC bool cpython_c_tuple_is_const(mp_parse_node_t pn) {
435
436
437
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string)) {
        return true;
    }
438
    if (!MP_PARSE_NODE_IS_LEAF(pn)) {
Damien's avatar
Damien committed
439
440
        return false;
    }
441
    if (MP_PARSE_NODE_IS_ID(pn)) {
Damien's avatar
Damien committed
442
443
444
445
446
        return false;
    }
    return true;
}

447
STATIC void cpython_c_print_quoted_str(vstr_t *vstr, const char *str, uint len, bool bytes) {
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
    bool has_single_quote = false;
    bool has_double_quote = false;
    for (int i = 0; i < len; i++) {
        if (str[i] == '\'') {
            has_single_quote = true;
        } else if (str[i] == '"') {
            has_double_quote = true;
        }
    }
    if (bytes) {
        vstr_printf(vstr, "b");
    }
    bool quote_single = false;
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        quote_single = true;
        vstr_printf(vstr, "'");
    }
    for (int i = 0; i < len; i++) {
        if (str[i] == '\n') {
            vstr_printf(vstr, "\\n");
        } else if (str[i] == '\\') {
            vstr_printf(vstr, "\\\\");
        } else if (str[i] == '\'' && quote_single) {
            vstr_printf(vstr, "\\'");
        } else {
            vstr_printf(vstr, "%c", str[i]);
        }
    }
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        vstr_printf(vstr, "'");
    }
}

485
STATIC void cpython_c_tuple_emit_const(compiler_t *comp, mp_parse_node_t pn, vstr_t *vstr) {
486
487
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
488
        cpython_c_print_quoted_str(vstr, (const char*)pns->nodes[0], (mp_uint_t)pns->nodes[1], false);
489
490
491
        return;
    }

492
    assert(MP_PARSE_NODE_IS_LEAF(pn));
493
494
495
496
497
    if (MP_PARSE_NODE_IS_SMALL_INT(pn)) {
        vstr_printf(vstr, INT_FMT, MP_PARSE_NODE_LEAF_SMALL_INT(pn));
        return;
    }

498
499
500
501
502
    int arg = MP_PARSE_NODE_LEAF_ARG(pn);
    switch (MP_PARSE_NODE_LEAF_KIND(pn)) {
        case MP_PARSE_NODE_ID: assert(0);
        case MP_PARSE_NODE_INTEGER: vstr_printf(vstr, "%s", qstr_str(arg)); break;
        case MP_PARSE_NODE_DECIMAL: vstr_printf(vstr, "%s", qstr_str(arg)); break;
503
504
505
506
507
508
509
        case MP_PARSE_NODE_STRING:
        case MP_PARSE_NODE_BYTES: {
            uint len;
            const byte *str = qstr_data(arg, &len);
            cpython_c_print_quoted_str(vstr, (const char*)str, len, MP_PARSE_NODE_LEAF_KIND(pn) == MP_PARSE_NODE_BYTES);
            break;
        }
510
        case MP_PARSE_NODE_TOKEN:
Damien's avatar
Damien committed
511
            switch (arg) {
512
513
514
                case MP_TOKEN_KW_FALSE: vstr_printf(vstr, "False"); break;
                case MP_TOKEN_KW_NONE: vstr_printf(vstr, "None"); break;
                case MP_TOKEN_KW_TRUE: vstr_printf(vstr, "True"); break;
515
                default: assert(0); // shouldn't happen
Damien's avatar
Damien committed
516
517
518
519
520
521
            }
            break;
        default: assert(0);
    }
}

522
STATIC void cpython_c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
Damien's avatar
Damien committed
523
524
    int n = 0;
    if (pns_list != NULL) {
525
        n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
Damien's avatar
Damien committed
526
527
528
    }
    int total = n;
    bool is_const = true;
529
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
530
        total += 1;
531
        if (!cpython_c_tuple_is_const(pn)) {
Damien's avatar
Damien committed
532
533
534
535
            is_const = false;
        }
    }
    for (int i = 0; i < n; i++) {
536
        if (!cpython_c_tuple_is_const(pns_list->nodes[i])) {
Damien's avatar
Damien committed
537
538
539
540
541
542
            is_const = false;
            break;
        }
    }
    if (total > 0 && is_const) {
        bool need_comma = false;
543
544
        vstr_t *vstr = vstr_new();
        vstr_printf(vstr, "(");
545
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
546
            cpython_c_tuple_emit_const(comp, pn, vstr);
Damien's avatar
Damien committed
547
548
549
550
            need_comma = true;
        }
        for (int i = 0; i < n; i++) {
            if (need_comma) {
551
                vstr_printf(vstr, ", ");
Damien's avatar
Damien committed
552
            }
553
            cpython_c_tuple_emit_const(comp, pns_list->nodes[i], vstr);
Damien's avatar
Damien committed
554
555
556
            need_comma = true;
        }
        if (total == 1) {
557
            vstr_printf(vstr, ",)");
Damien's avatar
Damien committed
558
        } else {
559
            vstr_printf(vstr, ")");
Damien's avatar
Damien committed
560
        }
561
        EMIT_ARG(load_const_verbatim_str, vstr_str(vstr));
562
        vstr_free(vstr);
Damien's avatar
Damien committed
563
    } else {
564
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
565
566
567
568
569
            compile_node(comp, pn);
        }
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
570
        EMIT_ARG(build_tuple, total);
Damien's avatar
Damien committed
571
572
    }
}
573
574
575
#endif

// funnelling all tuple creations through this function is purely so we can optionally agree with CPython
576
STATIC void c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
577
#if MICROPY_EMIT_CPYTHON
578
579
580
    cpython_c_tuple(comp, pn, pns_list);
#else
    int total = 0;
581
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
582
583
584
585
        compile_node(comp, pn);
        total += 1;
    }
    if (pns_list != NULL) {
586
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
587
588
589
590
591
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
        total += n;
    }
592
    EMIT_ARG(build_tuple, total);
593
594
#endif
}
Damien's avatar
Damien committed
595

596
void compile_generic_tuple(compiler_t *comp, mp_parse_node_struct_t *pns) {
Damien's avatar
Damien committed
597
    // a simple tuple expression
598
    c_tuple(comp, MP_PARSE_NODE_NULL, pns);
Damien's avatar
Damien committed
599
600
}

601
STATIC bool node_is_const_false(mp_parse_node_t pn) {
602
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_FALSE);
603
    // untested: || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) == 0);
Damien's avatar
Damien committed
604
605
}

606
STATIC bool node_is_const_true(mp_parse_node_t pn) {
607
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_TRUE) || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) == 1);
Damien's avatar
Damien committed
608
609
}

610
#if MICROPY_EMIT_CPYTHON
611
// the is_nested variable is purely to match with CPython, which doesn't fully optimise not's
612
STATIC void cpython_c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label, bool is_nested) {
Damien's avatar
Damien committed
613
614
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
615
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
616
617
618
619
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
620
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
621
622
        }
        return;
623
624
625
626
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
Damien's avatar
Damien committed
627
            if (jump_if == false) {
628
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
629
                for (int i = 0; i < n - 1; i++) {
630
                    cpython_c_if_cond(comp, pns->nodes[i], true, label2, true);
Damien's avatar
Damien committed
631
                }
632
                cpython_c_if_cond(comp, pns->nodes[n - 1], false, label, true);
633
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
634
635
            } else {
                for (int i = 0; i < n; i++) {
636
                    cpython_c_if_cond(comp, pns->nodes[i], true, label, true);
Damien's avatar
Damien committed
637
638
639
                }
            }
            return;
640
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
Damien's avatar
Damien committed
641
642
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
643
                    cpython_c_if_cond(comp, pns->nodes[i], false, label, true);
Damien's avatar
Damien committed
644
645
                }
            } else {
646
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
647
                for (int i = 0; i < n - 1; i++) {
648
                    cpython_c_if_cond(comp, pns->nodes[i], false, label2, true);
Damien's avatar
Damien committed
649
                }
650
                cpython_c_if_cond(comp, pns->nodes[n - 1], true, label, true);
651
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
652
653
            }
            return;
654
        } else if (!is_nested && MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
655
            cpython_c_if_cond(comp, pns->nodes[0], !jump_if, label, true);
Damien's avatar
Damien committed
656
657
658
659
660
661
662
            return;
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
    if (jump_if == false) {
663
        EMIT_ARG(pop_jump_if_false, label);
Damien's avatar
Damien committed
664
    } else {
665
        EMIT_ARG(pop_jump_if_true, label);
Damien's avatar
Damien committed
666
667
    }
}
668
#endif
Damien's avatar
Damien committed
669

670
STATIC void c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label) {
671
#if MICROPY_EMIT_CPYTHON
672
673
674
675
    cpython_c_if_cond(comp, pn, jump_if, label, false);
#else
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
676
            EMIT_ARG(jump, label);
677
678
679
680
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
681
            EMIT_ARG(jump, label);
682
683
        }
        return;
684
685
686
687
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
688
            if (jump_if == false) {
689
                uint label2 = comp_next_label(comp);
690
691
692
693
                for (int i = 0; i < n - 1; i++) {
                    c_if_cond(comp, pns->nodes[i], true, label2);
                }
                c_if_cond(comp, pns->nodes[n - 1], false, label);
694
                EMIT_ARG(label_assign, label2);
695
696
697
698
699
700
            } else {
                for (int i = 0; i < n; i++) {
                    c_if_cond(comp, pns->nodes[i], true, label);
                }
            }
            return;
701
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
702
703
704
705
706
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
                    c_if_cond(comp, pns->nodes[i], false, label);
                }
            } else {
707
                uint label2 = comp_next_label(comp);
708
709
710
711
                for (int i = 0; i < n - 1; i++) {
                    c_if_cond(comp, pns->nodes[i], false, label2);
                }
                c_if_cond(comp, pns->nodes[n - 1], true, label);
712
                EMIT_ARG(label_assign, label2);
713
714
            }
            return;
715
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
716
717
718
719
720
721
722
723
            c_if_cond(comp, pns->nodes[0], !jump_if, label);
            return;
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
    if (jump_if == false) {
724
        EMIT_ARG(pop_jump_if_false, label);
725
    } else {
726
        EMIT_ARG(pop_jump_if_true, label);
727
728
    }
#endif
Damien's avatar
Damien committed
729
730
731
}

typedef enum { ASSIGN_STORE, ASSIGN_AUG_LOAD, ASSIGN_AUG_STORE } assign_kind_t;
732
void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t kind);
Damien's avatar
Damien committed
733

734
void c_assign_power(compiler_t *comp, mp_parse_node_struct_t *pns, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
735
736
737
738
    if (assign_kind != ASSIGN_AUG_STORE) {
        compile_node(comp, pns->nodes[0]);
    }

739
740
741
742
    if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
        mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_power_trailers) {
            int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns1);
Damien's avatar
Damien committed
743
744
745
746
747
            if (assign_kind != ASSIGN_AUG_STORE) {
                for (int i = 0; i < n - 1; i++) {
                    compile_node(comp, pns1->nodes[i]);
                }
            }
748
749
            assert(MP_PARSE_NODE_IS_STRUCT(pns1->nodes[n - 1]));
            pns1 = (mp_parse_node_struct_t*)pns1->nodes[n - 1];
Damien's avatar
Damien committed
750
        }
751
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_paren) {
752
            goto cannot_assign;
753
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_bracket) {
Damien's avatar
Damien committed
754
755
756
757
758
759
760
            if (assign_kind == ASSIGN_AUG_STORE) {
                EMIT(rot_three);
                EMIT(store_subscr);
            } else {
                compile_node(comp, pns1->nodes[0]);
                if (assign_kind == ASSIGN_AUG_LOAD) {
                    EMIT(dup_top_two);
761
                    EMIT(load_subscr);
Damien's avatar
Damien committed
762
763
764
765
                } else {
                    EMIT(store_subscr);
                }
            }
766
767
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_period) {
            assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
Damien's avatar
Damien committed
768
769
            if (assign_kind == ASSIGN_AUG_LOAD) {
                EMIT(dup_top);
770
                EMIT_ARG(load_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
771
772
773
774
            } else {
                if (assign_kind == ASSIGN_AUG_STORE) {
                    EMIT(rot_two);
                }
775
                EMIT_ARG(store_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
776
777
            }
        } else {
778
            goto cannot_assign;
Damien's avatar
Damien committed
779
780
        }
    } else {
781
        goto cannot_assign;
Damien's avatar
Damien committed
782
783
    }

784
    if (!MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
785
        goto cannot_assign;
Damien's avatar
Damien committed
786
    }
787
788
789
790
791

    return;

cannot_assign:
    compile_syntax_error(comp, (mp_parse_node_t)pns, "can't assign to expression");
Damien's avatar
Damien committed
792
793
}

794
795
796
797
798
// we need to allow for a caller passing in 1 initial node (node_head) followed by an array of nodes (nodes_tail)
void c_assign_tuple(compiler_t *comp, mp_parse_node_t node_head, uint num_tail, mp_parse_node_t *nodes_tail) {
    uint num_head = (node_head == MP_PARSE_NODE_NULL) ? 0 : 1;

    // look for star expression
Damien's avatar
Damien committed
799
    int have_star_index = -1;
800
801
802
803
804
805
    if (num_head != 0 && MP_PARSE_NODE_IS_STRUCT_KIND(node_head, PN_star_expr)) {
        EMIT_ARG(unpack_ex, 0, num_tail);
        have_star_index = 0;
    }
    for (int i = 0; i < num_tail; i++) {
        if (MP_PARSE_NODE_IS_STRUCT_KIND(nodes_tail[i], PN_star_expr)) {
Damien's avatar
Damien committed
806
            if (have_star_index < 0) {
807
808
                EMIT_ARG(unpack_ex, num_head + i, num_tail - i - 1);
                have_star_index = num_head + i;
Damien's avatar
Damien committed
809
            } else {
810
                compile_syntax_error(comp, nodes_tail[i], "multiple *x in assignment");
Damien's avatar
Damien committed
811
812
813
814
815
                return;
            }
        }
    }
    if (have_star_index < 0) {
816
        EMIT_ARG(unpack_sequence, num_head + num_tail);
Damien's avatar
Damien committed
817
    }
818
819
820
    if (num_head != 0) {
        if (0 == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)node_head)->nodes[0], ASSIGN_STORE);
Damien's avatar
Damien committed
821
        } else {
822
823
824
825
826
827
828
829
            c_assign(comp, node_head, ASSIGN_STORE);
        }
    }
    for (int i = 0; i < num_tail; i++) {
        if (num_head + i == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)nodes_tail[i])->nodes[0], ASSIGN_STORE);
        } else {
            c_assign(comp, nodes_tail[i], ASSIGN_STORE);
Damien's avatar
Damien committed
830
831
832
833
834
        }
    }
}

// assigns top of stack to pn
835
void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
836
    tail_recursion:
837
    if (MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
838
        assert(0);
839
840
841
    } else if (MP_PARSE_NODE_IS_LEAF(pn)) {
        if (MP_PARSE_NODE_IS_ID(pn)) {
            int arg = MP_PARSE_NODE_LEAF_ARG(pn);
Damien's avatar
Damien committed
842
843
844
            switch (assign_kind) {
                case ASSIGN_STORE:
                case ASSIGN_AUG_STORE:
845
                    EMIT_ARG(store_id, arg);
Damien's avatar
Damien committed
846
847
                    break;
                case ASSIGN_AUG_LOAD:
848
                    EMIT_ARG(load_id, arg);
Damien's avatar
Damien committed
849
850
851
                    break;
            }
        } else {
852
            compile_syntax_error(comp, pn, "can't assign to literal");
Damien's avatar
Damien committed
853
854
855
            return;
        }
    } else {
856
857
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
Damien's avatar
Damien committed
858
859
860
861
862
863
864
865
866
867
868
            case PN_power:
                // lhs is an index or attribute
                c_assign_power(comp, pns, assign_kind);
                break;

            case PN_testlist_star_expr:
            case PN_exprlist:
                // lhs is a tuple
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
869
                c_assign_tuple(comp, MP_PARSE_NODE_NULL, MP_PARSE_NODE_STRUCT_NUM_NODES(pns), pns->nodes);
Damien's avatar
Damien committed
870
871
872
873
                break;

            case PN_atom_paren:
                // lhs is something in parenthesis
874
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
875
                    // empty tuple
876
                    goto cannot_assign;
877
878
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
879
880
881
882
883
884
885
886
887
888
889
890
891
                    goto testlist_comp;
                } else {
                    // parenthesis around 1 item, is just that item
                    pn = pns->nodes[0];
                    goto tail_recursion;
                }
                break;

            case PN_atom_bracket:
                // lhs is something in brackets
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
892
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
893
                    // empty list, assignment allowed
894
                    c_assign_tuple(comp, MP_PARSE_NODE_NULL, 0, NULL);
895
896
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
897
898
899
                    goto testlist_comp;
                } else {
                    // brackets around 1 item
900
                    c_assign_tuple(comp, pns->nodes[0], 0, NULL);
Damien's avatar
Damien committed
901
902
903
904
                }
                break;

            default:
905
                goto cannot_assign;
Damien's avatar
Damien committed
906
907
908
909
910
        }
        return;

        testlist_comp:
        // lhs is a sequence
911
912
913
        if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
            mp_parse_node_struct_t *pns2 = (mp_parse_node_struct_t*)pns->nodes[1];
            if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3b) {
Damien's avatar
Damien committed
914
                // sequence of one item, with trailing comma
915
                assert(MP_PARSE_NODE_IS_NULL(pns2->nodes[0]));
916
                c_assign_tuple(comp, pns->nodes[0], 0, NULL);
917
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3c) {
Damien's avatar
Damien committed
918
                // sequence of many items
919
920
                uint n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns2);
                c_assign_tuple(comp, pns->nodes[0], n, pns2->nodes);
921
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_comp_for) {
922
                // TODO can we ever get here? can it be compiled?
923
                goto cannot_assign;
Damien's avatar
Damien committed
924
925
926
927
928
929
930
            } else {
                // sequence with 2 items
                goto sequence_with_2_items;
            }
        } else {
            // sequence with 2 items
            sequence_with_2_items:
931
            c_assign_tuple(comp, MP_PARSE_NODE_NULL, 2, pns->nodes);
Damien's avatar
Damien committed
932
933
934
935
936
        }
        return;
    }
    return;

937
938
939
940
    cannot_assign:
    compile_syntax_error(comp, pn, "can't assign to expression");
    return;

Damien's avatar
Damien committed
941
    bad_aug:
942
    compile_syntax_error(comp, pn, "illegal expression for augmented assignment");
Damien's avatar
Damien committed
943
944
945
}

// stuff for lambda and comprehensions and generators
946
947
948
949
// if we are not in CPython compatibility mode then:
//  if n_pos_defaults > 0 then there is a tuple on the stack with the positional defaults
//  if n_kw_defaults > 0 then there is a dictionary on the stack with the keyword defaults
//  if both exist, the tuple is above the dictionary (ie the first pop gets the tuple)
950
951
952
953
void close_over_variables_etc(compiler_t *comp, scope_t *this_scope, int n_pos_defaults, int n_kw_defaults) {
    assert(n_pos_defaults >= 0);
    assert(n_kw_defaults >= 0);

Damien's avatar
Damien committed
954
    // make closed over variables, if any
955
    // ensure they are closed over in the order defined in the outer scope (mainly to agree with CPython)
Damien's avatar
Damien committed
956
957
    int nfree = 0;
    if (comp->scope_cur->kind != SCOPE_MODULE) {
958
959
960
961
962
963
        for (int i = 0; i < comp->scope_cur->id_info_len; i++) {
            id_info_t *id = &comp->scope_cur->id_info[i];
            if (id->kind == ID_INFO_KIND_CELL || id->kind == ID_INFO_KIND_FREE) {
                for (int j = 0; j < this_scope->id_info_len; j++) {
                    id_info_t *id2 = &this_scope->id_info[j];
                    if (id2->kind == ID_INFO_KIND_FREE && id->qstr == id2->qstr) {
Damien George's avatar
Damien George committed
964
#if MICROPY_EMIT_CPYTHON
965
                        EMIT_ARG(load_closure, id->qstr, id->local_num);
Damien George's avatar
Damien George committed
966
967
#else
                        // in Micro Python we load closures using LOAD_FAST
968
                        EMIT_ARG(load_fast, id->qstr, id->flags, id->local_num);
Damien George's avatar
Damien George committed
969
#endif
970
971
972
                        nfree += 1;
                    }
                }
Damien's avatar
Damien committed
973
974
975
976
977
978
            }
        }
    }

    // make the function/closure
    if (nfree == 0) {
979
        EMIT_ARG(make_function, this_scope, n_pos_defaults, n_kw_defaults);
Damien's avatar
Damien committed
980
    } else {
981
        EMIT_ARG(make_closure, this_scope, nfree, n_pos_defaults, n_kw_defaults);
Damien's avatar
Damien committed
982
983
984
    }
}

985
void compile_funcdef_param(compiler_t *comp, mp_parse_node_t pn) {
986
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_typedargslist_star)) {
987
988
        comp->have_star = true;
        /* don't need to distinguish bare from named star
989
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
990
991
        if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
            // bare star
992
993
        } else {
            // named star
994
        }
995
        */
996
997

    } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_typedargslist_dbl_star)) {
998
        // named double star
999
1000
        // TODO do we need to do anything with this?