compile.c 153 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
/*
 * This file is part of the Micro Python project, http://micropython.org/
 *
 * The MIT License (MIT)
 *
 * Copyright (c) 2013, 2014 Damien P. George
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

xbe's avatar
xbe committed
27
#include <stdbool.h>
Damien's avatar
Damien committed
28
29
30
31
32
#include <stdint.h>
#include <stdio.h>
#include <string.h>
#include <assert.h>

33
34
35
36
37
38
#include "py/scope.h"
#include "py/emit.h"
#include "py/compile.h"
#include "py/smallint.h"
#include "py/runtime.h"
#include "py/builtin.h"
Damien's avatar
Damien committed
39
40
41
42

// TODO need to mangle __attr names

typedef enum {
43
#define DEF_RULE(rule, comp, kind, ...) PN_##rule,
44
#include "py/grammar.h"
Damien's avatar
Damien committed
45
46
#undef DEF_RULE
    PN_maximum_number_of,
47
    PN_string, // special node for non-interned string
48
    PN_bytes, // special node for non-interned bytes
49
    PN_const_object, // special node for a constant, generic Python object
Damien's avatar
Damien committed
50
51
} pn_kind_t;

52
53
#define EMIT(fun) (comp->emit_method_table->fun(comp->emit))
#define EMIT_ARG(fun, ...) (comp->emit_method_table->fun(comp->emit, __VA_ARGS__))
54
55
#define EMIT_LOAD_FAST(qst, local_num) (comp->emit_method_table->load_id.fast(comp->emit, qst, local_num))
#define EMIT_LOAD_GLOBAL(qst) (comp->emit_method_table->load_id.global(comp->emit, qst))
56
57
#define EMIT_INLINE_ASM(fun) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm))
#define EMIT_INLINE_ASM_ARG(fun, ...) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm, __VA_ARGS__))
Damien's avatar
Damien committed
58

59
// elements in this struct are ordered to make it compact
Damien's avatar
Damien committed
60
typedef struct _compiler_t {
61
    qstr source_file;
62

63
64
65
    uint8_t is_repl;
    uint8_t pass; // holds enum type pass_kind_t
    uint8_t func_arg_is_super; // used to compile special case of super() function call
66
67
68
69
70
    uint8_t have_star;

    // try to keep compiler clean from nlr
    // this is set to an exception object if we have a compile error
    mp_obj_t compile_error;
Damien's avatar
Damien committed
71

72
    uint next_label;
73

74
75
76
    uint16_t num_dict_params;
    uint16_t num_default_params;

77
78
    uint16_t break_label; // highest bit set indicates we are breaking out of a for loop
    uint16_t continue_label;
79
    uint16_t cur_except_level; // increased for SETUP_EXCEPT, SETUP_FINALLY; decreased for POP_BLOCK, POP_EXCEPT
80
    uint16_t break_continue_except_level;
Damien's avatar
Damien committed
81
82
83
84

    scope_t *scope_head;
    scope_t *scope_cur;

85
86
    emit_t *emit;                                   // current emitter
    const emit_method_table_t *emit_method_table;   // current emit method table
87

88
    #if MICROPY_EMIT_INLINE_THUMB
89
90
    emit_inline_asm_t *emit_inline_asm;                                   // current emitter for inline asm
    const emit_inline_asm_method_table_t *emit_inline_asm_method_table;   // current emit method table for inline asm
91
    #endif
Damien's avatar
Damien committed
92
93
} compiler_t;

94
STATIC void compile_syntax_error(compiler_t *comp, mp_parse_node_t pn, const char *msg) {
95
96
    mp_obj_t exc = mp_obj_new_exception_msg(&mp_type_SyntaxError, msg);
    // we don't have a 'block' name, so just pass the NULL qstr to indicate this
97
    if (MP_PARSE_NODE_IS_STRUCT(pn)) {
98
        mp_obj_exception_add_traceback(exc, comp->source_file, (mp_uint_t)((mp_parse_node_struct_t*)pn)->source_line, comp->scope_cur->simple_name);
99
    } else {
100
        // we don't have a line number, so just pass 0
101
        mp_obj_exception_add_traceback(exc, comp->source_file, 0, comp->scope_cur->simple_name);
102
    }
103
    comp->compile_error = exc;
104
105
}

106
#if MICROPY_COMP_MODULE_CONST
107
STATIC const mp_map_elem_t mp_constants_table[] = {
108
109
110
    #if MICROPY_PY_UCTYPES
    { MP_OBJ_NEW_QSTR(MP_QSTR_uctypes), (mp_obj_t)&mp_module_uctypes },
    #endif
111
    // Extra constants as defined by a port
112
    MICROPY_PORT_CONSTANTS
113
};
114
115
STATIC MP_DEFINE_CONST_MAP(mp_constants_map, mp_constants_table);
#endif
116

117
118
119
120
// this function is essentially a simple preprocessor
STATIC mp_parse_node_t fold_constants(compiler_t *comp, mp_parse_node_t pn, mp_map_t *consts) {
    if (0) {
        // dummy
121
#if MICROPY_COMP_CONST
122
123
124
125
126
127
128
129
130
    } else if (MP_PARSE_NODE_IS_ID(pn)) {
        // lookup identifier in table of dynamic constants
        qstr qst = MP_PARSE_NODE_LEAF_ARG(pn);
        mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(qst), MP_MAP_LOOKUP);
        if (elem != NULL) {
            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, MP_OBJ_SMALL_INT_VALUE(elem->value));
        }
#endif
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
131
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
Damien's avatar
Damien committed
132

133
134
        // fold some parse nodes before folding their arguments
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
135
#if MICROPY_COMP_CONST
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
            case PN_expr_stmt:
                if (!MP_PARSE_NODE_IS_NULL(pns->nodes[1])) {
                    mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_expr_stmt_assign) {
                        if (MP_PARSE_NODE_IS_ID(pns->nodes[0])
                            && MP_PARSE_NODE_IS_STRUCT_KIND(pns1->nodes[0], PN_power)
                            && MP_PARSE_NODE_IS_ID(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0])
                            && MP_PARSE_NODE_LEAF_ARG(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0]) == MP_QSTR_const
                            && MP_PARSE_NODE_IS_STRUCT_KIND(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1], PN_trailer_paren)
                            && MP_PARSE_NODE_IS_NULL(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[2])
                            ) {
                            // code to assign dynamic constants: id = const(value)

                            // get the id
                            qstr id_qstr = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);

                            // get the value
                            mp_parse_node_t pn_value = ((mp_parse_node_struct_t*)((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1])->nodes[0];
                            pn_value = fold_constants(comp, pn_value, consts);
                            if (!MP_PARSE_NODE_IS_SMALL_INT(pn_value)) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant must be an integer");
                                break;
                            }
159
                            mp_int_t value = MP_PARSE_NODE_LEAF_SMALL_INT(pn_value);
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178

                            // store the value in the table of dynamic constants
                            mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(id_qstr), MP_MAP_LOOKUP_ADD_IF_NOT_FOUND);
                            if (elem->value != MP_OBJ_NULL) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant redefined");
                                break;
                            }
                            elem->value = MP_OBJ_NEW_SMALL_INT(value);

                            // replace const(value) with value
                            pns1->nodes[0] = pn_value;

                            // finished folding this assignment
                            return pn;
                        }
                    }
                }
                break;
#endif
179
            case PN_string:
180
            case PN_bytes:
181
            case PN_const_object:
182
                return pn;
183
184
185
186
        }

        // fold arguments
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
187
        for (int i = 0; i < n; i++) {
188
            pns->nodes[i] = fold_constants(comp, pns->nodes[i], consts);
Damien's avatar
Damien committed
189
190
        }

191
        // try to fold this parse node
192
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
193
194
195
196
197
198
199
200
201
202
            case PN_atom_paren:
                if (n == 1 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0])) {
                    // (int)
                    pn = pns->nodes[0];
                }
                break;

            case PN_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int | int
203
204
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
205
206
207
208
209
210
211
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 | arg1);
                }
                break;

            case PN_and_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int & int
212
213
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
214
215
216
217
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 & arg1);
                }
                break;

Damien's avatar
Damien committed
218
            case PN_shift_expr:
219
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
220
221
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
222
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_LESS)) {
223
                        // int << int
224
                        if (!(arg1 >= (mp_int_t)BITS_PER_WORD || arg0 > (MP_SMALL_INT_MAX >> arg1) || arg0 < (MP_SMALL_INT_MIN >> arg1))) {
225
226
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 << arg1);
                        }
227
228
                    } else {
                        assert(MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_MORE)); // should be
229
                        // int >> int
230
                        if (arg1 >= (mp_int_t)BITS_PER_WORD) {
231
232
233
234
                            // Shifting to big amounts is underfined behavior
                            // in C and is CPU-dependent; propagate sign bit.
                            arg1 = BITS_PER_WORD - 1;
                        }
235
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 >> arg1);
Damien's avatar
Damien committed
236
237
238
239
240
                    }
                }
                break;

            case PN_arith_expr:
241
                // overflow checking here relies on SMALL_INT being strictly smaller than mp_int_t
242
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
243
244
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
245
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PLUS)) {
246
                        // int + int
247
                        arg0 += arg1;
248
249
                    } else {
                        assert(MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_MINUS)); // should be
250
                        // int - int
251
                        arg0 -= arg1;
252
                    }
253
                    if (MP_SMALL_INT_FITS(arg0)) {
254
                        //printf("%ld + %ld\n", arg0, arg1);
255
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
Damien's avatar
Damien committed
256
257
258
259
260
                    }
                }
                break;

            case PN_term:
261
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
262
263
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
264
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_STAR)) {
265
                        // int * int
266
267
                        if (!mp_small_int_mul_overflow(arg0, arg1)) {
                            arg0 *= arg1;
268
                            if (MP_SMALL_INT_FITS(arg0)) {
269
270
271
                                pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
                            }
                        }
272
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_SLASH)) {
273
274
                        // int / int
                        // pass
275
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PERCENT)) {
276
                        // int%int
277
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_modulo(arg0, arg1));
278
279
                    } else {
                        assert(MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_SLASH)); // should be
280
                        if (arg1 != 0) {
281
                            // int // int
282
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_floor_divide(arg0, arg1));
283
                        }
Damien's avatar
Damien committed
284
285
286
287
288
                    }
                }
                break;

            case PN_factor_2:
289
                if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
290
                    mp_int_t arg = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
291
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_PLUS)) {
292
                        // +int
293
294
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_MINUS)) {
295
                        // -int
296
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, -arg);
297
298
                    } else {
                        assert(MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_TILDE)); // should be
299
                        // ~int
300
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ~arg);
Damien's avatar
Damien committed
301
302
303
304
305
                    }
                }
                break;

            case PN_power:
306
307
308
                if (0) {
#if MICROPY_EMIT_CPYTHON
                } else if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_NULL(pns->nodes[1]) && !MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
309
                    // int ** x
310
                    // can overflow; enabled only to compare with CPython
311
312
                    mp_parse_node_struct_t* pns2 = (mp_parse_node_struct_t*)pns->nodes[2];
                    if (MP_PARSE_NODE_IS_SMALL_INT(pns2->nodes[0])) {
313
                        int power = MP_PARSE_NODE_LEAF_SMALL_INT(pns2->nodes[0]);
Damien's avatar
Damien committed
314
315
                        if (power >= 0) {
                            int ans = 1;
316
                            int base = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
Damien's avatar
Damien committed
317
318
319
                            for (; power > 0; power--) {
                                ans *= base;
                            }
320
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ans);
Damien's avatar
Damien committed
321
322
                        }
                    }
323
#endif
324
#if MICROPY_COMP_MODULE_CONST
325
326
327
328
329
330
331
332
333
334
335
336
                } else if (MP_PARSE_NODE_IS_ID(pns->nodes[0]) && MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[1], PN_trailer_period) && MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
                    // id.id
                    // look it up in constant table, see if it can be replaced with an integer
                    mp_parse_node_struct_t* pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
                    qstr q_base = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);
                    qstr q_attr = MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]);
                    mp_map_elem_t *elem = mp_map_lookup((mp_map_t*)&mp_constants_map, MP_OBJ_NEW_QSTR(q_base), MP_MAP_LOOKUP);
                    if (elem != NULL) {
                        mp_obj_t dest[2];
                        mp_load_method_maybe(elem->value, q_attr, dest);
                        if (MP_OBJ_IS_SMALL_INT(dest[0]) && dest[1] == NULL) {
337
                            mp_int_t val = MP_OBJ_SMALL_INT_VALUE(dest[0]);
338
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, val);
339
340
                        }
                    }
341
#endif
Damien's avatar
Damien committed
342
343
344
345
346
347
348
349
                }
                break;
        }
    }

    return pn;
}

350
STATIC void compile_trailer_paren_helper(compiler_t *comp, mp_parse_node_t pn_arglist, bool is_method_call, int n_positional_extra);
351
STATIC void compile_comprehension(compiler_t *comp, mp_parse_node_struct_t *pns, scope_kind_t kind);
352
STATIC void compile_node(compiler_t *comp, mp_parse_node_t pn);
Damien's avatar
Damien committed
353

354
STATIC uint comp_next_label(compiler_t *comp) {
355
356
357
    return comp->next_label++;
}

358
359
360
361
362
363
364
365
366
367
368
369
STATIC void compile_increase_except_level(compiler_t *comp) {
    comp->cur_except_level += 1;
    if (comp->cur_except_level > comp->scope_cur->exc_stack_size) {
        comp->scope_cur->exc_stack_size = comp->cur_except_level;
    }
}

STATIC void compile_decrease_except_level(compiler_t *comp) {
    assert(comp->cur_except_level > 0);
    comp->cur_except_level -= 1;
}

370
STATIC scope_t *scope_new_and_link(compiler_t *comp, scope_kind_t kind, mp_parse_node_t pn, uint emit_options) {
371
    scope_t *scope = scope_new(kind, pn, comp->source_file, emit_options);
Damien's avatar
Damien committed
372
373
374
375
376
377
378
379
380
381
382
383
384
385
    scope->parent = comp->scope_cur;
    scope->next = NULL;
    if (comp->scope_head == NULL) {
        comp->scope_head = scope;
    } else {
        scope_t *s = comp->scope_head;
        while (s->next != NULL) {
            s = s->next;
        }
        s->next = scope;
    }
    return scope;
}

386
387
STATIC void apply_to_single_or_list(compiler_t *comp, mp_parse_node_t pn, pn_kind_t pn_list_kind, void (*f)(compiler_t*, mp_parse_node_t)) {
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, pn_list_kind)) {
388
389
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
390
391
392
        for (int i = 0; i < num_nodes; i++) {
            f(comp, pns->nodes[i]);
        }
393
    } else if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
394
395
396
397
        f(comp, pn);
    }
}

398
STATIC void compile_generic_all_nodes(compiler_t *comp, mp_parse_node_struct_t *pns) {
399
    int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
400
401
402
403
404
    for (int i = 0; i < num_nodes; i++) {
        compile_node(comp, pns->nodes[i]);
    }
}

405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
STATIC void compile_load_id(compiler_t *comp, qstr qst) {
    if (comp->pass == MP_PASS_SCOPE) {
        mp_emit_common_get_id_for_load(comp->scope_cur, qst);
    } else {
        mp_emit_common_id_op(comp->emit, &comp->emit_method_table->load_id, comp->scope_cur, qst);
    }
}

STATIC void compile_store_id(compiler_t *comp, qstr qst) {
    if (comp->pass == MP_PASS_SCOPE) {
        mp_emit_common_get_id_for_modification(comp->scope_cur, qst);
    } else {
        mp_emit_common_id_op(comp->emit, &comp->emit_method_table->store_id, comp->scope_cur, qst);
    }
}

STATIC void compile_delete_id(compiler_t *comp, qstr qst) {
    if (comp->pass == MP_PASS_SCOPE) {
        mp_emit_common_get_id_for_modification(comp->scope_cur, qst);
    } else {
        mp_emit_common_id_op(comp->emit, &comp->emit_method_table->delete_id, comp->scope_cur, qst);
    }
}

429
#if MICROPY_EMIT_CPYTHON
430
STATIC bool cpython_c_tuple_is_const(mp_parse_node_t pn) {
431
432
433
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string)) {
        return true;
    }
434
435
436
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_bytes)) {
        return true;
    }
437
438
439
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_const_object)) {
        return true;
    }
440
    if (!MP_PARSE_NODE_IS_LEAF(pn)) {
Damien's avatar
Damien committed
441
442
        return false;
    }
443
    if (MP_PARSE_NODE_IS_ID(pn)) {
Damien's avatar
Damien committed
444
445
446
447
448
        return false;
    }
    return true;
}

449
STATIC void cpython_c_print_quoted_str(vstr_t *vstr, const char *str, uint len, bool bytes) {
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
    bool has_single_quote = false;
    bool has_double_quote = false;
    for (int i = 0; i < len; i++) {
        if (str[i] == '\'') {
            has_single_quote = true;
        } else if (str[i] == '"') {
            has_double_quote = true;
        }
    }
    if (bytes) {
        vstr_printf(vstr, "b");
    }
    bool quote_single = false;
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        quote_single = true;
        vstr_printf(vstr, "'");
    }
    for (int i = 0; i < len; i++) {
        if (str[i] == '\n') {
            vstr_printf(vstr, "\\n");
        } else if (str[i] == '\\') {
            vstr_printf(vstr, "\\\\");
        } else if (str[i] == '\'' && quote_single) {
            vstr_printf(vstr, "\\'");
        } else {
            vstr_printf(vstr, "%c", str[i]);
        }
    }
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        vstr_printf(vstr, "'");
    }
}

487
STATIC void cpython_c_tuple_emit_const(compiler_t *comp, mp_parse_node_t pn, vstr_t *vstr) {
488
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string) || MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_bytes)) {
489
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
490
        cpython_c_print_quoted_str(vstr, (const char*)pns->nodes[0], (mp_uint_t)pns->nodes[1], MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_bytes));
491
492
493
        return;
    }

494
495
496
497
498
499
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_const_object)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        mp_obj_print((mp_obj_t)pns->nodes[0], PRINT_REPR);
        return;
    }

500
    assert(MP_PARSE_NODE_IS_LEAF(pn));
501
502
503
504
505
    if (MP_PARSE_NODE_IS_SMALL_INT(pn)) {
        vstr_printf(vstr, INT_FMT, MP_PARSE_NODE_LEAF_SMALL_INT(pn));
        return;
    }

506
    mp_uint_t arg = MP_PARSE_NODE_LEAF_ARG(pn);
507
508
    switch (MP_PARSE_NODE_LEAF_KIND(pn)) {
        case MP_PARSE_NODE_ID: assert(0);
509
510
        case MP_PARSE_NODE_STRING:
        case MP_PARSE_NODE_BYTES: {
511
            mp_uint_t len;
512
513
514
515
            const byte *str = qstr_data(arg, &len);
            cpython_c_print_quoted_str(vstr, (const char*)str, len, MP_PARSE_NODE_LEAF_KIND(pn) == MP_PARSE_NODE_BYTES);
            break;
        }
516
        case MP_PARSE_NODE_TOKEN:
Damien's avatar
Damien committed
517
            switch (arg) {
518
519
520
                case MP_TOKEN_KW_FALSE: vstr_printf(vstr, "False"); break;
                case MP_TOKEN_KW_NONE: vstr_printf(vstr, "None"); break;
                case MP_TOKEN_KW_TRUE: vstr_printf(vstr, "True"); break;
521
                default: assert(0); // shouldn't happen
Damien's avatar
Damien committed
522
523
524
525
526
527
            }
            break;
        default: assert(0);
    }
}

528
STATIC void cpython_c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
Damien's avatar
Damien committed
529
530
    int n = 0;
    if (pns_list != NULL) {
531
        n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
Damien's avatar
Damien committed
532
533
534
    }
    int total = n;
    bool is_const = true;
535
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
536
        total += 1;
537
        if (!cpython_c_tuple_is_const(pn)) {
Damien's avatar
Damien committed
538
539
540
541
            is_const = false;
        }
    }
    for (int i = 0; i < n; i++) {
542
        if (!cpython_c_tuple_is_const(pns_list->nodes[i])) {
Damien's avatar
Damien committed
543
544
545
546
547
548
            is_const = false;
            break;
        }
    }
    if (total > 0 && is_const) {
        bool need_comma = false;
549
550
        vstr_t *vstr = vstr_new();
        vstr_printf(vstr, "(");
551
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
552
            cpython_c_tuple_emit_const(comp, pn, vstr);
Damien's avatar
Damien committed
553
554
555
556
            need_comma = true;
        }
        for (int i = 0; i < n; i++) {
            if (need_comma) {
557
                vstr_printf(vstr, ", ");
Damien's avatar
Damien committed
558
            }
559
            cpython_c_tuple_emit_const(comp, pns_list->nodes[i], vstr);
Damien's avatar
Damien committed
560
561
562
            need_comma = true;
        }
        if (total == 1) {
563
            vstr_printf(vstr, ",)");
Damien's avatar
Damien committed
564
        } else {
565
            vstr_printf(vstr, ")");
Damien's avatar
Damien committed
566
        }
567
        EMIT_ARG(load_const_verbatim_strn, vstr_str(vstr), vstr_len(vstr));
568
        vstr_free(vstr);
Damien's avatar
Damien committed
569
    } else {
570
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
571
572
573
574
575
            compile_node(comp, pn);
        }
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
576
        EMIT_ARG(build_tuple, total);
Damien's avatar
Damien committed
577
578
    }
}
579
580
581
#endif

// funnelling all tuple creations through this function is purely so we can optionally agree with CPython
582
STATIC void c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
583
#if MICROPY_EMIT_CPYTHON
584
585
586
    cpython_c_tuple(comp, pn, pns_list);
#else
    int total = 0;
587
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
588
589
590
591
        compile_node(comp, pn);
        total += 1;
    }
    if (pns_list != NULL) {
592
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
593
594
595
596
597
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
        total += n;
    }
598
    EMIT_ARG(build_tuple, total);
599
600
#endif
}
Damien's avatar
Damien committed
601

602
STATIC void compile_generic_tuple(compiler_t *comp, mp_parse_node_struct_t *pns) {
Damien's avatar
Damien committed
603
    // a simple tuple expression
604
    c_tuple(comp, MP_PARSE_NODE_NULL, pns);
Damien's avatar
Damien committed
605
606
}

607
STATIC bool node_is_const_false(mp_parse_node_t pn) {
608
609
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_FALSE)
        || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) == 0);
Damien's avatar
Damien committed
610
611
}

612
STATIC bool node_is_const_true(mp_parse_node_t pn) {
613
614
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_TRUE)
        || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) != 0);
Damien's avatar
Damien committed
615
616
}

617
#if MICROPY_EMIT_CPYTHON
618
// the is_nested variable is purely to match with CPython, which doesn't fully optimise not's
619
STATIC void cpython_c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label, bool is_nested) {
Damien's avatar
Damien committed
620
621
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
622
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
623
624
625
626
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
627
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
628
629
        }
        return;
630
631
632
633
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
Damien's avatar
Damien committed
634
            if (jump_if == false) {
635
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
636
                for (int i = 0; i < n - 1; i++) {
637
                    cpython_c_if_cond(comp, pns->nodes[i], true, label2, true);
Damien's avatar
Damien committed
638
                }
639
                cpython_c_if_cond(comp, pns->nodes[n - 1], false, label, true);
640
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
641
642
            } else {
                for (int i = 0; i < n; i++) {
643
                    cpython_c_if_cond(comp, pns->nodes[i], true, label, true);
Damien's avatar
Damien committed
644
645
646
                }
            }
            return;
647
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
Damien's avatar
Damien committed
648
649
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
650
                    cpython_c_if_cond(comp, pns->nodes[i], false, label, true);
Damien's avatar
Damien committed
651
652
                }
            } else {
653
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
654
                for (int i = 0; i < n - 1; i++) {
655
                    cpython_c_if_cond(comp, pns->nodes[i], false, label2, true);
Damien's avatar
Damien committed
656
                }
657
                cpython_c_if_cond(comp, pns->nodes[n - 1], true, label, true);
658
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
659
660
            }
            return;
661
        } else if (!is_nested && MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
662
            cpython_c_if_cond(comp, pns->nodes[0], !jump_if, label, true);
Damien's avatar
Damien committed
663
664
665
666
667
668
            return;
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
669
    EMIT_ARG(pop_jump_if, jump_if, label);
Damien's avatar
Damien committed
670
}
671
#endif
Damien's avatar
Damien committed
672

673
STATIC void c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label) {
674
#if MICROPY_EMIT_CPYTHON
675
676
677
678
    cpython_c_if_cond(comp, pn, jump_if, label, false);
#else
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
679
            EMIT_ARG(jump, label);
680
681
682
683
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
684
            EMIT_ARG(jump, label);
685
686
        }
        return;
687
688
689
690
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
691
            if (jump_if == false) {
692
            and_or_logic1:;
693
                uint label2 = comp_next_label(comp);
694
                for (int i = 0; i < n - 1; i++) {
695
                    c_if_cond(comp, pns->nodes[i], !jump_if, label2);
696
                }
697
                c_if_cond(comp, pns->nodes[n - 1], jump_if, label);
698
                EMIT_ARG(label_assign, label2);
699
            } else {
700
            and_or_logic2:
701
                for (int i = 0; i < n; i++) {
702
                    c_if_cond(comp, pns->nodes[i], jump_if, label);
703
704
705
                }
            }
            return;
706
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
707
            if (jump_if == false) {
708
                goto and_or_logic2;
709
            } else {
710
                goto and_or_logic1;
711
            }
712
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
713
714
            c_if_cond(comp, pns->nodes[0], !jump_if, label);
            return;
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_atom_paren) {
            // cond is something in parenthesis
            if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
                // empty tuple, acts as false for the condition
                if (jump_if == false) {
                    EMIT_ARG(jump, label);
                }
            } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                // non-empty tuple, acts as true for the condition
                if (jump_if == true) {
                    EMIT_ARG(jump, label);
                }
            } else {
                // parenthesis around 1 item, is just that item
                c_if_cond(comp, pns->nodes[0], jump_if, label);
            }
            return;
732
733
734
735
736
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
737
    EMIT_ARG(pop_jump_if, jump_if, label);
738
#endif
Damien's avatar
Damien committed
739
740
741
}

typedef enum { ASSIGN_STORE, ASSIGN_AUG_LOAD, ASSIGN_AUG_STORE } assign_kind_t;
742
STATIC void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t kind);
Damien's avatar
Damien committed
743

744
STATIC void c_assign_power(compiler_t *comp, mp_parse_node_struct_t *pns, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
745
746
747
748
    if (assign_kind != ASSIGN_AUG_STORE) {
        compile_node(comp, pns->nodes[0]);
    }

749
750
751
752
    if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
        mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_power_trailers) {
            int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns1);
Damien's avatar
Damien committed
753
754
755
756
757
            if (assign_kind != ASSIGN_AUG_STORE) {
                for (int i = 0; i < n - 1; i++) {
                    compile_node(comp, pns1->nodes[i]);
                }
            }
758
759
            assert(MP_PARSE_NODE_IS_STRUCT(pns1->nodes[n - 1]));
            pns1 = (mp_parse_node_struct_t*)pns1->nodes[n - 1];
Damien's avatar
Damien committed
760
        }
761
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_bracket) {
Damien's avatar
Damien committed
762
763
764
765
766
767
768
            if (assign_kind == ASSIGN_AUG_STORE) {
                EMIT(rot_three);
                EMIT(store_subscr);
            } else {
                compile_node(comp, pns1->nodes[0]);
                if (assign_kind == ASSIGN_AUG_LOAD) {
                    EMIT(dup_top_two);
769
                    EMIT(load_subscr);
Damien's avatar
Damien committed
770
771
772
773
                } else {
                    EMIT(store_subscr);
                }
            }
774
775
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_period) {
            assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
Damien's avatar
Damien committed
776
777
            if (assign_kind == ASSIGN_AUG_LOAD) {
                EMIT(dup_top);
778
                EMIT_ARG(load_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
779
780
781
782
            } else {
                if (assign_kind == ASSIGN_AUG_STORE) {
                    EMIT(rot_two);
                }
783
                EMIT_ARG(store_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
784
785
            }
        } else {
786
            goto cannot_assign;
Damien's avatar
Damien committed
787
788
        }
    } else {
789
        goto cannot_assign;
Damien's avatar
Damien committed
790
791
    }

792
    if (!MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
793
        goto cannot_assign;
Damien's avatar
Damien committed
794
    }
795
796
797
798
799

    return;

cannot_assign:
    compile_syntax_error(comp, (mp_parse_node_t)pns, "can't assign to expression");
Damien's avatar
Damien committed
800
801
}

802
// we need to allow for a caller passing in 1 initial node (node_head) followed by an array of nodes (nodes_tail)
803
STATIC void c_assign_tuple(compiler_t *comp, mp_parse_node_t node_head, uint num_tail, mp_parse_node_t *nodes_tail) {
804
805
806
    uint num_head = (node_head == MP_PARSE_NODE_NULL) ? 0 : 1;

    // look for star expression
807
    uint have_star_index = -1;
808
809
810
811
    if (num_head != 0 && MP_PARSE_NODE_IS_STRUCT_KIND(node_head, PN_star_expr)) {
        EMIT_ARG(unpack_ex, 0, num_tail);
        have_star_index = 0;
    }
812
    for (uint i = 0; i < num_tail; i++) {
813
        if (MP_PARSE_NODE_IS_STRUCT_KIND(nodes_tail[i], PN_star_expr)) {
814
            if (have_star_index == (uint)-1) {
815
816
                EMIT_ARG(unpack_ex, num_head + i, num_tail - i - 1);
                have_star_index = num_head + i;
Damien's avatar
Damien committed
817
            } else {
818
                compile_syntax_error(comp, nodes_tail[i], "multiple *x in assignment");
Damien's avatar
Damien committed
819
820
821
822
                return;
            }
        }
    }
823
    if (have_star_index == (uint)-1) {
824
        EMIT_ARG(unpack_sequence, num_head + num_tail);
Damien's avatar
Damien committed
825
    }
826
827
828
    if (num_head != 0) {
        if (0 == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)node_head)->nodes[0], ASSIGN_STORE);
Damien's avatar
Damien committed
829
        } else {
830
831
832
            c_assign(comp, node_head, ASSIGN_STORE);
        }
    }
833
    for (uint i = 0; i < num_tail; i++) {
834
835
836
837
        if (num_head + i == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)nodes_tail[i])->nodes[0], ASSIGN_STORE);
        } else {
            c_assign(comp, nodes_tail[i], ASSIGN_STORE);
Damien's avatar
Damien committed
838
839
840
841
842
        }
    }
}

// assigns top of stack to pn
843
STATIC void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
844
    tail_recursion:
845
846
    assert(!MP_PARSE_NODE_IS_NULL(pn));
    if (MP_PARSE_NODE_IS_LEAF(pn)) {
847
        if (MP_PARSE_NODE_IS_ID(pn)) {
848
            qstr arg = MP_PARSE_NODE_LEAF_ARG(pn);
Damien's avatar
Damien committed
849
850
851
            switch (assign_kind) {
                case ASSIGN_STORE:
                case ASSIGN_AUG_STORE:
852
                    compile_store_id(comp, arg);
Damien's avatar
Damien committed
853
854
                    break;
                case ASSIGN_AUG_LOAD:
855
                default:
856
                    compile_load_id(comp, arg);
Damien's avatar
Damien committed
857
858
859
                    break;
            }
        } else {
860
            compile_syntax_error(comp, pn, "can't assign to literal");
Damien's avatar
Damien committed
861
862
863
            return;
        }
    } else {
864
        // pn must be a struct
865
866
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
Damien's avatar
Damien committed
867
868
869
870
871
872
873
874
875
876
877
            case PN_power:
                // lhs is an index or attribute
                c_assign_power(comp, pns, assign_kind);
                break;

            case PN_testlist_star_expr:
            case PN_exprlist:
                // lhs is a tuple
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
878
                c_assign_tuple(comp, MP_PARSE_NODE_NULL, MP_PARSE_NODE_STRUCT_NUM_NODES(pns), pns->nodes);
Damien's avatar
Damien committed
879
880
881
882
                break;

            case PN_atom_paren:
                // lhs is something in parenthesis
883
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
884
                    // empty tuple
885
                    goto cannot_assign;
886
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
887
888
889
                    if (assign_kind != ASSIGN_STORE) {
                        goto bad_aug;
                    }
890
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
891
892
893
894
895
896
897
898
899
900
901
902
903
                    goto testlist_comp;
                } else {
                    // parenthesis around 1 item, is just that item
                    pn = pns->nodes[0];
                    goto tail_recursion;
                }
                break;

            case PN_atom_bracket:
                // lhs is something in brackets
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
904
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
905
                    // empty list, assignment allowed
906
                    c_assign_tuple(comp, MP_PARSE_NODE_NULL, 0, NULL);
907
908
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
909
910
911
                    goto testlist_comp;
                } else {
                    // brackets around 1 item
912
                    c_assign_tuple(comp, pns->nodes[0], 0, NULL);
Damien's avatar
Damien committed
913
914
915
916
                }
                break;

            default:
917
                goto cannot_assign;
Damien's avatar
Damien committed
918
919
920
921
922
        }
        return;

        testlist_comp:
        // lhs is a sequence
923
924
925
        if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
            mp_parse_node_struct_t *pns2 = (mp_parse_node_struct_t*)pns->nodes[1];
            if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3b) {
Damien's avatar
Damien committed
926
                // sequence of one item, with trailing comma
927
                assert(MP_PARSE_NODE_IS_NULL(pns2->nodes[0]));
928
                c_assign_tuple(comp, pns->nodes[0], 0, NULL);
929
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3c) {
Damien's avatar
Damien committed
930
                // sequence of many items
931
932
                uint n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns2);
                c_assign_tuple(comp, pns->nodes[0], n, pns2->nodes);
933
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_comp_for) {
934
                // TODO can we ever get here? can it be compiled?
935
                goto cannot_assign;
Damien's avatar
Damien committed
936
937
938
939
940
941
942
            } else {
                // sequence with 2 items
                goto sequence_with_2_items;
            }
        } else {
            // sequence with 2 items
            sequence_with_2_items:
943
            c_assign_tuple(comp, MP_PARSE_NODE_NULL, 2, pns->nodes);
Damien's avatar
Damien committed
944
945
946
947
948
        }
        return;
    }
    return;

949
950
951
952
    cannot_assign:
    compile_syntax_error(comp, pn, "can't assign to expression");
    return;

Damien's avatar
Damien committed
953
    bad_aug:
954
    compile_syntax_error(comp, pn, "illegal expression for augmented assignment");
Damien's avatar
Damien committed
955
956
957
}

// stuff for lambda and comprehensions and generators
958
959
960
961
// if we are not in CPython compatibility mode then:
//  if n_pos_defaults > 0 then there is a tuple on the stack with the positional defaults
//  if n_kw_defaults > 0 then there is a dictionary on the stack with the keyword defaults
//  if both exist, the tuple is above the dictionary (ie the first pop gets the tuple)
962
STATIC void close_over_variables_etc(compiler_t *comp, scope_t *this_scope, int n_pos_defaults, int n_kw_defaults) {
963
964
965
    assert(n_pos_defaults >= 0);
    assert(n_kw_defaults >= 0);

Damien's avatar
Damien committed
966
    // make closed over variables, if any
967
    // ensure they are closed over in the order defined in the outer scope (mainly to agree with CPython)
Damien's avatar
Damien committed
968
969
    int nfree = 0;
    if (comp->scope_cur->kind != SCOPE_MODULE) {
970
971
972
973
974
        for (int i