compile.c 151 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
/*
 * This file is part of the Micro Python project, http://micropython.org/
 *
 * The MIT License (MIT)
 *
 * Copyright (c) 2013, 2014 Damien P. George
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

xbe's avatar
xbe committed
27
#include <stdbool.h>
Damien's avatar
Damien committed
28
29
30
31
32
#include <stdint.h>
#include <stdio.h>
#include <string.h>
#include <assert.h>

33
34
35
36
37
38
#include "py/scope.h"
#include "py/emit.h"
#include "py/compile.h"
#include "py/smallint.h"
#include "py/runtime.h"
#include "py/builtin.h"
Damien's avatar
Damien committed
39
40
41
42

// TODO need to mangle __attr names

typedef enum {
43
#define DEF_RULE(rule, comp, kind, ...) PN_##rule,
44
#include "py/grammar.h"
Damien's avatar
Damien committed
45
46
#undef DEF_RULE
    PN_maximum_number_of,
47
    PN_string, // special node for non-interned string
48
    PN_bytes, // special node for non-interned bytes
49
    PN_const_object, // special node for a constant, generic Python object
Damien's avatar
Damien committed
50
51
} pn_kind_t;

52
53
54
55
#define EMIT(fun) (comp->emit_method_table->fun(comp->emit))
#define EMIT_ARG(fun, ...) (comp->emit_method_table->fun(comp->emit, __VA_ARGS__))
#define EMIT_INLINE_ASM(fun) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm))
#define EMIT_INLINE_ASM_ARG(fun, ...) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm, __VA_ARGS__))
Damien's avatar
Damien committed
56

57
// elements in this struct are ordered to make it compact
Damien's avatar
Damien committed
58
typedef struct _compiler_t {
59
    qstr source_file;
60

61
62
63
    uint8_t is_repl;
    uint8_t pass; // holds enum type pass_kind_t
    uint8_t func_arg_is_super; // used to compile special case of super() function call
64
65
66
67
68
    uint8_t have_star;

    // try to keep compiler clean from nlr
    // this is set to an exception object if we have a compile error
    mp_obj_t compile_error;
Damien's avatar
Damien committed
69

70
    uint next_label;
71

72
73
74
    uint16_t num_dict_params;
    uint16_t num_default_params;

75
76
    uint16_t break_label; // highest bit set indicates we are breaking out of a for loop
    uint16_t continue_label;
77
    uint16_t cur_except_level; // increased for SETUP_EXCEPT, SETUP_FINALLY; decreased for POP_BLOCK, POP_EXCEPT
78
    uint16_t break_continue_except_level;
Damien's avatar
Damien committed
79
80
81
82

    scope_t *scope_head;
    scope_t *scope_cur;

83
84
    emit_t *emit;                                   // current emitter
    const emit_method_table_t *emit_method_table;   // current emit method table
85

86
    #if MICROPY_EMIT_INLINE_THUMB
87
88
    emit_inline_asm_t *emit_inline_asm;                                   // current emitter for inline asm
    const emit_inline_asm_method_table_t *emit_inline_asm_method_table;   // current emit method table for inline asm
89
    #endif
Damien's avatar
Damien committed
90
91
} compiler_t;

92
STATIC void compile_syntax_error(compiler_t *comp, mp_parse_node_t pn, const char *msg) {
93
94
    mp_obj_t exc = mp_obj_new_exception_msg(&mp_type_SyntaxError, msg);
    // we don't have a 'block' name, so just pass the NULL qstr to indicate this
95
    if (MP_PARSE_NODE_IS_STRUCT(pn)) {
96
        mp_obj_exception_add_traceback(exc, comp->source_file, (mp_uint_t)((mp_parse_node_struct_t*)pn)->source_line, comp->scope_cur->simple_name);
97
    } else {
98
        // we don't have a line number, so just pass 0
99
        mp_obj_exception_add_traceback(exc, comp->source_file, 0, comp->scope_cur->simple_name);
100
    }
101
    comp->compile_error = exc;
102
103
}

104
#if MICROPY_COMP_MODULE_CONST
105
STATIC const mp_map_elem_t mp_constants_table[] = {
106
107
108
    #if MICROPY_PY_UCTYPES
    { MP_OBJ_NEW_QSTR(MP_QSTR_uctypes), (mp_obj_t)&mp_module_uctypes },
    #endif
109
    // Extra constants as defined by a port
110
    MICROPY_PORT_CONSTANTS
111
};
112
113
STATIC MP_DEFINE_CONST_MAP(mp_constants_map, mp_constants_table);
#endif
114

115
116
117
118
// this function is essentially a simple preprocessor
STATIC mp_parse_node_t fold_constants(compiler_t *comp, mp_parse_node_t pn, mp_map_t *consts) {
    if (0) {
        // dummy
119
#if MICROPY_COMP_CONST
120
121
122
123
124
125
126
127
128
    } else if (MP_PARSE_NODE_IS_ID(pn)) {
        // lookup identifier in table of dynamic constants
        qstr qst = MP_PARSE_NODE_LEAF_ARG(pn);
        mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(qst), MP_MAP_LOOKUP);
        if (elem != NULL) {
            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, MP_OBJ_SMALL_INT_VALUE(elem->value));
        }
#endif
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
129
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
Damien's avatar
Damien committed
130

131
132
        // fold some parse nodes before folding their arguments
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
133
#if MICROPY_COMP_CONST
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
            case PN_expr_stmt:
                if (!MP_PARSE_NODE_IS_NULL(pns->nodes[1])) {
                    mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_expr_stmt_assign) {
                        if (MP_PARSE_NODE_IS_ID(pns->nodes[0])
                            && MP_PARSE_NODE_IS_STRUCT_KIND(pns1->nodes[0], PN_power)
                            && MP_PARSE_NODE_IS_ID(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0])
                            && MP_PARSE_NODE_LEAF_ARG(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0]) == MP_QSTR_const
                            && MP_PARSE_NODE_IS_STRUCT_KIND(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1], PN_trailer_paren)
                            && MP_PARSE_NODE_IS_NULL(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[2])
                            ) {
                            // code to assign dynamic constants: id = const(value)

                            // get the id
                            qstr id_qstr = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);

                            // get the value
                            mp_parse_node_t pn_value = ((mp_parse_node_struct_t*)((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1])->nodes[0];
                            pn_value = fold_constants(comp, pn_value, consts);
                            if (!MP_PARSE_NODE_IS_SMALL_INT(pn_value)) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant must be an integer");
                                break;
                            }
157
                            mp_int_t value = MP_PARSE_NODE_LEAF_SMALL_INT(pn_value);
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176

                            // store the value in the table of dynamic constants
                            mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(id_qstr), MP_MAP_LOOKUP_ADD_IF_NOT_FOUND);
                            if (elem->value != MP_OBJ_NULL) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant redefined");
                                break;
                            }
                            elem->value = MP_OBJ_NEW_SMALL_INT(value);

                            // replace const(value) with value
                            pns1->nodes[0] = pn_value;

                            // finished folding this assignment
                            return pn;
                        }
                    }
                }
                break;
#endif
177
            case PN_string:
178
            case PN_bytes:
179
            case PN_const_object:
180
                return pn;
181
182
183
184
        }

        // fold arguments
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
185
        for (int i = 0; i < n; i++) {
186
            pns->nodes[i] = fold_constants(comp, pns->nodes[i], consts);
Damien's avatar
Damien committed
187
188
        }

189
        // try to fold this parse node
190
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
191
192
193
194
195
196
197
198
199
200
            case PN_atom_paren:
                if (n == 1 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0])) {
                    // (int)
                    pn = pns->nodes[0];
                }
                break;

            case PN_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int | int
201
202
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
203
204
205
206
207
208
209
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 | arg1);
                }
                break;

            case PN_and_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int & int
210
211
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
212
213
214
215
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 & arg1);
                }
                break;

Damien's avatar
Damien committed
216
            case PN_shift_expr:
217
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
218
219
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
220
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_LESS)) {
221
                        // int << int
222
                        if (!(arg1 >= (mp_int_t)BITS_PER_WORD || arg0 > (MP_SMALL_INT_MAX >> arg1) || arg0 < (MP_SMALL_INT_MIN >> arg1))) {
223
224
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 << arg1);
                        }
225
226
                    } else {
                        assert(MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_MORE)); // should be
227
                        // int >> int
228
                        if (arg1 >= (mp_int_t)BITS_PER_WORD) {
229
230
231
232
                            // Shifting to big amounts is underfined behavior
                            // in C and is CPU-dependent; propagate sign bit.
                            arg1 = BITS_PER_WORD - 1;
                        }
233
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 >> arg1);
Damien's avatar
Damien committed
234
235
236
237
238
                    }
                }
                break;

            case PN_arith_expr:
239
                // overflow checking here relies on SMALL_INT being strictly smaller than mp_int_t
240
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
241
242
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
243
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PLUS)) {
244
                        // int + int
245
                        arg0 += arg1;
246
247
                    } else {
                        assert(MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_MINUS)); // should be
248
                        // int - int
249
                        arg0 -= arg1;
250
                    }
251
                    if (MP_SMALL_INT_FITS(arg0)) {
252
                        //printf("%ld + %ld\n", arg0, arg1);
253
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
Damien's avatar
Damien committed
254
255
256
257
258
                    }
                }
                break;

            case PN_term:
259
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
260
261
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
262
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_STAR)) {
263
                        // int * int
264
265
                        if (!mp_small_int_mul_overflow(arg0, arg1)) {
                            arg0 *= arg1;
266
                            if (MP_SMALL_INT_FITS(arg0)) {
267
268
269
                                pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
                            }
                        }
270
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_SLASH)) {
271
272
                        // int / int
                        // pass
273
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PERCENT)) {
274
                        // int%int
275
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_modulo(arg0, arg1));
276
277
                    } else {
                        assert(MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_SLASH)); // should be
278
                        if (arg1 != 0) {
279
                            // int // int
280
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_floor_divide(arg0, arg1));
281
                        }
Damien's avatar
Damien committed
282
283
284
285
286
                    }
                }
                break;

            case PN_factor_2:
287
                if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
288
                    mp_int_t arg = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
289
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_PLUS)) {
290
                        // +int
291
292
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_MINUS)) {
293
                        // -int
294
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, -arg);
295
296
                    } else {
                        assert(MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_TILDE)); // should be
297
                        // ~int
298
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ~arg);
Damien's avatar
Damien committed
299
300
301
302
303
                    }
                }
                break;

            case PN_power:
304
305
306
                if (0) {
#if MICROPY_EMIT_CPYTHON
                } else if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_NULL(pns->nodes[1]) && !MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
307
                    // int ** x
308
                    // can overflow; enabled only to compare with CPython
309
310
                    mp_parse_node_struct_t* pns2 = (mp_parse_node_struct_t*)pns->nodes[2];
                    if (MP_PARSE_NODE_IS_SMALL_INT(pns2->nodes[0])) {
311
                        int power = MP_PARSE_NODE_LEAF_SMALL_INT(pns2->nodes[0]);
Damien's avatar
Damien committed
312
313
                        if (power >= 0) {
                            int ans = 1;
314
                            int base = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
Damien's avatar
Damien committed
315
316
317
                            for (; power > 0; power--) {
                                ans *= base;
                            }
318
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ans);
Damien's avatar
Damien committed
319
320
                        }
                    }
321
#endif
322
#if MICROPY_COMP_MODULE_CONST
323
324
325
326
327
328
329
330
331
332
333
334
                } else if (MP_PARSE_NODE_IS_ID(pns->nodes[0]) && MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[1], PN_trailer_period) && MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
                    // id.id
                    // look it up in constant table, see if it can be replaced with an integer
                    mp_parse_node_struct_t* pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
                    qstr q_base = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);
                    qstr q_attr = MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]);
                    mp_map_elem_t *elem = mp_map_lookup((mp_map_t*)&mp_constants_map, MP_OBJ_NEW_QSTR(q_base), MP_MAP_LOOKUP);
                    if (elem != NULL) {
                        mp_obj_t dest[2];
                        mp_load_method_maybe(elem->value, q_attr, dest);
                        if (MP_OBJ_IS_SMALL_INT(dest[0]) && dest[1] == NULL) {
335
                            mp_int_t val = MP_OBJ_SMALL_INT_VALUE(dest[0]);
336
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, val);
337
338
                        }
                    }
339
#endif
Damien's avatar
Damien committed
340
341
342
343
344
345
346
347
                }
                break;
        }
    }

    return pn;
}

348
STATIC void compile_trailer_paren_helper(compiler_t *comp, mp_parse_node_t pn_arglist, bool is_method_call, int n_positional_extra);
349
STATIC void compile_comprehension(compiler_t *comp, mp_parse_node_struct_t *pns, scope_kind_t kind);
350
STATIC void compile_node(compiler_t *comp, mp_parse_node_t pn);
Damien's avatar
Damien committed
351

352
STATIC uint comp_next_label(compiler_t *comp) {
353
354
355
    return comp->next_label++;
}

356
357
358
359
360
361
362
363
364
365
366
367
STATIC void compile_increase_except_level(compiler_t *comp) {
    comp->cur_except_level += 1;
    if (comp->cur_except_level > comp->scope_cur->exc_stack_size) {
        comp->scope_cur->exc_stack_size = comp->cur_except_level;
    }
}

STATIC void compile_decrease_except_level(compiler_t *comp) {
    assert(comp->cur_except_level > 0);
    comp->cur_except_level -= 1;
}

368
STATIC scope_t *scope_new_and_link(compiler_t *comp, scope_kind_t kind, mp_parse_node_t pn, uint emit_options) {
369
    scope_t *scope = scope_new(kind, pn, comp->source_file, emit_options);
Damien's avatar
Damien committed
370
371
372
373
374
375
376
377
378
379
380
381
382
383
    scope->parent = comp->scope_cur;
    scope->next = NULL;
    if (comp->scope_head == NULL) {
        comp->scope_head = scope;
    } else {
        scope_t *s = comp->scope_head;
        while (s->next != NULL) {
            s = s->next;
        }
        s->next = scope;
    }
    return scope;
}

384
385
STATIC void apply_to_single_or_list(compiler_t *comp, mp_parse_node_t pn, pn_kind_t pn_list_kind, void (*f)(compiler_t*, mp_parse_node_t)) {
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, pn_list_kind)) {
386
387
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
388
389
390
        for (int i = 0; i < num_nodes; i++) {
            f(comp, pns->nodes[i]);
        }
391
    } else if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
392
393
394
395
        f(comp, pn);
    }
}

396
STATIC void compile_generic_all_nodes(compiler_t *comp, mp_parse_node_struct_t *pns) {
397
    int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
398
399
400
401
402
    for (int i = 0; i < num_nodes; i++) {
        compile_node(comp, pns->nodes[i]);
    }
}

403
#if MICROPY_EMIT_CPYTHON
404
STATIC bool cpython_c_tuple_is_const(mp_parse_node_t pn) {
405
406
407
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string)) {
        return true;
    }
408
409
410
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_bytes)) {
        return true;
    }
411
412
413
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_const_object)) {
        return true;
    }
414
    if (!MP_PARSE_NODE_IS_LEAF(pn)) {
Damien's avatar
Damien committed
415
416
        return false;
    }
417
    if (MP_PARSE_NODE_IS_ID(pn)) {
Damien's avatar
Damien committed
418
419
420
421
422
        return false;
    }
    return true;
}

423
STATIC void cpython_c_print_quoted_str(vstr_t *vstr, const char *str, uint len, bool bytes) {
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
    bool has_single_quote = false;
    bool has_double_quote = false;
    for (int i = 0; i < len; i++) {
        if (str[i] == '\'') {
            has_single_quote = true;
        } else if (str[i] == '"') {
            has_double_quote = true;
        }
    }
    if (bytes) {
        vstr_printf(vstr, "b");
    }
    bool quote_single = false;
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        quote_single = true;
        vstr_printf(vstr, "'");
    }
    for (int i = 0; i < len; i++) {
        if (str[i] == '\n') {
            vstr_printf(vstr, "\\n");
        } else if (str[i] == '\\') {
            vstr_printf(vstr, "\\\\");
        } else if (str[i] == '\'' && quote_single) {
            vstr_printf(vstr, "\\'");
        } else {
            vstr_printf(vstr, "%c", str[i]);
        }
    }
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        vstr_printf(vstr, "'");
    }
}

461
STATIC void cpython_c_tuple_emit_const(compiler_t *comp, mp_parse_node_t pn, vstr_t *vstr) {
462
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string) || MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_bytes)) {
463
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
464
        cpython_c_print_quoted_str(vstr, (const char*)pns->nodes[0], (mp_uint_t)pns->nodes[1], MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_bytes));
465
466
467
        return;
    }

468
469
470
471
472
473
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_const_object)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        mp_obj_print((mp_obj_t)pns->nodes[0], PRINT_REPR);
        return;
    }

474
    assert(MP_PARSE_NODE_IS_LEAF(pn));
475
476
477
478
479
    if (MP_PARSE_NODE_IS_SMALL_INT(pn)) {
        vstr_printf(vstr, INT_FMT, MP_PARSE_NODE_LEAF_SMALL_INT(pn));
        return;
    }

480
    mp_uint_t arg = MP_PARSE_NODE_LEAF_ARG(pn);
481
482
    switch (MP_PARSE_NODE_LEAF_KIND(pn)) {
        case MP_PARSE_NODE_ID: assert(0);
483
484
        case MP_PARSE_NODE_STRING:
        case MP_PARSE_NODE_BYTES: {
485
            mp_uint_t len;
486
487
488
489
            const byte *str = qstr_data(arg, &len);
            cpython_c_print_quoted_str(vstr, (const char*)str, len, MP_PARSE_NODE_LEAF_KIND(pn) == MP_PARSE_NODE_BYTES);
            break;
        }
490
        case MP_PARSE_NODE_TOKEN:
Damien's avatar
Damien committed
491
            switch (arg) {
492
493
494
                case MP_TOKEN_KW_FALSE: vstr_printf(vstr, "False"); break;
                case MP_TOKEN_KW_NONE: vstr_printf(vstr, "None"); break;
                case MP_TOKEN_KW_TRUE: vstr_printf(vstr, "True"); break;
495
                default: assert(0); // shouldn't happen
Damien's avatar
Damien committed
496
497
498
499
500
501
            }
            break;
        default: assert(0);
    }
}

502
STATIC void cpython_c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
Damien's avatar
Damien committed
503
504
    int n = 0;
    if (pns_list != NULL) {
505
        n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
Damien's avatar
Damien committed
506
507
508
    }
    int total = n;
    bool is_const = true;
509
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
510
        total += 1;
511
        if (!cpython_c_tuple_is_const(pn)) {
Damien's avatar
Damien committed
512
513
514
515
            is_const = false;
        }
    }
    for (int i = 0; i < n; i++) {
516
        if (!cpython_c_tuple_is_const(pns_list->nodes[i])) {
Damien's avatar
Damien committed
517
518
519
520
521
522
            is_const = false;
            break;
        }
    }
    if (total > 0 && is_const) {
        bool need_comma = false;
523
524
        vstr_t *vstr = vstr_new();
        vstr_printf(vstr, "(");
525
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
526
            cpython_c_tuple_emit_const(comp, pn, vstr);
Damien's avatar
Damien committed
527
528
529
530
            need_comma = true;
        }
        for (int i = 0; i < n; i++) {
            if (need_comma) {
531
                vstr_printf(vstr, ", ");
Damien's avatar
Damien committed
532
            }
533
            cpython_c_tuple_emit_const(comp, pns_list->nodes[i], vstr);
Damien's avatar
Damien committed
534
535
536
            need_comma = true;
        }
        if (total == 1) {
537
            vstr_printf(vstr, ",)");
Damien's avatar
Damien committed
538
        } else {
539
            vstr_printf(vstr, ")");
Damien's avatar
Damien committed
540
        }
541
        EMIT_ARG(load_const_verbatim_strn, vstr_str(vstr), vstr_len(vstr));
542
        vstr_free(vstr);
Damien's avatar
Damien committed
543
    } else {
544
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
545
546
547
548
549
            compile_node(comp, pn);
        }
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
550
        EMIT_ARG(build_tuple, total);
Damien's avatar
Damien committed
551
552
    }
}
553
554
555
#endif

// funnelling all tuple creations through this function is purely so we can optionally agree with CPython
556
STATIC void c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
557
#if MICROPY_EMIT_CPYTHON
558
559
560
    cpython_c_tuple(comp, pn, pns_list);
#else
    int total = 0;
561
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
562
563
564
565
        compile_node(comp, pn);
        total += 1;
    }
    if (pns_list != NULL) {
566
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
567
568
569
570
571
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
        total += n;
    }
572
    EMIT_ARG(build_tuple, total);
573
574
#endif
}
Damien's avatar
Damien committed
575

576
STATIC void compile_generic_tuple(compiler_t *comp, mp_parse_node_struct_t *pns) {
Damien's avatar
Damien committed
577
    // a simple tuple expression
578
    c_tuple(comp, MP_PARSE_NODE_NULL, pns);
Damien's avatar
Damien committed
579
580
}

581
STATIC bool node_is_const_false(mp_parse_node_t pn) {
582
583
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_FALSE)
        || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) == 0);
Damien's avatar
Damien committed
584
585
}

586
STATIC bool node_is_const_true(mp_parse_node_t pn) {
587
588
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_TRUE)
        || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) != 0);
Damien's avatar
Damien committed
589
590
}

591
#if MICROPY_EMIT_CPYTHON
592
// the is_nested variable is purely to match with CPython, which doesn't fully optimise not's
593
STATIC void cpython_c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label, bool is_nested) {
Damien's avatar
Damien committed
594
595
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
596
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
597
598
599
600
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
601
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
602
603
        }
        return;
604
605
606
607
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
Damien's avatar
Damien committed
608
            if (jump_if == false) {
609
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
610
                for (int i = 0; i < n - 1; i++) {
611
                    cpython_c_if_cond(comp, pns->nodes[i], true, label2, true);
Damien's avatar
Damien committed
612
                }
613
                cpython_c_if_cond(comp, pns->nodes[n - 1], false, label, true);
614
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
615
616
            } else {
                for (int i = 0; i < n; i++) {
617
                    cpython_c_if_cond(comp, pns->nodes[i], true, label, true);
Damien's avatar
Damien committed
618
619
620
                }
            }
            return;
621
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
Damien's avatar
Damien committed
622
623
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
624
                    cpython_c_if_cond(comp, pns->nodes[i], false, label, true);
Damien's avatar
Damien committed
625
626
                }
            } else {
627
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
628
                for (int i = 0; i < n - 1; i++) {
629
                    cpython_c_if_cond(comp, pns->nodes[i], false, label2, true);
Damien's avatar
Damien committed
630
                }
631
                cpython_c_if_cond(comp, pns->nodes[n - 1], true, label, true);
632
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
633
634
            }
            return;
635
        } else if (!is_nested && MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
636
            cpython_c_if_cond(comp, pns->nodes[0], !jump_if, label, true);
Damien's avatar
Damien committed
637
638
639
640
641
642
            return;
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
643
    EMIT_ARG(pop_jump_if, jump_if, label);
Damien's avatar
Damien committed
644
}
645
#endif
Damien's avatar
Damien committed
646

647
STATIC void c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label) {
648
#if MICROPY_EMIT_CPYTHON
649
650
651
652
    cpython_c_if_cond(comp, pn, jump_if, label, false);
#else
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
653
            EMIT_ARG(jump, label);
654
655
656
657
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
658
            EMIT_ARG(jump, label);
659
660
        }
        return;
661
662
663
664
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
665
            if (jump_if == false) {
666
            and_or_logic1:;
667
                uint label2 = comp_next_label(comp);
668
                for (int i = 0; i < n - 1; i++) {
669
                    c_if_cond(comp, pns->nodes[i], !jump_if, label2);
670
                }
671
                c_if_cond(comp, pns->nodes[n - 1], jump_if, label);
672
                EMIT_ARG(label_assign, label2);
673
            } else {
674
            and_or_logic2:
675
                for (int i = 0; i < n; i++) {
676
                    c_if_cond(comp, pns->nodes[i], jump_if, label);
677
678
679
                }
            }
            return;
680
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
681
            if (jump_if == false) {
682
                goto and_or_logic2;
683
            } else {
684
                goto and_or_logic1;
685
            }
686
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
687
688
            c_if_cond(comp, pns->nodes[0], !jump_if, label);
            return;
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_atom_paren) {
            // cond is something in parenthesis
            if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
                // empty tuple, acts as false for the condition
                if (jump_if == false) {
                    EMIT_ARG(jump, label);
                }
            } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                // non-empty tuple, acts as true for the condition
                if (jump_if == true) {
                    EMIT_ARG(jump, label);
                }
            } else {
                // parenthesis around 1 item, is just that item
                c_if_cond(comp, pns->nodes[0], jump_if, label);
            }
            return;
706
707
708
709
710
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
711
    EMIT_ARG(pop_jump_if, jump_if, label);
712
#endif
Damien's avatar
Damien committed
713
714
715
}

typedef enum { ASSIGN_STORE, ASSIGN_AUG_LOAD, ASSIGN_AUG_STORE } assign_kind_t;
716
STATIC void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t kind);
Damien's avatar
Damien committed
717

718
STATIC void c_assign_power(compiler_t *comp, mp_parse_node_struct_t *pns, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
719
720
721
722
    if (assign_kind != ASSIGN_AUG_STORE) {
        compile_node(comp, pns->nodes[0]);
    }

723
724
725
726
    if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
        mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_power_trailers) {
            int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns1);
Damien's avatar
Damien committed
727
728
729
730
731
            if (assign_kind != ASSIGN_AUG_STORE) {
                for (int i = 0; i < n - 1; i++) {
                    compile_node(comp, pns1->nodes[i]);
                }
            }
732
733
            assert(MP_PARSE_NODE_IS_STRUCT(pns1->nodes[n - 1]));
            pns1 = (mp_parse_node_struct_t*)pns1->nodes[n - 1];
Damien's avatar
Damien committed
734
        }
735
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_bracket) {
Damien's avatar
Damien committed
736
737
738
739
740
741
742
            if (assign_kind == ASSIGN_AUG_STORE) {
                EMIT(rot_three);
                EMIT(store_subscr);
            } else {
                compile_node(comp, pns1->nodes[0]);
                if (assign_kind == ASSIGN_AUG_LOAD) {
                    EMIT(dup_top_two);
743
                    EMIT(load_subscr);
Damien's avatar
Damien committed
744
745
746
747
                } else {
                    EMIT(store_subscr);
                }
            }
748
749
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_period) {
            assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
Damien's avatar
Damien committed
750
751
            if (assign_kind == ASSIGN_AUG_LOAD) {
                EMIT(dup_top);
752
                EMIT_ARG(load_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
753
754
755
756
            } else {
                if (assign_kind == ASSIGN_AUG_STORE) {
                    EMIT(rot_two);
                }
757
                EMIT_ARG(store_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
758
759
            }
        } else {
760
            goto cannot_assign;
Damien's avatar
Damien committed
761
762
        }
    } else {
763
        goto cannot_assign;
Damien's avatar
Damien committed
764
765
    }

766
    if (!MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
767
        goto cannot_assign;
Damien's avatar
Damien committed
768
    }
769
770
771
772
773

    return;

cannot_assign:
    compile_syntax_error(comp, (mp_parse_node_t)pns, "can't assign to expression");
Damien's avatar
Damien committed
774
775
}

776
// we need to allow for a caller passing in 1 initial node (node_head) followed by an array of nodes (nodes_tail)
777
STATIC void c_assign_tuple(compiler_t *comp, mp_parse_node_t node_head, uint num_tail, mp_parse_node_t *nodes_tail) {
778
779
780
    uint num_head = (node_head == MP_PARSE_NODE_NULL) ? 0 : 1;

    // look for star expression
781
    uint have_star_index = -1;
782
783
784
785
    if (num_head != 0 && MP_PARSE_NODE_IS_STRUCT_KIND(node_head, PN_star_expr)) {
        EMIT_ARG(unpack_ex, 0, num_tail);
        have_star_index = 0;
    }
786
    for (uint i = 0; i < num_tail; i++) {
787
        if (MP_PARSE_NODE_IS_STRUCT_KIND(nodes_tail[i], PN_star_expr)) {
788
            if (have_star_index == (uint)-1) {
789
790
                EMIT_ARG(unpack_ex, num_head + i, num_tail - i - 1);
                have_star_index = num_head + i;
Damien's avatar
Damien committed
791
            } else {
792
                compile_syntax_error(comp, nodes_tail[i], "multiple *x in assignment");
Damien's avatar
Damien committed
793
794
795
796
                return;
            }
        }
    }
797
    if (have_star_index == (uint)-1) {
798
        EMIT_ARG(unpack_sequence, num_head + num_tail);
Damien's avatar
Damien committed
799
    }
800
801
802
    if (num_head != 0) {
        if (0 == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)node_head)->nodes[0], ASSIGN_STORE);
Damien's avatar
Damien committed
803
        } else {
804
805
806
            c_assign(comp, node_head, ASSIGN_STORE);
        }
    }
807
    for (uint i = 0; i < num_tail; i++) {
808
809
810
811
        if (num_head + i == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)nodes_tail[i])->nodes[0], ASSIGN_STORE);
        } else {
            c_assign(comp, nodes_tail[i], ASSIGN_STORE);
Damien's avatar
Damien committed
812
813
814
815
816
        }
    }
}

// assigns top of stack to pn
817
STATIC void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
818
    tail_recursion:
819
820
    assert(!MP_PARSE_NODE_IS_NULL(pn));
    if (MP_PARSE_NODE_IS_LEAF(pn)) {
821
        if (MP_PARSE_NODE_IS_ID(pn)) {
822
            qstr arg = MP_PARSE_NODE_LEAF_ARG(pn);
Damien's avatar
Damien committed
823
824
825
            switch (assign_kind) {
                case ASSIGN_STORE:
                case ASSIGN_AUG_STORE:
826
                    EMIT_ARG(store_id, arg);
Damien's avatar
Damien committed
827
828
                    break;
                case ASSIGN_AUG_LOAD:
829
                default:
830
                    EMIT_ARG(load_id, arg);
Damien's avatar
Damien committed
831
832
833
                    break;
            }
        } else {
834
            compile_syntax_error(comp, pn, "can't assign to literal");
Damien's avatar
Damien committed
835
836
837
            return;
        }
    } else {
838
        // pn must be a struct
839
840
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
Damien's avatar
Damien committed
841
842
843
844
845
846
847
848
849
850
851
            case PN_power:
                // lhs is an index or attribute
                c_assign_power(comp, pns, assign_kind);
                break;

            case PN_testlist_star_expr:
            case PN_exprlist:
                // lhs is a tuple
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
852
                c_assign_tuple(comp, MP_PARSE_NODE_NULL, MP_PARSE_NODE_STRUCT_NUM_NODES(pns), pns->nodes);
Damien's avatar
Damien committed
853
854
855
856
                break;

            case PN_atom_paren:
                // lhs is something in parenthesis
857
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
858
                    // empty tuple
859
                    goto cannot_assign;
860
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
861
862
863
                    if (assign_kind != ASSIGN_STORE) {
                        goto bad_aug;
                    }
864
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
865
866
867
868
869
870
871
872
873
874
875
876
877
                    goto testlist_comp;
                } else {
                    // parenthesis around 1 item, is just that item
                    pn = pns->nodes[0];
                    goto tail_recursion;
                }
                break;

            case PN_atom_bracket:
                // lhs is something in brackets
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
878
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
879
                    // empty list, assignment allowed
880
                    c_assign_tuple(comp, MP_PARSE_NODE_NULL, 0, NULL);
881
882
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
883
884
885
                    goto testlist_comp;
                } else {
                    // brackets around 1 item
886
                    c_assign_tuple(comp, pns->nodes[0], 0, NULL);
Damien's avatar
Damien committed
887
888
889
890
                }
                break;

            default:
891
                goto cannot_assign;
Damien's avatar
Damien committed
892
893
894
895
896
        }
        return;

        testlist_comp:
        // lhs is a sequence
897
898
899
        if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
            mp_parse_node_struct_t *pns2 = (mp_parse_node_struct_t*)pns->nodes[1];
            if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3b) {
Damien's avatar
Damien committed
900
                // sequence of one item, with trailing comma
901
                assert(MP_PARSE_NODE_IS_NULL(pns2->nodes[0]));
902
                c_assign_tuple(comp, pns->nodes[0], 0, NULL);
903
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3c) {
Damien's avatar
Damien committed
904
                // sequence of many items
905
906
                uint n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns2);
                c_assign_tuple(comp, pns->nodes[0], n, pns2->nodes);
907
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_comp_for) {
908
                // TODO can we ever get here? can it be compiled?
909
                goto cannot_assign;
Damien's avatar
Damien committed
910
911
912
913
914
915
916
            } else {
                // sequence with 2 items
                goto sequence_with_2_items;
            }
        } else {
            // sequence with 2 items
            sequence_with_2_items:
917
            c_assign_tuple(comp, MP_PARSE_NODE_NULL, 2, pns->nodes);
Damien's avatar
Damien committed
918
919
920
921
922
        }
        return;
    }
    return;

923
924
925
926
    cannot_assign:
    compile_syntax_error(comp, pn, "can't assign to expression");
    return;

Damien's avatar
Damien committed
927
    bad_aug:
928
    compile_syntax_error(comp, pn, "illegal expression for augmented assignment");
Damien's avatar
Damien committed
929
930
931
}

// stuff for lambda and comprehensions and generators
932
933
934
935
// if we are not in CPython compatibility mode then:
//  if n_pos_defaults > 0 then there is a tuple on the stack with the positional defaults
//  if n_kw_defaults > 0 then there is a dictionary on the stack with the keyword defaults
//  if both exist, the tuple is above the dictionary (ie the first pop gets the tuple)
936
STATIC void close_over_variables_etc(compiler_t *comp, scope_t *this_scope, int n_pos_defaults, int n_kw_defaults) {
937
938
939
    assert(n_pos_defaults >= 0);
    assert(n_kw_defaults >= 0);

Damien's avatar
Damien committed
940
    // make closed over variables, if any
941
    // ensure they are closed over in the order defined in the outer scope (mainly to agree with CPython)
Damien's avatar
Damien committed
942
943
    int nfree = 0;
    if (comp->scope_cur->kind != SCOPE_MODULE) {
944
945
946
947
948
        for (int i = 0; i < comp->scope_cur->id_info_len; i++) {
            id_info_t *id = &comp->scope_cur->id_info[i];
            if (id->kind == ID_INFO_KIND_CELL || id->kind == ID_INFO_KIND_FREE) {
                for (int j = 0; j < this_scope->id_info_len; j++) {
                    id_info_t *id2 = &this_scope->id_info[j];
949
                    if (id2->kind == ID_INFO_KIND_FREE && id->qst == id2->qst) {
Damien George's avatar
Damien George committed
950
#if MICROPY_EMIT_CPYTHON
951
                        EMIT_ARG(load_closure, id->qst, id->local_num);
Damien George's avatar
Damien George committed
952
953
#else
                        // in Micro Python we load closures using LOAD_FAST
954
                        EMIT_ARG(load_fast, id->qst, id->local_num);
Damien George's avatar
Damien George committed
955
#endif