compile.c 154 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
/*
 * This file is part of the Micro Python project, http://micropython.org/
 *
 * The MIT License (MIT)
 *
 * Copyright (c) 2013, 2014 Damien P. George
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

xbe's avatar
xbe committed
27
#include <stdbool.h>
Damien's avatar
Damien committed
28
29
30
31
32
#include <stdint.h>
#include <stdio.h>
#include <string.h>
#include <assert.h>

33
34
35
36
37
38
#include "py/scope.h"
#include "py/emit.h"
#include "py/compile.h"
#include "py/smallint.h"
#include "py/runtime.h"
#include "py/builtin.h"
Damien's avatar
Damien committed
39
40
41
42

// TODO need to mangle __attr names

typedef enum {
43
#define DEF_RULE(rule, comp, kind, ...) PN_##rule,
44
#include "py/grammar.h"
Damien's avatar
Damien committed
45
46
#undef DEF_RULE
    PN_maximum_number_of,
47
    PN_string, // special node for non-interned string
48
    PN_bytes, // special node for non-interned bytes
49
    PN_const_object, // special node for a constant, generic Python object
Damien's avatar
Damien committed
50
51
} pn_kind_t;

52
53
54
55
56
#define NEED_METHOD_TABLE (MICROPY_EMIT_CPYTHON || MICROPY_EMIT_NATIVE)

#if NEED_METHOD_TABLE

// we need a method table to do the lookup for the emitter functions
57
58
#define EMIT(fun) (comp->emit_method_table->fun(comp->emit))
#define EMIT_ARG(fun, ...) (comp->emit_method_table->fun(comp->emit, __VA_ARGS__))
59
60
#define EMIT_LOAD_FAST(qst, local_num) (comp->emit_method_table->load_id.fast(comp->emit, qst, local_num))
#define EMIT_LOAD_GLOBAL(qst) (comp->emit_method_table->load_id.global(comp->emit, qst))
61
62
#define EMIT_INLINE_ASM(fun) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm))
#define EMIT_INLINE_ASM_ARG(fun, ...) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm, __VA_ARGS__))
Damien's avatar
Damien committed
63

64
65
66
67
68
69
70
71
72
73
#else

// if we only have the bytecode emitter enabled then we can do a direct call to the functions
#define EMIT(fun) (mp_emit_bc_##fun(comp->emit))
#define EMIT_ARG(fun, ...) (mp_emit_bc_##fun(comp->emit, __VA_ARGS__))
#define EMIT_LOAD_FAST(qst, local_num) (mp_emit_bc_load_fast(comp->emit, qst, local_num))
#define EMIT_LOAD_GLOBAL(qst) (mp_emit_bc_load_global(comp->emit, qst))

#endif

74
// elements in this struct are ordered to make it compact
Damien's avatar
Damien committed
75
typedef struct _compiler_t {
76
    qstr source_file;
77

78
79
80
    uint8_t is_repl;
    uint8_t pass; // holds enum type pass_kind_t
    uint8_t func_arg_is_super; // used to compile special case of super() function call
81
82
83
84
85
    uint8_t have_star;

    // try to keep compiler clean from nlr
    // this is set to an exception object if we have a compile error
    mp_obj_t compile_error;
Damien's avatar
Damien committed
86

87
    uint next_label;
88

89
90
91
    uint16_t num_dict_params;
    uint16_t num_default_params;

92
93
    uint16_t break_label; // highest bit set indicates we are breaking out of a for loop
    uint16_t continue_label;
94
    uint16_t cur_except_level; // increased for SETUP_EXCEPT, SETUP_FINALLY; decreased for POP_BLOCK, POP_EXCEPT
95
    uint16_t break_continue_except_level;
Damien's avatar
Damien committed
96
97
98
99

    scope_t *scope_head;
    scope_t *scope_cur;

100
    emit_t *emit;                                   // current emitter
101
    #if NEED_METHOD_TABLE
102
    const emit_method_table_t *emit_method_table;   // current emit method table
103
    #endif
104

105
    #if MICROPY_EMIT_INLINE_THUMB
106
107
    emit_inline_asm_t *emit_inline_asm;                                   // current emitter for inline asm
    const emit_inline_asm_method_table_t *emit_inline_asm_method_table;   // current emit method table for inline asm
108
    #endif
Damien's avatar
Damien committed
109
110
} compiler_t;

111
112
STATIC void compile_error_add_traceback(compiler_t *comp, mp_parse_node_t pn) {
    mp_uint_t line;
113
    if (MP_PARSE_NODE_IS_STRUCT(pn)) {
114
        line = (mp_uint_t)((mp_parse_node_struct_t*)pn)->source_line;
115
    } else {
116
        // we don't have a line number, so just pass 0
117
        line = 0;
118
    }
119
120
121
122
123
124
    mp_obj_exception_add_traceback(comp->compile_error, comp->source_file, line, comp->scope_cur->simple_name);
}

STATIC void compile_syntax_error(compiler_t *comp, mp_parse_node_t pn, const char *msg) {
    comp->compile_error = mp_obj_new_exception_msg(&mp_type_SyntaxError, msg);
    compile_error_add_traceback(comp, pn);
125
126
}

127
#if MICROPY_COMP_MODULE_CONST
128
STATIC const mp_map_elem_t mp_constants_table[] = {
129
130
131
    #if MICROPY_PY_UCTYPES
    { MP_OBJ_NEW_QSTR(MP_QSTR_uctypes), (mp_obj_t)&mp_module_uctypes },
    #endif
132
    // Extra constants as defined by a port
133
    MICROPY_PORT_CONSTANTS
134
};
135
136
STATIC MP_DEFINE_CONST_MAP(mp_constants_map, mp_constants_table);
#endif
137

138
139
140
141
// this function is essentially a simple preprocessor
STATIC mp_parse_node_t fold_constants(compiler_t *comp, mp_parse_node_t pn, mp_map_t *consts) {
    if (0) {
        // dummy
142
#if MICROPY_COMP_CONST
143
144
145
146
147
148
149
150
151
    } else if (MP_PARSE_NODE_IS_ID(pn)) {
        // lookup identifier in table of dynamic constants
        qstr qst = MP_PARSE_NODE_LEAF_ARG(pn);
        mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(qst), MP_MAP_LOOKUP);
        if (elem != NULL) {
            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, MP_OBJ_SMALL_INT_VALUE(elem->value));
        }
#endif
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
152
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
Damien's avatar
Damien committed
153

154
155
        // fold some parse nodes before folding their arguments
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
156
#if MICROPY_COMP_CONST
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
            case PN_expr_stmt:
                if (!MP_PARSE_NODE_IS_NULL(pns->nodes[1])) {
                    mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_expr_stmt_assign) {
                        if (MP_PARSE_NODE_IS_ID(pns->nodes[0])
                            && MP_PARSE_NODE_IS_STRUCT_KIND(pns1->nodes[0], PN_power)
                            && MP_PARSE_NODE_IS_ID(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0])
                            && MP_PARSE_NODE_LEAF_ARG(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0]) == MP_QSTR_const
                            && MP_PARSE_NODE_IS_STRUCT_KIND(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1], PN_trailer_paren)
                            && MP_PARSE_NODE_IS_NULL(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[2])
                            ) {
                            // code to assign dynamic constants: id = const(value)

                            // get the id
                            qstr id_qstr = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);

                            // get the value
                            mp_parse_node_t pn_value = ((mp_parse_node_struct_t*)((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1])->nodes[0];
                            pn_value = fold_constants(comp, pn_value, consts);
                            if (!MP_PARSE_NODE_IS_SMALL_INT(pn_value)) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant must be an integer");
                                break;
                            }
180
                            mp_int_t value = MP_PARSE_NODE_LEAF_SMALL_INT(pn_value);
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199

                            // store the value in the table of dynamic constants
                            mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(id_qstr), MP_MAP_LOOKUP_ADD_IF_NOT_FOUND);
                            if (elem->value != MP_OBJ_NULL) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant redefined");
                                break;
                            }
                            elem->value = MP_OBJ_NEW_SMALL_INT(value);

                            // replace const(value) with value
                            pns1->nodes[0] = pn_value;

                            // finished folding this assignment
                            return pn;
                        }
                    }
                }
                break;
#endif
200
            case PN_string:
201
            case PN_bytes:
202
            case PN_const_object:
203
                return pn;
204
205
206
207
        }

        // fold arguments
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
208
        for (int i = 0; i < n; i++) {
209
            pns->nodes[i] = fold_constants(comp, pns->nodes[i], consts);
Damien's avatar
Damien committed
210
211
        }

212
        // try to fold this parse node
213
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
214
215
216
217
218
219
220
221
222
223
            case PN_atom_paren:
                if (n == 1 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0])) {
                    // (int)
                    pn = pns->nodes[0];
                }
                break;

            case PN_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int | int
224
225
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
226
227
228
229
230
231
232
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 | arg1);
                }
                break;

            case PN_and_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int & int
233
234
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
235
236
237
238
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 & arg1);
                }
                break;

Damien's avatar
Damien committed
239
            case PN_shift_expr:
240
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
241
242
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
243
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_LESS)) {
244
                        // int << int
245
                        if (!(arg1 >= (mp_int_t)BITS_PER_WORD || arg0 > (MP_SMALL_INT_MAX >> arg1) || arg0 < (MP_SMALL_INT_MIN >> arg1))) {
246
247
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 << arg1);
                        }
248
249
                    } else {
                        assert(MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_MORE)); // should be
250
                        // int >> int
251
                        if (arg1 >= (mp_int_t)BITS_PER_WORD) {
252
253
254
255
                            // Shifting to big amounts is underfined behavior
                            // in C and is CPU-dependent; propagate sign bit.
                            arg1 = BITS_PER_WORD - 1;
                        }
256
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 >> arg1);
Damien's avatar
Damien committed
257
258
259
260
261
                    }
                }
                break;

            case PN_arith_expr:
262
                // overflow checking here relies on SMALL_INT being strictly smaller than mp_int_t
263
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
264
265
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
266
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PLUS)) {
267
                        // int + int
268
                        arg0 += arg1;
269
270
                    } else {
                        assert(MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_MINUS)); // should be
271
                        // int - int
272
                        arg0 -= arg1;
273
                    }
274
                    if (MP_SMALL_INT_FITS(arg0)) {
275
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
Damien's avatar
Damien committed
276
277
278
279
280
                    }
                }
                break;

            case PN_term:
281
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
282
283
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
284
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_STAR)) {
285
                        // int * int
286
287
                        if (!mp_small_int_mul_overflow(arg0, arg1)) {
                            arg0 *= arg1;
288
                            if (MP_SMALL_INT_FITS(arg0)) {
289
290
291
                                pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
                            }
                        }
292
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_SLASH)) {
293
294
                        // int / int
                        // pass
295
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PERCENT)) {
296
                        // int%int
297
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_modulo(arg0, arg1));
298
299
                    } else {
                        assert(MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_SLASH)); // should be
300
                        if (arg1 != 0) {
301
                            // int // int
302
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_floor_divide(arg0, arg1));
303
                        }
Damien's avatar
Damien committed
304
305
306
307
308
                    }
                }
                break;

            case PN_factor_2:
309
                if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
310
                    mp_int_t arg = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
311
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_PLUS)) {
312
                        // +int
313
314
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_MINUS)) {
315
                        // -int
316
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, -arg);
317
318
                    } else {
                        assert(MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_TILDE)); // should be
319
                        // ~int
320
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ~arg);
Damien's avatar
Damien committed
321
322
323
324
325
                    }
                }
                break;

            case PN_power:
326
327
328
                if (0) {
#if MICROPY_EMIT_CPYTHON
                } else if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_NULL(pns->nodes[1]) && !MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
329
                    // int ** x
330
                    // can overflow; enabled only to compare with CPython
331
                    mp_parse_node_struct_t *pns2 = (mp_parse_node_struct_t*)pns->nodes[2];
332
                    if (MP_PARSE_NODE_IS_SMALL_INT(pns2->nodes[0])) {
333
                        int power = MP_PARSE_NODE_LEAF_SMALL_INT(pns2->nodes[0]);
Damien's avatar
Damien committed
334
335
                        if (power >= 0) {
                            int ans = 1;
336
                            int base = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
Damien's avatar
Damien committed
337
338
339
                            for (; power > 0; power--) {
                                ans *= base;
                            }
340
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ans);
Damien's avatar
Damien committed
341
342
                        }
                    }
343
#endif
344
#if MICROPY_COMP_MODULE_CONST
345
346
347
                } else if (MP_PARSE_NODE_IS_ID(pns->nodes[0]) && MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[1], PN_trailer_period) && MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
                    // id.id
                    // look it up in constant table, see if it can be replaced with an integer
348
                    mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
349
350
351
352
353
354
355
356
                    assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
                    qstr q_base = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);
                    qstr q_attr = MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]);
                    mp_map_elem_t *elem = mp_map_lookup((mp_map_t*)&mp_constants_map, MP_OBJ_NEW_QSTR(q_base), MP_MAP_LOOKUP);
                    if (elem != NULL) {
                        mp_obj_t dest[2];
                        mp_load_method_maybe(elem->value, q_attr, dest);
                        if (MP_OBJ_IS_SMALL_INT(dest[0]) && dest[1] == NULL) {
357
                            mp_int_t val = MP_OBJ_SMALL_INT_VALUE(dest[0]);
358
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, val);
359
360
                        }
                    }
361
#endif
Damien's avatar
Damien committed
362
363
364
365
366
367
368
369
                }
                break;
        }
    }

    return pn;
}

370
STATIC void compile_trailer_paren_helper(compiler_t *comp, mp_parse_node_t pn_arglist, bool is_method_call, int n_positional_extra);
371
STATIC void compile_comprehension(compiler_t *comp, mp_parse_node_struct_t *pns, scope_kind_t kind);
372
STATIC void compile_node(compiler_t *comp, mp_parse_node_t pn);
Damien's avatar
Damien committed
373

374
STATIC uint comp_next_label(compiler_t *comp) {
375
376
377
    return comp->next_label++;
}

378
379
380
381
382
383
384
385
386
387
388
389
STATIC void compile_increase_except_level(compiler_t *comp) {
    comp->cur_except_level += 1;
    if (comp->cur_except_level > comp->scope_cur->exc_stack_size) {
        comp->scope_cur->exc_stack_size = comp->cur_except_level;
    }
}

STATIC void compile_decrease_except_level(compiler_t *comp) {
    assert(comp->cur_except_level > 0);
    comp->cur_except_level -= 1;
}

390
STATIC scope_t *scope_new_and_link(compiler_t *comp, scope_kind_t kind, mp_parse_node_t pn, uint emit_options) {
391
    scope_t *scope = scope_new(kind, pn, comp->source_file, emit_options);
Damien's avatar
Damien committed
392
393
394
395
396
397
398
399
400
401
402
403
404
405
    scope->parent = comp->scope_cur;
    scope->next = NULL;
    if (comp->scope_head == NULL) {
        comp->scope_head = scope;
    } else {
        scope_t *s = comp->scope_head;
        while (s->next != NULL) {
            s = s->next;
        }
        s->next = scope;
    }
    return scope;
}

406
407
408
typedef void (*apply_list_fun_t)(compiler_t *comp, mp_parse_node_t pn);

STATIC void apply_to_single_or_list(compiler_t *comp, mp_parse_node_t pn, pn_kind_t pn_list_kind, apply_list_fun_t f) {
409
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, pn_list_kind)) {
410
411
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
412
413
414
        for (int i = 0; i < num_nodes; i++) {
            f(comp, pns->nodes[i]);
        }
415
    } else if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
416
417
418
419
        f(comp, pn);
    }
}

420
STATIC void compile_generic_all_nodes(compiler_t *comp, mp_parse_node_struct_t *pns) {
421
    int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
422
423
424
425
426
    for (int i = 0; i < num_nodes; i++) {
        compile_node(comp, pns->nodes[i]);
    }
}

427
428
429
430
STATIC void compile_load_id(compiler_t *comp, qstr qst) {
    if (comp->pass == MP_PASS_SCOPE) {
        mp_emit_common_get_id_for_load(comp->scope_cur, qst);
    } else {
431
        #if NEED_METHOD_TABLE
432
        mp_emit_common_id_op(comp->emit, &comp->emit_method_table->load_id, comp->scope_cur, qst);
433
434
435
        #else
        mp_emit_common_id_op(comp->emit, &mp_emit_bc_method_table_load_id_ops, comp->scope_cur, qst);
        #endif
436
437
438
439
440
441
442
    }
}

STATIC void compile_store_id(compiler_t *comp, qstr qst) {
    if (comp->pass == MP_PASS_SCOPE) {
        mp_emit_common_get_id_for_modification(comp->scope_cur, qst);
    } else {
443
        #if NEED_METHOD_TABLE
444
        mp_emit_common_id_op(comp->emit, &comp->emit_method_table->store_id, comp->scope_cur, qst);
445
446
447
        #else
        mp_emit_common_id_op(comp->emit, &mp_emit_bc_method_table_store_id_ops, comp->scope_cur, qst);
        #endif
448
449
450
451
452
453
454
    }
}

STATIC void compile_delete_id(compiler_t *comp, qstr qst) {
    if (comp->pass == MP_PASS_SCOPE) {
        mp_emit_common_get_id_for_modification(comp->scope_cur, qst);
    } else {
455
        #if NEED_METHOD_TABLE
456
        mp_emit_common_id_op(comp->emit, &comp->emit_method_table->delete_id, comp->scope_cur, qst);
457
458
459
        #else
        mp_emit_common_id_op(comp->emit, &mp_emit_bc_method_table_delete_id_ops, comp->scope_cur, qst);
        #endif
460
461
462
    }
}

463
#if MICROPY_EMIT_CPYTHON
464
STATIC bool cpython_c_tuple_is_const(mp_parse_node_t pn) {
465
466
467
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string)) {
        return true;
    }
468
469
470
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_bytes)) {
        return true;
    }
471
472
473
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_const_object)) {
        return true;
    }
474
    if (!MP_PARSE_NODE_IS_LEAF(pn)) {
Damien's avatar
Damien committed
475
476
        return false;
    }
477
    if (MP_PARSE_NODE_IS_ID(pn)) {
Damien's avatar
Damien committed
478
479
480
481
482
        return false;
    }
    return true;
}

483
STATIC void cpython_c_print_quoted_str(vstr_t *vstr, const char *str, uint len, bool bytes) {
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
    bool has_single_quote = false;
    bool has_double_quote = false;
    for (int i = 0; i < len; i++) {
        if (str[i] == '\'') {
            has_single_quote = true;
        } else if (str[i] == '"') {
            has_double_quote = true;
        }
    }
    if (bytes) {
        vstr_printf(vstr, "b");
    }
    bool quote_single = false;
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        quote_single = true;
        vstr_printf(vstr, "'");
    }
    for (int i = 0; i < len; i++) {
        if (str[i] == '\n') {
            vstr_printf(vstr, "\\n");
        } else if (str[i] == '\\') {
            vstr_printf(vstr, "\\\\");
        } else if (str[i] == '\'' && quote_single) {
            vstr_printf(vstr, "\\'");
        } else {
            vstr_printf(vstr, "%c", str[i]);
        }
    }
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        vstr_printf(vstr, "'");
    }
}

521
STATIC void cpython_c_tuple_emit_const(compiler_t *comp, mp_parse_node_t pn, vstr_t *vstr) {
522
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string) || MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_bytes)) {
523
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
524
        cpython_c_print_quoted_str(vstr, (const char*)pns->nodes[0], (mp_uint_t)pns->nodes[1], MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_bytes));
525
526
527
        return;
    }

528
529
530
531
532
533
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_const_object)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        mp_obj_print((mp_obj_t)pns->nodes[0], PRINT_REPR);
        return;
    }

534
    assert(MP_PARSE_NODE_IS_LEAF(pn));
535
536
537
538
539
    if (MP_PARSE_NODE_IS_SMALL_INT(pn)) {
        vstr_printf(vstr, INT_FMT, MP_PARSE_NODE_LEAF_SMALL_INT(pn));
        return;
    }

540
    mp_uint_t arg = MP_PARSE_NODE_LEAF_ARG(pn);
541
542
    switch (MP_PARSE_NODE_LEAF_KIND(pn)) {
        case MP_PARSE_NODE_ID: assert(0);
543
544
        case MP_PARSE_NODE_STRING:
        case MP_PARSE_NODE_BYTES: {
545
            mp_uint_t len;
546
547
548
549
            const byte *str = qstr_data(arg, &len);
            cpython_c_print_quoted_str(vstr, (const char*)str, len, MP_PARSE_NODE_LEAF_KIND(pn) == MP_PARSE_NODE_BYTES);
            break;
        }
550
        case MP_PARSE_NODE_TOKEN:
Damien's avatar
Damien committed
551
            switch (arg) {
552
553
554
                case MP_TOKEN_KW_FALSE: vstr_printf(vstr, "False"); break;
                case MP_TOKEN_KW_NONE: vstr_printf(vstr, "None"); break;
                case MP_TOKEN_KW_TRUE: vstr_printf(vstr, "True"); break;
555
                default: assert(0); // shouldn't happen
Damien's avatar
Damien committed
556
557
558
559
560
561
            }
            break;
        default: assert(0);
    }
}

562
STATIC void cpython_c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
Damien's avatar
Damien committed
563
564
    int n = 0;
    if (pns_list != NULL) {
565
        n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
Damien's avatar
Damien committed
566
567
568
    }
    int total = n;
    bool is_const = true;
569
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
570
        total += 1;
571
        if (!cpython_c_tuple_is_const(pn)) {
Damien's avatar
Damien committed
572
573
574
575
            is_const = false;
        }
    }
    for (int i = 0; i < n; i++) {
576
        if (!cpython_c_tuple_is_const(pns_list->nodes[i])) {
Damien's avatar
Damien committed
577
578
579
580
581
582
            is_const = false;
            break;
        }
    }
    if (total > 0 && is_const) {
        bool need_comma = false;
583
584
        vstr_t *vstr = vstr_new();
        vstr_printf(vstr, "(");
585
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
586
            cpython_c_tuple_emit_const(comp, pn, vstr);
Damien's avatar
Damien committed
587
588
589
590
            need_comma = true;
        }
        for (int i = 0; i < n; i++) {
            if (need_comma) {
591
                vstr_printf(vstr, ", ");
Damien's avatar
Damien committed
592
            }
593
            cpython_c_tuple_emit_const(comp, pns_list->nodes[i], vstr);
Damien's avatar
Damien committed
594
595
596
            need_comma = true;
        }
        if (total == 1) {
597
            vstr_printf(vstr, ",)");
Damien's avatar
Damien committed
598
        } else {
599
            vstr_printf(vstr, ")");
Damien's avatar
Damien committed
600
        }
601
        EMIT_ARG(load_const_verbatim_strn, vstr_str(vstr), vstr_len(vstr));
602
        vstr_free(vstr);
Damien's avatar
Damien committed
603
    } else {
604
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
605
606
607
608
609
            compile_node(comp, pn);
        }
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
610
        EMIT_ARG(build_tuple, total);
Damien's avatar
Damien committed
611
612
    }
}
613
614
615
#endif

// funnelling all tuple creations through this function is purely so we can optionally agree with CPython
616
STATIC void c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
617
#if MICROPY_EMIT_CPYTHON
618
619
620
    cpython_c_tuple(comp, pn, pns_list);
#else
    int total = 0;
621
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
622
623
624
625
        compile_node(comp, pn);
        total += 1;
    }
    if (pns_list != NULL) {
626
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
627
628
629
630
631
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
        total += n;
    }
632
    EMIT_ARG(build_tuple, total);
633
634
#endif
}
Damien's avatar
Damien committed
635

636
STATIC void compile_generic_tuple(compiler_t *comp, mp_parse_node_struct_t *pns) {
Damien's avatar
Damien committed
637
    // a simple tuple expression
638
    c_tuple(comp, MP_PARSE_NODE_NULL, pns);
Damien's avatar
Damien committed
639
640
}

641
STATIC bool node_is_const_false(mp_parse_node_t pn) {
642
643
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_FALSE)
        || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) == 0);
Damien's avatar
Damien committed
644
645
}

646
STATIC bool node_is_const_true(mp_parse_node_t pn) {
647
648
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_TRUE)
        || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) != 0);
Damien's avatar
Damien committed
649
650
}

651
#if MICROPY_EMIT_CPYTHON
652
// the is_nested variable is purely to match with CPython, which doesn't fully optimise not's
653
STATIC void cpython_c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label, bool is_nested) {
Damien's avatar
Damien committed
654
655
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
656
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
657
658
659
660
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
661
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
662
663
        }
        return;
664
665
666
667
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
Damien's avatar
Damien committed
668
            if (jump_if == false) {
669
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
670
                for (int i = 0; i < n - 1; i++) {
671
                    cpython_c_if_cond(comp, pns->nodes[i], true, label2, true);
Damien's avatar
Damien committed
672
                }
673
                cpython_c_if_cond(comp, pns->nodes[n - 1], false, label, true);
674
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
675
676
            } else {
                for (int i = 0; i < n; i++) {
677
                    cpython_c_if_cond(comp, pns->nodes[i], true, label, true);
Damien's avatar
Damien committed
678
679
680
                }
            }
            return;
681
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
Damien's avatar
Damien committed
682
683
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
684
                    cpython_c_if_cond(comp, pns->nodes[i], false, label, true);
Damien's avatar
Damien committed
685
686
                }
            } else {
687
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
688
                for (int i = 0; i < n - 1; i++) {
689
                    cpython_c_if_cond(comp, pns->nodes[i], false, label2, true);
Damien's avatar
Damien committed
690
                }
691
                cpython_c_if_cond(comp, pns->nodes[n - 1], true, label, true);
692
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
693
694
            }
            return;
695
        } else if (!is_nested && MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
696
            cpython_c_if_cond(comp, pns->nodes[0], !jump_if, label, true);
Damien's avatar
Damien committed
697
698
699
700
701
702
            return;
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
703
    EMIT_ARG(pop_jump_if, jump_if, label);
Damien's avatar
Damien committed
704
}
705
#endif
Damien's avatar
Damien committed
706

707
STATIC void c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label) {
708
#if MICROPY_EMIT_CPYTHON
709
710
711
712
    cpython_c_if_cond(comp, pn, jump_if, label, false);
#else
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
713
            EMIT_ARG(jump, label);
714
715
716
717
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
718
            EMIT_ARG(jump, label);
719
720
        }
        return;
721
722
723
724
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
725
            if (jump_if == false) {
726
            and_or_logic1:;
727
                uint label2 = comp_next_label(comp);
728
                for (int i = 0; i < n - 1; i++) {
729
                    c_if_cond(comp, pns->nodes[i], !jump_if, label2);
730
                }
731
                c_if_cond(comp, pns->nodes[n - 1], jump_if, label);
732
                EMIT_ARG(label_assign, label2);
733
            } else {
734
            and_or_logic2:
735
                for (int i = 0; i < n; i++) {
736
                    c_if_cond(comp, pns->nodes[i], jump_if, label);
737
738
739
                }
            }
            return;
740
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
741
            if (jump_if == false) {
742
                goto and_or_logic2;
743
            } else {
744
                goto and_or_logic1;
745
            }
746
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
747
748
            c_if_cond(comp, pns->nodes[0], !jump_if, label);
            return;
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_atom_paren) {
            // cond is something in parenthesis
            if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
                // empty tuple, acts as false for the condition
                if (jump_if == false) {
                    EMIT_ARG(jump, label);
                }
            } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                // non-empty tuple, acts as true for the condition
                if (jump_if == true) {
                    EMIT_ARG(jump, label);
                }
            } else {
                // parenthesis around 1 item, is just that item
                c_if_cond(comp, pns->nodes[0], jump_if, label);
            }
            return;
766
767
768
769
770
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
771
    EMIT_ARG(pop_jump_if, jump_if, label);
772
#endif
Damien's avatar
Damien committed
773
774
775
}

typedef enum { ASSIGN_STORE, ASSIGN_AUG_LOAD, ASSIGN_AUG_STORE } assign_kind_t;
776
STATIC void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t kind);
Damien's avatar
Damien committed
777

778
STATIC void c_assign_power(compiler_t *comp, mp_parse_node_struct_t *pns, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
779
780
781
782
    if (assign_kind != ASSIGN_AUG_STORE) {
        compile_node(comp, pns->nodes[0]);
    }

783
784
785
786
    if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
        mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_power_trailers) {
            int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns1);
Damien's avatar
Damien committed
787
788
789
790
791
            if (assign_kind != ASSIGN_AUG_STORE) {
                for (int i = 0; i < n - 1; i++) {
                    compile_node(comp, pns1->nodes[i]);
                }
            }
792
793
            assert(MP_PARSE_NODE_IS_STRUCT(pns1->nodes[n - 1]));
            pns1 = (mp_parse_node_struct_t*)pns1->nodes[n - 1];
Damien's avatar
Damien committed
794
        }
795
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_bracket) {
Damien's avatar
Damien committed
796
797
798
799
800
801
802
            if (assign_kind == ASSIGN_AUG_STORE) {
                EMIT(rot_three);
                EMIT(store_subscr);
            } else {
                compile_node(comp, pns1->nodes[0]);
                if (assign_kind == ASSIGN_AUG_LOAD) {
                    EMIT(dup_top_two);
803
                    EMIT(load_subscr);
Damien's avatar
Damien committed
804
805
806
807
                } else {
                    EMIT(store_subscr);
                }
            }
808
809
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_period) {
            assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
Damien's avatar
Damien committed
810
811
            if (assign_kind == ASSIGN_AUG_LOAD) {
                EMIT(dup_top);
812
                EMIT_ARG(load_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
813
814
815
816
            } else {
                if (assign_kind == ASSIGN_AUG_STORE) {
                    EMIT(rot_two);
                }
817
                EMIT_ARG(store_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
818
819
            }
        } else {
820
            goto cannot_assign;
Damien's avatar
Damien committed
821
822
        }
    } else {
823
        goto cannot_assign;
Damien's avatar
Damien committed
824
825
    }

826
    if (!MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
827
        goto cannot_assign;
Damien's avatar
Damien committed
828
    }
829
830
831
832
833

    return;

cannot_assign:
    compile_syntax_error(comp, (mp_parse_node_t)pns, "can't assign to expression");
Damien's avatar
Damien committed
834
835
}

836
// we need to allow for a caller passing in 1 initial node (node_head) followed by an array of nodes (nodes_tail)
837
STATIC void c_assign_tuple(compiler_t *comp, mp_parse_node_t node_head, uint num_tail, mp_parse_node_t *nodes_tail) {
838
839
840
    uint num_head = (node_head == MP_PARSE_NODE_NULL) ? 0 : 1;

    // look for star expression
841
    uint have_star_index = -1;
842
843
844
845
    if (num_head != 0 && MP_PARSE_NODE_IS_STRUCT_KIND(node_head, PN_star_expr)) {
        EMIT_ARG(unpack_ex, 0, num_tail);
        have_star_index = 0;
    }
846
    for (uint i = 0; i < num_tail; i++) {
847
        if (MP_PARSE_NODE_IS_STRUCT_KIND(nodes_tail[i], PN_star_expr)) {
848
            if (have_star_index == (uint)-1) {
849
850
                EMIT_ARG(unpack_ex, num_head + i, num_tail - i - 1);
                have_star_index = num_head + i;
Damien's avatar
Damien committed
851
            } else {
852
                compile_syntax_error(comp, nodes_tail[i], "multiple *x in assignment");
Damien's avatar
Damien committed
853
854
855
856
                return;
            }
        }
    }
857
    if (have_star_index == (uint)-1) {
858
        EMIT_ARG(unpack_sequence, num_head + num_tail);
Damien's avatar
Damien committed
859
    }
860
861
862
    if (num_head != 0) {
        if (0 == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)node_head)->nodes[0], ASSIGN_STORE);
Damien's avatar
Damien committed
863
        } else {
864
865
866
            c_assign(comp, node_head, ASSIGN_STORE);
        }
    }
867
    for (uint i = 0; i < num_tail; i++) {
868
869
870
871
        if (num_head + i == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)nodes_tail[i])->nodes[0], ASSIGN_STORE);
        } else {
            c_assign(comp, nodes_tail[i], ASSIGN_STORE);
Damien's avatar
Damien committed
872
873
874
875
876
        }
    }
}

// assigns top of stack to pn
877
STATIC void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
878
    tail_recursion:
879
880
    assert(!MP_PARSE_NODE_IS_NULL(pn));
    if (MP_PARSE_NODE_IS_LEAF(pn)) {
881
        if (MP_PARSE_NODE_IS_ID(pn)) {
882
            qstr arg = MP_PARSE_NODE_LEAF_ARG(pn);
Damien's avatar
Damien committed
883
884
885
            switch (assign_kind) {
                case ASSIGN_STORE:
                case ASSIGN_AUG_STORE:
886
                    compile_store_id(comp, arg);
Damien's avatar
Damien committed
887
888
                    break;
                case ASSIGN_AUG_LOAD:
889
                default:
890
                    compile_load_id(comp, arg);
Damien's avatar
Damien committed
891
892
893
                    break;
            }
        } else {
894
            compile_syntax_error(comp, pn, "can't assign to literal");
Damien's avatar
Damien committed
895
896
897
            return;
        }
    } else {
898
        // pn must be a struct
899
900
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
Damien's avatar
Damien committed
901
902
903
904
905
906
907
908
909
910
911
            case PN_power:
                // lhs is an index or attribute
                c_assign_power(comp, pns, assign_kind);
                break;

            case PN_testlist_star_expr:
            case PN_exprlist:
                // lhs is a tuple
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
912
                c_assign_tuple(comp, MP_PARSE_NODE_NULL, MP_PARSE_NODE_STRUCT_NUM_NODES(pns), pns->nodes);
Damien's avatar
Damien committed
913
914
915
916
                break;

            case PN_atom_paren:
                // lhs is something in parenthesis
917
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
918
                    // empty tuple
919
                    goto cannot_assign;
920
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
921
922
923
                    if (assign_kind != ASSIGN_STORE) {
                        goto bad_aug;
                    }
924
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
925
926
927
928
929
930
931
932
933
934
935
936
937
                    goto testlist_comp;
                } else {
                    // parenthesis around 1 item, is just that item
                    pn = pns->nodes[0];
                    goto tail_recursion;
                }
                break;

            case PN_atom_bracket:
                // lhs is something in brackets
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
938
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
939
                    // empty list, assignment allowed
940
                    c_assign_tuple(comp, MP_PARSE_NODE_NULL, 0, NULL);
941
942
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
943
944
945
                    goto testlist_comp;
                } else {
                    // brackets around 1 item
946
                    c_assign_tuple(comp, pns->nodes[0], 0, NULL);
Damien's avatar
Damien committed
947
948
949
950
                }
                break;

            default:
951
                goto cannot_assign;
Damien's avatar
Damien committed
952
953
954
955
956
        }
        return;

        testlist_comp:
        // lhs is a sequence
957
958
959
        if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
            mp_parse_node_struct_t *pns2 = (mp_parse_node_struct_t*)pns->nodes[1];
            if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3b) {
Damien's avatar
Damien committed
960
                // sequence of one item, with trailing comma
961
                assert(MP_PARSE_NODE_IS_NULL(pns2->nodes[0]));
962
                c_assign_tuple(comp, pns->nodes[0], 0, NULL);
963
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3c) {
Damien's avatar
Damien committe