compile.c 137 KB
Newer Older
xbe's avatar
xbe committed
1
#include <stdbool.h>
Damien's avatar
Damien committed
2
3
4
5
#include <stdint.h>
#include <stdio.h>
#include <string.h>
#include <assert.h>
6
#include <math.h>
Damien's avatar
Damien committed
7
8

#include "misc.h"
9
#include "mpconfig.h"
10
#include "qstr.h"
Damien's avatar
Damien committed
11
12
#include "lexer.h"
#include "parse.h"
13
#include "runtime0.h"
14
#include "obj.h"
15
16
17
#include "emitglue.h"
#include "scope.h"
#include "emit.h"
18
19
#include "compile.h"
#include "runtime.h"
20
#include "builtin.h"
21
#include "smallint.h"
Damien's avatar
Damien committed
22
23
24

// TODO need to mangle __attr names

25
26
#define MICROPY_EMIT_NATIVE (MICROPY_EMIT_X64 || MICROPY_EMIT_THUMB)

Damien's avatar
Damien committed
27
28
typedef enum {
    PN_none = 0,
29
#define DEF_RULE(rule, comp, kind, ...) PN_##rule,
Damien's avatar
Damien committed
30
31
32
33
34
#include "grammar.h"
#undef DEF_RULE
    PN_maximum_number_of,
} pn_kind_t;

35
36
37
38
#define EMIT(fun) (comp->emit_method_table->fun(comp->emit))
#define EMIT_ARG(fun, ...) (comp->emit_method_table->fun(comp->emit, __VA_ARGS__))
#define EMIT_INLINE_ASM(fun) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm))
#define EMIT_INLINE_ASM_ARG(fun, ...) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm, __VA_ARGS__))
Damien's avatar
Damien committed
39
40

typedef struct _compiler_t {
41
    qstr source_file;
42
43
44
45
    uint8_t is_repl;
    uint8_t pass; // holds enum type pass_kind_t
    uint8_t had_error; // try to keep compiler clean from nlr
    uint8_t func_arg_is_super; // used to compile special case of super() function call
Damien's avatar
Damien committed
46

47
    uint next_label;
48

49
50
    uint break_label;
    uint continue_label;
51
    int break_continue_except_level;
52
    uint16_t cur_except_level; // increased for SETUP_EXCEPT, SETUP_FINALLY; decreased for POP_BLOCK, POP_EXCEPT
Damien's avatar
Damien committed
53

54
    uint16_t n_arg_keyword;
55
    uint8_t star_flags;
56
    uint8_t have_star;
57
58
    uint16_t num_dict_params;
    uint16_t num_default_params;
Damien's avatar
Damien committed
59
60
61
62

    scope_t *scope_head;
    scope_t *scope_cur;

63
64
    emit_t *emit;                                   // current emitter
    const emit_method_table_t *emit_method_table;   // current emit method table
65
66
67

    emit_inline_asm_t *emit_inline_asm;                                   // current emitter for inline asm
    const emit_inline_asm_method_table_t *emit_inline_asm_method_table;   // current emit method table for inline asm
Damien's avatar
Damien committed
68
69
} compiler_t;

70
STATIC void compile_syntax_error(compiler_t *comp, mp_parse_node_t pn, const char *msg) {
71
    // TODO store the error message to a variable in compiler_t instead of printing it
72
73
74
75
76
    if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        printf("  File \"%s\", line " UINT_FMT "\n", qstr_str(comp->source_file), (machine_uint_t)((mp_parse_node_struct_t*)pn)->source_line);
    } else {
        printf("  File \"%s\"\n", qstr_str(comp->source_file));
    }
77
78
79
80
    printf("SyntaxError: %s\n", msg);
    comp->had_error = true;
}

81
82
83
84
85
86
87
88
STATIC const mp_map_elem_t mp_constants_table[] = {
    // Extra constants as defined by a port
    MICROPY_EXTRA_CONSTANTS
};

STATIC const mp_map_t mp_constants_map = {
    .all_keys_are_qstrs = 1,
    .table_is_fixed_array = 1,
89
90
    .used = ARRAY_SIZE(mp_constants_table),
    .alloc = ARRAY_SIZE(mp_constants_table),
91
92
93
    .table = (mp_map_elem_t*)mp_constants_table,
};

94
STATIC mp_parse_node_t fold_constants(mp_parse_node_t pn) {
95
96
97
    if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
98
99
100
101
102
103

        // fold arguments first
        for (int i = 0; i < n; i++) {
            pns->nodes[i] = fold_constants(pns->nodes[i]);
        }

104
        // now try to fold this parse node
105
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
            case PN_atom_paren:
                if (n == 1 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0])) {
                    // (int)
                    pn = pns->nodes[0];
                }
                break;

            case PN_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int | int
                    machine_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    machine_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 | arg1);
                }
                break;

            case PN_and_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int & int
                    machine_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    machine_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 & arg1);
                }
                break;

Damien's avatar
Damien committed
131
            case PN_shift_expr:
132
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
133
134
                    machine_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    machine_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
135
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_LESS)) {
136
137
138
139
                        // int << int
                        if (!(arg1 >= BITS_PER_WORD || arg0 > (MP_SMALL_INT_MAX >> arg1) || arg0 < (MP_SMALL_INT_MIN >> arg1))) {
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 << arg1);
                        }
140
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_MORE)) {
141
                        // int >> int
142
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 >> arg1);
Damien's avatar
Damien committed
143
144
145
146
147
148
149
150
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_arith_expr:
151
                // overflow checking here relies on SMALL_INT being strictly smaller than machine_int_t
152
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
153
154
                    machine_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    machine_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
155
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PLUS)) {
156
                        // int + int
157
                        arg0 += arg1;
158
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_MINUS)) {
159
                        // int - int
160
                        arg0 -= arg1;
Damien's avatar
Damien committed
161
162
163
                    } else {
                        // shouldn't happen
                        assert(0);
164
                    }
165
                    if (MP_PARSE_FITS_SMALL_INT(arg0)) {
166
                        //printf("%ld + %ld\n", arg0, arg1);
167
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
Damien's avatar
Damien committed
168
169
170
171
172
                    }
                }
                break;

            case PN_term:
173
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
174
175
                    machine_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    machine_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
176
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_STAR)) {
177
                        // int * int
178
179
180
181
182
183
                        if (!mp_small_int_mul_overflow(arg0, arg1)) {
                            arg0 *= arg1;
                            if (MP_PARSE_FITS_SMALL_INT(arg0)) {
                                pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
                            }
                        }
184
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_SLASH)) {
185
186
                        // int / int
                        // pass
187
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PERCENT)) {
188
                        // int%int
189
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_modulo(arg0, arg1));
190
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_SLASH)) {
191
                        if (arg1 != 0) {
192
                            // int // int
193
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_floor_divide(arg0, arg1));
194
                        }
Damien's avatar
Damien committed
195
196
197
198
199
200
201
202
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_factor_2:
203
                if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
204
                    machine_int_t arg = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
205
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_PLUS)) {
206
                        // +int
207
208
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_MINUS)) {
209
                        // -int
210
211
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, -arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_TILDE)) {
212
                        // ~int
213
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ~arg);
Damien's avatar
Damien committed
214
215
216
217
218
219
220
221
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_power:
222
223
224
                if (0) {
#if MICROPY_EMIT_CPYTHON
                } else if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_NULL(pns->nodes[1]) && !MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
225
                    // int ** x
226
                    // can overflow; enabled only to compare with CPython
227
228
                    mp_parse_node_struct_t* pns2 = (mp_parse_node_struct_t*)pns->nodes[2];
                    if (MP_PARSE_NODE_IS_SMALL_INT(pns2->nodes[0])) {
229
                        int power = MP_PARSE_NODE_LEAF_SMALL_INT(pns2->nodes[0]);
Damien's avatar
Damien committed
230
231
                        if (power >= 0) {
                            int ans = 1;
232
                            int base = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
Damien's avatar
Damien committed
233
234
235
                            for (; power > 0; power--) {
                                ans *= base;
                            }
236
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ans);
Damien's avatar
Damien committed
237
238
                        }
                    }
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
#endif
                } else if (MP_PARSE_NODE_IS_ID(pns->nodes[0]) && MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[1], PN_trailer_period) && MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
                    // id.id
                    // look it up in constant table, see if it can be replaced with an integer
                    mp_parse_node_struct_t* pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
                    qstr q_base = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);
                    qstr q_attr = MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]);
                    mp_map_elem_t *elem = mp_map_lookup((mp_map_t*)&mp_constants_map, MP_OBJ_NEW_QSTR(q_base), MP_MAP_LOOKUP);
                    if (elem != NULL) {
                        mp_obj_t dest[2];
                        mp_load_method_maybe(elem->value, q_attr, dest);
                        if (MP_OBJ_IS_SMALL_INT(dest[0]) && dest[1] == NULL) {
                            machine_int_t val = MP_OBJ_SMALL_INT_VALUE(dest[0]);
                            if (MP_PARSE_FITS_SMALL_INT(val)) {
                                pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, val);
                            }
                        }
                    }
Damien's avatar
Damien committed
258
259
260
261
262
263
264
265
                }
                break;
        }
    }

    return pn;
}

266
STATIC void compile_trailer_paren_helper(compiler_t *comp, mp_parse_node_t pn_arglist, bool is_method_call, int n_positional_extra);
267
STATIC void compile_node(compiler_t *comp, mp_parse_node_t pn);
Damien's avatar
Damien committed
268

269
STATIC uint comp_next_label(compiler_t *comp) {
270
271
272
    return comp->next_label++;
}

273
274
275
276
277
278
279
280
281
282
283
284
STATIC void compile_increase_except_level(compiler_t *comp) {
    comp->cur_except_level += 1;
    if (comp->cur_except_level > comp->scope_cur->exc_stack_size) {
        comp->scope_cur->exc_stack_size = comp->cur_except_level;
    }
}

STATIC void compile_decrease_except_level(compiler_t *comp) {
    assert(comp->cur_except_level > 0);
    comp->cur_except_level -= 1;
}

285
STATIC scope_t *scope_new_and_link(compiler_t *comp, scope_kind_t kind, mp_parse_node_t pn, uint emit_options) {
286
    scope_t *scope = scope_new(kind, pn, comp->source_file, emit_options);
Damien's avatar
Damien committed
287
288
289
290
291
292
293
294
295
296
297
298
299
300
    scope->parent = comp->scope_cur;
    scope->next = NULL;
    if (comp->scope_head == NULL) {
        comp->scope_head = scope;
    } else {
        scope_t *s = comp->scope_head;
        while (s->next != NULL) {
            s = s->next;
        }
        s->next = scope;
    }
    return scope;
}

301
STATIC int list_len(mp_parse_node_t pn, int pn_kind) {
302
    if (MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
303
        return 0;
304
    } else if (MP_PARSE_NODE_IS_LEAF(pn)) {
Damien's avatar
Damien committed
305
306
        return 1;
    } else {
307
308
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        if (MP_PARSE_NODE_STRUCT_KIND(pns) != pn_kind) {
Damien's avatar
Damien committed
309
310
            return 1;
        } else {
311
            return MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
312
313
314
315
        }
    }
}

316
STATIC void apply_to_single_or_list(compiler_t *comp, mp_parse_node_t pn, int pn_list_kind, void (*f)(compiler_t*, mp_parse_node_t)) {
317
318
319
    if (MP_PARSE_NODE_IS_STRUCT(pn) && MP_PARSE_NODE_STRUCT_KIND((mp_parse_node_struct_t*)pn) == pn_list_kind) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
320
321
322
        for (int i = 0; i < num_nodes; i++) {
            f(comp, pns->nodes[i]);
        }
323
    } else if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
324
325
326
327
        f(comp, pn);
    }
}

328
STATIC int list_get(mp_parse_node_t *pn, int pn_kind, mp_parse_node_t **nodes) {
329
    if (MP_PARSE_NODE_IS_NULL(*pn)) {
Damien's avatar
Damien committed
330
331
        *nodes = NULL;
        return 0;
332
    } else if (MP_PARSE_NODE_IS_LEAF(*pn)) {
Damien's avatar
Damien committed
333
334
335
        *nodes = pn;
        return 1;
    } else {
336
337
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)(*pn);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) != pn_kind) {
Damien's avatar
Damien committed
338
339
340
341
            *nodes = pn;
            return 1;
        } else {
            *nodes = pns->nodes;
342
            return MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
343
344
345
346
        }
    }
}

347
void compile_do_nothing(compiler_t *comp, mp_parse_node_struct_t *pns) {
Damien's avatar
Damien committed
348
349
}

350
351
void compile_generic_all_nodes(compiler_t *comp, mp_parse_node_struct_t *pns) {
    int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
352
353
354
355
356
    for (int i = 0; i < num_nodes; i++) {
        compile_node(comp, pns->nodes[i]);
    }
}

357
#if MICROPY_EMIT_CPYTHON
358
STATIC bool cpython_c_tuple_is_const(mp_parse_node_t pn) {
359
    if (!MP_PARSE_NODE_IS_LEAF(pn)) {
Damien's avatar
Damien committed
360
361
        return false;
    }
362
    if (MP_PARSE_NODE_IS_ID(pn)) {
Damien's avatar
Damien committed
363
364
365
366
367
        return false;
    }
    return true;
}

368
STATIC void cpython_c_print_quoted_str(vstr_t *vstr, qstr qstr, bool bytes) {
369
370
    uint len;
    const byte *str = qstr_data(qstr, &len);
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
    bool has_single_quote = false;
    bool has_double_quote = false;
    for (int i = 0; i < len; i++) {
        if (str[i] == '\'') {
            has_single_quote = true;
        } else if (str[i] == '"') {
            has_double_quote = true;
        }
    }
    if (bytes) {
        vstr_printf(vstr, "b");
    }
    bool quote_single = false;
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        quote_single = true;
        vstr_printf(vstr, "'");
    }
    for (int i = 0; i < len; i++) {
        if (str[i] == '\n') {
            vstr_printf(vstr, "\\n");
        } else if (str[i] == '\\') {
            vstr_printf(vstr, "\\\\");
        } else if (str[i] == '\'' && quote_single) {
            vstr_printf(vstr, "\\'");
        } else {
            vstr_printf(vstr, "%c", str[i]);
        }
    }
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        vstr_printf(vstr, "'");
    }
}

408
STATIC void cpython_c_tuple_emit_const(compiler_t *comp, mp_parse_node_t pn, vstr_t *vstr) {
409
    assert(MP_PARSE_NODE_IS_LEAF(pn));
410
411
412
413
414
    if (MP_PARSE_NODE_IS_SMALL_INT(pn)) {
        vstr_printf(vstr, INT_FMT, MP_PARSE_NODE_LEAF_SMALL_INT(pn));
        return;
    }

415
416
417
418
419
420
421
422
    int arg = MP_PARSE_NODE_LEAF_ARG(pn);
    switch (MP_PARSE_NODE_LEAF_KIND(pn)) {
        case MP_PARSE_NODE_ID: assert(0);
        case MP_PARSE_NODE_INTEGER: vstr_printf(vstr, "%s", qstr_str(arg)); break;
        case MP_PARSE_NODE_DECIMAL: vstr_printf(vstr, "%s", qstr_str(arg)); break;
        case MP_PARSE_NODE_STRING: cpython_c_print_quoted_str(vstr, arg, false); break;
        case MP_PARSE_NODE_BYTES: cpython_c_print_quoted_str(vstr, arg, true); break;
        case MP_PARSE_NODE_TOKEN:
Damien's avatar
Damien committed
423
            switch (arg) {
424
425
426
                case MP_TOKEN_KW_FALSE: vstr_printf(vstr, "False"); break;
                case MP_TOKEN_KW_NONE: vstr_printf(vstr, "None"); break;
                case MP_TOKEN_KW_TRUE: vstr_printf(vstr, "True"); break;
427
                default: assert(0); // shouldn't happen
Damien's avatar
Damien committed
428
429
430
431
432
433
            }
            break;
        default: assert(0);
    }
}

434
STATIC void cpython_c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
Damien's avatar
Damien committed
435
436
    int n = 0;
    if (pns_list != NULL) {
437
        n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
Damien's avatar
Damien committed
438
439
440
    }
    int total = n;
    bool is_const = true;
441
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
442
        total += 1;
443
        if (!cpython_c_tuple_is_const(pn)) {
Damien's avatar
Damien committed
444
445
446
447
            is_const = false;
        }
    }
    for (int i = 0; i < n; i++) {
448
        if (!cpython_c_tuple_is_const(pns_list->nodes[i])) {
Damien's avatar
Damien committed
449
450
451
452
453
454
            is_const = false;
            break;
        }
    }
    if (total > 0 && is_const) {
        bool need_comma = false;
455
456
        vstr_t *vstr = vstr_new();
        vstr_printf(vstr, "(");
457
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
458
            cpython_c_tuple_emit_const(comp, pn, vstr);
Damien's avatar
Damien committed
459
460
461
462
            need_comma = true;
        }
        for (int i = 0; i < n; i++) {
            if (need_comma) {
463
                vstr_printf(vstr, ", ");
Damien's avatar
Damien committed
464
            }
465
            cpython_c_tuple_emit_const(comp, pns_list->nodes[i], vstr);
Damien's avatar
Damien committed
466
467
468
            need_comma = true;
        }
        if (total == 1) {
469
            vstr_printf(vstr, ",)");
Damien's avatar
Damien committed
470
        } else {
471
            vstr_printf(vstr, ")");
Damien's avatar
Damien committed
472
        }
473
        EMIT_ARG(load_const_verbatim_str, vstr_str(vstr));
474
        vstr_free(vstr);
Damien's avatar
Damien committed
475
    } else {
476
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
477
478
479
480
481
            compile_node(comp, pn);
        }
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
482
        EMIT_ARG(build_tuple, total);
Damien's avatar
Damien committed
483
484
    }
}
485
486
487
#endif

// funnelling all tuple creations through this function is purely so we can optionally agree with CPython
488
void c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
489
#if MICROPY_EMIT_CPYTHON
490
491
492
    cpython_c_tuple(comp, pn, pns_list);
#else
    int total = 0;
493
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
494
495
496
497
        compile_node(comp, pn);
        total += 1;
    }
    if (pns_list != NULL) {
498
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
499
500
501
502
503
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
        total += n;
    }
504
    EMIT_ARG(build_tuple, total);
505
506
#endif
}
Damien's avatar
Damien committed
507

508
void compile_generic_tuple(compiler_t *comp, mp_parse_node_struct_t *pns) {
Damien's avatar
Damien committed
509
    // a simple tuple expression
510
    c_tuple(comp, MP_PARSE_NODE_NULL, pns);
Damien's avatar
Damien committed
511
512
}

513
STATIC bool node_is_const_false(mp_parse_node_t pn) {
514
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_FALSE);
515
    // untested: || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) == 0);
Damien's avatar
Damien committed
516
517
}

518
STATIC bool node_is_const_true(mp_parse_node_t pn) {
519
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_TRUE) || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) == 1);
Damien's avatar
Damien committed
520
521
}

522
#if MICROPY_EMIT_CPYTHON
523
// the is_nested variable is purely to match with CPython, which doesn't fully optimise not's
524
STATIC void cpython_c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label, bool is_nested) {
Damien's avatar
Damien committed
525
526
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
527
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
528
529
530
531
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
532
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
533
534
        }
        return;
535
536
537
538
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
Damien's avatar
Damien committed
539
            if (jump_if == false) {
540
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
541
                for (int i = 0; i < n - 1; i++) {
542
                    cpython_c_if_cond(comp, pns->nodes[i], true, label2, true);
Damien's avatar
Damien committed
543
                }
544
                cpython_c_if_cond(comp, pns->nodes[n - 1], false, label, true);
545
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
546
547
            } else {
                for (int i = 0; i < n; i++) {
548
                    cpython_c_if_cond(comp, pns->nodes[i], true, label, true);
Damien's avatar
Damien committed
549
550
551
                }
            }
            return;
552
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
Damien's avatar
Damien committed
553
554
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
555
                    cpython_c_if_cond(comp, pns->nodes[i], false, label, true);
Damien's avatar
Damien committed
556
557
                }
            } else {
558
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
559
                for (int i = 0; i < n - 1; i++) {
560
                    cpython_c_if_cond(comp, pns->nodes[i], false, label2, true);
Damien's avatar
Damien committed
561
                }
562
                cpython_c_if_cond(comp, pns->nodes[n - 1], true, label, true);
563
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
564
565
            }
            return;
566
        } else if (!is_nested && MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
567
            cpython_c_if_cond(comp, pns->nodes[0], !jump_if, label, true);
Damien's avatar
Damien committed
568
569
570
571
572
573
574
            return;
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
    if (jump_if == false) {
575
        EMIT_ARG(pop_jump_if_false, label);
Damien's avatar
Damien committed
576
    } else {
577
        EMIT_ARG(pop_jump_if_true, label);
Damien's avatar
Damien committed
578
579
    }
}
580
#endif
Damien's avatar
Damien committed
581

582
STATIC void c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label) {
583
#if MICROPY_EMIT_CPYTHON
584
585
586
587
    cpython_c_if_cond(comp, pn, jump_if, label, false);
#else
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
588
            EMIT_ARG(jump, label);
589
590
591
592
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
593
            EMIT_ARG(jump, label);
594
595
        }
        return;
596
597
598
599
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
600
            if (jump_if == false) {
601
                uint label2 = comp_next_label(comp);
602
603
604
605
                for (int i = 0; i < n - 1; i++) {
                    c_if_cond(comp, pns->nodes[i], true, label2);
                }
                c_if_cond(comp, pns->nodes[n - 1], false, label);
606
                EMIT_ARG(label_assign, label2);
607
608
609
610
611
612
            } else {
                for (int i = 0; i < n; i++) {
                    c_if_cond(comp, pns->nodes[i], true, label);
                }
            }
            return;
613
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
614
615
616
617
618
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
                    c_if_cond(comp, pns->nodes[i], false, label);
                }
            } else {
619
                uint label2 = comp_next_label(comp);
620
621
622
623
                for (int i = 0; i < n - 1; i++) {
                    c_if_cond(comp, pns->nodes[i], false, label2);
                }
                c_if_cond(comp, pns->nodes[n - 1], true, label);
624
                EMIT_ARG(label_assign, label2);
625
626
            }
            return;
627
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
628
629
630
631
632
633
634
635
            c_if_cond(comp, pns->nodes[0], !jump_if, label);
            return;
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
    if (jump_if == false) {
636
        EMIT_ARG(pop_jump_if_false, label);
637
    } else {
638
        EMIT_ARG(pop_jump_if_true, label);
639
640
    }
#endif
Damien's avatar
Damien committed
641
642
643
}

typedef enum { ASSIGN_STORE, ASSIGN_AUG_LOAD, ASSIGN_AUG_STORE } assign_kind_t;
644
void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t kind);
Damien's avatar
Damien committed
645

646
void c_assign_power(compiler_t *comp, mp_parse_node_struct_t *pns, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
647
648
649
650
    if (assign_kind != ASSIGN_AUG_STORE) {
        compile_node(comp, pns->nodes[0]);
    }

651
652
653
654
    if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
        mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_power_trailers) {
            int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns1);
Damien's avatar
Damien committed
655
656
657
658
659
            if (assign_kind != ASSIGN_AUG_STORE) {
                for (int i = 0; i < n - 1; i++) {
                    compile_node(comp, pns1->nodes[i]);
                }
            }
660
661
            assert(MP_PARSE_NODE_IS_STRUCT(pns1->nodes[n - 1]));
            pns1 = (mp_parse_node_struct_t*)pns1->nodes[n - 1];
Damien's avatar
Damien committed
662
        }
663
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_paren) {
664
            goto cannot_assign;
665
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_bracket) {
Damien's avatar
Damien committed
666
667
668
669
670
671
672
            if (assign_kind == ASSIGN_AUG_STORE) {
                EMIT(rot_three);
                EMIT(store_subscr);
            } else {
                compile_node(comp, pns1->nodes[0]);
                if (assign_kind == ASSIGN_AUG_LOAD) {
                    EMIT(dup_top_two);
673
                    EMIT(load_subscr);
Damien's avatar
Damien committed
674
675
676
677
                } else {
                    EMIT(store_subscr);
                }
            }
678
679
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_period) {
            assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
Damien's avatar
Damien committed
680
681
            if (assign_kind == ASSIGN_AUG_LOAD) {
                EMIT(dup_top);
682
                EMIT_ARG(load_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
683
684
685
686
            } else {
                if (assign_kind == ASSIGN_AUG_STORE) {
                    EMIT(rot_two);
                }
687
                EMIT_ARG(store_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
688
689
            }
        } else {
690
            goto cannot_assign;
Damien's avatar
Damien committed
691
692
        }
    } else {
693
        goto cannot_assign;
Damien's avatar
Damien committed
694
695
    }

696
    if (!MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
697
        goto cannot_assign;
Damien's avatar
Damien committed
698
    }
699
700
701
702
703

    return;

cannot_assign:
    compile_syntax_error(comp, (mp_parse_node_t)pns, "can't assign to expression");
Damien's avatar
Damien committed
704
705
}

706
707
708
709
710
// we need to allow for a caller passing in 1 initial node (node_head) followed by an array of nodes (nodes_tail)
void c_assign_tuple(compiler_t *comp, mp_parse_node_t node_head, uint num_tail, mp_parse_node_t *nodes_tail) {
    uint num_head = (node_head == MP_PARSE_NODE_NULL) ? 0 : 1;

    // look for star expression
Damien's avatar
Damien committed
711
    int have_star_index = -1;
712
713
714
715
716
717
    if (num_head != 0 && MP_PARSE_NODE_IS_STRUCT_KIND(node_head, PN_star_expr)) {
        EMIT_ARG(unpack_ex, 0, num_tail);
        have_star_index = 0;
    }
    for (int i = 0; i < num_tail; i++) {
        if (MP_PARSE_NODE_IS_STRUCT_KIND(nodes_tail[i], PN_star_expr)) {
Damien's avatar
Damien committed
718
            if (have_star_index < 0) {
719
720
                EMIT_ARG(unpack_ex, num_head + i, num_tail - i - 1);
                have_star_index = num_head + i;
Damien's avatar
Damien committed
721
            } else {
722
                compile_syntax_error(comp, nodes_tail[i], "two starred expressions in assignment");
Damien's avatar
Damien committed
723
724
725
726
727
                return;
            }
        }
    }
    if (have_star_index < 0) {
728
        EMIT_ARG(unpack_sequence, num_head + num_tail);
Damien's avatar
Damien committed
729
    }
730
731
732
    if (num_head != 0) {
        if (0 == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)node_head)->nodes[0], ASSIGN_STORE);
Damien's avatar
Damien committed
733
        } else {
734
735
736
737
738
739
740
741
            c_assign(comp, node_head, ASSIGN_STORE);
        }
    }
    for (int i = 0; i < num_tail; i++) {
        if (num_head + i == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)nodes_tail[i])->nodes[0], ASSIGN_STORE);
        } else {
            c_assign(comp, nodes_tail[i], ASSIGN_STORE);
Damien's avatar
Damien committed
742
743
744
745
746
        }
    }
}

// assigns top of stack to pn
747
void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
748
    tail_recursion:
749
    if (MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
750
        assert(0);
751
752
753
    } else if (MP_PARSE_NODE_IS_LEAF(pn)) {
        if (MP_PARSE_NODE_IS_ID(pn)) {
            int arg = MP_PARSE_NODE_LEAF_ARG(pn);
Damien's avatar
Damien committed
754
755
756
            switch (assign_kind) {
                case ASSIGN_STORE:
                case ASSIGN_AUG_STORE:
757
                    EMIT_ARG(store_id, arg);
Damien's avatar
Damien committed
758
759
                    break;
                case ASSIGN_AUG_LOAD:
760
                    EMIT_ARG(load_id, arg);
Damien's avatar
Damien committed
761
762
763
                    break;
            }
        } else {
764
            compile_syntax_error(comp, pn, "can't assign to literal");
Damien's avatar
Damien committed
765
766
767
            return;
        }
    } else {
768
769
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
Damien's avatar
Damien committed
770
771
772
773
774
775
776
777
778
779
780
            case PN_power:
                // lhs is an index or attribute
                c_assign_power(comp, pns, assign_kind);
                break;

            case PN_testlist_star_expr:
            case PN_exprlist:
                // lhs is a tuple
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
781
                c_assign_tuple(comp, MP_PARSE_NODE_NULL, MP_PARSE_NODE_STRUCT_NUM_NODES(pns), pns->nodes);
Damien's avatar
Damien committed
782
783
784
785
                break;

            case PN_atom_paren:
                // lhs is something in parenthesis
786
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
787
                    // empty tuple
788
                    compile_syntax_error(comp, pn, "can't assign to ()");
Damien's avatar
Damien committed
789
                    return;
790
791
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
792
793
794
795
796
797
798
799
800
801
802
803
804
                    goto testlist_comp;
                } else {
                    // parenthesis around 1 item, is just that item
                    pn = pns->nodes[0];
                    goto tail_recursion;
                }
                break;

            case PN_atom_bracket:
                // lhs is something in brackets
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
805
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
806
                    // empty list, assignment allowed
807
                    c_assign_tuple(comp, MP_PARSE_NODE_NULL, 0, NULL);
808
809
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
810
811
812
                    goto testlist_comp;
                } else {
                    // brackets around 1 item
813
                    c_assign_tuple(comp, pns->nodes[0], 0, NULL);
Damien's avatar
Damien committed
814
815
816
817
                }
                break;

            default:
818
819
                compile_syntax_error(comp, (mp_parse_node_t)pns, "can't assign to expression");
                return;
Damien's avatar
Damien committed
820
821
822
823
824
        }
        return;

        testlist_comp:
        // lhs is a sequence
825
826
827
        if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
            mp_parse_node_struct_t *pns2 = (mp_parse_node_struct_t*)pns->nodes[1];
            if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3b) {
Damien's avatar
Damien committed
828
                // sequence of one item, with trailing comma
829
                assert(MP_PARSE_NODE_IS_NULL(pns2->nodes[0]));
830
                c_assign_tuple(comp, pns->nodes[0], 0, NULL);
831
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3c) {
Damien's avatar
Damien committed
832
                // sequence of many items
833
834
                uint n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns2);
                c_assign_tuple(comp, pns->nodes[0], n, pns2->nodes);
835
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_comp_for) {
836
837
838
                // TODO can we ever get here? can it be compiled?
                compile_syntax_error(comp, (mp_parse_node_t)pns, "can't assign to expression");
                return;
Damien's avatar
Damien committed
839
840
841
842
843
844
845
            } else {
                // sequence with 2 items
                goto sequence_with_2_items;
            }
        } else {
            // sequence with 2 items
            sequence_with_2_items:
846
            c_assign_tuple(comp, MP_PARSE_NODE_NULL, 2, pns->nodes);
Damien's avatar
Damien committed
847
848
849
850
851
852
        }
        return;
    }
    return;

    bad_aug:
853
    compile_syntax_error(comp, pn, "illegal expression for augmented assignment");
Damien's avatar
Damien committed
854
855
856
}

// stuff for lambda and comprehensions and generators
857
858
859
860
// if we are not in CPython compatibility mode then:
//  if n_pos_defaults > 0 then there is a tuple on the stack with the positional defaults
//  if n_kw_defaults > 0 then there is a dictionary on the stack with the keyword defaults
//  if both exist, the tuple is above the dictionary (ie the first pop gets the tuple)
861
862
863
864
void close_over_variables_etc(compiler_t *comp, scope_t *this_scope, int n_pos_defaults, int n_kw_defaults) {
    assert(n_pos_defaults >= 0);
    assert(n_kw_defaults >= 0);

Damien's avatar
Damien committed
865
    // make closed over variables, if any
866
    // ensure they are closed over in the order defined in the outer scope (mainly to agree with CPython)
Damien's avatar
Damien committed
867
868
    int nfree = 0;
    if (comp->scope_cur->kind != SCOPE_MODULE) {
869
870
871
872
873
874
        for (int i = 0; i < comp->scope_cur->id_info_len; i++) {
            id_info_t *id = &comp->scope_cur->id_info[i];
            if (id->kind == ID_INFO_KIND_CELL || id->kind == ID_INFO_KIND_FREE) {
                for (int j = 0; j < this_scope->id_info_len; j++) {
                    id_info_t *id2 = &this_scope->id_info[j];
                    if (id2->kind == ID_INFO_KIND_FREE && id->qstr == id2->qstr) {
Damien George's avatar
Damien George committed
875
#if MICROPY_EMIT_CPYTHON
876
                        EMIT_ARG(load_closure, id->qstr, id->local_num);
Damien George's avatar
Damien George committed
877
878
#else
                        // in Micro Python we load closures using LOAD_FAST
879
                        EMIT_ARG(load_fast, id->qstr, id->flags, id->local_num);
Damien George's avatar
Damien George committed
880
#endif
881
882
883
                        nfree += 1;
                    }
                }
Damien's avatar
Damien committed
884
885
886
887
888
889
            }
        }
    }

    // make the function/closure
    if (nfree == 0) {
890
        EMIT_ARG(make_function, this_scope, n_pos_defaults, n_kw_defaults);
Damien's avatar
Damien committed
891
    } else {
892
        EMIT_ARG(make_closure, this_scope, nfree, n_pos_defaults, n_kw_defaults);
Damien's avatar
Damien committed
893
894
895
    }
}

896
void compile_funcdef_param(compiler_t *comp, mp_parse_node_t pn) {
897
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_typedargslist_star)) {
898
899
        comp->have_star = true;
        /* don't need to distinguish bare from named star
900
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
901
902
        if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
            // bare star
903
904
        } else {
            // named star
905
        }
906
        */
907
908

    } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_typedargslist_dbl_star)) {
909
        // named double star
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
        // TODO do we need to do anything with this?

    } else {
        mp_parse_node_t pn_id;
        mp_parse_node_t pn_colon;
        mp_parse_node_t pn_equal;
        if (MP_PARSE_NODE_IS_ID(pn)) {
            // this parameter is just an id

            pn_id = pn;
            pn_colon = MP_PARSE_NODE_NULL;
            pn_equal = MP_PARSE_NODE_NULL;

        } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_typedargslist_name)) {
            // this parameter has a colon and/or equal specifier

            mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
            pn_id = pns->nodes[0];
            pn_colon = pns->nodes[1];
            pn_equal = pns->nodes[2];

        } else {
932
            // XXX what to do here?
933
934
935
936
937
938
939
940
            assert(0);
            return;
        }

        if (MP_PARSE_NODE_IS_NULL(pn_equal)) {
            // this parameter does not have a default value

            // check for non-default parameters given after default parameters (allowed by parser, but not syntactically valid)
941
            if (!comp->have_star && comp->num_default_params != 0) {
942
                compile_syntax_error(comp, pn, "non-default argument follows default argument");
943
944
945
946
                return;
            }

        } else {
Damien's avatar
Damien committed
947
948
            // this parameter has a default value
            // in CPython, None (and True, False?) as default parameters are loaded with LOAD_NAME; don't understandy why
949

950
            if (comp->have_star) {
951
                comp->num_dict_params += 1;
952
#if !MICROPY_EMIT_CPYTHON
953
954
                // in Micro Python we put the default dict parameters into a dictionary using the bytecode
                if (comp->num_dict_params == 1) {
955
956
957
958
                    // in Micro Python we put the default positional parameters into a tuple using the bytecode
                    // we need to do this here before we start building the map for the default keywords
                    if (comp->num_default_params > 0) {
                        EMIT_ARG(build_tuple, comp->num_default_params);
959
960
                    } else {
                        EMIT(load_null); // sentinel indicating empty default positional args
961
                    }
962
963
964
                    // first default dict param, so make the map
                    EMIT_ARG(build_map, 0);
                }
965
#endif
966
967
                EMIT_ARG(load_const_id, MP_PARSE_NODE_LEAF_ARG(pn_id));
                compile_node(comp, pn_equal);
968
#if !MICROPY_EMIT_CPYTHON
969
970
                // in Micro Python we put the default dict parameters into a dictionary using the bytecode
                EMIT(store_map);
971
#endif
Damien's avatar
Damien committed
972
            } else {
973
974
                comp->num_default_params += 1;
                compile_node(comp, pn_equal);
Damien's avatar
Damien committed
975
976
            }
        }
977
978
979

        // TODO pn_colon not implemented
        (void)pn_colon;
Damien's avatar
Damien committed
980
981
982
983
984
    }
}

// leaves function object on stack
// returns function name
985
qstr compile_funcdef_helper(compiler_t *comp, mp_parse_node_struct_t *pns, uint emit_options) {
Damien's avatar
Damien committed
986
987
    if (comp->pass == PASS_1) {
        // create a new scope for this function
988
        scope_t *s = scope_new_and_link(comp, SCOPE_FUNCTION, (mp_parse_node_t)pns, emit_options);
Damien's avatar
Damien committed
989
        // store the function scope so the compiling function can use it at each pass
990
        pns->nodes[4] = (mp_parse_node_t)s;
Damien's avatar
Damien committed
991
992
993
    }

    // save variables (probably don't need to do this, since we can't have nested definitions..?)
994
    uint old_have_star = comp->have_star;
995
996
    uint old_num_dict_params = comp->num_dict_params;
    uint old_num_default_params = comp->num_default_params;
Damien's avatar
Damien committed
997
998

    // compile default parameters
999
    comp->have_star = false;
1000
1001
    comp->num_dict_params = 0;
    comp->num_default_params = 0;
Damien's avatar
Damien committed
1002
    apply_to_single_or_list(comp, pns->nodes[1], PN_typedargslist, compile_funcdef_param);
1003
1004
1005
1006
1007

    if (comp->had_error) {
        return MP_QSTR_NULL;
    }

1008
1009
#if !MICROPY_EMIT_CPYTHON
    // in Micro Python we put the default positional parameters into a tuple using the bytecode
1010
1011
    // the default keywords args may have already made the tuple; if not, do it now
    if (comp->num_default_params > 0 && comp->num_dict_params == 0) {
1012
        EMIT_ARG(build_tuple, comp->num_default_params);
1013
        EMIT(load_null); // sentinel indicating empty default keyword args
1014
1015
1016
    }
#endif

Damien's avatar
Damien committed
1017
1018
1019
1020
    // get the scope for this function
    scope_t *fscope = (scope_t*)pns->nodes[4];

    // make the function
1021
    close_over_variables_etc(comp, fscope, comp->num_default_params, comp->num_dict_params);
Damien's avatar
Damien committed
1022
1023

    // restore variables
1024
    comp->have_star = old_have_star;
1025
1026