compile.c 147 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
/*
 * This file is part of the Micro Python project, http://micropython.org/
 *
 * The MIT License (MIT)
 *
 * Copyright (c) 2013, 2014 Damien P. George
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

xbe's avatar
xbe committed
27
#include <stdbool.h>
Damien's avatar
Damien committed
28
29
30
31
#include <stdint.h>
#include <stdio.h>
#include <string.h>
#include <assert.h>
32
#include <math.h>
Damien's avatar
Damien committed
33

34
#include "mpconfig.h"
35
#include "misc.h"
36
#include "qstr.h"
Damien's avatar
Damien committed
37
38
#include "lexer.h"
#include "parse.h"
39
#include "runtime0.h"
40
#include "obj.h"
41
42
43
#include "emitglue.h"
#include "scope.h"
#include "emit.h"
44
45
#include "compile.h"
#include "runtime.h"
46
#include "builtin.h"
47
#include "smallint.h"
Damien's avatar
Damien committed
48
49
50
51
52

// TODO need to mangle __attr names

typedef enum {
    PN_none = 0,
53
#define DEF_RULE(rule, comp, kind, ...) PN_##rule,
Damien's avatar
Damien committed
54
55
56
#include "grammar.h"
#undef DEF_RULE
    PN_maximum_number_of,
57
    PN_string, // special node for non-interned string
Damien's avatar
Damien committed
58
59
} pn_kind_t;

60
61
62
63
#define EMIT(fun) (comp->emit_method_table->fun(comp->emit))
#define EMIT_ARG(fun, ...) (comp->emit_method_table->fun(comp->emit, __VA_ARGS__))
#define EMIT_INLINE_ASM(fun) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm))
#define EMIT_INLINE_ASM_ARG(fun, ...) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm, __VA_ARGS__))
Damien's avatar
Damien committed
64

65
// elements in this struct are ordered to make it compact
Damien's avatar
Damien committed
66
typedef struct _compiler_t {
67
    qstr source_file;
68

69
70
71
    uint8_t is_repl;
    uint8_t pass; // holds enum type pass_kind_t
    uint8_t func_arg_is_super; // used to compile special case of super() function call
72
73
74
75
76
    uint8_t have_star;

    // try to keep compiler clean from nlr
    // this is set to an exception object if we have a compile error
    mp_obj_t compile_error;
Damien's avatar
Damien committed
77

78
    uint next_label;
79

80
81
82
    uint16_t num_dict_params;
    uint16_t num_default_params;

83
84
    uint16_t break_label; // highest bit set indicates we are breaking out of a for loop
    uint16_t continue_label;
85
    uint16_t cur_except_level; // increased for SETUP_EXCEPT, SETUP_FINALLY; decreased for POP_BLOCK, POP_EXCEPT
86
    uint16_t break_continue_except_level;
Damien's avatar
Damien committed
87
88
89
90

    scope_t *scope_head;
    scope_t *scope_cur;

91
92
    emit_t *emit;                                   // current emitter
    const emit_method_table_t *emit_method_table;   // current emit method table
93
94
95

    emit_inline_asm_t *emit_inline_asm;                                   // current emitter for inline asm
    const emit_inline_asm_method_table_t *emit_inline_asm_method_table;   // current emit method table for inline asm
Damien's avatar
Damien committed
96
97
} compiler_t;

98
STATIC void compile_syntax_error(compiler_t *comp, mp_parse_node_t pn, const char *msg) {
99
100
    mp_obj_t exc = mp_obj_new_exception_msg(&mp_type_SyntaxError, msg);
    // we don't have a 'block' name, so just pass the NULL qstr to indicate this
101
    if (MP_PARSE_NODE_IS_STRUCT(pn)) {
102
        mp_obj_exception_add_traceback(exc, comp->source_file, (mp_uint_t)((mp_parse_node_struct_t*)pn)->source_line, MP_QSTR_NULL);
103
    } else {
104
105
        // we don't have a line number, so just pass 0
        mp_obj_exception_add_traceback(exc, comp->source_file, 0, MP_QSTR_NULL);
106
    }
107
    comp->compile_error = exc;
108
109
}

110
STATIC const mp_map_elem_t mp_constants_table[] = {
111
112
113
    #if MICROPY_PY_UCTYPES
    { MP_OBJ_NEW_QSTR(MP_QSTR_uctypes), (mp_obj_t)&mp_module_uctypes },
    #endif
114
    // Extra constants as defined by a port
115
    MICROPY_PORT_CONSTANTS
116
117
118
119
120
};

STATIC const mp_map_t mp_constants_map = {
    .all_keys_are_qstrs = 1,
    .table_is_fixed_array = 1,
121
122
    .used = MP_ARRAY_SIZE(mp_constants_table),
    .alloc = MP_ARRAY_SIZE(mp_constants_table),
123
124
125
    .table = (mp_map_elem_t*)mp_constants_table,
};

126
127
128
129
// this function is essentially a simple preprocessor
STATIC mp_parse_node_t fold_constants(compiler_t *comp, mp_parse_node_t pn, mp_map_t *consts) {
    if (0) {
        // dummy
130
#if MICROPY_COMP_CONST
131
132
133
134
135
136
137
138
139
    } else if (MP_PARSE_NODE_IS_ID(pn)) {
        // lookup identifier in table of dynamic constants
        qstr qst = MP_PARSE_NODE_LEAF_ARG(pn);
        mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(qst), MP_MAP_LOOKUP);
        if (elem != NULL) {
            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, MP_OBJ_SMALL_INT_VALUE(elem->value));
        }
#endif
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
140
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
Damien's avatar
Damien committed
141

142
143
        // fold some parse nodes before folding their arguments
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
144
#if MICROPY_COMP_CONST
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
            case PN_expr_stmt:
                if (!MP_PARSE_NODE_IS_NULL(pns->nodes[1])) {
                    mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_expr_stmt_assign) {
                        if (MP_PARSE_NODE_IS_ID(pns->nodes[0])
                            && MP_PARSE_NODE_IS_STRUCT_KIND(pns1->nodes[0], PN_power)
                            && MP_PARSE_NODE_IS_ID(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0])
                            && MP_PARSE_NODE_LEAF_ARG(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0]) == MP_QSTR_const
                            && MP_PARSE_NODE_IS_STRUCT_KIND(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1], PN_trailer_paren)
                            && MP_PARSE_NODE_IS_NULL(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[2])
                            ) {
                            // code to assign dynamic constants: id = const(value)

                            // get the id
                            qstr id_qstr = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);

                            // get the value
                            mp_parse_node_t pn_value = ((mp_parse_node_struct_t*)((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1])->nodes[0];
                            pn_value = fold_constants(comp, pn_value, consts);
                            if (!MP_PARSE_NODE_IS_SMALL_INT(pn_value)) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant must be an integer");
                                break;
                            }
168
                            mp_int_t value = MP_PARSE_NODE_LEAF_SMALL_INT(pn_value);
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187

                            // store the value in the table of dynamic constants
                            mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(id_qstr), MP_MAP_LOOKUP_ADD_IF_NOT_FOUND);
                            if (elem->value != MP_OBJ_NULL) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant redefined");
                                break;
                            }
                            elem->value = MP_OBJ_NEW_SMALL_INT(value);

                            // replace const(value) with value
                            pns1->nodes[0] = pn_value;

                            // finished folding this assignment
                            return pn;
                        }
                    }
                }
                break;
#endif
188
189
            case PN_string:
                return pn;
190
191
192
193
        }

        // fold arguments
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
194
        for (int i = 0; i < n; i++) {
195
            pns->nodes[i] = fold_constants(comp, pns->nodes[i], consts);
Damien's avatar
Damien committed
196
197
        }

198
        // try to fold this parse node
199
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
200
201
202
203
204
205
206
207
208
209
            case PN_atom_paren:
                if (n == 1 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0])) {
                    // (int)
                    pn = pns->nodes[0];
                }
                break;

            case PN_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int | int
210
211
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
212
213
214
215
216
217
218
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 | arg1);
                }
                break;

            case PN_and_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int & int
219
220
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
221
222
223
224
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 & arg1);
                }
                break;

Damien's avatar
Damien committed
225
            case PN_shift_expr:
226
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
227
228
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
229
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_LESS)) {
230
231
232
233
                        // int << int
                        if (!(arg1 >= BITS_PER_WORD || arg0 > (MP_SMALL_INT_MAX >> arg1) || arg0 < (MP_SMALL_INT_MIN >> arg1))) {
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 << arg1);
                        }
234
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_MORE)) {
235
                        // int >> int
236
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 >> arg1);
Damien's avatar
Damien committed
237
238
239
240
241
242
243
244
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_arith_expr:
245
                // overflow checking here relies on SMALL_INT being strictly smaller than mp_int_t
246
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
247
248
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
249
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PLUS)) {
250
                        // int + int
251
                        arg0 += arg1;
252
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_MINUS)) {
253
                        // int - int
254
                        arg0 -= arg1;
Damien's avatar
Damien committed
255
256
257
                    } else {
                        // shouldn't happen
                        assert(0);
258
                    }
259
                    if (MP_SMALL_INT_FITS(arg0)) {
260
                        //printf("%ld + %ld\n", arg0, arg1);
261
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
Damien's avatar
Damien committed
262
263
264
265
266
                    }
                }
                break;

            case PN_term:
267
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
268
269
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
270
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_STAR)) {
271
                        // int * int
272
273
                        if (!mp_small_int_mul_overflow(arg0, arg1)) {
                            arg0 *= arg1;
274
                            if (MP_SMALL_INT_FITS(arg0)) {
275
276
277
                                pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
                            }
                        }
278
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_SLASH)) {
279
280
                        // int / int
                        // pass
281
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PERCENT)) {
282
                        // int%int
283
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_modulo(arg0, arg1));
284
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_SLASH)) {
285
                        if (arg1 != 0) {
286
                            // int // int
287
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_floor_divide(arg0, arg1));
288
                        }
Damien's avatar
Damien committed
289
290
291
292
293
294
295
296
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_factor_2:
297
                if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
298
                    mp_int_t arg = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
299
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_PLUS)) {
300
                        // +int
301
302
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_MINUS)) {
303
                        // -int
304
305
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, -arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_TILDE)) {
306
                        // ~int
307
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ~arg);
Damien's avatar
Damien committed
308
309
310
311
312
313
314
315
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_power:
316
317
318
                if (0) {
#if MICROPY_EMIT_CPYTHON
                } else if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_NULL(pns->nodes[1]) && !MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
319
                    // int ** x
320
                    // can overflow; enabled only to compare with CPython
321
322
                    mp_parse_node_struct_t* pns2 = (mp_parse_node_struct_t*)pns->nodes[2];
                    if (MP_PARSE_NODE_IS_SMALL_INT(pns2->nodes[0])) {
323
                        int power = MP_PARSE_NODE_LEAF_SMALL_INT(pns2->nodes[0]);
Damien's avatar
Damien committed
324
325
                        if (power >= 0) {
                            int ans = 1;
326
                            int base = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
Damien's avatar
Damien committed
327
328
329
                            for (; power > 0; power--) {
                                ans *= base;
                            }
330
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ans);
Damien's avatar
Damien committed
331
332
                        }
                    }
333
334
335
336
337
338
339
340
341
342
343
344
345
#endif
                } else if (MP_PARSE_NODE_IS_ID(pns->nodes[0]) && MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[1], PN_trailer_period) && MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
                    // id.id
                    // look it up in constant table, see if it can be replaced with an integer
                    mp_parse_node_struct_t* pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
                    qstr q_base = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);
                    qstr q_attr = MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]);
                    mp_map_elem_t *elem = mp_map_lookup((mp_map_t*)&mp_constants_map, MP_OBJ_NEW_QSTR(q_base), MP_MAP_LOOKUP);
                    if (elem != NULL) {
                        mp_obj_t dest[2];
                        mp_load_method_maybe(elem->value, q_attr, dest);
                        if (MP_OBJ_IS_SMALL_INT(dest[0]) && dest[1] == NULL) {
346
                            mp_int_t val = MP_OBJ_SMALL_INT_VALUE(dest[0]);
347
                            if (MP_SMALL_INT_FITS(val)) {
348
349
350
351
                                pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, val);
                            }
                        }
                    }
Damien's avatar
Damien committed
352
353
354
355
356
357
358
359
                }
                break;
        }
    }

    return pn;
}

360
STATIC void compile_trailer_paren_helper(compiler_t *comp, mp_parse_node_t pn_arglist, bool is_method_call, int n_positional_extra);
361
STATIC void compile_comprehension(compiler_t *comp, mp_parse_node_struct_t *pns, scope_kind_t kind);
362
STATIC void compile_node(compiler_t *comp, mp_parse_node_t pn);
Damien's avatar
Damien committed
363

364
STATIC uint comp_next_label(compiler_t *comp) {
365
366
367
    return comp->next_label++;
}

368
369
370
371
372
373
374
375
376
377
378
379
STATIC void compile_increase_except_level(compiler_t *comp) {
    comp->cur_except_level += 1;
    if (comp->cur_except_level > comp->scope_cur->exc_stack_size) {
        comp->scope_cur->exc_stack_size = comp->cur_except_level;
    }
}

STATIC void compile_decrease_except_level(compiler_t *comp) {
    assert(comp->cur_except_level > 0);
    comp->cur_except_level -= 1;
}

380
STATIC scope_t *scope_new_and_link(compiler_t *comp, scope_kind_t kind, mp_parse_node_t pn, uint emit_options) {
381
    scope_t *scope = scope_new(kind, pn, comp->source_file, emit_options);
Damien's avatar
Damien committed
382
383
384
385
386
387
388
389
390
391
392
393
394
395
    scope->parent = comp->scope_cur;
    scope->next = NULL;
    if (comp->scope_head == NULL) {
        comp->scope_head = scope;
    } else {
        scope_t *s = comp->scope_head;
        while (s->next != NULL) {
            s = s->next;
        }
        s->next = scope;
    }
    return scope;
}

396
STATIC void apply_to_single_or_list(compiler_t *comp, mp_parse_node_t pn, int pn_list_kind, void (*f)(compiler_t*, mp_parse_node_t)) {
397
398
399
    if (MP_PARSE_NODE_IS_STRUCT(pn) && MP_PARSE_NODE_STRUCT_KIND((mp_parse_node_struct_t*)pn) == pn_list_kind) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
400
401
402
        for (int i = 0; i < num_nodes; i++) {
            f(comp, pns->nodes[i]);
        }
403
    } else if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
404
405
406
407
        f(comp, pn);
    }
}

408
STATIC int list_get(mp_parse_node_t *pn, int pn_kind, mp_parse_node_t **nodes) {
409
    if (MP_PARSE_NODE_IS_NULL(*pn)) {
Damien's avatar
Damien committed
410
411
        *nodes = NULL;
        return 0;
412
    } else if (MP_PARSE_NODE_IS_LEAF(*pn)) {
Damien's avatar
Damien committed
413
414
415
        *nodes = pn;
        return 1;
    } else {
416
417
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)(*pn);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) != pn_kind) {
Damien's avatar
Damien committed
418
419
420
421
            *nodes = pn;
            return 1;
        } else {
            *nodes = pns->nodes;
422
            return MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
423
424
425
426
        }
    }
}

427
void compile_do_nothing(compiler_t *comp, mp_parse_node_struct_t *pns) {
Damien's avatar
Damien committed
428
429
}

430
431
void compile_generic_all_nodes(compiler_t *comp, mp_parse_node_struct_t *pns) {
    int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
432
433
434
435
436
    for (int i = 0; i < num_nodes; i++) {
        compile_node(comp, pns->nodes[i]);
    }
}

437
#if MICROPY_EMIT_CPYTHON
438
STATIC bool cpython_c_tuple_is_const(mp_parse_node_t pn) {
439
440
441
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string)) {
        return true;
    }
442
    if (!MP_PARSE_NODE_IS_LEAF(pn)) {
Damien's avatar
Damien committed
443
444
        return false;
    }
445
    if (MP_PARSE_NODE_IS_ID(pn)) {
Damien's avatar
Damien committed
446
447
448
449
450
        return false;
    }
    return true;
}

451
STATIC void cpython_c_print_quoted_str(vstr_t *vstr, const char *str, uint len, bool bytes) {
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
    bool has_single_quote = false;
    bool has_double_quote = false;
    for (int i = 0; i < len; i++) {
        if (str[i] == '\'') {
            has_single_quote = true;
        } else if (str[i] == '"') {
            has_double_quote = true;
        }
    }
    if (bytes) {
        vstr_printf(vstr, "b");
    }
    bool quote_single = false;
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        quote_single = true;
        vstr_printf(vstr, "'");
    }
    for (int i = 0; i < len; i++) {
        if (str[i] == '\n') {
            vstr_printf(vstr, "\\n");
        } else if (str[i] == '\\') {
            vstr_printf(vstr, "\\\\");
        } else if (str[i] == '\'' && quote_single) {
            vstr_printf(vstr, "\\'");
        } else {
            vstr_printf(vstr, "%c", str[i]);
        }
    }
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        vstr_printf(vstr, "'");
    }
}

489
STATIC void cpython_c_tuple_emit_const(compiler_t *comp, mp_parse_node_t pn, vstr_t *vstr) {
490
491
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
492
        cpython_c_print_quoted_str(vstr, (const char*)pns->nodes[0], (mp_uint_t)pns->nodes[1], false);
493
494
495
        return;
    }

496
    assert(MP_PARSE_NODE_IS_LEAF(pn));
497
498
499
500
501
    if (MP_PARSE_NODE_IS_SMALL_INT(pn)) {
        vstr_printf(vstr, INT_FMT, MP_PARSE_NODE_LEAF_SMALL_INT(pn));
        return;
    }

502
    mp_uint_t arg = MP_PARSE_NODE_LEAF_ARG(pn);
503
504
505
506
    switch (MP_PARSE_NODE_LEAF_KIND(pn)) {
        case MP_PARSE_NODE_ID: assert(0);
        case MP_PARSE_NODE_INTEGER: vstr_printf(vstr, "%s", qstr_str(arg)); break;
        case MP_PARSE_NODE_DECIMAL: vstr_printf(vstr, "%s", qstr_str(arg)); break;
507
508
        case MP_PARSE_NODE_STRING:
        case MP_PARSE_NODE_BYTES: {
509
            mp_uint_t len;
510
511
512
513
            const byte *str = qstr_data(arg, &len);
            cpython_c_print_quoted_str(vstr, (const char*)str, len, MP_PARSE_NODE_LEAF_KIND(pn) == MP_PARSE_NODE_BYTES);
            break;
        }
514
        case MP_PARSE_NODE_TOKEN:
Damien's avatar
Damien committed
515
            switch (arg) {
516
517
518
                case MP_TOKEN_KW_FALSE: vstr_printf(vstr, "False"); break;
                case MP_TOKEN_KW_NONE: vstr_printf(vstr, "None"); break;
                case MP_TOKEN_KW_TRUE: vstr_printf(vstr, "True"); break;
519
                default: assert(0); // shouldn't happen
Damien's avatar
Damien committed
520
521
522
523
524
525
            }
            break;
        default: assert(0);
    }
}

526
STATIC void cpython_c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
Damien's avatar
Damien committed
527
528
    int n = 0;
    if (pns_list != NULL) {
529
        n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
Damien's avatar
Damien committed
530
531
532
    }
    int total = n;
    bool is_const = true;
533
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
534
        total += 1;
535
        if (!cpython_c_tuple_is_const(pn)) {
Damien's avatar
Damien committed
536
537
538
539
            is_const = false;
        }
    }
    for (int i = 0; i < n; i++) {
540
        if (!cpython_c_tuple_is_const(pns_list->nodes[i])) {
Damien's avatar
Damien committed
541
542
543
544
545
546
            is_const = false;
            break;
        }
    }
    if (total > 0 && is_const) {
        bool need_comma = false;
547
548
        vstr_t *vstr = vstr_new();
        vstr_printf(vstr, "(");
549
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
550
            cpython_c_tuple_emit_const(comp, pn, vstr);
Damien's avatar
Damien committed
551
552
553
554
            need_comma = true;
        }
        for (int i = 0; i < n; i++) {
            if (need_comma) {
555
                vstr_printf(vstr, ", ");
Damien's avatar
Damien committed
556
            }
557
            cpython_c_tuple_emit_const(comp, pns_list->nodes[i], vstr);
Damien's avatar
Damien committed
558
559
560
            need_comma = true;
        }
        if (total == 1) {
561
            vstr_printf(vstr, ",)");
Damien's avatar
Damien committed
562
        } else {
563
            vstr_printf(vstr, ")");
Damien's avatar
Damien committed
564
        }
565
        EMIT_ARG(load_const_verbatim_str, vstr_str(vstr));
566
        vstr_free(vstr);
Damien's avatar
Damien committed
567
    } else {
568
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
569
570
571
572
573
            compile_node(comp, pn);
        }
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
574
        EMIT_ARG(build_tuple, total);
Damien's avatar
Damien committed
575
576
    }
}
577
578
579
#endif

// funnelling all tuple creations through this function is purely so we can optionally agree with CPython
580
STATIC void c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
581
#if MICROPY_EMIT_CPYTHON
582
583
584
    cpython_c_tuple(comp, pn, pns_list);
#else
    int total = 0;
585
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
586
587
588
589
        compile_node(comp, pn);
        total += 1;
    }
    if (pns_list != NULL) {
590
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
591
592
593
594
595
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
        total += n;
    }
596
    EMIT_ARG(build_tuple, total);
597
598
#endif
}
Damien's avatar
Damien committed
599

600
void compile_generic_tuple(compiler_t *comp, mp_parse_node_struct_t *pns) {
Damien's avatar
Damien committed
601
    // a simple tuple expression
602
    c_tuple(comp, MP_PARSE_NODE_NULL, pns);
Damien's avatar
Damien committed
603
604
}

605
STATIC bool node_is_const_false(mp_parse_node_t pn) {
606
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_FALSE);
607
    // untested: || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) == 0);
Damien's avatar
Damien committed
608
609
}

610
STATIC bool node_is_const_true(mp_parse_node_t pn) {
611
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_TRUE) || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) == 1);
Damien's avatar
Damien committed
612
613
}

614
#if MICROPY_EMIT_CPYTHON
615
// the is_nested variable is purely to match with CPython, which doesn't fully optimise not's
616
STATIC void cpython_c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label, bool is_nested) {
Damien's avatar
Damien committed
617
618
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
619
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
620
621
622
623
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
624
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
625
626
        }
        return;
627
628
629
630
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
Damien's avatar
Damien committed
631
            if (jump_if == false) {
632
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
633
                for (int i = 0; i < n - 1; i++) {
634
                    cpython_c_if_cond(comp, pns->nodes[i], true, label2, true);
Damien's avatar
Damien committed
635
                }
636
                cpython_c_if_cond(comp, pns->nodes[n - 1], false, label, true);
637
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
638
639
            } else {
                for (int i = 0; i < n; i++) {
640
                    cpython_c_if_cond(comp, pns->nodes[i], true, label, true);
Damien's avatar
Damien committed
641
642
643
                }
            }
            return;
644
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
Damien's avatar
Damien committed
645
646
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
647
                    cpython_c_if_cond(comp, pns->nodes[i], false, label, true);
Damien's avatar
Damien committed
648
649
                }
            } else {
650
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
651
                for (int i = 0; i < n - 1; i++) {
652
                    cpython_c_if_cond(comp, pns->nodes[i], false, label2, true);
Damien's avatar
Damien committed
653
                }
654
                cpython_c_if_cond(comp, pns->nodes[n - 1], true, label, true);
655
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
656
657
            }
            return;
658
        } else if (!is_nested && MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
659
            cpython_c_if_cond(comp, pns->nodes[0], !jump_if, label, true);
Damien's avatar
Damien committed
660
661
662
663
664
665
666
            return;
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
    if (jump_if == false) {
667
        EMIT_ARG(pop_jump_if_false, label);
Damien's avatar
Damien committed
668
    } else {
669
        EMIT_ARG(pop_jump_if_true, label);
Damien's avatar
Damien committed
670
671
    }
}
672
#endif
Damien's avatar
Damien committed
673

674
STATIC void c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label) {
675
#if MICROPY_EMIT_CPYTHON
676
677
678
679
    cpython_c_if_cond(comp, pn, jump_if, label, false);
#else
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
680
            EMIT_ARG(jump, label);
681
682
683
684
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
685
            EMIT_ARG(jump, label);
686
687
        }
        return;
688
689
690
691
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
692
            if (jump_if == false) {
693
                uint label2 = comp_next_label(comp);
694
695
696
697
                for (int i = 0; i < n - 1; i++) {
                    c_if_cond(comp, pns->nodes[i], true, label2);
                }
                c_if_cond(comp, pns->nodes[n - 1], false, label);
698
                EMIT_ARG(label_assign, label2);
699
700
701
702
703
704
            } else {
                for (int i = 0; i < n; i++) {
                    c_if_cond(comp, pns->nodes[i], true, label);
                }
            }
            return;
705
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
706
707
708
709
710
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
                    c_if_cond(comp, pns->nodes[i], false, label);
                }
            } else {
711
                uint label2 = comp_next_label(comp);
712
713
714
715
                for (int i = 0; i < n - 1; i++) {
                    c_if_cond(comp, pns->nodes[i], false, label2);
                }
                c_if_cond(comp, pns->nodes[n - 1], true, label);
716
                EMIT_ARG(label_assign, label2);
717
718
            }
            return;
719
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
720
721
            c_if_cond(comp, pns->nodes[0], !jump_if, label);
            return;
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_atom_paren) {
            // cond is something in parenthesis
            if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
                // empty tuple, acts as false for the condition
                if (jump_if == false) {
                    EMIT_ARG(jump, label);
                }
            } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                // non-empty tuple, acts as true for the condition
                if (jump_if == true) {
                    EMIT_ARG(jump, label);
                }
            } else {
                // parenthesis around 1 item, is just that item
                c_if_cond(comp, pns->nodes[0], jump_if, label);
            }
            return;
739
740
741
742
743
744
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
    if (jump_if == false) {
745
        EMIT_ARG(pop_jump_if_false, label);
746
    } else {
747
        EMIT_ARG(pop_jump_if_true, label);
748
749
    }
#endif
Damien's avatar
Damien committed
750
751
752
}

typedef enum { ASSIGN_STORE, ASSIGN_AUG_LOAD, ASSIGN_AUG_STORE } assign_kind_t;
753
STATIC void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t kind);
Damien's avatar
Damien committed
754

755
STATIC void c_assign_power(compiler_t *comp, mp_parse_node_struct_t *pns, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
756
757
758
759
    if (assign_kind != ASSIGN_AUG_STORE) {
        compile_node(comp, pns->nodes[0]);
    }

760
761
762
763
    if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
        mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_power_trailers) {
            int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns1);
Damien's avatar
Damien committed
764
765
766
767
768
            if (assign_kind != ASSIGN_AUG_STORE) {
                for (int i = 0; i < n - 1; i++) {
                    compile_node(comp, pns1->nodes[i]);
                }
            }
769
770
            assert(MP_PARSE_NODE_IS_STRUCT(pns1->nodes[n - 1]));
            pns1 = (mp_parse_node_struct_t*)pns1->nodes[n - 1];
Damien's avatar
Damien committed
771
        }
772
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_paren) {
773
            goto cannot_assign;
774
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_bracket) {
Damien's avatar
Damien committed
775
776
777
778
779
780
781
            if (assign_kind == ASSIGN_AUG_STORE) {
                EMIT(rot_three);
                EMIT(store_subscr);
            } else {
                compile_node(comp, pns1->nodes[0]);
                if (assign_kind == ASSIGN_AUG_LOAD) {
                    EMIT(dup_top_two);
782
                    EMIT(load_subscr);
Damien's avatar
Damien committed
783
784
785
786
                } else {
                    EMIT(store_subscr);
                }
            }
787
788
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_period) {
            assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
Damien's avatar
Damien committed
789
790
            if (assign_kind == ASSIGN_AUG_LOAD) {
                EMIT(dup_top);
791
                EMIT_ARG(load_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
792
793
794
795
            } else {
                if (assign_kind == ASSIGN_AUG_STORE) {
                    EMIT(rot_two);
                }
796
                EMIT_ARG(store_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
797
798
            }
        } else {
799
            goto cannot_assign;
Damien's avatar
Damien committed
800
801
        }
    } else {
802
        goto cannot_assign;
Damien's avatar
Damien committed
803
804
    }

805
    if (!MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
806
        goto cannot_assign;
Damien's avatar
Damien committed
807
    }
808
809
810
811
812

    return;

cannot_assign:
    compile_syntax_error(comp, (mp_parse_node_t)pns, "can't assign to expression");
Damien's avatar
Damien committed
813
814
}

815
// we need to allow for a caller passing in 1 initial node (node_head) followed by an array of nodes (nodes_tail)
816
STATIC void c_assign_tuple(compiler_t *comp, mp_parse_node_t node_head, uint num_tail, mp_parse_node_t *nodes_tail) {
817
818
819
    uint num_head = (node_head == MP_PARSE_NODE_NULL) ? 0 : 1;

    // look for star expression
Damien's avatar
Damien committed
820
    int have_star_index = -1;
821
822
823
824
825
826
    if (num_head != 0 && MP_PARSE_NODE_IS_STRUCT_KIND(node_head, PN_star_expr)) {
        EMIT_ARG(unpack_ex, 0, num_tail);
        have_star_index = 0;
    }
    for (int i = 0; i < num_tail; i++) {
        if (MP_PARSE_NODE_IS_STRUCT_KIND(nodes_tail[i], PN_star_expr)) {
Damien's avatar
Damien committed
827
            if (have_star_index < 0) {
828
829
                EMIT_ARG(unpack_ex, num_head + i, num_tail - i - 1);
                have_star_index = num_head + i;
Damien's avatar
Damien committed
830
            } else {
831
                compile_syntax_error(comp, nodes_tail[i], "multiple *x in assignment");
Damien's avatar
Damien committed
832
833
834
835
836
                return;
            }
        }
    }
    if (have_star_index < 0) {
837
        EMIT_ARG(unpack_sequence, num_head + num_tail);
Damien's avatar
Damien committed
838
    }
839
840
841
    if (num_head != 0) {
        if (0 == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)node_head)->nodes[0], ASSIGN_STORE);
Damien's avatar
Damien committed
842
        } else {
843
844
845
846
847
848
849
850
            c_assign(comp, node_head, ASSIGN_STORE);
        }
    }
    for (int i = 0; i < num_tail; i++) {
        if (num_head + i == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)nodes_tail[i])->nodes[0], ASSIGN_STORE);
        } else {
            c_assign(comp, nodes_tail[i], ASSIGN_STORE);
Damien's avatar
Damien committed
851
852
853
854
855
        }
    }
}

// assigns top of stack to pn
856
STATIC void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
857
    tail_recursion:
858
    if (MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
859
        assert(0);
860
861
    } else if (MP_PARSE_NODE_IS_LEAF(pn)) {
        if (MP_PARSE_NODE_IS_ID(pn)) {
862
            qstr arg = MP_PARSE_NODE_LEAF_ARG(pn);
Damien's avatar
Damien committed
863
864
865
            switch (assign_kind) {
                case ASSIGN_STORE:
                case ASSIGN_AUG_STORE:
866
                    EMIT_ARG(store_id, arg);
Damien's avatar
Damien committed
867
868
                    break;
                case ASSIGN_AUG_LOAD:
869
                    EMIT_ARG(load_id, arg);
Damien's avatar
Damien committed
870
871
872
                    break;
            }
        } else {
873
            compile_syntax_error(comp, pn, "can't assign to literal");
Damien's avatar
Damien committed
874
875
876
            return;
        }
    } else {
877
878
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
Damien's avatar
Damien committed
879
880
881
882
883
884
885
886
887
888
889
            case PN_power:
                // lhs is an index or attribute
                c_assign_power(comp, pns, assign_kind);
                break;

            case PN_testlist_star_expr:
            case PN_exprlist:
                // lhs is a tuple
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
890
                c_assign_tuple(comp, MP_PARSE_NODE_NULL, MP_PARSE_NODE_STRUCT_NUM_NODES(pns), pns->nodes);
Damien's avatar
Damien committed
891
892
893
894
                break;

            case PN_atom_paren:
                // lhs is something in parenthesis
895
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
896
                    // empty tuple
897
                    goto cannot_assign;
898
899
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
900
901
902
903
904
905
906
907
908
909
910
911
912
                    goto testlist_comp;
                } else {
                    // parenthesis around 1 item, is just that item
                    pn = pns->nodes[0];
                    goto tail_recursion;
                }
                break;

            case PN_atom_bracket:
                // lhs is something in brackets
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
913
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
914
                    // empty list, assignment allowed
915
                    c_assign_tuple(comp, MP_PARSE_NODE_NULL, 0, NULL);
916
917
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
918
919
920
                    goto testlist_comp;
                } else {
                    // brackets around 1 item
921
                    c_assign_tuple(comp, pns->nodes[0], 0, NULL);
Damien's avatar
Damien committed
922
923
924
925
                }
                break;

            default:
926
                goto cannot_assign;
Damien's avatar
Damien committed
927
928
929
930
931
        }
        return;

        testlist_comp:
        // lhs is a sequence
932
933
934
        if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
            mp_parse_node_struct_t *pns2 = (mp_parse_node_struct_t*)pns->nodes[1];
            if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3b) {
Damien's avatar
Damien committed
935
                // sequence of one item, with trailing comma
936
                assert(MP_PARSE_NODE_IS_NULL(pns2->nodes[0]));
937
                c_assign_tuple(comp, pns->nodes[0], 0, NULL);
938
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3c) {
Damien's avatar
Damien committed
939
                // sequence of many items
940
941
                uint n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns2);
                c_assign_tuple(comp, pns->nodes[0], n, pns2->nodes);
942
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_comp_for) {
943
                // TODO can we ever get here? can it be compiled?
944
                goto cannot_assign;
Damien's avatar
Damien committed
945
946
947
948
949
950
951
            } else {
                // sequence with 2 items
                goto sequence_with_2_items;
            }
        } else {
            // sequence with 2 items
            sequence_with_2_items:
952
            c_assign_tuple(comp, MP_PARSE_NODE_NULL, 2, pns->nodes);
Damien's avatar
Damien committed
953
954
955
956
957
        }
        return;
    }
    return;

958
959
960
961
    cannot_assign:
    compile_syntax_error(comp, pn, "can't assign to expression");
    return;

Damien's avatar
Damien committed
962
    bad_aug:
963
    compile_syntax_error(comp, pn, "illegal expression for augmented assignment");
Damien's avatar
Damien committed
964
965
966
}

// stuff for lambda and comprehensions and generators
967
968
969
970
// if we are not in CPython compatibility mode then:
//  if n_pos_defaults > 0 then there is a tuple on the stack with the positional defaults
//  if n_kw_defaults > 0 then there is a dictionary on the stack with the keyword defaults
//  if both exist, the tuple is above the dictionary (ie the first pop gets the tuple)
971
STATIC void close_over_variables_etc(compiler_t *comp, scope_t *this_scope, int n_pos_defaults, int n_kw_defaults) {
972
973
974
    assert(n_pos_defaults >= 0);
    assert(n_kw_defaults >= 0);

Damien's avatar
Damien committed
975
    // make closed over variables, if any
976
    // ensure they are closed over in the order defined in the outer scope (mainly to agree with CPython)
Damien's avatar
Damien committed
977
978
    int nfree = 0;
    if (comp->scope_cur->kind != SCOPE_MODULE) {
979
980
981
982
983
        for (int i = 0; i < comp->scope_cur->id_info_len; i++) {
            id_info_t *id = &comp->scope_cur->id_info[i];
            if (id->kind == ID_INFO_KIND_CELL || id->kind == ID_INFO_KIND_FREE) {
                for (int j = 0; j < this_scope->id_info_len; j++) {
                    id_info_t *id2 = &this_scope->id_info[j];
984
                    if (id2->kind == ID_INFO_KIND_FREE && id->qst == id2->qst) {
Damien George's avatar
Damien George committed
985
#if MICROPY_EMIT_CPYTHON
986
                        EMIT_ARG(load_closure, id->qst, id->local_num);
Damien George's avatar
Damien George committed
987
988
#else
                        // in Micro Python we load closures using LOAD_FAST
989
                        EMIT_ARG(load_fast, id->qst, id->flags, id->local_num);
Damien George's avatar
Damien George committed
990
#endif
991
992
993
                        nfree += 1;
                    }
                }
Damien's avatar
Damien committed
994
995
996
997
998
999
            }
        }
    }

    // make the function/closure
    if (nfree == 0) {
1000
        EMIT_ARG(make_function, this_scope, n_pos_defaults, n_kw_defaults);