compile.c 152 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
/*
 * This file is part of the Micro Python project, http://micropython.org/
 *
 * The MIT License (MIT)
 *
 * Copyright (c) 2013, 2014 Damien P. George
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

xbe's avatar
xbe committed
27
#include <stdbool.h>
Damien's avatar
Damien committed
28
29
30
31
#include <stdint.h>
#include <stdio.h>
#include <string.h>
#include <assert.h>
32
#include <math.h>
Damien's avatar
Damien committed
33

34
35
36
37
38
39
#include "py/scope.h"
#include "py/emit.h"
#include "py/compile.h"
#include "py/smallint.h"
#include "py/runtime.h"
#include "py/builtin.h"
Damien's avatar
Damien committed
40
41
42
43

// TODO need to mangle __attr names

typedef enum {
44
#define DEF_RULE(rule, comp, kind, ...) PN_##rule,
45
#include "py/grammar.h"
Damien's avatar
Damien committed
46
47
#undef DEF_RULE
    PN_maximum_number_of,
48
    PN_string, // special node for non-interned string
49
    PN_bytes, // special node for non-interned bytes
Damien's avatar
Damien committed
50
51
} pn_kind_t;

52
53
54
55
#define EMIT(fun) (comp->emit_method_table->fun(comp->emit))
#define EMIT_ARG(fun, ...) (comp->emit_method_table->fun(comp->emit, __VA_ARGS__))
#define EMIT_INLINE_ASM(fun) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm))
#define EMIT_INLINE_ASM_ARG(fun, ...) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm, __VA_ARGS__))
Damien's avatar
Damien committed
56

57
// elements in this struct are ordered to make it compact
Damien's avatar
Damien committed
58
typedef struct _compiler_t {
59
    qstr source_file;
60

61
62
63
    uint8_t is_repl;
    uint8_t pass; // holds enum type pass_kind_t
    uint8_t func_arg_is_super; // used to compile special case of super() function call
64
65
66
67
68
    uint8_t have_star;

    // try to keep compiler clean from nlr
    // this is set to an exception object if we have a compile error
    mp_obj_t compile_error;
Damien's avatar
Damien committed
69

70
    uint next_label;
71

72
73
74
    uint16_t num_dict_params;
    uint16_t num_default_params;

75
76
    uint16_t break_label; // highest bit set indicates we are breaking out of a for loop
    uint16_t continue_label;
77
    uint16_t cur_except_level; // increased for SETUP_EXCEPT, SETUP_FINALLY; decreased for POP_BLOCK, POP_EXCEPT
78
    uint16_t break_continue_except_level;
Damien's avatar
Damien committed
79
80
81
82

    scope_t *scope_head;
    scope_t *scope_cur;

83
84
    emit_t *emit;                                   // current emitter
    const emit_method_table_t *emit_method_table;   // current emit method table
85
86
87

    emit_inline_asm_t *emit_inline_asm;                                   // current emitter for inline asm
    const emit_inline_asm_method_table_t *emit_inline_asm_method_table;   // current emit method table for inline asm
Damien's avatar
Damien committed
88
89
} compiler_t;

90
STATIC void compile_syntax_error(compiler_t *comp, mp_parse_node_t pn, const char *msg) {
91
92
    mp_obj_t exc = mp_obj_new_exception_msg(&mp_type_SyntaxError, msg);
    // we don't have a 'block' name, so just pass the NULL qstr to indicate this
93
    if (MP_PARSE_NODE_IS_STRUCT(pn)) {
94
        mp_obj_exception_add_traceback(exc, comp->source_file, (mp_uint_t)((mp_parse_node_struct_t*)pn)->source_line, MP_QSTR_NULL);
95
    } else {
96
97
        // we don't have a line number, so just pass 0
        mp_obj_exception_add_traceback(exc, comp->source_file, 0, MP_QSTR_NULL);
98
    }
99
    comp->compile_error = exc;
100
101
}

102
#if MICROPY_COMP_MODULE_CONST
103
STATIC const mp_map_elem_t mp_constants_table[] = {
104
105
106
    #if MICROPY_PY_UCTYPES
    { MP_OBJ_NEW_QSTR(MP_QSTR_uctypes), (mp_obj_t)&mp_module_uctypes },
    #endif
107
    // Extra constants as defined by a port
108
    MICROPY_PORT_CONSTANTS
109
};
110
111
STATIC MP_DEFINE_CONST_MAP(mp_constants_map, mp_constants_table);
#endif
112

113
114
115
116
// this function is essentially a simple preprocessor
STATIC mp_parse_node_t fold_constants(compiler_t *comp, mp_parse_node_t pn, mp_map_t *consts) {
    if (0) {
        // dummy
117
#if MICROPY_COMP_CONST
118
119
120
121
122
123
124
125
126
    } else if (MP_PARSE_NODE_IS_ID(pn)) {
        // lookup identifier in table of dynamic constants
        qstr qst = MP_PARSE_NODE_LEAF_ARG(pn);
        mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(qst), MP_MAP_LOOKUP);
        if (elem != NULL) {
            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, MP_OBJ_SMALL_INT_VALUE(elem->value));
        }
#endif
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
127
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
Damien's avatar
Damien committed
128

129
130
        // fold some parse nodes before folding their arguments
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
131
#if MICROPY_COMP_CONST
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
            case PN_expr_stmt:
                if (!MP_PARSE_NODE_IS_NULL(pns->nodes[1])) {
                    mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_expr_stmt_assign) {
                        if (MP_PARSE_NODE_IS_ID(pns->nodes[0])
                            && MP_PARSE_NODE_IS_STRUCT_KIND(pns1->nodes[0], PN_power)
                            && MP_PARSE_NODE_IS_ID(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0])
                            && MP_PARSE_NODE_LEAF_ARG(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0]) == MP_QSTR_const
                            && MP_PARSE_NODE_IS_STRUCT_KIND(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1], PN_trailer_paren)
                            && MP_PARSE_NODE_IS_NULL(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[2])
                            ) {
                            // code to assign dynamic constants: id = const(value)

                            // get the id
                            qstr id_qstr = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);

                            // get the value
                            mp_parse_node_t pn_value = ((mp_parse_node_struct_t*)((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1])->nodes[0];
                            pn_value = fold_constants(comp, pn_value, consts);
                            if (!MP_PARSE_NODE_IS_SMALL_INT(pn_value)) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant must be an integer");
                                break;
                            }
155
                            mp_int_t value = MP_PARSE_NODE_LEAF_SMALL_INT(pn_value);
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174

                            // store the value in the table of dynamic constants
                            mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(id_qstr), MP_MAP_LOOKUP_ADD_IF_NOT_FOUND);
                            if (elem->value != MP_OBJ_NULL) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant redefined");
                                break;
                            }
                            elem->value = MP_OBJ_NEW_SMALL_INT(value);

                            // replace const(value) with value
                            pns1->nodes[0] = pn_value;

                            // finished folding this assignment
                            return pn;
                        }
                    }
                }
                break;
#endif
175
            case PN_string:
176
            case PN_bytes:
177
                return pn;
178
179
180
181
        }

        // fold arguments
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
182
        for (int i = 0; i < n; i++) {
183
            pns->nodes[i] = fold_constants(comp, pns->nodes[i], consts);
Damien's avatar
Damien committed
184
185
        }

186
        // try to fold this parse node
187
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
188
189
190
191
192
193
194
195
196
197
            case PN_atom_paren:
                if (n == 1 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0])) {
                    // (int)
                    pn = pns->nodes[0];
                }
                break;

            case PN_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int | int
198
199
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
200
201
202
203
204
205
206
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 | arg1);
                }
                break;

            case PN_and_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int & int
207
208
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
209
210
211
212
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 & arg1);
                }
                break;

Damien's avatar
Damien committed
213
            case PN_shift_expr:
214
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
215
216
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
217
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_LESS)) {
218
219
220
221
                        // int << int
                        if (!(arg1 >= BITS_PER_WORD || arg0 > (MP_SMALL_INT_MAX >> arg1) || arg0 < (MP_SMALL_INT_MIN >> arg1))) {
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 << arg1);
                        }
222
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_MORE)) {
223
                        // int >> int
224
225
226
227
228
                        if (arg1 >= BITS_PER_WORD) {
                            // Shifting to big amounts is underfined behavior
                            // in C and is CPU-dependent; propagate sign bit.
                            arg1 = BITS_PER_WORD - 1;
                        }
229
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 >> arg1);
Damien's avatar
Damien committed
230
231
232
233
234
235
236
237
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_arith_expr:
238
                // overflow checking here relies on SMALL_INT being strictly smaller than mp_int_t
239
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
240
241
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
242
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PLUS)) {
243
                        // int + int
244
                        arg0 += arg1;
245
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_MINUS)) {
246
                        // int - int
247
                        arg0 -= arg1;
Damien's avatar
Damien committed
248
249
250
                    } else {
                        // shouldn't happen
                        assert(0);
251
                    }
252
                    if (MP_SMALL_INT_FITS(arg0)) {
253
                        //printf("%ld + %ld\n", arg0, arg1);
254
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
Damien's avatar
Damien committed
255
256
257
258
259
                    }
                }
                break;

            case PN_term:
260
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
261
262
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
263
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_STAR)) {
264
                        // int * int
265
266
                        if (!mp_small_int_mul_overflow(arg0, arg1)) {
                            arg0 *= arg1;
267
                            if (MP_SMALL_INT_FITS(arg0)) {
268
269
270
                                pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
                            }
                        }
271
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_SLASH)) {
272
273
                        // int / int
                        // pass
274
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PERCENT)) {
275
                        // int%int
276
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_modulo(arg0, arg1));
277
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_SLASH)) {
278
                        if (arg1 != 0) {
279
                            // int // int
280
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_floor_divide(arg0, arg1));
281
                        }
Damien's avatar
Damien committed
282
283
284
285
286
287
288
289
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_factor_2:
290
                if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
291
                    mp_int_t arg = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
292
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_PLUS)) {
293
                        // +int
294
295
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_MINUS)) {
296
                        // -int
297
298
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, -arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_TILDE)) {
299
                        // ~int
300
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ~arg);
Damien's avatar
Damien committed
301
302
303
304
305
306
307
308
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_power:
309
310
311
                if (0) {
#if MICROPY_EMIT_CPYTHON
                } else if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_NULL(pns->nodes[1]) && !MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
312
                    // int ** x
313
                    // can overflow; enabled only to compare with CPython
314
315
                    mp_parse_node_struct_t* pns2 = (mp_parse_node_struct_t*)pns->nodes[2];
                    if (MP_PARSE_NODE_IS_SMALL_INT(pns2->nodes[0])) {
316
                        int power = MP_PARSE_NODE_LEAF_SMALL_INT(pns2->nodes[0]);
Damien's avatar
Damien committed
317
318
                        if (power >= 0) {
                            int ans = 1;
319
                            int base = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
Damien's avatar
Damien committed
320
321
322
                            for (; power > 0; power--) {
                                ans *= base;
                            }
323
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ans);
Damien's avatar
Damien committed
324
325
                        }
                    }
326
#endif
327
#if MICROPY_COMP_MODULE_CONST
328
329
330
331
332
333
334
335
336
337
338
339
                } else if (MP_PARSE_NODE_IS_ID(pns->nodes[0]) && MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[1], PN_trailer_period) && MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
                    // id.id
                    // look it up in constant table, see if it can be replaced with an integer
                    mp_parse_node_struct_t* pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
                    qstr q_base = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);
                    qstr q_attr = MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]);
                    mp_map_elem_t *elem = mp_map_lookup((mp_map_t*)&mp_constants_map, MP_OBJ_NEW_QSTR(q_base), MP_MAP_LOOKUP);
                    if (elem != NULL) {
                        mp_obj_t dest[2];
                        mp_load_method_maybe(elem->value, q_attr, dest);
                        if (MP_OBJ_IS_SMALL_INT(dest[0]) && dest[1] == NULL) {
340
                            mp_int_t val = MP_OBJ_SMALL_INT_VALUE(dest[0]);
341
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, val);
342
343
                        }
                    }
344
#endif
Damien's avatar
Damien committed
345
346
347
348
349
350
351
352
                }
                break;
        }
    }

    return pn;
}

353
STATIC void compile_trailer_paren_helper(compiler_t *comp, mp_parse_node_t pn_arglist, bool is_method_call, int n_positional_extra);
354
STATIC void compile_comprehension(compiler_t *comp, mp_parse_node_struct_t *pns, scope_kind_t kind);
355
STATIC void compile_node(compiler_t *comp, mp_parse_node_t pn);
Damien's avatar
Damien committed
356

357
STATIC uint comp_next_label(compiler_t *comp) {
358
359
360
    return comp->next_label++;
}

361
362
363
364
365
366
367
368
369
370
371
372
STATIC void compile_increase_except_level(compiler_t *comp) {
    comp->cur_except_level += 1;
    if (comp->cur_except_level > comp->scope_cur->exc_stack_size) {
        comp->scope_cur->exc_stack_size = comp->cur_except_level;
    }
}

STATIC void compile_decrease_except_level(compiler_t *comp) {
    assert(comp->cur_except_level > 0);
    comp->cur_except_level -= 1;
}

373
STATIC scope_t *scope_new_and_link(compiler_t *comp, scope_kind_t kind, mp_parse_node_t pn, uint emit_options) {
374
    scope_t *scope = scope_new(kind, pn, comp->source_file, emit_options);
Damien's avatar
Damien committed
375
376
377
378
379
380
381
382
383
384
385
386
387
388
    scope->parent = comp->scope_cur;
    scope->next = NULL;
    if (comp->scope_head == NULL) {
        comp->scope_head = scope;
    } else {
        scope_t *s = comp->scope_head;
        while (s->next != NULL) {
            s = s->next;
        }
        s->next = scope;
    }
    return scope;
}

389
STATIC void apply_to_single_or_list(compiler_t *comp, mp_parse_node_t pn, int pn_list_kind, void (*f)(compiler_t*, mp_parse_node_t)) {
390
391
392
    if (MP_PARSE_NODE_IS_STRUCT(pn) && MP_PARSE_NODE_STRUCT_KIND((mp_parse_node_struct_t*)pn) == pn_list_kind) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
393
394
395
        for (int i = 0; i < num_nodes; i++) {
            f(comp, pns->nodes[i]);
        }
396
    } else if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
397
398
399
400
        f(comp, pn);
    }
}

401
STATIC int list_get(mp_parse_node_t *pn, int pn_kind, mp_parse_node_t **nodes) {
402
    if (MP_PARSE_NODE_IS_NULL(*pn)) {
Damien's avatar
Damien committed
403
404
        *nodes = NULL;
        return 0;
405
    } else if (MP_PARSE_NODE_IS_LEAF(*pn)) {
Damien's avatar
Damien committed
406
407
408
        *nodes = pn;
        return 1;
    } else {
409
410
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)(*pn);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) != pn_kind) {
Damien's avatar
Damien committed
411
412
413
414
            *nodes = pn;
            return 1;
        } else {
            *nodes = pns->nodes;
415
            return MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
416
417
418
419
        }
    }
}

420
STATIC void compile_generic_all_nodes(compiler_t *comp, mp_parse_node_struct_t *pns) {
421
    int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
422
423
424
425
426
    for (int i = 0; i < num_nodes; i++) {
        compile_node(comp, pns->nodes[i]);
    }
}

427
#if MICROPY_EMIT_CPYTHON
428
STATIC bool cpython_c_tuple_is_const(mp_parse_node_t pn) {
429
430
431
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string)) {
        return true;
    }
432
433
434
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_bytes)) {
        return true;
    }
435
    if (!MP_PARSE_NODE_IS_LEAF(pn)) {
Damien's avatar
Damien committed
436
437
        return false;
    }
438
    if (MP_PARSE_NODE_IS_ID(pn)) {
Damien's avatar
Damien committed
439
440
441
442
443
        return false;
    }
    return true;
}

444
STATIC void cpython_c_print_quoted_str(vstr_t *vstr, const char *str, uint len, bool bytes) {
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
    bool has_single_quote = false;
    bool has_double_quote = false;
    for (int i = 0; i < len; i++) {
        if (str[i] == '\'') {
            has_single_quote = true;
        } else if (str[i] == '"') {
            has_double_quote = true;
        }
    }
    if (bytes) {
        vstr_printf(vstr, "b");
    }
    bool quote_single = false;
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        quote_single = true;
        vstr_printf(vstr, "'");
    }
    for (int i = 0; i < len; i++) {
        if (str[i] == '\n') {
            vstr_printf(vstr, "\\n");
        } else if (str[i] == '\\') {
            vstr_printf(vstr, "\\\\");
        } else if (str[i] == '\'' && quote_single) {
            vstr_printf(vstr, "\\'");
        } else {
            vstr_printf(vstr, "%c", str[i]);
        }
    }
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        vstr_printf(vstr, "'");
    }
}

482
STATIC void cpython_c_tuple_emit_const(compiler_t *comp, mp_parse_node_t pn, vstr_t *vstr) {
483
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string) || MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_bytes)) {
484
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
485
        cpython_c_print_quoted_str(vstr, (const char*)pns->nodes[0], (mp_uint_t)pns->nodes[1], MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_bytes));
486
487
488
        return;
    }

489
    assert(MP_PARSE_NODE_IS_LEAF(pn));
490
491
492
493
494
    if (MP_PARSE_NODE_IS_SMALL_INT(pn)) {
        vstr_printf(vstr, INT_FMT, MP_PARSE_NODE_LEAF_SMALL_INT(pn));
        return;
    }

495
    mp_uint_t arg = MP_PARSE_NODE_LEAF_ARG(pn);
496
497
498
499
    switch (MP_PARSE_NODE_LEAF_KIND(pn)) {
        case MP_PARSE_NODE_ID: assert(0);
        case MP_PARSE_NODE_INTEGER: vstr_printf(vstr, "%s", qstr_str(arg)); break;
        case MP_PARSE_NODE_DECIMAL: vstr_printf(vstr, "%s", qstr_str(arg)); break;
500
501
        case MP_PARSE_NODE_STRING:
        case MP_PARSE_NODE_BYTES: {
502
            mp_uint_t len;
503
504
505
506
            const byte *str = qstr_data(arg, &len);
            cpython_c_print_quoted_str(vstr, (const char*)str, len, MP_PARSE_NODE_LEAF_KIND(pn) == MP_PARSE_NODE_BYTES);
            break;
        }
507
        case MP_PARSE_NODE_TOKEN:
Damien's avatar
Damien committed
508
            switch (arg) {
509
510
511
                case MP_TOKEN_KW_FALSE: vstr_printf(vstr, "False"); break;
                case MP_TOKEN_KW_NONE: vstr_printf(vstr, "None"); break;
                case MP_TOKEN_KW_TRUE: vstr_printf(vstr, "True"); break;
512
                default: assert(0); // shouldn't happen
Damien's avatar
Damien committed
513
514
515
516
517
518
            }
            break;
        default: assert(0);
    }
}

519
STATIC void cpython_c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
Damien's avatar
Damien committed
520
521
    int n = 0;
    if (pns_list != NULL) {
522
        n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
Damien's avatar
Damien committed
523
524
525
    }
    int total = n;
    bool is_const = true;
526
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
527
        total += 1;
528
        if (!cpython_c_tuple_is_const(pn)) {
Damien's avatar
Damien committed
529
530
531
532
            is_const = false;
        }
    }
    for (int i = 0; i < n; i++) {
533
        if (!cpython_c_tuple_is_const(pns_list->nodes[i])) {
Damien's avatar
Damien committed
534
535
536
537
538
539
            is_const = false;
            break;
        }
    }
    if (total > 0 && is_const) {
        bool need_comma = false;
540
541
        vstr_t *vstr = vstr_new();
        vstr_printf(vstr, "(");
542
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
543
            cpython_c_tuple_emit_const(comp, pn, vstr);
Damien's avatar
Damien committed
544
545
546
547
            need_comma = true;
        }
        for (int i = 0; i < n; i++) {
            if (need_comma) {
548
                vstr_printf(vstr, ", ");
Damien's avatar
Damien committed
549
            }
550
            cpython_c_tuple_emit_const(comp, pns_list->nodes[i], vstr);
Damien's avatar
Damien committed
551
552
553
            need_comma = true;
        }
        if (total == 1) {
554
            vstr_printf(vstr, ",)");
Damien's avatar
Damien committed
555
        } else {
556
            vstr_printf(vstr, ")");
Damien's avatar
Damien committed
557
        }
558
        EMIT_ARG(load_const_verbatim_str, vstr_str(vstr));
559
        vstr_free(vstr);
Damien's avatar
Damien committed
560
    } else {
561
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
562
563
564
565
566
            compile_node(comp, pn);
        }
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
567
        EMIT_ARG(build_tuple, total);
Damien's avatar
Damien committed
568
569
    }
}
570
571
572
#endif

// funnelling all tuple creations through this function is purely so we can optionally agree with CPython
573
STATIC void c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
574
#if MICROPY_EMIT_CPYTHON
575
576
577
    cpython_c_tuple(comp, pn, pns_list);
#else
    int total = 0;
578
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
579
580
581
582
        compile_node(comp, pn);
        total += 1;
    }
    if (pns_list != NULL) {
583
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
584
585
586
587
588
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
        total += n;
    }
589
    EMIT_ARG(build_tuple, total);
590
591
#endif
}
Damien's avatar
Damien committed
592

593
STATIC void compile_generic_tuple(compiler_t *comp, mp_parse_node_struct_t *pns) {
Damien's avatar
Damien committed
594
    // a simple tuple expression
595
    c_tuple(comp, MP_PARSE_NODE_NULL, pns);
Damien's avatar
Damien committed
596
597
}

598
STATIC bool node_is_const_false(mp_parse_node_t pn) {
599
600
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_FALSE)
        || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) == 0);
Damien's avatar
Damien committed
601
602
}

603
STATIC bool node_is_const_true(mp_parse_node_t pn) {
604
605
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_TRUE)
        || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) != 0);
Damien's avatar
Damien committed
606
607
}

608
#if MICROPY_EMIT_CPYTHON
609
// the is_nested variable is purely to match with CPython, which doesn't fully optimise not's
610
STATIC void cpython_c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label, bool is_nested) {
Damien's avatar
Damien committed
611
612
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
613
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
614
615
616
617
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
618
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
619
620
        }
        return;
621
622
623
624
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
Damien's avatar
Damien committed
625
            if (jump_if == false) {
626
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
627
                for (int i = 0; i < n - 1; i++) {
628
                    cpython_c_if_cond(comp, pns->nodes[i], true, label2, true);
Damien's avatar
Damien committed
629
                }
630
                cpython_c_if_cond(comp, pns->nodes[n - 1], false, label, true);
631
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
632
633
            } else {
                for (int i = 0; i < n; i++) {
634
                    cpython_c_if_cond(comp, pns->nodes[i], true, label, true);
Damien's avatar
Damien committed
635
636
637
                }
            }
            return;
638
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
Damien's avatar
Damien committed
639
640
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
641
                    cpython_c_if_cond(comp, pns->nodes[i], false, label, true);
Damien's avatar
Damien committed
642
643
                }
            } else {
644
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
645
                for (int i = 0; i < n - 1; i++) {
646
                    cpython_c_if_cond(comp, pns->nodes[i], false, label2, true);
Damien's avatar
Damien committed
647
                }
648
                cpython_c_if_cond(comp, pns->nodes[n - 1], true, label, true);
649
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
650
651
            }
            return;
652
        } else if (!is_nested && MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
653
            cpython_c_if_cond(comp, pns->nodes[0], !jump_if, label, true);
Damien's avatar
Damien committed
654
655
656
657
658
659
660
            return;
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
    if (jump_if == false) {
661
        EMIT_ARG(pop_jump_if_false, label);
Damien's avatar
Damien committed
662
    } else {
663
        EMIT_ARG(pop_jump_if_true, label);
Damien's avatar
Damien committed
664
665
    }
}
666
#endif
Damien's avatar
Damien committed
667

668
STATIC void c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label) {
669
#if MICROPY_EMIT_CPYTHON
670
671
672
673
    cpython_c_if_cond(comp, pn, jump_if, label, false);
#else
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
674
            EMIT_ARG(jump, label);
675
676
677
678
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
679
            EMIT_ARG(jump, label);
680
681
        }
        return;
682
683
684
685
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
686
            if (jump_if == false) {
687
                uint label2 = comp_next_label(comp);
688
689
690
691
                for (int i = 0; i < n - 1; i++) {
                    c_if_cond(comp, pns->nodes[i], true, label2);
                }
                c_if_cond(comp, pns->nodes[n - 1], false, label);
692
                EMIT_ARG(label_assign, label2);
693
694
695
696
697
698
            } else {
                for (int i = 0; i < n; i++) {
                    c_if_cond(comp, pns->nodes[i], true, label);
                }
            }
            return;
699
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
700
701
702
703
704
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
                    c_if_cond(comp, pns->nodes[i], false, label);
                }
            } else {
705
                uint label2 = comp_next_label(comp);
706
707
708
709
                for (int i = 0; i < n - 1; i++) {
                    c_if_cond(comp, pns->nodes[i], false, label2);
                }
                c_if_cond(comp, pns->nodes[n - 1], true, label);
710
                EMIT_ARG(label_assign, label2);
711
712
            }
            return;
713
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
714
715
            c_if_cond(comp, pns->nodes[0], !jump_if, label);
            return;
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_atom_paren) {
            // cond is something in parenthesis
            if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
                // empty tuple, acts as false for the condition
                if (jump_if == false) {
                    EMIT_ARG(jump, label);
                }
            } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                // non-empty tuple, acts as true for the condition
                if (jump_if == true) {
                    EMIT_ARG(jump, label);
                }
            } else {
                // parenthesis around 1 item, is just that item
                c_if_cond(comp, pns->nodes[0], jump_if, label);
            }
            return;
733
734
735
736
737
738
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
    if (jump_if == false) {
739
        EMIT_ARG(pop_jump_if_false, label);
740
    } else {
741
        EMIT_ARG(pop_jump_if_true, label);
742
743
    }
#endif
Damien's avatar
Damien committed
744
745
746
}

typedef enum { ASSIGN_STORE, ASSIGN_AUG_LOAD, ASSIGN_AUG_STORE } assign_kind_t;
747
STATIC void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t kind);
Damien's avatar
Damien committed
748

749
STATIC void c_assign_power(compiler_t *comp, mp_parse_node_struct_t *pns, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
750
751
752
753
    if (assign_kind != ASSIGN_AUG_STORE) {
        compile_node(comp, pns->nodes[0]);
    }

754
755
756
757
    if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
        mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_power_trailers) {
            int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns1);
Damien's avatar
Damien committed
758
759
760
761
762
            if (assign_kind != ASSIGN_AUG_STORE) {
                for (int i = 0; i < n - 1; i++) {
                    compile_node(comp, pns1->nodes[i]);
                }
            }
763
764
            assert(MP_PARSE_NODE_IS_STRUCT(pns1->nodes[n - 1]));
            pns1 = (mp_parse_node_struct_t*)pns1->nodes[n - 1];
Damien's avatar
Damien committed
765
        }
766
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_paren) {
767
            goto cannot_assign;
768
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_bracket) {
Damien's avatar
Damien committed
769
770
771
772
773
774
775
            if (assign_kind == ASSIGN_AUG_STORE) {
                EMIT(rot_three);
                EMIT(store_subscr);
            } else {
                compile_node(comp, pns1->nodes[0]);
                if (assign_kind == ASSIGN_AUG_LOAD) {
                    EMIT(dup_top_two);
776
                    EMIT(load_subscr);
Damien's avatar
Damien committed
777
778
779
780
                } else {
                    EMIT(store_subscr);
                }
            }
781
782
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_period) {
            assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
Damien's avatar
Damien committed
783
784
            if (assign_kind == ASSIGN_AUG_LOAD) {
                EMIT(dup_top);
785
                EMIT_ARG(load_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
786
787
788
789
            } else {
                if (assign_kind == ASSIGN_AUG_STORE) {
                    EMIT(rot_two);
                }
790
                EMIT_ARG(store_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
791
792
            }
        } else {
793
            goto cannot_assign;
Damien's avatar
Damien committed
794
795
        }
    } else {
796
        goto cannot_assign;
Damien's avatar
Damien committed
797
798
    }

799
    if (!MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
800
        goto cannot_assign;
Damien's avatar
Damien committed
801
    }
802
803
804
805
806

    return;

cannot_assign:
    compile_syntax_error(comp, (mp_parse_node_t)pns, "can't assign to expression");
Damien's avatar
Damien committed
807
808
}

809
// we need to allow for a caller passing in 1 initial node (node_head) followed by an array of nodes (nodes_tail)
810
STATIC void c_assign_tuple(compiler_t *comp, mp_parse_node_t node_head, uint num_tail, mp_parse_node_t *nodes_tail) {
811
812
813
    uint num_head = (node_head == MP_PARSE_NODE_NULL) ? 0 : 1;

    // look for star expression
Damien's avatar
Damien committed
814
    int have_star_index = -1;
815
816
817
818
819
820
    if (num_head != 0 && MP_PARSE_NODE_IS_STRUCT_KIND(node_head, PN_star_expr)) {
        EMIT_ARG(unpack_ex, 0, num_tail);
        have_star_index = 0;
    }
    for (int i = 0; i < num_tail; i++) {
        if (MP_PARSE_NODE_IS_STRUCT_KIND(nodes_tail[i], PN_star_expr)) {
Damien's avatar
Damien committed
821
            if (have_star_index < 0) {
822
823
                EMIT_ARG(unpack_ex, num_head + i, num_tail - i - 1);
                have_star_index = num_head + i;
Damien's avatar
Damien committed
824
            } else {
825
                compile_syntax_error(comp, nodes_tail[i], "multiple *x in assignment");
Damien's avatar
Damien committed
826
827
828
829
830
                return;
            }
        }
    }
    if (have_star_index < 0) {
831
        EMIT_ARG(unpack_sequence, num_head + num_tail);
Damien's avatar
Damien committed
832
    }
833
834
835
    if (num_head != 0) {
        if (0 == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)node_head)->nodes[0], ASSIGN_STORE);
Damien's avatar
Damien committed
836
        } else {
837
838
839
840
841
842
843
844
            c_assign(comp, node_head, ASSIGN_STORE);
        }
    }
    for (int i = 0; i < num_tail; i++) {
        if (num_head + i == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)nodes_tail[i])->nodes[0], ASSIGN_STORE);
        } else {
            c_assign(comp, nodes_tail[i], ASSIGN_STORE);
Damien's avatar
Damien committed
845
846
847
848
849
        }
    }
}

// assigns top of stack to pn
850
STATIC void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
851
    tail_recursion:
852
    if (MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
853
        assert(0);
854
855
    } else if (MP_PARSE_NODE_IS_LEAF(pn)) {
        if (MP_PARSE_NODE_IS_ID(pn)) {
856
            qstr arg = MP_PARSE_NODE_LEAF_ARG(pn);
Damien's avatar
Damien committed
857
858
859
            switch (assign_kind) {
                case ASSIGN_STORE:
                case ASSIGN_AUG_STORE:
860
                    EMIT_ARG(store_id, arg);
Damien's avatar
Damien committed
861
862
                    break;
                case ASSIGN_AUG_LOAD:
863
                default:
864
                    EMIT_ARG(load_id, arg);
Damien's avatar
Damien committed
865
866
867
                    break;
            }
        } else {
868
            compile_syntax_error(comp, pn, "can't assign to literal");
Damien's avatar
Damien committed
869
870
871
            return;
        }
    } else {
872
873
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
Damien's avatar
Damien committed
874
875
876
877
878
879
880
881
882
883
884
            case PN_power:
                // lhs is an index or attribute
                c_assign_power(comp, pns, assign_kind);
                break;

            case PN_testlist_star_expr:
            case PN_exprlist:
                // lhs is a tuple
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
885
                c_assign_tuple(comp, MP_PARSE_NODE_NULL, MP_PARSE_NODE_STRUCT_NUM_NODES(pns), pns->nodes);
Damien's avatar
Damien committed
886
887
888
889
                break;

            case PN_atom_paren:
                // lhs is something in parenthesis
890
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
891
                    // empty tuple
892
                    goto cannot_assign;
893
894
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
895
896
897
898
899
900
901
902
903
904
905
906
907
                    goto testlist_comp;
                } else {
                    // parenthesis around 1 item, is just that item
                    pn = pns->nodes[0];
                    goto tail_recursion;
                }
                break;

            case PN_atom_bracket:
                // lhs is something in brackets
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
908
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
909
                    // empty list, assignment allowed
910
                    c_assign_tuple(comp, MP_PARSE_NODE_NULL, 0, NULL);
911
912
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
913
914
915
                    goto testlist_comp;
                } else {
                    // brackets around 1 item
916
                    c_assign_tuple(comp, pns->nodes[0], 0, NULL);
Damien's avatar
Damien committed
917
918
919
920
                }
                break;

            default:
921
                goto cannot_assign;
Damien's avatar
Damien committed
922
923
924
925
926
        }
        return;

        testlist_comp:
        // lhs is a sequence
927
928
929
        if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
            mp_parse_node_struct_t *pns2 = (mp_parse_node_struct_t*)pns->nodes[1];
            if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3b) {
Damien's avatar
Damien committed
930
                // sequence of one item, with trailing comma
931
                assert(MP_PARSE_NODE_IS_NULL(pns2->nodes[0]));
932
                c_assign_tuple(comp, pns->nodes[0], 0, NULL);
933
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3c) {
Damien's avatar
Damien committed
934
                // sequence of many items
935
936
                uint n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns2);
                c_assign_tuple(comp, pns->nodes[0], n, pns2->nodes);
937
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_comp_for) {
938
                // TODO can we ever get here? can it be compiled?
939
                goto cannot_assign;
Damien's avatar
Damien committed
940
941
942
943
944
945
946
            } else {
                // sequence with 2 items
                goto sequence_with_2_items;
            }
        } else {
            // sequence with 2 items
            sequence_with_2_items:
947
            c_assign_tuple(comp, MP_PARSE_NODE_NULL, 2, pns->nodes);
Damien's avatar
Damien committed
948
949
950
951
952
        }
        return;
    }
    return;

953
954
955
956
    cannot_assign:
    compile_syntax_error(comp, pn, "can't assign to expression");
    return;

Damien's avatar
Damien committed
957
    bad_aug:
958
    compile_syntax_error(comp, pn, "illegal expression for augmented assignment");
Damien's avatar
Damien committed
959
960
961
}

// stuff for lambda and comprehensions and generators
962
963
964
965
// if we are not in CPython compatibility mode then:
//  if n_pos_defaults > 0 then there is a tuple on the stack with the positional defaults
//  if n_kw_defaults > 0 then there is a dictionary on the stack with the keyword defaults
//  if both exist, the tuple is above the dictionary (ie the first pop gets the tuple)
966
STATIC void close_over_variables_etc(compiler_t *comp, scope_t *this_scope, int n_pos_defaults, int n_kw_defaults) {
967
968
969
    assert(n_pos_defaults >= 0);
    assert(n_kw_defaults >= 0);

Damien's avatar
Damien committed
970
    // make closed over variables, if any
971
    // ensure they are closed over in the order defined in the outer scope (mainly to agree with CPython)
Damien's avatar
Damien committed
972
973
    int nfree = 0;
    if (comp->scope_cur->kind != SCOPE_MODULE) {
974
975
976
977
978
        for (int i = 0; i < comp->scope_cur->id_info_len; i++) {
            id_info_t *id = &comp->scope_cur->id_info[i];
            if (id->kind == ID_INFO_KIND_CELL || id->kind == ID_INFO_KIND_FREE) {
                for (int j = 0; j < this_scope->id_info_len; j++) {
                    id_info_t *id2 = &this_scope->id_info[j];
979
                    if (id2->kind == ID_INFO_KIND_FREE && id->qst == id2->qst) {
Damien George's avatar
Damien George committed
980
#if MICROPY_EMIT_CPYTHON
981
                        EMIT_ARG(load_closure, id->qst, id->local_num);
Damien George's avatar
Damien George committed
982
983
#else
                        // in Micro Python we load closures using LOAD_FAST
984
                        EMIT_ARG(load_fast, id->qst, id->flags, id->local_num);
Damien George's avatar
Damien George committed
985
#endif
986
987
988
                        nfree += 1;
                    }
                }
Damien's avatar
Damien committed
989
990
991
992
993
994
            }
        }
    }

    // make the function/closure
    if (nfree == 0) {