compile.c 146 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
/*
 * This file is part of the Micro Python project, http://micropython.org/
 *
 * The MIT License (MIT)
 *
 * Copyright (c) 2013, 2014 Damien P. George
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

xbe's avatar
xbe committed
27
#include <stdbool.h>
Damien's avatar
Damien committed
28
29
30
31
#include <stdint.h>
#include <stdio.h>
#include <string.h>
#include <assert.h>
32
#include <math.h>
Damien's avatar
Damien committed
33

34
#include "mpconfig.h"
35
#include "misc.h"
36
#include "qstr.h"
Damien's avatar
Damien committed
37
38
#include "lexer.h"
#include "parse.h"
39
#include "runtime0.h"
40
#include "obj.h"
41
42
43
#include "emitglue.h"
#include "scope.h"
#include "emit.h"
44
45
#include "compile.h"
#include "runtime.h"
46
#include "builtin.h"
47
#include "smallint.h"
Damien's avatar
Damien committed
48
49
50
51
52

// TODO need to mangle __attr names

typedef enum {
    PN_none = 0,
53
#define DEF_RULE(rule, comp, kind, ...) PN_##rule,
Damien's avatar
Damien committed
54
55
56
#include "grammar.h"
#undef DEF_RULE
    PN_maximum_number_of,
57
    PN_string, // special node for non-interned string
Damien's avatar
Damien committed
58
59
} pn_kind_t;

60
61
62
63
#define EMIT(fun) (comp->emit_method_table->fun(comp->emit))
#define EMIT_ARG(fun, ...) (comp->emit_method_table->fun(comp->emit, __VA_ARGS__))
#define EMIT_INLINE_ASM(fun) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm))
#define EMIT_INLINE_ASM_ARG(fun, ...) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm, __VA_ARGS__))
Damien's avatar
Damien committed
64
65

typedef struct _compiler_t {
66
    qstr source_file;
67
68
69
70
    uint8_t is_repl;
    uint8_t pass; // holds enum type pass_kind_t
    uint8_t had_error; // try to keep compiler clean from nlr
    uint8_t func_arg_is_super; // used to compile special case of super() function call
Damien's avatar
Damien committed
71

72
    uint next_label;
73

74
75
    uint16_t break_label; // highest bit set indicates we are breaking out of a for loop
    uint16_t continue_label;
76
    int break_continue_except_level;
77
    uint16_t cur_except_level; // increased for SETUP_EXCEPT, SETUP_FINALLY; decreased for POP_BLOCK, POP_EXCEPT
Damien's avatar
Damien committed
78

79
    uint8_t have_star;
80
81
    uint16_t num_dict_params;
    uint16_t num_default_params;
Damien's avatar
Damien committed
82
83
84
85

    scope_t *scope_head;
    scope_t *scope_cur;

86
87
    emit_t *emit;                                   // current emitter
    const emit_method_table_t *emit_method_table;   // current emit method table
88
89
90

    emit_inline_asm_t *emit_inline_asm;                                   // current emitter for inline asm
    const emit_inline_asm_method_table_t *emit_inline_asm_method_table;   // current emit method table for inline asm
Damien's avatar
Damien committed
91
92
} compiler_t;

93
STATIC void compile_syntax_error(compiler_t *comp, mp_parse_node_t pn, const char *msg) {
94
    // TODO store the error message to a variable in compiler_t instead of printing it
95
    if (MP_PARSE_NODE_IS_STRUCT(pn)) {
96
        printf("  File \"%s\", line " UINT_FMT "\n", qstr_str(comp->source_file), (mp_uint_t)((mp_parse_node_struct_t*)pn)->source_line);
97
98
99
    } else {
        printf("  File \"%s\"\n", qstr_str(comp->source_file));
    }
100
101
102
103
    printf("SyntaxError: %s\n", msg);
    comp->had_error = true;
}

104
STATIC const mp_map_elem_t mp_constants_table[] = {
105
106
107
    #if MICROPY_PY_UCTYPES
    { MP_OBJ_NEW_QSTR(MP_QSTR_uctypes), (mp_obj_t)&mp_module_uctypes },
    #endif
108
    // Extra constants as defined by a port
109
    MICROPY_PORT_CONSTANTS
110
111
112
113
114
};

STATIC const mp_map_t mp_constants_map = {
    .all_keys_are_qstrs = 1,
    .table_is_fixed_array = 1,
115
116
    .used = MP_ARRAY_SIZE(mp_constants_table),
    .alloc = MP_ARRAY_SIZE(mp_constants_table),
117
118
119
    .table = (mp_map_elem_t*)mp_constants_table,
};

120
121
122
123
// this function is essentially a simple preprocessor
STATIC mp_parse_node_t fold_constants(compiler_t *comp, mp_parse_node_t pn, mp_map_t *consts) {
    if (0) {
        // dummy
124
#if MICROPY_COMP_CONST
125
126
127
128
129
130
131
132
133
    } else if (MP_PARSE_NODE_IS_ID(pn)) {
        // lookup identifier in table of dynamic constants
        qstr qst = MP_PARSE_NODE_LEAF_ARG(pn);
        mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(qst), MP_MAP_LOOKUP);
        if (elem != NULL) {
            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, MP_OBJ_SMALL_INT_VALUE(elem->value));
        }
#endif
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
134
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
Damien's avatar
Damien committed
135

136
137
        // fold some parse nodes before folding their arguments
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
138
#if MICROPY_COMP_CONST
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
            case PN_expr_stmt:
                if (!MP_PARSE_NODE_IS_NULL(pns->nodes[1])) {
                    mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_expr_stmt_assign) {
                        if (MP_PARSE_NODE_IS_ID(pns->nodes[0])
                            && MP_PARSE_NODE_IS_STRUCT_KIND(pns1->nodes[0], PN_power)
                            && MP_PARSE_NODE_IS_ID(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0])
                            && MP_PARSE_NODE_LEAF_ARG(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0]) == MP_QSTR_const
                            && MP_PARSE_NODE_IS_STRUCT_KIND(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1], PN_trailer_paren)
                            && MP_PARSE_NODE_IS_NULL(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[2])
                            ) {
                            // code to assign dynamic constants: id = const(value)

                            // get the id
                            qstr id_qstr = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);

                            // get the value
                            mp_parse_node_t pn_value = ((mp_parse_node_struct_t*)((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1])->nodes[0];
                            pn_value = fold_constants(comp, pn_value, consts);
                            if (!MP_PARSE_NODE_IS_SMALL_INT(pn_value)) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant must be an integer");
                                break;
                            }
162
                            mp_int_t value = MP_PARSE_NODE_LEAF_SMALL_INT(pn_value);
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181

                            // store the value in the table of dynamic constants
                            mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(id_qstr), MP_MAP_LOOKUP_ADD_IF_NOT_FOUND);
                            if (elem->value != MP_OBJ_NULL) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant redefined");
                                break;
                            }
                            elem->value = MP_OBJ_NEW_SMALL_INT(value);

                            // replace const(value) with value
                            pns1->nodes[0] = pn_value;

                            // finished folding this assignment
                            return pn;
                        }
                    }
                }
                break;
#endif
182
183
            case PN_string:
                return pn;
184
185
186
187
        }

        // fold arguments
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
188
        for (int i = 0; i < n; i++) {
189
            pns->nodes[i] = fold_constants(comp, pns->nodes[i], consts);
Damien's avatar
Damien committed
190
191
        }

192
        // try to fold this parse node
193
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
194
195
196
197
198
199
200
201
202
203
            case PN_atom_paren:
                if (n == 1 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0])) {
                    // (int)
                    pn = pns->nodes[0];
                }
                break;

            case PN_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int | int
204
205
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
206
207
208
209
210
211
212
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 | arg1);
                }
                break;

            case PN_and_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int & int
213
214
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
215
216
217
218
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 & arg1);
                }
                break;

Damien's avatar
Damien committed
219
            case PN_shift_expr:
220
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
221
222
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
223
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_LESS)) {
224
225
226
227
                        // int << int
                        if (!(arg1 >= BITS_PER_WORD || arg0 > (MP_SMALL_INT_MAX >> arg1) || arg0 < (MP_SMALL_INT_MIN >> arg1))) {
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 << arg1);
                        }
228
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_MORE)) {
229
                        // int >> int
230
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 >> arg1);
Damien's avatar
Damien committed
231
232
233
234
235
236
237
238
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_arith_expr:
239
                // overflow checking here relies on SMALL_INT being strictly smaller than mp_int_t
240
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
241
242
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
243
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PLUS)) {
244
                        // int + int
245
                        arg0 += arg1;
246
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_MINUS)) {
247
                        // int - int
248
                        arg0 -= arg1;
Damien's avatar
Damien committed
249
250
251
                    } else {
                        // shouldn't happen
                        assert(0);
252
                    }
253
                    if (MP_SMALL_INT_FITS(arg0)) {
254
                        //printf("%ld + %ld\n", arg0, arg1);
255
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
Damien's avatar
Damien committed
256
257
258
259
260
                    }
                }
                break;

            case PN_term:
261
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
262
263
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
264
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_STAR)) {
265
                        // int * int
266
267
                        if (!mp_small_int_mul_overflow(arg0, arg1)) {
                            arg0 *= arg1;
268
                            if (MP_SMALL_INT_FITS(arg0)) {
269
270
271
                                pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
                            }
                        }
272
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_SLASH)) {
273
274
                        // int / int
                        // pass
275
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PERCENT)) {
276
                        // int%int
277
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_modulo(arg0, arg1));
278
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_SLASH)) {
279
                        if (arg1 != 0) {
280
                            // int // int
281
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_floor_divide(arg0, arg1));
282
                        }
Damien's avatar
Damien committed
283
284
285
286
287
288
289
290
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_factor_2:
291
                if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
292
                    mp_int_t arg = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
293
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_PLUS)) {
294
                        // +int
295
296
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_MINUS)) {
297
                        // -int
298
299
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, -arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_TILDE)) {
300
                        // ~int
301
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ~arg);
Damien's avatar
Damien committed
302
303
304
305
306
307
308
309
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_power:
310
311
312
                if (0) {
#if MICROPY_EMIT_CPYTHON
                } else if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_NULL(pns->nodes[1]) && !MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
313
                    // int ** x
314
                    // can overflow; enabled only to compare with CPython
315
316
                    mp_parse_node_struct_t* pns2 = (mp_parse_node_struct_t*)pns->nodes[2];
                    if (MP_PARSE_NODE_IS_SMALL_INT(pns2->nodes[0])) {
317
                        int power = MP_PARSE_NODE_LEAF_SMALL_INT(pns2->nodes[0]);
Damien's avatar
Damien committed
318
319
                        if (power >= 0) {
                            int ans = 1;
320
                            int base = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
Damien's avatar
Damien committed
321
322
323
                            for (; power > 0; power--) {
                                ans *= base;
                            }
324
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ans);
Damien's avatar
Damien committed
325
326
                        }
                    }
327
328
329
330
331
332
333
334
335
336
337
338
339
#endif
                } else if (MP_PARSE_NODE_IS_ID(pns->nodes[0]) && MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[1], PN_trailer_period) && MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
                    // id.id
                    // look it up in constant table, see if it can be replaced with an integer
                    mp_parse_node_struct_t* pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
                    qstr q_base = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);
                    qstr q_attr = MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]);
                    mp_map_elem_t *elem = mp_map_lookup((mp_map_t*)&mp_constants_map, MP_OBJ_NEW_QSTR(q_base), MP_MAP_LOOKUP);
                    if (elem != NULL) {
                        mp_obj_t dest[2];
                        mp_load_method_maybe(elem->value, q_attr, dest);
                        if (MP_OBJ_IS_SMALL_INT(dest[0]) && dest[1] == NULL) {
340
                            mp_int_t val = MP_OBJ_SMALL_INT_VALUE(dest[0]);
341
                            if (MP_SMALL_INT_FITS(val)) {
342
343
344
345
                                pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, val);
                            }
                        }
                    }
Damien's avatar
Damien committed
346
347
348
349
350
351
352
353
                }
                break;
        }
    }

    return pn;
}

354
STATIC void compile_trailer_paren_helper(compiler_t *comp, mp_parse_node_t pn_arglist, bool is_method_call, int n_positional_extra);
355
STATIC void compile_comprehension(compiler_t *comp, mp_parse_node_struct_t *pns, scope_kind_t kind);
356
STATIC void compile_node(compiler_t *comp, mp_parse_node_t pn);
Damien's avatar
Damien committed
357

358
STATIC uint comp_next_label(compiler_t *comp) {
359
360
361
    return comp->next_label++;
}

362
363
364
365
366
367
368
369
370
371
372
373
STATIC void compile_increase_except_level(compiler_t *comp) {
    comp->cur_except_level += 1;
    if (comp->cur_except_level > comp->scope_cur->exc_stack_size) {
        comp->scope_cur->exc_stack_size = comp->cur_except_level;
    }
}

STATIC void compile_decrease_except_level(compiler_t *comp) {
    assert(comp->cur_except_level > 0);
    comp->cur_except_level -= 1;
}

374
STATIC scope_t *scope_new_and_link(compiler_t *comp, scope_kind_t kind, mp_parse_node_t pn, uint emit_options) {
375
    scope_t *scope = scope_new(kind, pn, comp->source_file, emit_options);
Damien's avatar
Damien committed
376
377
378
379
380
381
382
383
384
385
386
387
388
389
    scope->parent = comp->scope_cur;
    scope->next = NULL;
    if (comp->scope_head == NULL) {
        comp->scope_head = scope;
    } else {
        scope_t *s = comp->scope_head;
        while (s->next != NULL) {
            s = s->next;
        }
        s->next = scope;
    }
    return scope;
}

390
STATIC void apply_to_single_or_list(compiler_t *comp, mp_parse_node_t pn, int pn_list_kind, void (*f)(compiler_t*, mp_parse_node_t)) {
391
392
393
    if (MP_PARSE_NODE_IS_STRUCT(pn) && MP_PARSE_NODE_STRUCT_KIND((mp_parse_node_struct_t*)pn) == pn_list_kind) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
394
395
396
        for (int i = 0; i < num_nodes; i++) {
            f(comp, pns->nodes[i]);
        }
397
    } else if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
398
399
400
401
        f(comp, pn);
    }
}

402
STATIC int list_get(mp_parse_node_t *pn, int pn_kind, mp_parse_node_t **nodes) {
403
    if (MP_PARSE_NODE_IS_NULL(*pn)) {
Damien's avatar
Damien committed
404
405
        *nodes = NULL;
        return 0;
406
    } else if (MP_PARSE_NODE_IS_LEAF(*pn)) {
Damien's avatar
Damien committed
407
408
409
        *nodes = pn;
        return 1;
    } else {
410
411
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)(*pn);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) != pn_kind) {
Damien's avatar
Damien committed
412
413
414
415
            *nodes = pn;
            return 1;
        } else {
            *nodes = pns->nodes;
416
            return MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
417
418
419
420
        }
    }
}

421
void compile_do_nothing(compiler_t *comp, mp_parse_node_struct_t *pns) {
Damien's avatar
Damien committed
422
423
}

424
425
void compile_generic_all_nodes(compiler_t *comp, mp_parse_node_struct_t *pns) {
    int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
426
427
428
429
430
    for (int i = 0; i < num_nodes; i++) {
        compile_node(comp, pns->nodes[i]);
    }
}

431
#if MICROPY_EMIT_CPYTHON
432
STATIC bool cpython_c_tuple_is_const(mp_parse_node_t pn) {
433
434
435
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string)) {
        return true;
    }
436
    if (!MP_PARSE_NODE_IS_LEAF(pn)) {
Damien's avatar
Damien committed
437
438
        return false;
    }
439
    if (MP_PARSE_NODE_IS_ID(pn)) {
Damien's avatar
Damien committed
440
441
442
443
444
        return false;
    }
    return true;
}

445
STATIC void cpython_c_print_quoted_str(vstr_t *vstr, const char *str, uint len, bool bytes) {
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
    bool has_single_quote = false;
    bool has_double_quote = false;
    for (int i = 0; i < len; i++) {
        if (str[i] == '\'') {
            has_single_quote = true;
        } else if (str[i] == '"') {
            has_double_quote = true;
        }
    }
    if (bytes) {
        vstr_printf(vstr, "b");
    }
    bool quote_single = false;
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        quote_single = true;
        vstr_printf(vstr, "'");
    }
    for (int i = 0; i < len; i++) {
        if (str[i] == '\n') {
            vstr_printf(vstr, "\\n");
        } else if (str[i] == '\\') {
            vstr_printf(vstr, "\\\\");
        } else if (str[i] == '\'' && quote_single) {
            vstr_printf(vstr, "\\'");
        } else {
            vstr_printf(vstr, "%c", str[i]);
        }
    }
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        vstr_printf(vstr, "'");
    }
}

483
STATIC void cpython_c_tuple_emit_const(compiler_t *comp, mp_parse_node_t pn, vstr_t *vstr) {
484
485
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
486
        cpython_c_print_quoted_str(vstr, (const char*)pns->nodes[0], (mp_uint_t)pns->nodes[1], false);
487
488
489
        return;
    }

490
    assert(MP_PARSE_NODE_IS_LEAF(pn));
491
492
493
494
495
    if (MP_PARSE_NODE_IS_SMALL_INT(pn)) {
        vstr_printf(vstr, INT_FMT, MP_PARSE_NODE_LEAF_SMALL_INT(pn));
        return;
    }

496
497
498
499
500
    int arg = MP_PARSE_NODE_LEAF_ARG(pn);
    switch (MP_PARSE_NODE_LEAF_KIND(pn)) {
        case MP_PARSE_NODE_ID: assert(0);
        case MP_PARSE_NODE_INTEGER: vstr_printf(vstr, "%s", qstr_str(arg)); break;
        case MP_PARSE_NODE_DECIMAL: vstr_printf(vstr, "%s", qstr_str(arg)); break;
501
502
503
504
505
506
507
        case MP_PARSE_NODE_STRING:
        case MP_PARSE_NODE_BYTES: {
            uint len;
            const byte *str = qstr_data(arg, &len);
            cpython_c_print_quoted_str(vstr, (const char*)str, len, MP_PARSE_NODE_LEAF_KIND(pn) == MP_PARSE_NODE_BYTES);
            break;
        }
508
        case MP_PARSE_NODE_TOKEN:
Damien's avatar
Damien committed
509
            switch (arg) {
510
511
512
                case MP_TOKEN_KW_FALSE: vstr_printf(vstr, "False"); break;
                case MP_TOKEN_KW_NONE: vstr_printf(vstr, "None"); break;
                case MP_TOKEN_KW_TRUE: vstr_printf(vstr, "True"); break;
513
                default: assert(0); // shouldn't happen
Damien's avatar
Damien committed
514
515
516
517
518
519
            }
            break;
        default: assert(0);
    }
}

520
STATIC void cpython_c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
Damien's avatar
Damien committed
521
522
    int n = 0;
    if (pns_list != NULL) {
523
        n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
Damien's avatar
Damien committed
524
525
526
    }
    int total = n;
    bool is_const = true;
527
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
528
        total += 1;
529
        if (!cpython_c_tuple_is_const(pn)) {
Damien's avatar
Damien committed
530
531
532
533
            is_const = false;
        }
    }
    for (int i = 0; i < n; i++) {
534
        if (!cpython_c_tuple_is_const(pns_list->nodes[i])) {
Damien's avatar
Damien committed
535
536
537
538
539
540
            is_const = false;
            break;
        }
    }
    if (total > 0 && is_const) {
        bool need_comma = false;
541
542
        vstr_t *vstr = vstr_new();
        vstr_printf(vstr, "(");
543
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
544
            cpython_c_tuple_emit_const(comp, pn, vstr);
Damien's avatar
Damien committed
545
546
547
548
            need_comma = true;
        }
        for (int i = 0; i < n; i++) {
            if (need_comma) {
549
                vstr_printf(vstr, ", ");
Damien's avatar
Damien committed
550
            }
551
            cpython_c_tuple_emit_const(comp, pns_list->nodes[i], vstr);
Damien's avatar
Damien committed
552
553
554
            need_comma = true;
        }
        if (total == 1) {
555
            vstr_printf(vstr, ",)");
Damien's avatar
Damien committed
556
        } else {
557
            vstr_printf(vstr, ")");
Damien's avatar
Damien committed
558
        }
559
        EMIT_ARG(load_const_verbatim_str, vstr_str(vstr));
560
        vstr_free(vstr);
Damien's avatar
Damien committed
561
    } else {
562
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
563
564
565
566
567
            compile_node(comp, pn);
        }
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
568
        EMIT_ARG(build_tuple, total);
Damien's avatar
Damien committed
569
570
    }
}
571
572
573
#endif

// funnelling all tuple creations through this function is purely so we can optionally agree with CPython
574
STATIC void c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
575
#if MICROPY_EMIT_CPYTHON
576
577
578
    cpython_c_tuple(comp, pn, pns_list);
#else
    int total = 0;
579
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
580
581
582
583
        compile_node(comp, pn);
        total += 1;
    }
    if (pns_list != NULL) {
584
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
585
586
587
588
589
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
        total += n;
    }
590
    EMIT_ARG(build_tuple, total);
591
592
#endif
}
Damien's avatar
Damien committed
593

594
void compile_generic_tuple(compiler_t *comp, mp_parse_node_struct_t *pns) {
Damien's avatar
Damien committed
595
    // a simple tuple expression
596
    c_tuple(comp, MP_PARSE_NODE_NULL, pns);
Damien's avatar
Damien committed
597
598
}

599
STATIC bool node_is_const_false(mp_parse_node_t pn) {
600
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_FALSE);
601
    // untested: || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) == 0);
Damien's avatar
Damien committed
602
603
}

604
STATIC bool node_is_const_true(mp_parse_node_t pn) {
605
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_TRUE) || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) == 1);
Damien's avatar
Damien committed
606
607
}

608
#if MICROPY_EMIT_CPYTHON
609
// the is_nested variable is purely to match with CPython, which doesn't fully optimise not's
610
STATIC void cpython_c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label, bool is_nested) {
Damien's avatar
Damien committed
611
612
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
613
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
614
615
616
617
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
618
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
619
620
        }
        return;
621
622
623
624
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
Damien's avatar
Damien committed
625
            if (jump_if == false) {
626
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
627
                for (int i = 0; i < n - 1; i++) {
628
                    cpython_c_if_cond(comp, pns->nodes[i], true, label2, true);
Damien's avatar
Damien committed
629
                }
630
                cpython_c_if_cond(comp, pns->nodes[n - 1], false, label, true);
631
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
632
633
            } else {
                for (int i = 0; i < n; i++) {
634
                    cpython_c_if_cond(comp, pns->nodes[i], true, label, true);
Damien's avatar
Damien committed
635
636
637
                }
            }
            return;
638
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
Damien's avatar
Damien committed
639
640
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
641
                    cpython_c_if_cond(comp, pns->nodes[i], false, label, true);
Damien's avatar
Damien committed
642
643
                }
            } else {
644
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
645
                for (int i = 0; i < n - 1; i++) {
646
                    cpython_c_if_cond(comp, pns->nodes[i], false, label2, true);
Damien's avatar
Damien committed
647
                }
648
                cpython_c_if_cond(comp, pns->nodes[n - 1], true, label, true);
649
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
650
651
            }
            return;
652
        } else if (!is_nested && MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
653
            cpython_c_if_cond(comp, pns->nodes[0], !jump_if, label, true);
Damien's avatar
Damien committed
654
655
656
657
658
659
660
            return;
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
    if (jump_if == false) {
661
        EMIT_ARG(pop_jump_if_false, label);
Damien's avatar
Damien committed
662
    } else {
663
        EMIT_ARG(pop_jump_if_true, label);
Damien's avatar
Damien committed
664
665
    }
}
666
#endif
Damien's avatar
Damien committed
667

668
STATIC void c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label) {
669
#if MICROPY_EMIT_CPYTHON
670
671
672
673
    cpython_c_if_cond(comp, pn, jump_if, label, false);
#else
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
674
            EMIT_ARG(jump, label);
675
676
677
678
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
679
            EMIT_ARG(jump, label);
680
681
        }
        return;
682
683
684
685
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
686
            if (jump_if == false) {
687
                uint label2 = comp_next_label(comp);
688
689
690
691
                for (int i = 0; i < n - 1; i++) {
                    c_if_cond(comp, pns->nodes[i], true, label2);
                }
                c_if_cond(comp, pns->nodes[n - 1], false, label);
692
                EMIT_ARG(label_assign, label2);
693
694
695
696
697
698
            } else {
                for (int i = 0; i < n; i++) {
                    c_if_cond(comp, pns->nodes[i], true, label);
                }
            }
            return;
699
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
700
701
702
703
704
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
                    c_if_cond(comp, pns->nodes[i], false, label);
                }
            } else {
705
                uint label2 = comp_next_label(comp);
706
707
708
709
                for (int i = 0; i < n - 1; i++) {
                    c_if_cond(comp, pns->nodes[i], false, label2);
                }
                c_if_cond(comp, pns->nodes[n - 1], true, label);
710
                EMIT_ARG(label_assign, label2);
711
712
            }
            return;
713
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
714
715
716
717
718
719
720
721
            c_if_cond(comp, pns->nodes[0], !jump_if, label);
            return;
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
    if (jump_if == false) {
722
        EMIT_ARG(pop_jump_if_false, label);
723
    } else {
724
        EMIT_ARG(pop_jump_if_true, label);
725
726
    }
#endif
Damien's avatar
Damien committed
727
728
729
}

typedef enum { ASSIGN_STORE, ASSIGN_AUG_LOAD, ASSIGN_AUG_STORE } assign_kind_t;
730
STATIC void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t kind);
Damien's avatar
Damien committed
731

732
STATIC void c_assign_power(compiler_t *comp, mp_parse_node_struct_t *pns, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
733
734
735
736
    if (assign_kind != ASSIGN_AUG_STORE) {
        compile_node(comp, pns->nodes[0]);
    }

737
738
739
740
    if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
        mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_power_trailers) {
            int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns1);
Damien's avatar
Damien committed
741
742
743
744
745
            if (assign_kind != ASSIGN_AUG_STORE) {
                for (int i = 0; i < n - 1; i++) {
                    compile_node(comp, pns1->nodes[i]);
                }
            }
746
747
            assert(MP_PARSE_NODE_IS_STRUCT(pns1->nodes[n - 1]));
            pns1 = (mp_parse_node_struct_t*)pns1->nodes[n - 1];
Damien's avatar
Damien committed
748
        }
749
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_paren) {
750
            goto cannot_assign;
751
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_bracket) {
Damien's avatar
Damien committed
752
753
754
755
756
757
758
            if (assign_kind == ASSIGN_AUG_STORE) {
                EMIT(rot_three);
                EMIT(store_subscr);
            } else {
                compile_node(comp, pns1->nodes[0]);
                if (assign_kind == ASSIGN_AUG_LOAD) {
                    EMIT(dup_top_two);
759
                    EMIT(load_subscr);
Damien's avatar
Damien committed
760
761
762
763
                } else {
                    EMIT(store_subscr);
                }
            }
764
765
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_period) {
            assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
Damien's avatar
Damien committed
766
767
            if (assign_kind == ASSIGN_AUG_LOAD) {
                EMIT(dup_top);
768
                EMIT_ARG(load_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
769
770
771
772
            } else {
                if (assign_kind == ASSIGN_AUG_STORE) {
                    EMIT(rot_two);
                }
773
                EMIT_ARG(store_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
774
775
            }
        } else {
776
            goto cannot_assign;
Damien's avatar
Damien committed
777
778
        }
    } else {
779
        goto cannot_assign;
Damien's avatar
Damien committed
780
781
    }

782
    if (!MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
783
        goto cannot_assign;
Damien's avatar
Damien committed
784
    }
785
786
787
788
789

    return;

cannot_assign:
    compile_syntax_error(comp, (mp_parse_node_t)pns, "can't assign to expression");
Damien's avatar
Damien committed
790
791
}

792
// we need to allow for a caller passing in 1 initial node (node_head) followed by an array of nodes (nodes_tail)
793
STATIC void c_assign_tuple(compiler_t *comp, mp_parse_node_t node_head, uint num_tail, mp_parse_node_t *nodes_tail) {
794
795
796
    uint num_head = (node_head == MP_PARSE_NODE_NULL) ? 0 : 1;

    // look for star expression
Damien's avatar
Damien committed
797
    int have_star_index = -1;
798
799
800
801
802
803
    if (num_head != 0 && MP_PARSE_NODE_IS_STRUCT_KIND(node_head, PN_star_expr)) {
        EMIT_ARG(unpack_ex, 0, num_tail);
        have_star_index = 0;
    }
    for (int i = 0; i < num_tail; i++) {
        if (MP_PARSE_NODE_IS_STRUCT_KIND(nodes_tail[i], PN_star_expr)) {
Damien's avatar
Damien committed
804
            if (have_star_index < 0) {
805
806
                EMIT_ARG(unpack_ex, num_head + i, num_tail - i - 1);
                have_star_index = num_head + i;
Damien's avatar
Damien committed
807
            } else {
808
                compile_syntax_error(comp, nodes_tail[i], "multiple *x in assignment");
Damien's avatar
Damien committed
809
810
811
812
813
                return;
            }
        }
    }
    if (have_star_index < 0) {
814
        EMIT_ARG(unpack_sequence, num_head + num_tail);
Damien's avatar
Damien committed
815
    }
816
817
818
    if (num_head != 0) {
        if (0 == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)node_head)->nodes[0], ASSIGN_STORE);
Damien's avatar
Damien committed
819
        } else {
820
821
822
823
824
825
826
827
            c_assign(comp, node_head, ASSIGN_STORE);
        }
    }
    for (int i = 0; i < num_tail; i++) {
        if (num_head + i == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)nodes_tail[i])->nodes[0], ASSIGN_STORE);
        } else {
            c_assign(comp, nodes_tail[i], ASSIGN_STORE);
Damien's avatar
Damien committed
828
829
830
831
832
        }
    }
}

// assigns top of stack to pn
833
STATIC void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
834
    tail_recursion:
835
    if (MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
836
        assert(0);
837
838
839
    } else if (MP_PARSE_NODE_IS_LEAF(pn)) {
        if (MP_PARSE_NODE_IS_ID(pn)) {
            int arg = MP_PARSE_NODE_LEAF_ARG(pn);
Damien's avatar
Damien committed
840
841
842
            switch (assign_kind) {
                case ASSIGN_STORE:
                case ASSIGN_AUG_STORE:
843
                    EMIT_ARG(store_id, arg);
Damien's avatar
Damien committed
844
845
                    break;
                case ASSIGN_AUG_LOAD:
846
                    EMIT_ARG(load_id, arg);
Damien's avatar
Damien committed
847
848
849
                    break;
            }
        } else {
850
            compile_syntax_error(comp, pn, "can't assign to literal");
Damien's avatar
Damien committed
851
852
853
            return;
        }
    } else {
854
855
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
Damien's avatar
Damien committed
856
857
858
859
860
861
862
863
864
865
866
            case PN_power:
                // lhs is an index or attribute
                c_assign_power(comp, pns, assign_kind);
                break;

            case PN_testlist_star_expr:
            case PN_exprlist:
                // lhs is a tuple
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
867
                c_assign_tuple(comp, MP_PARSE_NODE_NULL, MP_PARSE_NODE_STRUCT_NUM_NODES(pns), pns->nodes);
Damien's avatar
Damien committed
868
869
870
871
                break;

            case PN_atom_paren:
                // lhs is something in parenthesis
872
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
873
                    // empty tuple
874
                    goto cannot_assign;
875
876
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
877
878
879
880
881
882
883
884
885
886
887
888
889
                    goto testlist_comp;
                } else {
                    // parenthesis around 1 item, is just that item
                    pn = pns->nodes[0];
                    goto tail_recursion;
                }
                break;

            case PN_atom_bracket:
                // lhs is something in brackets
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
890
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
891
                    // empty list, assignment allowed
892
                    c_assign_tuple(comp, MP_PARSE_NODE_NULL, 0, NULL);
893
894
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
895
896
897
                    goto testlist_comp;
                } else {
                    // brackets around 1 item
898
                    c_assign_tuple(comp, pns->nodes[0], 0, NULL);
Damien's avatar
Damien committed
899
900
901
902
                }
                break;

            default:
903
                goto cannot_assign;
Damien's avatar
Damien committed
904
905
906
907
908
        }
        return;

        testlist_comp:
        // lhs is a sequence
909
910
911
        if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
            mp_parse_node_struct_t *pns2 = (mp_parse_node_struct_t*)pns->nodes[1];
            if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3b) {
Damien's avatar
Damien committed
912
                // sequence of one item, with trailing comma
913
                assert(MP_PARSE_NODE_IS_NULL(pns2->nodes[0]));
914
                c_assign_tuple(comp, pns->nodes[0], 0, NULL);
915
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3c) {
Damien's avatar
Damien committed
916
                // sequence of many items
917
918
                uint n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns2);
                c_assign_tuple(comp, pns->nodes[0], n, pns2->nodes);
919
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_comp_for) {
920
                // TODO can we ever get here? can it be compiled?
921
                goto cannot_assign;
Damien's avatar
Damien committed
922
923
924
925
926
927
928
            } else {
                // sequence with 2 items
                goto sequence_with_2_items;
            }
        } else {
            // sequence with 2 items
            sequence_with_2_items:
929
            c_assign_tuple(comp, MP_PARSE_NODE_NULL, 2, pns->nodes);
Damien's avatar
Damien committed
930
931
932
933
934
        }
        return;
    }
    return;

935
936
937
938
    cannot_assign:
    compile_syntax_error(comp, pn, "can't assign to expression");
    return;

Damien's avatar
Damien committed
939
    bad_aug:
940
    compile_syntax_error(comp, pn, "illegal expression for augmented assignment");
Damien's avatar
Damien committed
941
942
943
}

// stuff for lambda and comprehensions and generators
944
945
946
947
// if we are not in CPython compatibility mode then:
//  if n_pos_defaults > 0 then there is a tuple on the stack with the positional defaults
//  if n_kw_defaults > 0 then there is a dictionary on the stack with the keyword defaults
//  if both exist, the tuple is above the dictionary (ie the first pop gets the tuple)
948
STATIC void close_over_variables_etc(compiler_t *comp, scope_t *this_scope, int n_pos_defaults, int n_kw_defaults) {
949
950
951
    assert(n_pos_defaults >= 0);
    assert(n_kw_defaults >= 0);

Damien's avatar
Damien committed
952
    // make closed over variables, if any
953
    // ensure they are closed over in the order defined in the outer scope (mainly to agree with CPython)
Damien's avatar
Damien committed
954
955
    int nfree = 0;
    if (comp->scope_cur->kind != SCOPE_MODULE) {
956
957
958
959
960
961
        for (int i = 0; i < comp->scope_cur->id_info_len; i++) {
            id_info_t *id = &comp->scope_cur->id_info[i];
            if (id->kind == ID_INFO_KIND_CELL || id->kind == ID_INFO_KIND_FREE) {
                for (int j = 0; j < this_scope->id_info_len; j++) {
                    id_info_t *id2 = &this_scope->id_info[j];
                    if (id2->kind == ID_INFO_KIND_FREE && id->qstr == id2->qstr) {
Damien George's avatar
Damien George committed
962
#if MICROPY_EMIT_CPYTHON
963
                        EMIT_ARG(load_closure, id->qstr, id->local_num);
Damien George's avatar
Damien George committed
964
965
#else
                        // in Micro Python we load closures using LOAD_FAST
966
                        EMIT_ARG(load_fast, id->qstr, id->flags, id->local_num);
Damien George's avatar
Damien George committed
967
#endif
968
969
970
                        nfree += 1;
                    }
                }
Damien's avatar
Damien committed
971
972
973
974
975
976
            }
        }
    }

    // make the function/closure
    if (nfree == 0) {
977
        EMIT_ARG(make_function, this_scope, n_pos_defaults, n_kw_defaults);
Damien's avatar
Damien committed
978
    } else {
979
        EMIT_ARG(make_closure, this_scope, nfree, n_pos_defaults, n_kw_defaults);
Damien's avatar
Damien committed
980
981
982
    }
}

983
STATIC void compile_funcdef_param(compiler_t *comp, mp_parse_node_t pn) {
984
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_typedargslist_star)) {
985
986
        comp->have_star = true;
        /* don't need to distinguish bare from named star
987
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
988
989
        if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
            // bare star
990
991
        } else {
            // named star
992
        }
993
        */
994
995

    } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_typedargslist_dbl_star)) {
996
        // named double star
<