compile.c 155 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
/*
 * This file is part of the Micro Python project, http://micropython.org/
 *
 * The MIT License (MIT)
 *
 * Copyright (c) 2013, 2014 Damien P. George
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

xbe's avatar
xbe committed
27
#include <stdbool.h>
Damien's avatar
Damien committed
28
29
30
31
32
#include <stdint.h>
#include <stdio.h>
#include <string.h>
#include <assert.h>

33
34
35
36
37
38
#include "py/scope.h"
#include "py/emit.h"
#include "py/compile.h"
#include "py/smallint.h"
#include "py/runtime.h"
#include "py/builtin.h"
Damien's avatar
Damien committed
39
40
41
42

// TODO need to mangle __attr names

typedef enum {
43
#define DEF_RULE(rule, comp, kind, ...) PN_##rule,
44
#include "py/grammar.h"
Damien's avatar
Damien committed
45
46
#undef DEF_RULE
    PN_maximum_number_of,
47
    PN_string, // special node for non-interned string
48
    PN_bytes, // special node for non-interned bytes
49
    PN_const_object, // special node for a constant, generic Python object
Damien's avatar
Damien committed
50
51
} pn_kind_t;

52
53
54
55
56
#define NEED_METHOD_TABLE (MICROPY_EMIT_CPYTHON || MICROPY_EMIT_NATIVE)

#if NEED_METHOD_TABLE

// we need a method table to do the lookup for the emitter functions
57
58
#define EMIT(fun) (comp->emit_method_table->fun(comp->emit))
#define EMIT_ARG(fun, ...) (comp->emit_method_table->fun(comp->emit, __VA_ARGS__))
59
60
#define EMIT_LOAD_FAST(qst, local_num) (comp->emit_method_table->load_id.fast(comp->emit, qst, local_num))
#define EMIT_LOAD_GLOBAL(qst) (comp->emit_method_table->load_id.global(comp->emit, qst))
61
62
#define EMIT_INLINE_ASM(fun) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm))
#define EMIT_INLINE_ASM_ARG(fun, ...) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm, __VA_ARGS__))
Damien's avatar
Damien committed
63

64
65
66
67
68
69
70
71
72
73
#else

// if we only have the bytecode emitter enabled then we can do a direct call to the functions
#define EMIT(fun) (mp_emit_bc_##fun(comp->emit))
#define EMIT_ARG(fun, ...) (mp_emit_bc_##fun(comp->emit, __VA_ARGS__))
#define EMIT_LOAD_FAST(qst, local_num) (mp_emit_bc_load_fast(comp->emit, qst, local_num))
#define EMIT_LOAD_GLOBAL(qst) (mp_emit_bc_load_global(comp->emit, qst))

#endif

74
// elements in this struct are ordered to make it compact
Damien's avatar
Damien committed
75
typedef struct _compiler_t {
76
    qstr source_file;
77

78
79
80
    uint8_t is_repl;
    uint8_t pass; // holds enum type pass_kind_t
    uint8_t func_arg_is_super; // used to compile special case of super() function call
81
82
83
    uint8_t have_star;

    // try to keep compiler clean from nlr
84
85
    mp_obj_t compile_error; // set to an exception object if there's an error
    mp_uint_t compile_error_line; // set to best guess of line of error
Damien's avatar
Damien committed
86

87
    uint next_label;
88

89
90
91
    uint16_t num_dict_params;
    uint16_t num_default_params;

92
93
    uint16_t break_label; // highest bit set indicates we are breaking out of a for loop
    uint16_t continue_label;
94
    uint16_t cur_except_level; // increased for SETUP_EXCEPT, SETUP_FINALLY; decreased for POP_BLOCK, POP_EXCEPT
95
    uint16_t break_continue_except_level;
Damien's avatar
Damien committed
96
97
98
99

    scope_t *scope_head;
    scope_t *scope_cur;

100
    emit_t *emit;                                   // current emitter
101
    #if NEED_METHOD_TABLE
102
    const emit_method_table_t *emit_method_table;   // current emit method table
103
    #endif
104

105
    #if MICROPY_EMIT_INLINE_THUMB
106
107
    emit_inline_asm_t *emit_inline_asm;                                   // current emitter for inline asm
    const emit_inline_asm_method_table_t *emit_inline_asm_method_table;   // current emit method table for inline asm
108
    #endif
Damien's avatar
Damien committed
109
110
} compiler_t;

111
112
113
114
STATIC void compile_error_set_line(compiler_t *comp, mp_parse_node_t pn) {
    // if the line of the error is unknown then try to update it from the pn
    if (comp->compile_error_line == 0 && MP_PARSE_NODE_IS_STRUCT(pn)) {
        comp->compile_error_line = (mp_uint_t)((mp_parse_node_struct_t*)pn)->source_line;
115
    }
116
117
118
}

STATIC void compile_syntax_error(compiler_t *comp, mp_parse_node_t pn, const char *msg) {
119
120
121
122
123
    // only register the error if there has been no other error
    if (comp->compile_error == MP_OBJ_NULL) {
        comp->compile_error = mp_obj_new_exception_msg(&mp_type_SyntaxError, msg);
        compile_error_set_line(comp, pn);
    }
124
125
}

126
#if MICROPY_COMP_MODULE_CONST
127
STATIC const mp_map_elem_t mp_constants_table[] = {
128
129
130
    #if MICROPY_PY_UCTYPES
    { MP_OBJ_NEW_QSTR(MP_QSTR_uctypes), (mp_obj_t)&mp_module_uctypes },
    #endif
131
    // Extra constants as defined by a port
132
    MICROPY_PORT_CONSTANTS
133
};
134
135
STATIC MP_DEFINE_CONST_MAP(mp_constants_map, mp_constants_table);
#endif
136

137
138
139
140
// this function is essentially a simple preprocessor
STATIC mp_parse_node_t fold_constants(compiler_t *comp, mp_parse_node_t pn, mp_map_t *consts) {
    if (0) {
        // dummy
141
#if MICROPY_COMP_CONST
142
143
144
145
146
147
148
149
150
    } else if (MP_PARSE_NODE_IS_ID(pn)) {
        // lookup identifier in table of dynamic constants
        qstr qst = MP_PARSE_NODE_LEAF_ARG(pn);
        mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(qst), MP_MAP_LOOKUP);
        if (elem != NULL) {
            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, MP_OBJ_SMALL_INT_VALUE(elem->value));
        }
#endif
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
151
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
Damien's avatar
Damien committed
152

153
154
        // fold some parse nodes before folding their arguments
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
155
#if MICROPY_COMP_CONST
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
            case PN_expr_stmt:
                if (!MP_PARSE_NODE_IS_NULL(pns->nodes[1])) {
                    mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_expr_stmt_assign) {
                        if (MP_PARSE_NODE_IS_ID(pns->nodes[0])
                            && MP_PARSE_NODE_IS_STRUCT_KIND(pns1->nodes[0], PN_power)
                            && MP_PARSE_NODE_IS_ID(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0])
                            && MP_PARSE_NODE_LEAF_ARG(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[0]) == MP_QSTR_const
                            && MP_PARSE_NODE_IS_STRUCT_KIND(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1], PN_trailer_paren)
                            && MP_PARSE_NODE_IS_NULL(((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[2])
                            ) {
                            // code to assign dynamic constants: id = const(value)

                            // get the id
                            qstr id_qstr = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);

                            // get the value
                            mp_parse_node_t pn_value = ((mp_parse_node_struct_t*)((mp_parse_node_struct_t*)pns1->nodes[0])->nodes[1])->nodes[0];
                            pn_value = fold_constants(comp, pn_value, consts);
                            if (!MP_PARSE_NODE_IS_SMALL_INT(pn_value)) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant must be an integer");
                                break;
                            }
179
                            mp_int_t value = MP_PARSE_NODE_LEAF_SMALL_INT(pn_value);
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198

                            // store the value in the table of dynamic constants
                            mp_map_elem_t *elem = mp_map_lookup(consts, MP_OBJ_NEW_QSTR(id_qstr), MP_MAP_LOOKUP_ADD_IF_NOT_FOUND);
                            if (elem->value != MP_OBJ_NULL) {
                                compile_syntax_error(comp, (mp_parse_node_t)pns, "constant redefined");
                                break;
                            }
                            elem->value = MP_OBJ_NEW_SMALL_INT(value);

                            // replace const(value) with value
                            pns1->nodes[0] = pn_value;

                            // finished folding this assignment
                            return pn;
                        }
                    }
                }
                break;
#endif
199
            case PN_string:
200
            case PN_bytes:
201
            case PN_const_object:
202
                return pn;
203
204
205
206
        }

        // fold arguments
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
207
        for (int i = 0; i < n; i++) {
208
            pns->nodes[i] = fold_constants(comp, pns->nodes[i], consts);
Damien's avatar
Damien committed
209
210
        }

211
        // try to fold this parse node
212
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
213
214
215
216
217
218
219
220
221
222
            case PN_atom_paren:
                if (n == 1 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0])) {
                    // (int)
                    pn = pns->nodes[0];
                }
                break;

            case PN_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int | int
223
224
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
225
226
227
228
229
230
231
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 | arg1);
                }
                break;

            case PN_and_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int & int
232
233
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
234
235
236
237
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 & arg1);
                }
                break;

Damien's avatar
Damien committed
238
            case PN_shift_expr:
239
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
240
241
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
242
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_LESS)) {
243
                        // int << int
244
                        if (!(arg1 >= (mp_int_t)BITS_PER_WORD || arg0 > (MP_SMALL_INT_MAX >> arg1) || arg0 < (MP_SMALL_INT_MIN >> arg1))) {
245
246
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 << arg1);
                        }
247
248
                    } else {
                        assert(MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_MORE)); // should be
249
                        // int >> int
250
                        if (arg1 >= (mp_int_t)BITS_PER_WORD) {
251
252
253
254
                            // Shifting to big amounts is underfined behavior
                            // in C and is CPU-dependent; propagate sign bit.
                            arg1 = BITS_PER_WORD - 1;
                        }
255
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 >> arg1);
Damien's avatar
Damien committed
256
257
258
259
260
                    }
                }
                break;

            case PN_arith_expr:
261
                // overflow checking here relies on SMALL_INT being strictly smaller than mp_int_t
262
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
263
264
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
265
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PLUS)) {
266
                        // int + int
267
                        arg0 += arg1;
268
269
                    } else {
                        assert(MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_MINUS)); // should be
270
                        // int - int
271
                        arg0 -= arg1;
272
                    }
273
                    if (MP_SMALL_INT_FITS(arg0)) {
274
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
Damien's avatar
Damien committed
275
276
277
278
279
                    }
                }
                break;

            case PN_term:
280
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
281
282
                    mp_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    mp_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
283
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_STAR)) {
284
                        // int * int
285
286
                        if (!mp_small_int_mul_overflow(arg0, arg1)) {
                            arg0 *= arg1;
287
                            if (MP_SMALL_INT_FITS(arg0)) {
288
289
290
                                pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
                            }
                        }
291
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_SLASH)) {
292
293
                        // int / int
                        // pass
294
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PERCENT)) {
295
                        // int%int
296
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_modulo(arg0, arg1));
297
298
                    } else {
                        assert(MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_SLASH)); // should be
299
                        if (arg1 != 0) {
300
                            // int // int
301
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_floor_divide(arg0, arg1));
302
                        }
Damien's avatar
Damien committed
303
304
305
306
307
                    }
                }
                break;

            case PN_factor_2:
308
                if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
309
                    mp_int_t arg = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
310
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_PLUS)) {
311
                        // +int
312
313
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_MINUS)) {
314
                        // -int
315
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, -arg);
316
317
                    } else {
                        assert(MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_TILDE)); // should be
318
                        // ~int
319
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ~arg);
Damien's avatar
Damien committed
320
321
322
323
324
                    }
                }
                break;

            case PN_power:
325
326
327
                if (0) {
#if MICROPY_EMIT_CPYTHON
                } else if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_NULL(pns->nodes[1]) && !MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
328
                    // int ** x
329
                    // can overflow; enabled only to compare with CPython
330
                    mp_parse_node_struct_t *pns2 = (mp_parse_node_struct_t*)pns->nodes[2];
331
                    if (MP_PARSE_NODE_IS_SMALL_INT(pns2->nodes[0])) {
332
                        int power = MP_PARSE_NODE_LEAF_SMALL_INT(pns2->nodes[0]);
Damien's avatar
Damien committed
333
334
                        if (power >= 0) {
                            int ans = 1;
335
                            int base = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
Damien's avatar
Damien committed
336
337
338
                            for (; power > 0; power--) {
                                ans *= base;
                            }
339
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ans);
Damien's avatar
Damien committed
340
341
                        }
                    }
342
#endif
343
#if MICROPY_COMP_MODULE_CONST
344
345
346
                } else if (MP_PARSE_NODE_IS_ID(pns->nodes[0]) && MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[1], PN_trailer_period) && MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
                    // id.id
                    // look it up in constant table, see if it can be replaced with an integer
347
                    mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
348
349
350
351
352
353
354
355
                    assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
                    qstr q_base = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);
                    qstr q_attr = MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]);
                    mp_map_elem_t *elem = mp_map_lookup((mp_map_t*)&mp_constants_map, MP_OBJ_NEW_QSTR(q_base), MP_MAP_LOOKUP);
                    if (elem != NULL) {
                        mp_obj_t dest[2];
                        mp_load_method_maybe(elem->value, q_attr, dest);
                        if (MP_OBJ_IS_SMALL_INT(dest[0]) && dest[1] == NULL) {
356
                            mp_int_t val = MP_OBJ_SMALL_INT_VALUE(dest[0]);
357
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, val);
358
359
                        }
                    }
360
#endif
Damien's avatar
Damien committed
361
362
363
364
365
366
367
368
                }
                break;
        }
    }

    return pn;
}

369
STATIC void compile_trailer_paren_helper(compiler_t *comp, mp_parse_node_t pn_arglist, bool is_method_call, int n_positional_extra);
370
STATIC void compile_comprehension(compiler_t *comp, mp_parse_node_struct_t *pns, scope_kind_t kind);
371
STATIC void compile_node(compiler_t *comp, mp_parse_node_t pn);
Damien's avatar
Damien committed
372

373
STATIC uint comp_next_label(compiler_t *comp) {
374
375
376
    return comp->next_label++;
}

377
378
379
380
381
382
383
384
385
386
387
388
STATIC void compile_increase_except_level(compiler_t *comp) {
    comp->cur_except_level += 1;
    if (comp->cur_except_level > comp->scope_cur->exc_stack_size) {
        comp->scope_cur->exc_stack_size = comp->cur_except_level;
    }
}

STATIC void compile_decrease_except_level(compiler_t *comp) {
    assert(comp->cur_except_level > 0);
    comp->cur_except_level -= 1;
}

389
STATIC scope_t *scope_new_and_link(compiler_t *comp, scope_kind_t kind, mp_parse_node_t pn, uint emit_options) {
390
    scope_t *scope = scope_new(kind, pn, comp->source_file, emit_options);
Damien's avatar
Damien committed
391
392
393
394
395
396
397
398
399
400
401
402
403
404
    scope->parent = comp->scope_cur;
    scope->next = NULL;
    if (comp->scope_head == NULL) {
        comp->scope_head = scope;
    } else {
        scope_t *s = comp->scope_head;
        while (s->next != NULL) {
            s = s->next;
        }
        s->next = scope;
    }
    return scope;
}

405
406
407
typedef void (*apply_list_fun_t)(compiler_t *comp, mp_parse_node_t pn);

STATIC void apply_to_single_or_list(compiler_t *comp, mp_parse_node_t pn, pn_kind_t pn_list_kind, apply_list_fun_t f) {
408
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, pn_list_kind)) {
409
410
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
411
412
413
        for (int i = 0; i < num_nodes; i++) {
            f(comp, pns->nodes[i]);
        }
414
    } else if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
415
416
417
418
        f(comp, pn);
    }
}

419
STATIC void compile_generic_all_nodes(compiler_t *comp, mp_parse_node_struct_t *pns) {
420
    int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
421
422
    for (int i = 0; i < num_nodes; i++) {
        compile_node(comp, pns->nodes[i]);
423
424
425
426
427
        if (comp->compile_error != MP_OBJ_NULL) {
            // add line info for the error in case it didn't have a line number
            compile_error_set_line(comp, pns->nodes[i]);
            return;
        }
Damien's avatar
Damien committed
428
429
430
    }
}

431
432
433
434
STATIC void compile_load_id(compiler_t *comp, qstr qst) {
    if (comp->pass == MP_PASS_SCOPE) {
        mp_emit_common_get_id_for_load(comp->scope_cur, qst);
    } else {
435
        #if NEED_METHOD_TABLE
436
        mp_emit_common_id_op(comp->emit, &comp->emit_method_table->load_id, comp->scope_cur, qst);
437
438
439
        #else
        mp_emit_common_id_op(comp->emit, &mp_emit_bc_method_table_load_id_ops, comp->scope_cur, qst);
        #endif
440
441
442
443
444
445
446
    }
}

STATIC void compile_store_id(compiler_t *comp, qstr qst) {
    if (comp->pass == MP_PASS_SCOPE) {
        mp_emit_common_get_id_for_modification(comp->scope_cur, qst);
    } else {
447
        #if NEED_METHOD_TABLE
448
        mp_emit_common_id_op(comp->emit, &comp->emit_method_table->store_id, comp->scope_cur, qst);
449
450
451
        #else
        mp_emit_common_id_op(comp->emit, &mp_emit_bc_method_table_store_id_ops, comp->scope_cur, qst);
        #endif
452
453
454
455
456
457
458
    }
}

STATIC void compile_delete_id(compiler_t *comp, qstr qst) {
    if (comp->pass == MP_PASS_SCOPE) {
        mp_emit_common_get_id_for_modification(comp->scope_cur, qst);
    } else {
459
        #if NEED_METHOD_TABLE
460
        mp_emit_common_id_op(comp->emit, &comp->emit_method_table->delete_id, comp->scope_cur, qst);
461
462
463
        #else
        mp_emit_common_id_op(comp->emit, &mp_emit_bc_method_table_delete_id_ops, comp->scope_cur, qst);
        #endif
464
465
466
    }
}

467
#if MICROPY_EMIT_CPYTHON
468
STATIC bool cpython_c_tuple_is_const(mp_parse_node_t pn) {
469
470
471
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string)) {
        return true;
    }
472
473
474
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_bytes)) {
        return true;
    }
475
476
477
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_const_object)) {
        return true;
    }
478
    if (!MP_PARSE_NODE_IS_LEAF(pn)) {
Damien's avatar
Damien committed
479
480
        return false;
    }
481
    if (MP_PARSE_NODE_IS_ID(pn)) {
Damien's avatar
Damien committed
482
483
484
485
486
        return false;
    }
    return true;
}

487
STATIC void cpython_c_print_quoted_str(vstr_t *vstr, const char *str, uint len, bool bytes) {
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
    bool has_single_quote = false;
    bool has_double_quote = false;
    for (int i = 0; i < len; i++) {
        if (str[i] == '\'') {
            has_single_quote = true;
        } else if (str[i] == '"') {
            has_double_quote = true;
        }
    }
    if (bytes) {
        vstr_printf(vstr, "b");
    }
    bool quote_single = false;
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        quote_single = true;
        vstr_printf(vstr, "'");
    }
    for (int i = 0; i < len; i++) {
        if (str[i] == '\n') {
            vstr_printf(vstr, "\\n");
        } else if (str[i] == '\\') {
            vstr_printf(vstr, "\\\\");
        } else if (str[i] == '\'' && quote_single) {
            vstr_printf(vstr, "\\'");
        } else {
            vstr_printf(vstr, "%c", str[i]);
        }
    }
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        vstr_printf(vstr, "'");
    }
}

525
STATIC void cpython_c_tuple_emit_const(compiler_t *comp, mp_parse_node_t pn, vstr_t *vstr) {
526
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_string) || MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_bytes)) {
527
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
528
        cpython_c_print_quoted_str(vstr, (const char*)pns->nodes[0], (mp_uint_t)pns->nodes[1], MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_bytes));
529
530
531
        return;
    }

532
533
534
535
536
537
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_const_object)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        mp_obj_print((mp_obj_t)pns->nodes[0], PRINT_REPR);
        return;
    }

538
    assert(MP_PARSE_NODE_IS_LEAF(pn));
539
540
541
542
543
    if (MP_PARSE_NODE_IS_SMALL_INT(pn)) {
        vstr_printf(vstr, INT_FMT, MP_PARSE_NODE_LEAF_SMALL_INT(pn));
        return;
    }

544
    mp_uint_t arg = MP_PARSE_NODE_LEAF_ARG(pn);
545
546
    switch (MP_PARSE_NODE_LEAF_KIND(pn)) {
        case MP_PARSE_NODE_ID: assert(0);
547
548
        case MP_PARSE_NODE_STRING:
        case MP_PARSE_NODE_BYTES: {
549
            mp_uint_t len;
550
551
552
553
            const byte *str = qstr_data(arg, &len);
            cpython_c_print_quoted_str(vstr, (const char*)str, len, MP_PARSE_NODE_LEAF_KIND(pn) == MP_PARSE_NODE_BYTES);
            break;
        }
554
        case MP_PARSE_NODE_TOKEN:
Damien's avatar
Damien committed
555
            switch (arg) {
556
557
558
                case MP_TOKEN_KW_FALSE: vstr_printf(vstr, "False"); break;
                case MP_TOKEN_KW_NONE: vstr_printf(vstr, "None"); break;
                case MP_TOKEN_KW_TRUE: vstr_printf(vstr, "True"); break;
559
                default: assert(0); // shouldn't happen
Damien's avatar
Damien committed
560
561
562
563
564
565
            }
            break;
        default: assert(0);
    }
}

566
STATIC void cpython_c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
Damien's avatar
Damien committed
567
568
    int n = 0;
    if (pns_list != NULL) {
569
        n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
Damien's avatar
Damien committed
570
571
572
    }
    int total = n;
    bool is_const = true;
573
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
574
        total += 1;
575
        if (!cpython_c_tuple_is_const(pn)) {
Damien's avatar
Damien committed
576
577
578
579
            is_const = false;
        }
    }
    for (int i = 0; i < n; i++) {
580
        if (!cpython_c_tuple_is_const(pns_list->nodes[i])) {
Damien's avatar
Damien committed
581
582
583
584
585
586
            is_const = false;
            break;
        }
    }
    if (total > 0 && is_const) {
        bool need_comma = false;
587
588
        vstr_t *vstr = vstr_new();
        vstr_printf(vstr, "(");
589
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
590
            cpython_c_tuple_emit_const(comp, pn, vstr);
Damien's avatar
Damien committed
591
592
593
594
            need_comma = true;
        }
        for (int i = 0; i < n; i++) {
            if (need_comma) {
595
                vstr_printf(vstr, ", ");
Damien's avatar
Damien committed
596
            }
597
            cpython_c_tuple_emit_const(comp, pns_list->nodes[i], vstr);
Damien's avatar
Damien committed
598
599
600
            need_comma = true;
        }
        if (total == 1) {
601
            vstr_printf(vstr, ",)");
Damien's avatar
Damien committed
602
        } else {
603
            vstr_printf(vstr, ")");
Damien's avatar
Damien committed
604
        }
605
        EMIT_ARG(load_const_verbatim_strn, vstr_str(vstr), vstr_len(vstr));
606
        vstr_free(vstr);
Damien's avatar
Damien committed
607
    } else {
608
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
609
610
611
612
613
            compile_node(comp, pn);
        }
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
614
        EMIT_ARG(build_tuple, total);
Damien's avatar
Damien committed
615
616
    }
}
617
618
619
#endif

// funnelling all tuple creations through this function is purely so we can optionally agree with CPython
620
STATIC void c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
621
#if MICROPY_EMIT_CPYTHON
622
623
624
    cpython_c_tuple(comp, pn, pns_list);
#else
    int total = 0;
625
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
626
627
628
629
        compile_node(comp, pn);
        total += 1;
    }
    if (pns_list != NULL) {
630
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
631
632
633
634
635
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
        total += n;
    }
636
    EMIT_ARG(build_tuple, total);
637
638
#endif
}
Damien's avatar
Damien committed
639

640
STATIC void compile_generic_tuple(compiler_t *comp, mp_parse_node_struct_t *pns) {
Damien's avatar
Damien committed
641
    // a simple tuple expression
642
    c_tuple(comp, MP_PARSE_NODE_NULL, pns);
Damien's avatar
Damien committed
643
644
}

645
STATIC bool node_is_const_false(mp_parse_node_t pn) {
646
647
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_FALSE)
        || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) == 0);
Damien's avatar
Damien committed
648
649
}

650
STATIC bool node_is_const_true(mp_parse_node_t pn) {
651
652
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_TRUE)
        || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) != 0);
Damien's avatar
Damien committed
653
654
}

655
#if MICROPY_EMIT_CPYTHON
656
// the is_nested variable is purely to match with CPython, which doesn't fully optimise not's
657
STATIC void cpython_c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label, bool is_nested) {
Damien's avatar
Damien committed
658
659
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
660
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
661
662
663
664
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
665
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
666
667
        }
        return;
668
669
670
671
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
Damien's avatar
Damien committed
672
            if (jump_if == false) {
673
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
674
                for (int i = 0; i < n - 1; i++) {
675
                    cpython_c_if_cond(comp, pns->nodes[i], true, label2, true);
Damien's avatar
Damien committed
676
                }
677
                cpython_c_if_cond(comp, pns->nodes[n - 1], false, label, true);
678
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
679
680
            } else {
                for (int i = 0; i < n; i++) {
681
                    cpython_c_if_cond(comp, pns->nodes[i], true, label, true);
Damien's avatar
Damien committed
682
683
684
                }
            }
            return;
685
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
Damien's avatar
Damien committed
686
687
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
688
                    cpython_c_if_cond(comp, pns->nodes[i], false, label, true);
Damien's avatar
Damien committed
689
690
                }
            } else {
691
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
692
                for (int i = 0; i < n - 1; i++) {
693
                    cpython_c_if_cond(comp, pns->nodes[i], false, label2, true);
Damien's avatar
Damien committed
694
                }
695
                cpython_c_if_cond(comp, pns->nodes[n - 1], true, label, true);
696
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
697
698
            }
            return;
699
        } else if (!is_nested && MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
700
            cpython_c_if_cond(comp, pns->nodes[0], !jump_if, label, true);
Damien's avatar
Damien committed
701
702
703
704
705
706
            return;
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
707
    EMIT_ARG(pop_jump_if, jump_if, label);
Damien's avatar
Damien committed
708
}
709
#endif
Damien's avatar
Damien committed
710

711
STATIC void c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label) {
712
#if MICROPY_EMIT_CPYTHON
713
714
715
716
    cpython_c_if_cond(comp, pn, jump_if, label, false);
#else
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
717
            EMIT_ARG(jump, label);
718
719
720
721
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
722
            EMIT_ARG(jump, label);
723
724
        }
        return;
725
726
727
728
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
729
            if (jump_if == false) {
730
            and_or_logic1:;
731
                uint label2 = comp_next_label(comp);
732
                for (int i = 0; i < n - 1; i++) {
733
                    c_if_cond(comp, pns->nodes[i], !jump_if, label2);
734
                }
735
                c_if_cond(comp, pns->nodes[n - 1], jump_if, label);
736
                EMIT_ARG(label_assign, label2);
737
            } else {
738
            and_or_logic2:
739
                for (int i = 0; i < n; i++) {
740
                    c_if_cond(comp, pns->nodes[i], jump_if, label);
741
742
743
                }
            }
            return;
744
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
745
            if (jump_if == false) {
746
                goto and_or_logic2;
747
            } else {
748
                goto and_or_logic1;
749
            }
750
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
751
752
            c_if_cond(comp, pns->nodes[0], !jump_if, label);
            return;
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_atom_paren) {
            // cond is something in parenthesis
            if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
                // empty tuple, acts as false for the condition
                if (jump_if == false) {
                    EMIT_ARG(jump, label);
                }
            } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                // non-empty tuple, acts as true for the condition
                if (jump_if == true) {
                    EMIT_ARG(jump, label);
                }
            } else {
                // parenthesis around 1 item, is just that item
                c_if_cond(comp, pns->nodes[0], jump_if, label);
            }
            return;
770
771
772
773
774
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
775
    EMIT_ARG(pop_jump_if, jump_if, label);
776
#endif
Damien's avatar
Damien committed
777
778
779
}

typedef enum { ASSIGN_STORE, ASSIGN_AUG_LOAD, ASSIGN_AUG_STORE } assign_kind_t;
780
STATIC void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t kind);
Damien's avatar
Damien committed
781

782
STATIC void c_assign_power(compiler_t *comp, mp_parse_node_struct_t *pns, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
783
784
785
786
    if (assign_kind != ASSIGN_AUG_STORE) {
        compile_node(comp, pns->nodes[0]);
    }

787
788
789
790
    if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
        mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_power_trailers) {
            int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns1);
Damien's avatar
Damien committed
791
792
793
794
795
            if (assign_kind != ASSIGN_AUG_STORE) {
                for (int i = 0; i < n - 1; i++) {
                    compile_node(comp, pns1->nodes[i]);
                }
            }
796
797
            assert(MP_PARSE_NODE_IS_STRUCT(pns1->nodes[n - 1]));
            pns1 = (mp_parse_node_struct_t*)pns1->nodes[n - 1];
Damien's avatar
Damien committed
798
        }
799
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_bracket) {
Damien's avatar
Damien committed
800
801
802
803
804
805
806
            if (assign_kind == ASSIGN_AUG_STORE) {
                EMIT(rot_three);
                EMIT(store_subscr);
            } else {
                compile_node(comp, pns1->nodes[0]);
                if (assign_kind == ASSIGN_AUG_LOAD) {
                    EMIT(dup_top_two);
807
                    EMIT(load_subscr);
Damien's avatar
Damien committed
808
809
810
811
                } else {
                    EMIT(store_subscr);
                }
            }
812
813
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_period) {
            assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
Damien's avatar
Damien committed
814
815
            if (assign_kind == ASSIGN_AUG_LOAD) {
                EMIT(dup_top);
816
                EMIT_ARG(load_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
817
818
819
820
            } else {
                if (assign_kind == ASSIGN_AUG_STORE) {
                    EMIT(rot_two);
                }
821
                EMIT_ARG(store_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
822
823
            }
        } else {
824
            goto cannot_assign;
Damien's avatar
Damien committed
825
826
        }
    } else {
827
        goto cannot_assign;
Damien's avatar
Damien committed
828
829
    }

830
    if (!MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
831
        goto cannot_assign;
Damien's avatar
Damien committed
832
    }
833
834
835
836
837

    return;

cannot_assign:
    compile_syntax_error(comp, (mp_parse_node_t)pns, "can't assign to expression");
Damien's avatar
Damien committed
838
839
}

840
// we need to allow for a caller passing in 1 initial node (node_head) followed by an array of nodes (nodes_tail)
841
STATIC void c_assign_tuple(compiler_t *comp, mp_parse_node_t node_head, uint num_tail, mp_parse_node_t *nodes_tail) {
842
843
844
    uint num_head = (node_head == MP_PARSE_NODE_NULL) ? 0 : 1;

    // look for star expression
845
    uint have_star_index = -1;
846
847
848
849
    if (num_head != 0 && MP_PARSE_NODE_IS_STRUCT_KIND(node_head, PN_star_expr)) {
        EMIT_ARG(unpack_ex, 0, num_tail);
        have_star_index = 0;
    }
850
    for (uint i = 0; i < num_tail; i++) {
851
        if (MP_PARSE_NODE_IS_STRUCT_KIND(nodes_tail[i], PN_star_expr)) {
852
            if (have_star_index == (uint)-1) {
853
854
                EMIT_ARG(unpack_ex, num_head + i, num_tail - i - 1);
                have_star_index = num_head + i;
Damien's avatar
Damien committed
855
            } else {
856
                compile_syntax_error(comp, nodes_tail[i], "multiple *x in assignment");
Damien's avatar
Damien committed
857
858
859
860
                return;
            }
        }
    }
861
    if (have_star_index == (uint)-1) {
862
        EMIT_ARG(unpack_sequence, num_head + num_tail);
Damien's avatar
Damien committed
863
    }
864
865
866
    if (num_head != 0) {
        if (0 == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)node_head)->nodes[0], ASSIGN_STORE);
Damien's avatar
Damien committed
867
        } else {
868
869
870
            c_assign(comp, node_head, ASSIGN_STORE);
        }
    }
871
    for (uint i = 0; i < num_tail; i++) {
872
873
874
875
        if (num_head + i == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)nodes_tail[i])->nodes[0], ASSIGN_STORE);
        } else {
            c_assign(comp, nodes_tail[i], ASSIGN_STORE);
Damien's avatar
Damien committed
876
877
878
879
880
        }
    }
}

// assigns top of stack to pn
881
STATIC void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
882
    tail_recursion:
883
884
    assert(!MP_PARSE_NODE_IS_NULL(pn));
    if (MP_PARSE_NODE_IS_LEAF(pn)) {
885
        if (MP_PARSE_NODE_IS_ID(pn)) {
886
            qstr arg = MP_PARSE_NODE_LEAF_ARG(pn);
Damien's avatar
Damien committed
887
888
889
            switch (assign_kind) {
                case ASSIGN_STORE:
                case ASSIGN_AUG_STORE:
890
                    compile_store_id(comp, arg);
Damien's avatar
Damien committed
891
892
                    break;
                case ASSIGN_AUG_LOAD:
893
                default:
894
                    compile_load_id(comp, arg);
Damien's avatar
Damien committed
895
896
897
                    break;
            }
        } else {
898
            compile_syntax_error(comp, pn, "can't assign to literal");
Damien's avatar
Damien committed
899
900
901
            return;
        }
    } else {
902
        // pn must be a struct
903
904
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
Damien's avatar
Damien committed
905
906
907
908
909
910
911
912
913
914
915
            case PN_power:
                // lhs is an index or attribute
                c_assign_power(comp, pns, assign_kind);
                break;

            case PN_testlist_star_expr:
            case PN_exprlist:
                // lhs is a tuple
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
916
                c_assign_tuple(comp, MP_PARSE_NODE_NULL, MP_PARSE_NODE_STRUCT_NUM_NODES(pns), pns->nodes);
Damien's avatar
Damien committed
917
918
919
920
                break;

            case PN_atom_paren:
                // lhs is something in parenthesis
921
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
922
                    // empty tuple
923
                    goto cannot_assign;
924
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
925
926
927
                    if (assign_kind != ASSIGN_STORE) {
                        goto bad_aug;
                    }
928
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
929
930
931
932
933
934
935
936
937
938
939
940
941
                    goto testlist_comp;
                } else {
                    // parenthesis around 1 item, is just that item
                    pn = pns->nodes[0];
                    goto tail_recursion;
                }
                break;

            case PN_atom_bracket:
                // lhs is something in brackets
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
942
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
943
                    // empty list, assignment allowed
944
                    c_assign_tuple(comp, MP_PARSE_NODE_NULL, 0, NULL);
945
946
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
947
948
949
                    goto testlist_comp;
                } else {
                    // brackets around 1 item
950
                    c_assign_tuple(comp, pns->nodes[0], 0, NULL);
Damien's avatar
Damien committed
951
952
953
954
                }
                break;

            default:
955
                goto cannot_assign;
Damien's avatar
Damien committed
956
957
958
959
960
        }
        return;

        testlist_comp:
        // lhs is a sequence
961
962
963
        if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
            mp_parse_node_struct_t *pns2 = (mp_parse_node_struct_t*)pns->nodes[1];
            if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3b) {
Damien's avatar
Damien committed
964
                // sequence of one item, with trailing comma
965
                assert(MP_PARSE_NODE_IS_NULL(pns2->nodes[0]));
966
                c_assign_tuple(comp, pns->nodes[0], 0, NULL);
967
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3c) {
Damien's avatar
Damien committed
968
<