compile.c 139 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
/*
 * This file is part of the Micro Python project, http://micropython.org/
 *
 * The MIT License (MIT)
 *
 * Copyright (c) 2013, 2014 Damien P. George
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

xbe's avatar
xbe committed
27
#include <stdbool.h>
Damien's avatar
Damien committed
28
29
30
31
#include <stdint.h>
#include <stdio.h>
#include <string.h>
#include <assert.h>
32
#include <math.h>
Damien's avatar
Damien committed
33
34

#include "misc.h"
35
#include "mpconfig.h"
36
#include "qstr.h"
Damien's avatar
Damien committed
37
38
#include "lexer.h"
#include "parse.h"
39
#include "runtime0.h"
40
#include "obj.h"
41
42
43
#include "emitglue.h"
#include "scope.h"
#include "emit.h"
44
45
#include "compile.h"
#include "runtime.h"
46
#include "builtin.h"
47
#include "smallint.h"
Damien's avatar
Damien committed
48
49
50

// TODO need to mangle __attr names

51
52
#define MICROPY_EMIT_NATIVE (MICROPY_EMIT_X64 || MICROPY_EMIT_THUMB)

Damien's avatar
Damien committed
53
54
typedef enum {
    PN_none = 0,
55
#define DEF_RULE(rule, comp, kind, ...) PN_##rule,
Damien's avatar
Damien committed
56
57
58
59
60
#include "grammar.h"
#undef DEF_RULE
    PN_maximum_number_of,
} pn_kind_t;

61
62
63
64
#define EMIT(fun) (comp->emit_method_table->fun(comp->emit))
#define EMIT_ARG(fun, ...) (comp->emit_method_table->fun(comp->emit, __VA_ARGS__))
#define EMIT_INLINE_ASM(fun) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm))
#define EMIT_INLINE_ASM_ARG(fun, ...) (comp->emit_inline_asm_method_table->fun(comp->emit_inline_asm, __VA_ARGS__))
Damien's avatar
Damien committed
65
66

typedef struct _compiler_t {
67
    qstr source_file;
68
69
70
71
    uint8_t is_repl;
    uint8_t pass; // holds enum type pass_kind_t
    uint8_t had_error; // try to keep compiler clean from nlr
    uint8_t func_arg_is_super; // used to compile special case of super() function call
Damien's avatar
Damien committed
72

73
    uint next_label;
74

75
76
    uint break_label;
    uint continue_label;
77
    int break_continue_except_level;
78
    uint16_t cur_except_level; // increased for SETUP_EXCEPT, SETUP_FINALLY; decreased for POP_BLOCK, POP_EXCEPT
Damien's avatar
Damien committed
79

80
    uint8_t have_star;
81
82
    uint16_t num_dict_params;
    uint16_t num_default_params;
Damien's avatar
Damien committed
83
84
85
86

    scope_t *scope_head;
    scope_t *scope_cur;

87
88
    emit_t *emit;                                   // current emitter
    const emit_method_table_t *emit_method_table;   // current emit method table
89
90
91

    emit_inline_asm_t *emit_inline_asm;                                   // current emitter for inline asm
    const emit_inline_asm_method_table_t *emit_inline_asm_method_table;   // current emit method table for inline asm
Damien's avatar
Damien committed
92
93
} compiler_t;

94
STATIC void compile_syntax_error(compiler_t *comp, mp_parse_node_t pn, const char *msg) {
95
    // TODO store the error message to a variable in compiler_t instead of printing it
96
97
98
99
100
    if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        printf("  File \"%s\", line " UINT_FMT "\n", qstr_str(comp->source_file), (machine_uint_t)((mp_parse_node_struct_t*)pn)->source_line);
    } else {
        printf("  File \"%s\"\n", qstr_str(comp->source_file));
    }
101
102
103
104
    printf("SyntaxError: %s\n", msg);
    comp->had_error = true;
}

105
106
107
108
109
110
111
112
STATIC const mp_map_elem_t mp_constants_table[] = {
    // Extra constants as defined by a port
    MICROPY_EXTRA_CONSTANTS
};

STATIC const mp_map_t mp_constants_map = {
    .all_keys_are_qstrs = 1,
    .table_is_fixed_array = 1,
113
114
    .used = ARRAY_SIZE(mp_constants_table),
    .alloc = ARRAY_SIZE(mp_constants_table),
115
116
117
    .table = (mp_map_elem_t*)mp_constants_table,
};

118
STATIC mp_parse_node_t fold_constants(mp_parse_node_t pn) {
119
120
121
    if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
122
123
124
125
126
127

        // fold arguments first
        for (int i = 0; i < n; i++) {
            pns->nodes[i] = fold_constants(pns->nodes[i]);
        }

128
        // now try to fold this parse node
129
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
            case PN_atom_paren:
                if (n == 1 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0])) {
                    // (int)
                    pn = pns->nodes[0];
                }
                break;

            case PN_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int | int
                    machine_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    machine_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 | arg1);
                }
                break;

            case PN_and_expr:
                if (n == 2 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
                    // int & int
                    machine_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    machine_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
                    pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 & arg1);
                }
                break;

Damien's avatar
Damien committed
155
            case PN_shift_expr:
156
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
157
158
                    machine_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    machine_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
159
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_LESS)) {
160
161
162
163
                        // int << int
                        if (!(arg1 >= BITS_PER_WORD || arg0 > (MP_SMALL_INT_MAX >> arg1) || arg0 < (MP_SMALL_INT_MIN >> arg1))) {
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 << arg1);
                        }
164
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_MORE)) {
165
                        // int >> int
166
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0 >> arg1);
Damien's avatar
Damien committed
167
168
169
170
171
172
173
174
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_arith_expr:
175
                // overflow checking here relies on SMALL_INT being strictly smaller than machine_int_t
176
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
177
178
                    machine_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    machine_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
179
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PLUS)) {
180
                        // int + int
181
                        arg0 += arg1;
182
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_MINUS)) {
183
                        // int - int
184
                        arg0 -= arg1;
Damien's avatar
Damien committed
185
186
187
                    } else {
                        // shouldn't happen
                        assert(0);
188
                    }
189
                    if (MP_PARSE_FITS_SMALL_INT(arg0)) {
190
                        //printf("%ld + %ld\n", arg0, arg1);
191
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
Damien's avatar
Damien committed
192
193
194
195
196
                    }
                }
                break;

            case PN_term:
197
                if (n == 3 && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[2])) {
198
199
                    machine_int_t arg0 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
                    machine_int_t arg1 = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[2]);
200
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_STAR)) {
201
                        // int * int
202
203
204
205
206
207
                        if (!mp_small_int_mul_overflow(arg0, arg1)) {
                            arg0 *= arg1;
                            if (MP_PARSE_FITS_SMALL_INT(arg0)) {
                                pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg0);
                            }
                        }
208
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_SLASH)) {
209
210
                        // int / int
                        // pass
211
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_PERCENT)) {
212
                        // int%int
213
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_modulo(arg0, arg1));
214
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[1], MP_TOKEN_OP_DBL_SLASH)) {
215
                        if (arg1 != 0) {
216
                            // int // int
217
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, mp_small_int_floor_divide(arg0, arg1));
218
                        }
Damien's avatar
Damien committed
219
220
221
222
223
224
225
226
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_factor_2:
227
                if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[1])) {
228
                    machine_int_t arg = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[1]);
229
                    if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_PLUS)) {
230
                        // +int
231
232
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_MINUS)) {
233
                        // -int
234
235
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, -arg);
                    } else if (MP_PARSE_NODE_IS_TOKEN_KIND(pns->nodes[0], MP_TOKEN_OP_TILDE)) {
236
                        // ~int
237
                        pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ~arg);
Damien's avatar
Damien committed
238
239
240
241
242
243
244
245
                    } else {
                        // shouldn't happen
                        assert(0);
                    }
                }
                break;

            case PN_power:
246
247
248
                if (0) {
#if MICROPY_EMIT_CPYTHON
                } else if (MP_PARSE_NODE_IS_SMALL_INT(pns->nodes[0]) && MP_PARSE_NODE_IS_NULL(pns->nodes[1]) && !MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
249
                    // int ** x
250
                    // can overflow; enabled only to compare with CPython
251
252
                    mp_parse_node_struct_t* pns2 = (mp_parse_node_struct_t*)pns->nodes[2];
                    if (MP_PARSE_NODE_IS_SMALL_INT(pns2->nodes[0])) {
253
                        int power = MP_PARSE_NODE_LEAF_SMALL_INT(pns2->nodes[0]);
Damien's avatar
Damien committed
254
255
                        if (power >= 0) {
                            int ans = 1;
256
                            int base = MP_PARSE_NODE_LEAF_SMALL_INT(pns->nodes[0]);
Damien's avatar
Damien committed
257
258
259
                            for (; power > 0; power--) {
                                ans *= base;
                            }
260
                            pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, ans);
Damien's avatar
Damien committed
261
262
                        }
                    }
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
#endif
                } else if (MP_PARSE_NODE_IS_ID(pns->nodes[0]) && MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[1], PN_trailer_period) && MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
                    // id.id
                    // look it up in constant table, see if it can be replaced with an integer
                    mp_parse_node_struct_t* pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
                    assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
                    qstr q_base = MP_PARSE_NODE_LEAF_ARG(pns->nodes[0]);
                    qstr q_attr = MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]);
                    mp_map_elem_t *elem = mp_map_lookup((mp_map_t*)&mp_constants_map, MP_OBJ_NEW_QSTR(q_base), MP_MAP_LOOKUP);
                    if (elem != NULL) {
                        mp_obj_t dest[2];
                        mp_load_method_maybe(elem->value, q_attr, dest);
                        if (MP_OBJ_IS_SMALL_INT(dest[0]) && dest[1] == NULL) {
                            machine_int_t val = MP_OBJ_SMALL_INT_VALUE(dest[0]);
                            if (MP_PARSE_FITS_SMALL_INT(val)) {
                                pn = mp_parse_node_new_leaf(MP_PARSE_NODE_SMALL_INT, val);
                            }
                        }
                    }
Damien's avatar
Damien committed
282
283
284
285
286
287
288
289
                }
                break;
        }
    }

    return pn;
}

290
STATIC void compile_trailer_paren_helper(compiler_t *comp, mp_parse_node_t pn_arglist, bool is_method_call, int n_positional_extra);
291
void compile_comprehension(compiler_t *comp, mp_parse_node_struct_t *pns, scope_kind_t kind);
292
STATIC void compile_node(compiler_t *comp, mp_parse_node_t pn);
Damien's avatar
Damien committed
293

294
STATIC uint comp_next_label(compiler_t *comp) {
295
296
297
    return comp->next_label++;
}

298
299
300
301
302
303
304
305
306
307
308
309
STATIC void compile_increase_except_level(compiler_t *comp) {
    comp->cur_except_level += 1;
    if (comp->cur_except_level > comp->scope_cur->exc_stack_size) {
        comp->scope_cur->exc_stack_size = comp->cur_except_level;
    }
}

STATIC void compile_decrease_except_level(compiler_t *comp) {
    assert(comp->cur_except_level > 0);
    comp->cur_except_level -= 1;
}

310
STATIC scope_t *scope_new_and_link(compiler_t *comp, scope_kind_t kind, mp_parse_node_t pn, uint emit_options) {
311
    scope_t *scope = scope_new(kind, pn, comp->source_file, emit_options);
Damien's avatar
Damien committed
312
313
314
315
316
317
318
319
320
321
322
323
324
325
    scope->parent = comp->scope_cur;
    scope->next = NULL;
    if (comp->scope_head == NULL) {
        comp->scope_head = scope;
    } else {
        scope_t *s = comp->scope_head;
        while (s->next != NULL) {
            s = s->next;
        }
        s->next = scope;
    }
    return scope;
}

326
STATIC void apply_to_single_or_list(compiler_t *comp, mp_parse_node_t pn, int pn_list_kind, void (*f)(compiler_t*, mp_parse_node_t)) {
327
328
329
    if (MP_PARSE_NODE_IS_STRUCT(pn) && MP_PARSE_NODE_STRUCT_KIND((mp_parse_node_struct_t*)pn) == pn_list_kind) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
330
331
332
        for (int i = 0; i < num_nodes; i++) {
            f(comp, pns->nodes[i]);
        }
333
    } else if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
334
335
336
337
        f(comp, pn);
    }
}

338
STATIC int list_get(mp_parse_node_t *pn, int pn_kind, mp_parse_node_t **nodes) {
339
    if (MP_PARSE_NODE_IS_NULL(*pn)) {
Damien's avatar
Damien committed
340
341
        *nodes = NULL;
        return 0;
342
    } else if (MP_PARSE_NODE_IS_LEAF(*pn)) {
Damien's avatar
Damien committed
343
344
345
        *nodes = pn;
        return 1;
    } else {
346
347
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)(*pn);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) != pn_kind) {
Damien's avatar
Damien committed
348
349
350
351
            *nodes = pn;
            return 1;
        } else {
            *nodes = pns->nodes;
352
            return MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
353
354
355
356
        }
    }
}

357
void compile_do_nothing(compiler_t *comp, mp_parse_node_struct_t *pns) {
Damien's avatar
Damien committed
358
359
}

360
361
void compile_generic_all_nodes(compiler_t *comp, mp_parse_node_struct_t *pns) {
    int num_nodes = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
Damien's avatar
Damien committed
362
363
364
365
366
    for (int i = 0; i < num_nodes; i++) {
        compile_node(comp, pns->nodes[i]);
    }
}

367
#if MICROPY_EMIT_CPYTHON
368
STATIC bool cpython_c_tuple_is_const(mp_parse_node_t pn) {
369
    if (!MP_PARSE_NODE_IS_LEAF(pn)) {
Damien's avatar
Damien committed
370
371
        return false;
    }
372
    if (MP_PARSE_NODE_IS_ID(pn)) {
Damien's avatar
Damien committed
373
374
375
376
377
        return false;
    }
    return true;
}

378
STATIC void cpython_c_print_quoted_str(vstr_t *vstr, qstr qstr, bool bytes) {
379
380
    uint len;
    const byte *str = qstr_data(qstr, &len);
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
    bool has_single_quote = false;
    bool has_double_quote = false;
    for (int i = 0; i < len; i++) {
        if (str[i] == '\'') {
            has_single_quote = true;
        } else if (str[i] == '"') {
            has_double_quote = true;
        }
    }
    if (bytes) {
        vstr_printf(vstr, "b");
    }
    bool quote_single = false;
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        quote_single = true;
        vstr_printf(vstr, "'");
    }
    for (int i = 0; i < len; i++) {
        if (str[i] == '\n') {
            vstr_printf(vstr, "\\n");
        } else if (str[i] == '\\') {
            vstr_printf(vstr, "\\\\");
        } else if (str[i] == '\'' && quote_single) {
            vstr_printf(vstr, "\\'");
        } else {
            vstr_printf(vstr, "%c", str[i]);
        }
    }
    if (has_single_quote && !has_double_quote) {
        vstr_printf(vstr, "\"");
    } else {
        vstr_printf(vstr, "'");
    }
}

418
STATIC void cpython_c_tuple_emit_const(compiler_t *comp, mp_parse_node_t pn, vstr_t *vstr) {
419
    assert(MP_PARSE_NODE_IS_LEAF(pn));
420
421
422
423
424
    if (MP_PARSE_NODE_IS_SMALL_INT(pn)) {
        vstr_printf(vstr, INT_FMT, MP_PARSE_NODE_LEAF_SMALL_INT(pn));
        return;
    }

425
426
427
428
429
430
431
432
    int arg = MP_PARSE_NODE_LEAF_ARG(pn);
    switch (MP_PARSE_NODE_LEAF_KIND(pn)) {
        case MP_PARSE_NODE_ID: assert(0);
        case MP_PARSE_NODE_INTEGER: vstr_printf(vstr, "%s", qstr_str(arg)); break;
        case MP_PARSE_NODE_DECIMAL: vstr_printf(vstr, "%s", qstr_str(arg)); break;
        case MP_PARSE_NODE_STRING: cpython_c_print_quoted_str(vstr, arg, false); break;
        case MP_PARSE_NODE_BYTES: cpython_c_print_quoted_str(vstr, arg, true); break;
        case MP_PARSE_NODE_TOKEN:
Damien's avatar
Damien committed
433
            switch (arg) {
434
435
436
                case MP_TOKEN_KW_FALSE: vstr_printf(vstr, "False"); break;
                case MP_TOKEN_KW_NONE: vstr_printf(vstr, "None"); break;
                case MP_TOKEN_KW_TRUE: vstr_printf(vstr, "True"); break;
437
                default: assert(0); // shouldn't happen
Damien's avatar
Damien committed
438
439
440
441
442
443
            }
            break;
        default: assert(0);
    }
}

444
STATIC void cpython_c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
Damien's avatar
Damien committed
445
446
    int n = 0;
    if (pns_list != NULL) {
447
        n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
Damien's avatar
Damien committed
448
449
450
    }
    int total = n;
    bool is_const = true;
451
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
452
        total += 1;
453
        if (!cpython_c_tuple_is_const(pn)) {
Damien's avatar
Damien committed
454
455
456
457
            is_const = false;
        }
    }
    for (int i = 0; i < n; i++) {
458
        if (!cpython_c_tuple_is_const(pns_list->nodes[i])) {
Damien's avatar
Damien committed
459
460
461
462
463
464
            is_const = false;
            break;
        }
    }
    if (total > 0 && is_const) {
        bool need_comma = false;
465
466
        vstr_t *vstr = vstr_new();
        vstr_printf(vstr, "(");
467
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
468
            cpython_c_tuple_emit_const(comp, pn, vstr);
Damien's avatar
Damien committed
469
470
471
472
            need_comma = true;
        }
        for (int i = 0; i < n; i++) {
            if (need_comma) {
473
                vstr_printf(vstr, ", ");
Damien's avatar
Damien committed
474
            }
475
            cpython_c_tuple_emit_const(comp, pns_list->nodes[i], vstr);
Damien's avatar
Damien committed
476
477
478
            need_comma = true;
        }
        if (total == 1) {
479
            vstr_printf(vstr, ",)");
Damien's avatar
Damien committed
480
        } else {
481
            vstr_printf(vstr, ")");
Damien's avatar
Damien committed
482
        }
483
        EMIT_ARG(load_const_verbatim_str, vstr_str(vstr));
484
        vstr_free(vstr);
Damien's avatar
Damien committed
485
    } else {
486
        if (!MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
487
488
489
490
491
            compile_node(comp, pn);
        }
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
492
        EMIT_ARG(build_tuple, total);
Damien's avatar
Damien committed
493
494
    }
}
495
496
497
#endif

// funnelling all tuple creations through this function is purely so we can optionally agree with CPython
498
STATIC void c_tuple(compiler_t *comp, mp_parse_node_t pn, mp_parse_node_struct_t *pns_list) {
499
#if MICROPY_EMIT_CPYTHON
500
501
502
    cpython_c_tuple(comp, pn, pns_list);
#else
    int total = 0;
503
    if (!MP_PARSE_NODE_IS_NULL(pn)) {
504
505
506
507
        compile_node(comp, pn);
        total += 1;
    }
    if (pns_list != NULL) {
508
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns_list);
509
510
511
512
513
        for (int i = 0; i < n; i++) {
            compile_node(comp, pns_list->nodes[i]);
        }
        total += n;
    }
514
    EMIT_ARG(build_tuple, total);
515
516
#endif
}
Damien's avatar
Damien committed
517

518
void compile_generic_tuple(compiler_t *comp, mp_parse_node_struct_t *pns) {
Damien's avatar
Damien committed
519
    // a simple tuple expression
520
    c_tuple(comp, MP_PARSE_NODE_NULL, pns);
Damien's avatar
Damien committed
521
522
}

523
STATIC bool node_is_const_false(mp_parse_node_t pn) {
524
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_FALSE);
525
    // untested: || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) == 0);
Damien's avatar
Damien committed
526
527
}

528
STATIC bool node_is_const_true(mp_parse_node_t pn) {
529
    return MP_PARSE_NODE_IS_TOKEN_KIND(pn, MP_TOKEN_KW_TRUE) || (MP_PARSE_NODE_IS_SMALL_INT(pn) && MP_PARSE_NODE_LEAF_SMALL_INT(pn) == 1);
Damien's avatar
Damien committed
530
531
}

532
#if MICROPY_EMIT_CPYTHON
533
// the is_nested variable is purely to match with CPython, which doesn't fully optimise not's
534
STATIC void cpython_c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label, bool is_nested) {
Damien's avatar
Damien committed
535
536
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
537
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
538
539
540
541
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
542
            EMIT_ARG(jump, label);
Damien's avatar
Damien committed
543
544
        }
        return;
545
546
547
548
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
Damien's avatar
Damien committed
549
            if (jump_if == false) {
550
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
551
                for (int i = 0; i < n - 1; i++) {
552
                    cpython_c_if_cond(comp, pns->nodes[i], true, label2, true);
Damien's avatar
Damien committed
553
                }
554
                cpython_c_if_cond(comp, pns->nodes[n - 1], false, label, true);
555
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
556
557
            } else {
                for (int i = 0; i < n; i++) {
558
                    cpython_c_if_cond(comp, pns->nodes[i], true, label, true);
Damien's avatar
Damien committed
559
560
561
                }
            }
            return;
562
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
Damien's avatar
Damien committed
563
564
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
565
                    cpython_c_if_cond(comp, pns->nodes[i], false, label, true);
Damien's avatar
Damien committed
566
567
                }
            } else {
568
                uint label2 = comp_next_label(comp);
Damien's avatar
Damien committed
569
                for (int i = 0; i < n - 1; i++) {
570
                    cpython_c_if_cond(comp, pns->nodes[i], false, label2, true);
Damien's avatar
Damien committed
571
                }
572
                cpython_c_if_cond(comp, pns->nodes[n - 1], true, label, true);
573
                EMIT_ARG(label_assign, label2);
Damien's avatar
Damien committed
574
575
            }
            return;
576
        } else if (!is_nested && MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
577
            cpython_c_if_cond(comp, pns->nodes[0], !jump_if, label, true);
Damien's avatar
Damien committed
578
579
580
581
582
583
584
            return;
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
    if (jump_if == false) {
585
        EMIT_ARG(pop_jump_if_false, label);
Damien's avatar
Damien committed
586
    } else {
587
        EMIT_ARG(pop_jump_if_true, label);
Damien's avatar
Damien committed
588
589
    }
}
590
#endif
Damien's avatar
Damien committed
591

592
STATIC void c_if_cond(compiler_t *comp, mp_parse_node_t pn, bool jump_if, int label) {
593
#if MICROPY_EMIT_CPYTHON
594
595
596
597
    cpython_c_if_cond(comp, pn, jump_if, label, false);
#else
    if (node_is_const_false(pn)) {
        if (jump_if == false) {
598
            EMIT_ARG(jump, label);
599
600
601
602
        }
        return;
    } else if (node_is_const_true(pn)) {
        if (jump_if == true) {
603
            EMIT_ARG(jump, label);
604
605
        }
        return;
606
607
608
609
    } else if (MP_PARSE_NODE_IS_STRUCT(pn)) {
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns);
        if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_or_test) {
610
            if (jump_if == false) {
611
                uint label2 = comp_next_label(comp);
612
613
614
615
                for (int i = 0; i < n - 1; i++) {
                    c_if_cond(comp, pns->nodes[i], true, label2);
                }
                c_if_cond(comp, pns->nodes[n - 1], false, label);
616
                EMIT_ARG(label_assign, label2);
617
618
619
620
621
622
            } else {
                for (int i = 0; i < n; i++) {
                    c_if_cond(comp, pns->nodes[i], true, label);
                }
            }
            return;
623
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_and_test) {
624
625
626
627
628
            if (jump_if == false) {
                for (int i = 0; i < n; i++) {
                    c_if_cond(comp, pns->nodes[i], false, label);
                }
            } else {
629
                uint label2 = comp_next_label(comp);
630
631
632
633
                for (int i = 0; i < n - 1; i++) {
                    c_if_cond(comp, pns->nodes[i], false, label2);
                }
                c_if_cond(comp, pns->nodes[n - 1], true, label);
634
                EMIT_ARG(label_assign, label2);
635
636
            }
            return;
637
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_not_test_2) {
638
639
640
641
642
643
644
645
            c_if_cond(comp, pns->nodes[0], !jump_if, label);
            return;
        }
    }

    // nothing special, fall back to default compiling for node and jump
    compile_node(comp, pn);
    if (jump_if == false) {
646
        EMIT_ARG(pop_jump_if_false, label);
647
    } else {
648
        EMIT_ARG(pop_jump_if_true, label);
649
650
    }
#endif
Damien's avatar
Damien committed
651
652
653
}

typedef enum { ASSIGN_STORE, ASSIGN_AUG_LOAD, ASSIGN_AUG_STORE } assign_kind_t;
654
void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t kind);
Damien's avatar
Damien committed
655

656
void c_assign_power(compiler_t *comp, mp_parse_node_struct_t *pns, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
657
658
659
660
    if (assign_kind != ASSIGN_AUG_STORE) {
        compile_node(comp, pns->nodes[0]);
    }

661
662
663
664
    if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
        mp_parse_node_struct_t *pns1 = (mp_parse_node_struct_t*)pns->nodes[1];
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_power_trailers) {
            int n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns1);
Damien's avatar
Damien committed
665
666
667
668
669
            if (assign_kind != ASSIGN_AUG_STORE) {
                for (int i = 0; i < n - 1; i++) {
                    compile_node(comp, pns1->nodes[i]);
                }
            }
670
671
            assert(MP_PARSE_NODE_IS_STRUCT(pns1->nodes[n - 1]));
            pns1 = (mp_parse_node_struct_t*)pns1->nodes[n - 1];
Damien's avatar
Damien committed
672
        }
673
        if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_paren) {
674
            goto cannot_assign;
675
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_bracket) {
Damien's avatar
Damien committed
676
677
678
679
680
681
682
            if (assign_kind == ASSIGN_AUG_STORE) {
                EMIT(rot_three);
                EMIT(store_subscr);
            } else {
                compile_node(comp, pns1->nodes[0]);
                if (assign_kind == ASSIGN_AUG_LOAD) {
                    EMIT(dup_top_two);
683
                    EMIT(load_subscr);
Damien's avatar
Damien committed
684
685
686
687
                } else {
                    EMIT(store_subscr);
                }
            }
688
689
        } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_period) {
            assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
Damien's avatar
Damien committed
690
691
            if (assign_kind == ASSIGN_AUG_LOAD) {
                EMIT(dup_top);
692
                EMIT_ARG(load_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
693
694
695
696
            } else {
                if (assign_kind == ASSIGN_AUG_STORE) {
                    EMIT(rot_two);
                }
697
                EMIT_ARG(store_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
Damien's avatar
Damien committed
698
699
            }
        } else {
700
            goto cannot_assign;
Damien's avatar
Damien committed
701
702
        }
    } else {
703
        goto cannot_assign;
Damien's avatar
Damien committed
704
705
    }

706
    if (!MP_PARSE_NODE_IS_NULL(pns->nodes[2])) {
707
        goto cannot_assign;
Damien's avatar
Damien committed
708
    }
709
710
711
712
713

    return;

cannot_assign:
    compile_syntax_error(comp, (mp_parse_node_t)pns, "can't assign to expression");
Damien's avatar
Damien committed
714
715
}

716
717
718
719
720
// we need to allow for a caller passing in 1 initial node (node_head) followed by an array of nodes (nodes_tail)
void c_assign_tuple(compiler_t *comp, mp_parse_node_t node_head, uint num_tail, mp_parse_node_t *nodes_tail) {
    uint num_head = (node_head == MP_PARSE_NODE_NULL) ? 0 : 1;

    // look for star expression
Damien's avatar
Damien committed
721
    int have_star_index = -1;
722
723
724
725
726
727
    if (num_head != 0 && MP_PARSE_NODE_IS_STRUCT_KIND(node_head, PN_star_expr)) {
        EMIT_ARG(unpack_ex, 0, num_tail);
        have_star_index = 0;
    }
    for (int i = 0; i < num_tail; i++) {
        if (MP_PARSE_NODE_IS_STRUCT_KIND(nodes_tail[i], PN_star_expr)) {
Damien's avatar
Damien committed
728
            if (have_star_index < 0) {
729
730
                EMIT_ARG(unpack_ex, num_head + i, num_tail - i - 1);
                have_star_index = num_head + i;
Damien's avatar
Damien committed
731
            } else {
732
                compile_syntax_error(comp, nodes_tail[i], "multiple *x in assignment");
Damien's avatar
Damien committed
733
734
735
736
737
                return;
            }
        }
    }
    if (have_star_index < 0) {
738
        EMIT_ARG(unpack_sequence, num_head + num_tail);
Damien's avatar
Damien committed
739
    }
740
741
742
    if (num_head != 0) {
        if (0 == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)node_head)->nodes[0], ASSIGN_STORE);
Damien's avatar
Damien committed
743
        } else {
744
745
746
747
748
749
750
751
            c_assign(comp, node_head, ASSIGN_STORE);
        }
    }
    for (int i = 0; i < num_tail; i++) {
        if (num_head + i == have_star_index) {
            c_assign(comp, ((mp_parse_node_struct_t*)nodes_tail[i])->nodes[0], ASSIGN_STORE);
        } else {
            c_assign(comp, nodes_tail[i], ASSIGN_STORE);
Damien's avatar
Damien committed
752
753
754
755
756
        }
    }
}

// assigns top of stack to pn
757
void c_assign(compiler_t *comp, mp_parse_node_t pn, assign_kind_t assign_kind) {
Damien's avatar
Damien committed
758
    tail_recursion:
759
    if (MP_PARSE_NODE_IS_NULL(pn)) {
Damien's avatar
Damien committed
760
        assert(0);
761
762
763
    } else if (MP_PARSE_NODE_IS_LEAF(pn)) {
        if (MP_PARSE_NODE_IS_ID(pn)) {
            int arg = MP_PARSE_NODE_LEAF_ARG(pn);
Damien's avatar
Damien committed
764
765
766
            switch (assign_kind) {
                case ASSIGN_STORE:
                case ASSIGN_AUG_STORE:
767
                    EMIT_ARG(store_id, arg);
Damien's avatar
Damien committed
768
769
                    break;
                case ASSIGN_AUG_LOAD:
770
                    EMIT_ARG(load_id, arg);
Damien's avatar
Damien committed
771
772
773
                    break;
            }
        } else {
774
            compile_syntax_error(comp, pn, "can't assign to literal");
Damien's avatar
Damien committed
775
776
777
            return;
        }
    } else {
778
779
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
        switch (MP_PARSE_NODE_STRUCT_KIND(pns)) {
Damien's avatar
Damien committed
780
781
782
783
784
785
786
787
788
789
790
            case PN_power:
                // lhs is an index or attribute
                c_assign_power(comp, pns, assign_kind);
                break;

            case PN_testlist_star_expr:
            case PN_exprlist:
                // lhs is a tuple
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
791
                c_assign_tuple(comp, MP_PARSE_NODE_NULL, MP_PARSE_NODE_STRUCT_NUM_NODES(pns), pns->nodes);
Damien's avatar
Damien committed
792
793
794
795
                break;

            case PN_atom_paren:
                // lhs is something in parenthesis
796
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
797
                    // empty tuple
798
                    goto cannot_assign;
799
800
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
801
802
803
804
805
806
807
808
809
810
811
812
813
                    goto testlist_comp;
                } else {
                    // parenthesis around 1 item, is just that item
                    pn = pns->nodes[0];
                    goto tail_recursion;
                }
                break;

            case PN_atom_bracket:
                // lhs is something in brackets
                if (assign_kind != ASSIGN_STORE) {
                    goto bad_aug;
                }
814
                if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
Damien's avatar
Damien committed
815
                    // empty list, assignment allowed
816
                    c_assign_tuple(comp, MP_PARSE_NODE_NULL, 0, NULL);
817
818
                } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pns->nodes[0], PN_testlist_comp)) {
                    pns = (mp_parse_node_struct_t*)pns->nodes[0];
Damien's avatar
Damien committed
819
820
821
                    goto testlist_comp;
                } else {
                    // brackets around 1 item
822
                    c_assign_tuple(comp, pns->nodes[0], 0, NULL);
Damien's avatar
Damien committed
823
824
825
826
                }
                break;

            default:
827
                goto cannot_assign;
Damien's avatar
Damien committed
828
829
830
831
832
        }
        return;

        testlist_comp:
        // lhs is a sequence
833
834
835
        if (MP_PARSE_NODE_IS_STRUCT(pns->nodes[1])) {
            mp_parse_node_struct_t *pns2 = (mp_parse_node_struct_t*)pns->nodes[1];
            if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3b) {
Damien's avatar
Damien committed
836
                // sequence of one item, with trailing comma
837
                assert(MP_PARSE_NODE_IS_NULL(pns2->nodes[0]));
838
                c_assign_tuple(comp, pns->nodes[0], 0, NULL);
839
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns2) == PN_testlist_comp_3c) {
Damien's avatar
Damien committed
840
                // sequence of many items
841
842
                uint n = MP_PARSE_NODE_STRUCT_NUM_NODES(pns2);
                c_assign_tuple(comp, pns->nodes[0], n, pns2->nodes);
843
            } else if (MP_PARSE_NODE_STRUCT_KIND(pns) == PN_comp_for) {
844
                // TODO can we ever get here? can it be compiled?
845
                goto cannot_assign;
Damien's avatar
Damien committed
846
847
848
849
850
851
852
            } else {
                // sequence with 2 items
                goto sequence_with_2_items;
            }
        } else {
            // sequence with 2 items
            sequence_with_2_items:
853
            c_assign_tuple(comp, MP_PARSE_NODE_NULL, 2, pns->nodes);
Damien's avatar
Damien committed
854
855
856
857
858
        }
        return;
    }
    return;

859
860
861
862
    cannot_assign:
    compile_syntax_error(comp, pn, "can't assign to expression");
    return;

Damien's avatar
Damien committed
863
    bad_aug:
864
    compile_syntax_error(comp, pn, "illegal expression for augmented assignment");
Damien's avatar
Damien committed
865
866
867
}

// stuff for lambda and comprehensions and generators
868
869
870
871
// if we are not in CPython compatibility mode then:
//  if n_pos_defaults > 0 then there is a tuple on the stack with the positional defaults
//  if n_kw_defaults > 0 then there is a dictionary on the stack with the keyword defaults
//  if both exist, the tuple is above the dictionary (ie the first pop gets the tuple)
872
873
874
875
void close_over_variables_etc(compiler_t *comp, scope_t *this_scope, int n_pos_defaults, int n_kw_defaults) {
    assert(n_pos_defaults >= 0);
    assert(n_kw_defaults >= 0);

Damien's avatar
Damien committed
876
    // make closed over variables, if any
877
    // ensure they are closed over in the order defined in the outer scope (mainly to agree with CPython)
Damien's avatar
Damien committed
878
879
    int nfree = 0;
    if (comp->scope_cur->kind != SCOPE_MODULE) {
880
881
882
883
884
885
        for (int i = 0; i < comp->scope_cur->id_info_len; i++) {
            id_info_t *id = &comp->scope_cur->id_info[i];
            if (id->kind == ID_INFO_KIND_CELL || id->kind == ID_INFO_KIND_FREE) {
                for (int j = 0; j < this_scope->id_info_len; j++) {
                    id_info_t *id2 = &this_scope->id_info[j];
                    if (id2->kind == ID_INFO_KIND_FREE && id->qstr == id2->qstr) {
Damien George's avatar
Damien George committed
886
#if MICROPY_EMIT_CPYTHON
887
                        EMIT_ARG(load_closure, id->qstr, id->local_num);
Damien George's avatar
Damien George committed
888
889
#else
                        // in Micro Python we load closures using LOAD_FAST
890
                        EMIT_ARG(load_fast, id->qstr, id->flags, id->local_num);
Damien George's avatar
Damien George committed
891
#endif
892
893
894
                        nfree += 1;
                    }
                }
Damien's avatar
Damien committed
895
896
897
898
899
900
            }
        }
    }

    // make the function/closure
    if (nfree == 0) {
901
        EMIT_ARG(make_function, this_scope, n_pos_defaults, n_kw_defaults);
Damien's avatar
Damien committed
902
    } else {
903
        EMIT_ARG(make_closure, this_scope, nfree, n_pos_defaults, n_kw_defaults);
Damien's avatar
Damien committed
904
905
906
    }
}

907
void compile_funcdef_param(compiler_t *comp, mp_parse_node_t pn) {
908
    if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_typedargslist_star)) {
909
910
        comp->have_star = true;
        /* don't need to distinguish bare from named star
911
        mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
912
913
        if (MP_PARSE_NODE_IS_NULL(pns->nodes[0])) {
            // bare star
914
915
        } else {
            // named star
916
        }
917
        */
918
919

    } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_typedargslist_dbl_star)) {
920
        // named double star
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
        // TODO do we need to do anything with this?

    } else {
        mp_parse_node_t pn_id;
        mp_parse_node_t pn_colon;
        mp_parse_node_t pn_equal;
        if (MP_PARSE_NODE_IS_ID(pn)) {
            // this parameter is just an id

            pn_id = pn;
            pn_colon = MP_PARSE_NODE_NULL;
            pn_equal = MP_PARSE_NODE_NULL;

        } else if (MP_PARSE_NODE_IS_STRUCT_KIND(pn, PN_typedargslist_name)) {
            // this parameter has a colon and/or equal specifier

            mp_parse_node_struct_t *pns = (mp_parse_node_struct_t*)pn;
            pn_id = pns->nodes[0];
            pn_colon = pns->nodes[1];
            pn_equal = pns->nodes[2];

        } else {
943
            // XXX what to do here?
944
945
946
947
948
949
950
951
            assert(0);
            return;
        }

        if (MP_PARSE_NODE_IS_NULL(pn_equal)) {
            // this parameter does not have a default value

            // check for non-default parameters given after default parameters (allowed by parser, but not syntactically valid)
952
            if (!comp->have_star && comp->num_default_params != 0) {
953
                compile_syntax_error(comp, pn, "non-default argument follows default argument");
954
955
956
957
                return;
            }

        } else {
Damien's avatar
Damien committed
958
959
            // this parameter has a default value
            // in CPython, None (and True, False?) as default parameters are loaded with LOAD_NAME; don't understandy why
960

961
            if (comp->have_star) {
962
                comp->num_dict_params += 1;
963
#if !MICROPY_EMIT_CPYTHON
964
965
                // in Micro Python we put the default dict parameters into a dictionary using the bytecode
                if (comp->num_dict_params == 1) {
966
967
968
969
                    // in Micro Python we put the default positional parameters into a tuple using the bytecode
                    // we need to do this here before we start building the map for the default keywords
                    if (comp->num_default_params > 0) {
                        EMIT_ARG(build_tuple, comp->num_default_params);
970
971
                    } else {
                        EMIT(load_null); // sentinel indicating empty default positional args
972
                    }
973
974
975
                    // first default dict param, so make the map
                    EMIT_ARG(build_map, 0);
                }
976
#endif
977
                EMIT_ARG(load_const_str, MP_PARSE_NODE_LEAF_ARG(pn_id), false);
978
                compile_node(comp, pn_equal);
979
#if !MICROPY_EMIT_CPYTHON
980
981
                // in Micro Python we put the default dict parameters into a dictionary using the bytecode
                EMIT(store_map);
982
#endif
Damien's avatar
Damien committed
983
            } else {
984
985
                comp->num_default_params += 1;
                compile_node(comp, pn_equal);
Damien's avatar
Damien committed
986
987
            }
        }
988
989
990

        // TODO pn_colon not implemented
        (void)pn_colon;
Damien's avatar
Damien committed
991
992
993
994
995
    }
}

// leaves function object on stack
// returns function name
996
qstr compile_funcdef_helper(compiler_t *comp, mp_parse_node_struct_t *pns, uint emit_options) {
Damien's avatar
Damien committed
997
998
    if (comp->pass == PASS_1) {
        // create a new scope for this function
999
        scope_t *s = scope_new_and_link(comp, SCOPE_FUNCTION, (mp_parse_node_t)pns, emit_options);
Damien's avatar
Damien committed
1000
        // store the function scope so the compiling function can use it at each pass
1001
        pns->nodes[4] = (mp_parse_node_t)s;
Damien's avatar
Damien committed
1002
1003
1004
    }

    // save variables (probably don't need to do this, since we can't have nested definitions..?)
1005
    uint old_have_star = comp->have_star;
1006
1007
    uint old_num_dict_params = comp->num_dict_params;
    uint old_num_default_params = comp->num_default_params;
Damien's avatar
Damien committed
1008
1009

    // compile default parameters
1010
    comp->have_star = false;
1011
1012
    comp->num_dict_params = 0;
    comp->num_default_params = 0;
Damien's avatar
Damien committed
1013
    apply_to_single_or_list(comp, pns->nodes[1], PN_typedargslist, compile_funcdef_param);
1014
1015
1016
1017
1018

    if (comp->had_error) {
        return MP_QSTR_NULL;
    }

1019
1020
#if !MICROPY_EMIT_CPYTHON
    // in Micro Python we put the default positional parameters into a tuple using the bytecode
1021
1022
    // the default keywords args may have already made the tuple; if not, do it now
    if (comp->num_default_params > 0 && comp->num_dict_params == 0) {
1023
        EMIT_ARG(build_tuple, comp->num_default_params);
1024
        EMIT(load_null); // sentinel indicating empty default keyword args
1025
1026
1027
    }
#endif

Damien's avatar
Damien committed
1028
1029
1030
1031
    // get the scope for this function
    scope_t *fscope = (scope_t*)pns->nodes[4];

    // make the function
1032
    close_over_variables_etc(comp, fscope, comp->num_default_params, comp->num_dict_params);
Damien's avatar
Damien committed
1033
1034

    // restore variables
1035
    comp->have_star = old_have_star;
1036
1037
    comp->num_dict_params = old_num_dict_params;
    comp->num_default_params = old_num_default_params;
Damien's avatar
Damien committed
1038
1039
1040
1041
1042
1043
1044

    // return its name (the 'f' in "def f(...):")
    return fscope->simple_name;
}

// leaves class object on stack
// returns class name
1045
qstr compile_classdef_helper(compiler_t *comp, mp_parse_node_struct_t *pns, uint emit_options) {
Damien's avatar
Damien committed
1046
1047
    if (comp->pass == PASS_1) {